update code-review and plan skills
This commit is contained in:
parent
9e8f77e956
commit
db0de6d4a7
4 changed files with 34 additions and 16 deletions
|
|
@ -1,6 +1,6 @@
|
|||
---
|
||||
name: code-review
|
||||
description: Use for active task review requests such as 리뷰 진행해, 리뷰해줘, 코드 리뷰해줘, code review, CODE_REVIEW.md, or 리뷰 루프. Review the active PLAN/CODE_REVIEW pair, append PASS/WARN/FAIL, archive both active files, and create the required next state: PASS writes complete.log and moves the task to archive; WARN/FAIL immediately writes follow-up PLAN/CODE_REVIEW files. Never stop after verdict append.
|
||||
description: Use for active task review requests such as 리뷰 진행해, 리뷰해줘, 코드 리뷰해줘, code review, CODE_REVIEW.md, or 리뷰 루프. Review the active PLAN/CODE_REVIEW pair, append PASS/WARN/FAIL, archive both active files, and create the required next state: PASS writes complete.log, updates matching roadmap status/current milestone context only when agent-ops/roadmap/ exists, and moves the task to archive; WARN/FAIL immediately writes follow-up PLAN/CODE_REVIEW files. Never stop after verdict append.
|
||||
---
|
||||
|
||||
# Code Review
|
||||
|
|
@ -19,7 +19,7 @@ plan skill -> implementation -> code-review skill
|
|||
|
||||
- Trigger: Korean or English active-task review requests, including `리뷰 진행해` and `리뷰해줘`, must use this skill when an active `CODE_REVIEW-*-G??.md` exists under `agent-task/*/` or `agent-task/*/*/`, excluding `agent-task/archive/**`.
|
||||
- Finalize every selected active review: append one verdict, archive the active review and plan files, then create exactly one next state before reporting.
|
||||
- Next state: `PASS` writes `complete.log` and moves the task under `agent-task/archive/YYYY/MM/`; `WARN` or `FAIL` writes the next active `PLAN-{build_lane}-GNN.md` and `CODE_REVIEW-{review_lane}-GNN.md`.
|
||||
- Next state: `PASS` writes `complete.log`, reviews and updates matching roadmap/current Milestone context only if `agent-ops/roadmap/` exists, then moves the task under `agent-task/archive/YYYY/MM/`; `WARN` or `FAIL` writes the next active `PLAN-{build_lane}-GNN.md` and `CODE_REVIEW-{review_lane}-GNN.md`.
|
||||
- Do not ask for confirmation before WARN/FAIL follow-up files. If details are uncertain, write the smallest concrete follow-up plan with file references and verification commands.
|
||||
- Recovery: if a prior turn appended a verdict without archive or next-state files, resume at Step 5 and finish finalization first.
|
||||
|
||||
|
|
@ -117,7 +117,7 @@ Required fields:
|
|||
- `발견된 문제`: `없음`, or bullets using `Required`, `Suggested`, or `Nit` with `file:line` and a concrete fix.
|
||||
- `다음 단계`: keep only the matching PASS/WARN/FAIL line.
|
||||
|
||||
Do not check archive/next-state items in `코드리뷰 전용 체크리스트` during Step 4. Complete the applicable dedicated checklist items in the archived `code_review_*.log` during Step 7, after archive, next-state writes, and PASS task-directory moves are done.
|
||||
Do not check archive/next-state items in `코드리뷰 전용 체크리스트` during Step 4. Complete the applicable dedicated checklist items in the archived `code_review_*.log` during Step 7, after archive, next-state writes, conditional PASS roadmap sync, and PASS task-directory moves are done.
|
||||
|
||||
Severity semantics:
|
||||
|
||||
|
|
@ -159,6 +159,18 @@ Complete log template:
|
|||
- Do not leave placeholders in `complete.log`.
|
||||
- Use `없음` for empty `잔여 Nit` or `후속 작업`.
|
||||
- A PASS `complete.log` must not contain unresolved Required or Suggested issues. Nit-only leftovers may be recorded under `잔여 Nit`.
|
||||
- Fill `로드맵 반영` with one of:
|
||||
- `agent-ops/roadmap/` exists and matching roadmap item(s) were updated, including Milestone path and checked item names
|
||||
- `agent-ops/roadmap/` exists and was reviewed, but no matching item was found
|
||||
- `agent-ops/roadmap/` directory is absent, so roadmap review/update was skipped
|
||||
|
||||
After writing `complete.log`, review the roadmap before the PASS archive move only when `agent-ops/roadmap/` exists:
|
||||
|
||||
- If `agent-ops/roadmap/` does not exist, do not invoke `update-roadmap`, do not create roadmap files, and record the skip in `complete.log`.
|
||||
- If `agent-ops/roadmap/current.md` exists, read it and the active Milestone documents it references. If `current.md` is absent, or the completed task is not in the active Milestone window, read `agent-ops/roadmap/ROADMAP.md` only as needed to find the likely Milestone.
|
||||
- If the completed work matches an existing roadmap task, subtask, or completion criterion, apply the `update-roadmap` skill's status/sync workflow: mark the matching checklist item(s) complete, update Milestone status only when the evidence supports it, and sync `current.md` so the active Milestone window reflects the next current work point.
|
||||
- Do not add personal/session progress notes to `current.md`; keep it as the shared active Milestone window.
|
||||
- If the match is ambiguous, do not guess. Leave roadmap files unchanged, record the ambiguity in `complete.log` under `로드맵 반영`, and report it as 확인 필요.
|
||||
|
||||
For `WARN` or `FAIL`, write new routed plan/review files using the plan skill format:
|
||||
|
||||
|
|
@ -188,7 +200,7 @@ Routed review stub template (fill `{…}` placeholders; everything else is fixed
|
|||
> The task is NOT complete until every implementation-owned section below is filled in.
|
||||
> Complete the `구현 체크리스트`; the final checklist item is mandatory before saving.
|
||||
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
|
||||
> Finalization (`코드리뷰 결과`, log rename, `complete.log`, archive moves, `코드리뷰 전용 체크리스트`) is review-agent-only, even after compaction/resume.
|
||||
> Finalization (`코드리뷰 결과`, log rename, `complete.log`, conditional roadmap sync, archive moves, `코드리뷰 전용 체크리스트`) is review-agent-only, even after compaction/resume.
|
||||
> Follow the ownership table at the bottom of this file for which sections you own.
|
||||
|
||||
## 개요
|
||||
|
|
@ -205,7 +217,7 @@ task={task_name}, plan={N}, tag={TAG}
|
|||
|
||||
1. 판정을 append한다.
|
||||
2. `CODE_REVIEW-{review_lane}-GNN.md` → `code_review_{review_lane}_GNN_N.log`, `PLAN-{build_lane}-GNN.md` → `plan_{build_lane}_GNN_M.log`로 아카이브한다.
|
||||
3. PASS이면 `complete.log` 작성 후 active task 디렉터리를 `agent-task/archive/YYYY/MM/{task_name}/`로 이동한다. WARN/FAIL이면 다음 active plan/review 파일을 즉시 작성한다.
|
||||
3. PASS이면 `complete.log` 작성 후 `agent-ops/roadmap/` 폴더가 있을 때만 로드맵을 검토하고, 방금 완료한 작업이 로드맵 항목이면 `update-roadmap` 스킬 기준으로 상태와 `current.md`의 활성 Milestone 창을 갱신한 뒤 active task 디렉터리를 `agent-task/archive/YYYY/MM/{task_name}/`로 이동한다. WARN/FAIL이면 다음 active plan/review 파일을 즉시 작성한다.
|
||||
4. 적용 가능한 `코드리뷰 전용 체크리스트` 항목을 최종 `.log` 위치에서 체크한 뒤 보고한다.
|
||||
|
||||
---
|
||||
|
|
@ -231,6 +243,7 @@ task={task_name}, plan={N}, tag={TAG}
|
|||
- [ ] active `CODE_REVIEW-*-G??.md`를 `code_review_{review_lane}_GNN_N.log`로 아카이브한다.
|
||||
- [ ] active `PLAN-*-G??.md`를 `plan_{build_lane}_GNN_M.log`로 아카이브한다.
|
||||
- [ ] PASS이면 `agent-ops/skills/common/code-review/templates/complete-log-template.md` 기준으로 `complete.log`를 작성하고 active `.md` 파일을 남기지 않는다.
|
||||
- [ ] PASS이고 `agent-ops/roadmap/` 폴더가 있으면 로드맵을 검토하고, 완료 작업이 로드맵 항목이면 `update-roadmap` 스킬 기준으로 해당 항목과 `current.md`의 활성 Milestone 창을 갱신한다.
|
||||
- [ ] PASS이면 active task 디렉터리 `agent-task/{task_name}/`를 `agent-task/archive/YYYY/MM/{task_name}/`로 이동하고 최종 archive 경로에서 이 체크리스트를 갱신한다.
|
||||
- [ ] PASS split 작업이면 이동 후 빈 active parent `agent-task/{task_group}/`를 제거하거나, 남은 sibling/file이 있어 유지했다고 확인한다.
|
||||
- [ ] WARN/FAIL이면 다음 active `PLAN-{build_lane}-GNN.md`와 `CODE_REVIEW-{review_lane}-GNN.md`를 작성하고 `complete.log`를 작성하지 않는다.
|
||||
|
|
@ -292,17 +305,17 @@ Sections and their ownership:
|
|||
|
||||
After Step 6:
|
||||
|
||||
- If verdict is `PASS`, determine archive month from the current completion date as `YYYY/MM`, create the needed archive parent directories, then move the selected active task directory `agent-task/{task_name}/` to `agent-task/archive/YYYY/MM/{task_name}/`. For split work, the selected active task directory is the subtask directory, and the archive must preserve the task group path, e.g. `agent-task/refactoring/01_core/` moves to `agent-task/archive/YYYY/MM/refactoring/01_core/`.
|
||||
- If verdict is `PASS`, complete the roadmap review/update described in Step 6 only when `agent-ops/roadmap/` exists, determine archive month from the current completion date as `YYYY/MM`, create the needed archive parent directories, then move the selected active task directory `agent-task/{task_name}/` to `agent-task/archive/YYYY/MM/{task_name}/`. For split work, the selected active task directory is the subtask directory, and the archive must preserve the task group path, e.g. `agent-task/refactoring/01_core/` moves to `agent-task/archive/YYYY/MM/refactoring/01_core/`.
|
||||
- Do not overwrite an existing archive directory. If `agent-task/archive/YYYY/MM/{task_name}/` already exists, append the next numeric suffix to the final path segment: single-plan `agent-task/archive/YYYY/MM/{task_group}_1/`, split-plan `agent-task/archive/YYYY/MM/{task_group}/{subtask_dir}_1/`, and so on.
|
||||
- After moving a split subtask, remove the active parent `agent-task/{task_group}/` only if it is empty. If sibling subtask directories or other files remain, leave the parent task group in place.
|
||||
- For `PASS`, open the moved `agent-task/archive/YYYY/MM/{final_task_name}/code_review_{review_lane}_GNN_N.log`, where `{final_task_name}` is the archived task path, including `{task_group}/` for split work.
|
||||
- For `WARN` or `FAIL`, open `agent-task/{task_name}/code_review_{review_lane}_GNN_N.log`.
|
||||
- Check every applicable item in `코드리뷰 전용 체크리스트`; leave mutually exclusive verdict items unchecked.
|
||||
- If any applicable item cannot be checked, finish the missing archive, `complete.log`, task-directory move, or follow-up plan/review write first.
|
||||
- If any applicable item cannot be checked, finish the missing archive, `complete.log`, roadmap review/update if `agent-ops/roadmap/` exists, task-directory move, or follow-up plan/review write first.
|
||||
- Do not recreate an active review file just to update this checklist; update the archived `code_review_*.log`.
|
||||
- Only report after the archived review log has the verdict, applicable checked review-only checklist, required next-state files, and for `PASS` the final task archive move.
|
||||
- Only report after the archived review log has the verdict, applicable checked review-only checklist, required next-state files, and for `PASS` the conditional roadmap review/update and final task archive move.
|
||||
|
||||
Report Required/Suggested counts, archive names, and the final task archive path for `PASS` or new plan path for `WARN`/`FAIL`.
|
||||
Report Required/Suggested counts, archive names, roadmap update result for `PASS` when `agent-ops/roadmap/` exists, and the final task archive path for `PASS` or new plan path for `WARN`/`FAIL`.
|
||||
|
||||
## Review Dimensions
|
||||
|
||||
|
|
@ -330,7 +343,7 @@ Report Required/Suggested counts, archive names, and the final task archive path
|
|||
- `code_review_{review_lane}_GNN_N.log` exists with verdict appended.
|
||||
- `plan_{build_lane}_GNN_M.log` exists.
|
||||
- No active `.md` files remain after PASS.
|
||||
- PASS: `complete.log` written from `agent-ops/skills/common/code-review/templates/complete-log-template.md`, then task directory moved under `agent-task/archive/YYYY/MM/` with task-group path preserved for split work.
|
||||
- PASS: `complete.log` written from `agent-ops/skills/common/code-review/templates/complete-log-template.md`, roadmap reviewed and matching roadmap/current Milestone context updated only when `agent-ops/roadmap/` exists, then task directory moved under `agent-task/archive/YYYY/MM/` with task-group path preserved for split work.
|
||||
- PASS split: empty active parent `agent-task/{task_group}/` removed after the subtask move; non-empty parent left in place.
|
||||
- WARN/FAIL: new active `PLAN-{build_lane}-GNN.md` and `CODE_REVIEW-{review_lane}-GNN.md` created with matching headers and matching `구현 체크리스트`; no `complete.log`.
|
||||
- The applicable review-agent-only finalization checklist was completed before reporting.
|
||||
|
|
|
|||
|
|
@ -1,4 +1,4 @@
|
|||
interface:
|
||||
display_name: "Code Review"
|
||||
short_description: "Review and continue task loops"
|
||||
default_prompt: "Use $code-review to review the active repository task, archive active files, and create complete.log or follow-up plan/review files."
|
||||
default_prompt: "Use $code-review to review the active repository task, archive active files, update matching roadmap state on PASS when agent-ops/roadmap/ exists, and create complete.log or follow-up plan/review files."
|
||||
|
|
|
|||
|
|
@ -22,6 +22,10 @@
|
|||
|
||||
- `{command}` - {PASS/FAIL/BLOCKED}; {actual output summary or saved output path}
|
||||
|
||||
## 로드맵 반영
|
||||
|
||||
- {agent-ops/roadmap/ 폴더가 있으면 갱신한 로드맵 항목과 current.md 활성 Milestone 창, 또는 검토했으나 매칭 없음; 폴더가 없으면 로드맵 반영 생략}
|
||||
|
||||
## 잔여 Nit
|
||||
|
||||
- 없음
|
||||
|
|
|
|||
|
|
@ -1,6 +1,6 @@
|
|||
---
|
||||
name: plan
|
||||
description: Analyze the current repository and write a detailed PLAN-{build_lane}-GNN.md for implementation work. Also writes the CODE_REVIEW-{review_lane}-GNN.md stub that the implementing agent will fill in after coding. Use for any feature, refactor, bug fix, or follow-up fix that should enter the plan-code-review loop. A separate implementing agent, or the same agent in an implementation pass, reads the plan file and does the coding. The code-review skill archives both files after review and moves PASS tasks under agent-task/archive/YYYY/MM/.
|
||||
description: Analyze the current repository and write a detailed PLAN-{build_lane}-GNN.md for implementation work. Also writes the CODE_REVIEW-{review_lane}-GNN.md stub that the implementing agent will fill in after coding. Use for any feature, refactor, bug fix, or follow-up fix that should enter the plan-code-review loop. A separate implementing agent, or the same agent in an implementation pass, reads the plan file and does the coding. The code-review skill archives both files after review, writes complete.log, updates matching roadmap/current Milestone state on PASS only when agent-ops/roadmap/ exists, and moves PASS tasks under agent-task/archive/YYYY/MM/.
|
||||
---
|
||||
|
||||
# Plan
|
||||
|
|
@ -12,7 +12,7 @@ Create the planning artifacts for the implementation loop:
|
|||
```text
|
||||
plan skill -> PLAN-{build_lane}-GNN.md + CODE_REVIEW-{review_lane}-GNN.md stub
|
||||
implementation -> code changes + filled CODE_REVIEW-{review_lane}-GNN.md
|
||||
code-review skill -> verdict + archive, complete.log, and PASS task-directory archive move or new follow-up plan/review files
|
||||
code-review skill -> verdict + archive, complete.log, conditional PASS roadmap sync, and task-directory archive move or new follow-up plan/review files
|
||||
```
|
||||
|
||||
## Workflow Contract
|
||||
|
|
@ -38,7 +38,7 @@ Filename rules:
|
|||
Role boundary rules:
|
||||
|
||||
- Implementing agents fill implementation-owned `CODE_REVIEW-*-G??.md` sections, keep active files in place, and report ready for review.
|
||||
- Finalization (`코드리뷰 결과`, log rename, `complete.log`, archive moves, review-only checklist) is code-review-skill only.
|
||||
- Finalization (`코드리뷰 결과`, log rename, `complete.log`, conditional roadmap sync, archive moves, review-only checklist) is code-review-skill only.
|
||||
|
||||
Split decision policy:
|
||||
|
||||
|
|
@ -240,7 +240,7 @@ Use the template below exactly. Fill `{…}` placeholders from the plan; everyth
|
|||
> The task is NOT complete until every implementation-owned section below is filled in.
|
||||
> Complete the `구현 체크리스트`; the final checklist item is mandatory before saving.
|
||||
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
|
||||
> Finalization (`코드리뷰 결과`, log rename, `complete.log`, archive moves, `코드리뷰 전용 체크리스트`) is review-agent-only, even after compaction/resume.
|
||||
> Finalization (`코드리뷰 결과`, log rename, `complete.log`, conditional roadmap sync, archive moves, `코드리뷰 전용 체크리스트`) is review-agent-only, even after compaction/resume.
|
||||
> Follow the ownership table at the bottom of this file for which sections you own.
|
||||
|
||||
## 개요
|
||||
|
|
@ -257,7 +257,7 @@ task={task_name}, plan={N}, tag={TAG}
|
|||
|
||||
1. 판정을 append한다.
|
||||
2. `CODE_REVIEW-{review_lane}-GNN.md` → `code_review_{review_lane}_GNN_N.log`, `PLAN-{build_lane}-GNN.md` → `plan_{build_lane}_GNN_M.log`로 아카이브한다.
|
||||
3. PASS이면 `complete.log` 작성 후 active task 디렉터리를 `agent-task/archive/YYYY/MM/{task_name}/`로 이동한다. WARN/FAIL이면 다음 active plan/review 파일을 즉시 작성한다.
|
||||
3. PASS이면 `complete.log` 작성 후 `agent-ops/roadmap/` 폴더가 있을 때만 로드맵을 검토하고, 방금 완료한 작업이 로드맵 항목이면 `update-roadmap` 스킬 기준으로 상태와 `current.md`의 활성 Milestone 창을 갱신한 뒤 active task 디렉터리를 `agent-task/archive/YYYY/MM/{task_name}/`로 이동한다. WARN/FAIL이면 다음 active plan/review 파일을 즉시 작성한다.
|
||||
4. 적용 가능한 `코드리뷰 전용 체크리스트` 항목을 최종 `.log` 위치에서 체크한 뒤 보고한다.
|
||||
|
||||
---
|
||||
|
|
@ -283,6 +283,7 @@ task={task_name}, plan={N}, tag={TAG}
|
|||
- [ ] active `CODE_REVIEW-*-G??.md`를 `code_review_{review_lane}_GNN_N.log`로 아카이브한다.
|
||||
- [ ] active `PLAN-*-G??.md`를 `plan_{build_lane}_GNN_M.log`로 아카이브한다.
|
||||
- [ ] PASS이면 `agent-ops/skills/common/code-review/templates/complete-log-template.md` 기준으로 `complete.log`를 작성하고 active `.md` 파일을 남기지 않는다.
|
||||
- [ ] PASS이고 `agent-ops/roadmap/` 폴더가 있으면 로드맵을 검토하고, 완료 작업이 로드맵 항목이면 `update-roadmap` 스킬 기준으로 해당 항목과 `current.md`의 활성 Milestone 창을 갱신한다.
|
||||
- [ ] PASS이면 active task 디렉터리 `agent-task/{task_name}/`를 `agent-task/archive/YYYY/MM/{task_name}/`로 이동하고 최종 archive 경로에서 이 체크리스트를 갱신한다.
|
||||
- [ ] PASS split 작업이면 이동 후 빈 active parent `agent-task/{task_group}/`를 제거하거나, 남은 sibling/file이 있어 유지했다고 확인한다.
|
||||
- [ ] WARN/FAIL이면 다음 active `PLAN-{build_lane}-GNN.md`와 `CODE_REVIEW-{review_lane}-GNN.md`를 작성하고 `complete.log`를 작성하지 않는다.
|
||||
|
|
|
|||
Loading…
Reference in a new issue