From bdbf5941326aa6843f380b4b61dd5583cdd4b50f Mon Sep 17 00:00:00 2001 From: toki Date: Sat, 6 Jun 2026 14:28:25 +0900 Subject: [PATCH] sync: agent-ops from agentic-framework v1.1.132 --- agent-ops/.version | 2 +- agent-ops/skills/common/code-review/SKILL.md | 3 ++- agent-ops/skills/common/plan/SKILL.md | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/agent-ops/.version b/agent-ops/.version index c4c90b9..dc96943 100644 --- a/agent-ops/.version +++ b/agent-ops/.version @@ -1 +1 @@ -1.1.131 +1.1.132 diff --git a/agent-ops/skills/common/code-review/SKILL.md b/agent-ops/skills/common/code-review/SKILL.md index d2d7b0f..ba444f2 100644 --- a/agent-ops/skills/common/code-review/SKILL.md +++ b/agent-ops/skills/common/code-review/SKILL.md @@ -153,6 +153,7 @@ Before writing the verdict: - Compare actual source files against every planned checklist item. - Compare the plan `구현 체크리스트` and review stub `구현 체크리스트`; repair non-behavioral drift when implementation remains judgeable. +- Directly repair obvious non-behavioral source nits when safe: typos, stale comments, docs, or formatting only, with no behavior/test/API contract change. - If a checklist item contains integrated verification for a feature, treat that feature item as incomplete until both implementation evidence and the matching verification output are present. Do not accept a separate unchecked completion-criteria item as a substitute. - Confirm the implementation marked the matching checklist items in the active review file, including the final mandatory `CODE_REVIEW-*-G??.md` completion item; repair clear artifact drift when evidence supports completion. - Treat review artifact gaps as failures only when they prevent judging implementation correctness, tests, contracts, or verification trust. @@ -187,7 +188,7 @@ Issue severity: - `Required`: correctness, API contract, missing required test, missing integrated verification, plan-completeness issue, or review artifact gaps that prevent judging implementation quality. - `Suggested`: useful improvement that should enter the loop but does not block correctness. -- `Nit`: tiny cleanup; may be recorded without forcing WARN. +- `Nit`: tiny cleanup; directly repair obvious non-behavioral cases when safe, otherwise record without forcing WARN. Verdict consistency: diff --git a/agent-ops/skills/common/plan/SKILL.md b/agent-ops/skills/common/plan/SKILL.md index c353415..7d8dffa 100644 --- a/agent-ops/skills/common/plan/SKILL.md +++ b/agent-ops/skills/common/plan/SKILL.md @@ -102,6 +102,7 @@ Routing rules: - Use `cloud-G07` or higher only when terminal-agent or external interactive behavior is central and cannot be made deterministic for local handling, or when the task requires more source/test/diff/log context than local can hold without omitting material evidence: shell/CLI workflow implementation, bin script orchestration, process control, stdout/stderr parsing, exit-status contracts, long-running command diagnosis, terminal benchmark-style tasks, TUI/PTY/browser/screen repaint/cursor stream behavior, real bin/smoke/integration failures after unit tests passed, or very large cross-module/cross-domain changes that cannot be safely split. - Review uses the same balance: choose `local` for review-detectable work with bounded scope, bounded context, and rerunnable verification, and choose `cloud` for reviews requiring frontier-level judgment, larger-than-local context, weak tests, security/auth, storage/migration, concurrency, protocol/schema, cross-domain behavior, repeated Required issues, or untrusted verification evidence. - Treat non-behavioral review artifact drift as reviewer-repairable unless it prevents judging implementation correctness, tests, or contracts. +- Treat obvious non-behavioral source nits as reviewer-repairable too: typos, stale comments, docs, or formatting only, with no behavior/test/API contract change. - Raise `GNN` with scope, ambiguity, missing tests, irreversible behavior, and blast radius after lane selection; keep grade model-independent. Directory states: