<!-- task=m-iop-hot-path-one-shot-execution/16+14,15_terminal_disposition plan=5 tag=REVIEW_REVIEW_REVIEW_API milestone-task=error-cancel -->

# Code Review Reference - REVIEW_REVIEW_REVIEW_API

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-08-04
task=m-iop-hot-path-one-shot-execution/16+14,15_terminal_disposition, plan=5, tag=REVIEW_REVIEW_REVIEW_API

## Archive Evidence Snapshot

- The current loop will archive to `agent-task/m-iop-hot-path-one-shot-execution/16+14,15_terminal_disposition/plan_cloud_G07_4.log` and `agent-task/m-iop-hot-path-one-shot-execution/16+14,15_terminal_disposition/code_review_cloud_G07_4.log` with verdict `FAIL`, 2 Required findings, 0 Suggested findings, and 0 Nits.
- Required correctness finding: downstream progressive and buffered switches accept a path whose expected handle is nil and delegate before aborting the result-scoped owner; a normalized-path/tunnel-only real-entry-point reproducer observed zero cancel calls and left the tunnel open. The symmetric tunnel-path/run-only variants share the defect.
- Required verification finding: the active review claimed `go test -count=1 ./apps/edge/...` exited 0, while a fresh exact run failed when the bootstrap integration test tried to execute its fixture from `/tmp`, which is mounted `noexec` on this host.
- Fresh review evidence passed the focused Hot Path race suite, the common streamgate/config/openai/service race suite, Edge vet, formatting, and `git diff --check`. `TMPDIR=/config/workspace/iop-s0 go test -count=1 ./apps/edge/...` also passed and is the repository-local supported full-Edge command for this host.
- Roadmap carryover remains `milestone-task=error-cancel`; SDD S13 requires standard terminal failure with no partial success or hidden provider work. This follow-up does not assert milestone completion.

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G07.md` → `code_review_cloud_G07_5.log` and `PLAN-cloud-G07.md` → `plan_cloud_G07_5.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-iop-hot-path-one-shot-execution/16+14,15_terminal_disposition/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and task group is `m-<milestone-slug>`, preserve the first-line `milestone-task` metadata in `complete.log` and report it for the runtime aggregation event. Roadmap state evaluation belongs to `sync-milestone-workstate`.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| REVIEW_REVIEW_REVIEW_API-1 Pre-execution path/handle ownership gate | [x] |
| REVIEW_REVIEW_REVIEW_API-2 Missing/wrong-handle matrix and trusted verification | [x] |

## Implementation Checklist

- [x] [REVIEW_REVIEW_REVIEW_API-1] Reject every downstream provider-pool missing/wrong-handle shape before progressive or buffered execution and dispose it through the existing result-scoped owner with typed validation disposition.
- [x] [REVIEW_REVIEW_REVIEW_API-2] Extend the downstream matrix across normalized/tunnel, buffered/progressive, no-handle/opposite-handle variants and record fresh focused/common/full-Edge verification using the supported executable `TMPDIR`.
- [x] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [x] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [x] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [x] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G07_5.log`.
- [x] Archive active `PLAN-*-G??.md` to `plan_cloud_G07_5.log`.
- [x] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [x] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [x] If PASS, move active task directory `agent-task/m-iop-hot-path-one-shot-execution/16+14,15_terminal_disposition/` to `agent-task/archive/YYYY/MM/m-iop-hot-path-one-shot-execution/16+14,15_terminal_disposition/` and update this checklist at the final archive path.
- [x] If PASS and task group is `m-<milestone-slug>`, preserve and report `milestone-task` metadata for runtime aggregation, without modifying roadmap or directly calling `update-roadmap`.
- [x] If PASS for split work, remove empty active parent `agent-task/m-iop-hot-path-one-shot-execution/` or verify it was kept due to remaining siblings/files.
- [ ] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

None.

## Key Design Decisions

- `validateHotPathStageResultShape` is the single pre-execution gate for provider-pool results. It permits only normalized-plus-run and tunnel-plus-tunnel shapes, before dispatch metadata validation and before either execution mode receives a handle.
- Invalid shapes use the existing result-scoped rejection owner, preserving its immutable cancel target and exact-once close behavior for every non-nil returned handle.
- The existing stage matrix now covers no-handle and opposite-handle cases for both normalized and tunnel paths in buffered and progressive modes, while retaining validation, unsupported-path, and dual-handle coverage.

## Reviewer Checkpoints

- Confirm invalid downstream result shapes are rejected before either progressive or buffered helper receives a handle.
- Confirm every invalid shape reuses one result-scoped owner, sends one immutable-target `CANCEL_RUN`, closes every non-nil handle once, and returns typed `validation_error` disposition.
- Confirm the table covers normalized/tunnel, buffered/progressive, no-handle/opposite-handle, dual-handle, validation, unsupported, and repeated-observation variants through real entry points.
- Confirm full-Edge evidence uses an executable temporary filesystem on this host and contains fresh actual stdout/stderr.

## Verification Results

Paste actual stdout/stderr and exit status for every command. Do not summarize or reconstruct output.

### Environment preflight

Command: `findmnt -no TARGET,OPTIONS /tmp`

```text
/tmp   rw,nosuid,nodev,noexec,relatime,size=8388608k
```

Exit status: 0

### Focused exact-once race regression

Command: `go test -race -count=1 ./apps/edge/internal/openai -run 'TestHotPath(RejectedDispatch|TerminalDisposition|ActiveStageCancel|CancelCompleteRace|Cleanup)'`

```text
ok  	iop/apps/edge/internal/openai	3.946s
```

Exit status: 0

### Common race regression

Command: `go test -race -count=1 ./packages/go/streamgate ./packages/go/config ./apps/edge/internal/openai ./apps/edge/internal/service`

```text
ok  	iop/packages/go/streamgate	2.239s
ok  	iop/packages/go/config	1.771s
ok  	iop/apps/edge/internal/openai	13.329s
ok  	iop/apps/edge/internal/service	7.193s
```

Exit status: 0

### Full Edge regression with executable temporary path

Command: `TMPDIR=/config/workspace/iop-s0 go test -count=1 ./apps/edge/...`

```text
ok  	iop/apps/edge/cmd/edge	4.691s
ok  	iop/apps/edge/internal/authprojection	1.900s
ok  	iop/apps/edge/internal/bootstrap	55.610s
ok  	iop/apps/edge/internal/configrefresh	2.375s
ok  	iop/apps/edge/internal/controlplane	7.544s
ok  	iop/apps/edge/internal/edgecmd	1.374s
ok  	iop/apps/edge/internal/edgevalidate	0.528s
ok  	iop/apps/edge/internal/events	0.318s
ok  	iop/apps/edge/internal/input	0.609s
ok  	iop/apps/edge/internal/input/a2a	0.627s
ok  	iop/apps/edge/internal/node	0.588s
ok  	iop/apps/edge/internal/openai	17.199s
ok  	iop/apps/edge/internal/opsconsole	0.435s
ok  	iop/apps/edge/internal/service	7.234s
ok  	iop/apps/edge/internal/transport	5.866s
```

Exit status: 0

### Edge vet

Command: `go vet ./apps/edge/...`

```text
```

Exit status: 0

### Formatting

Command: `gofmt -d apps/edge/internal/openai/hot_path_dispatch.go apps/edge/internal/openai/hot_path_terminal_control_test.go`

```text
```

Exit status: 0

### Diff

Command: `git diff --check`

```text
```

Exit status: 0

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |

## Code Review Result

- Overall Verdict: PASS
- Dimension Assessment:
  - Correctness: Pass
  - Completeness: Pass
  - Test Coverage: Pass
  - API Contract: Pass
  - Code Quality: Pass
  - Implementation Deviation: Pass
  - Verification Trust: Pass
  - Spec Conformance: Pass
- Findings: None
- Routing Signals:
  - `review_rework_count=3`
  - `evidence_integrity_failure=false`
- Next Step: Archive the active pair, write `complete.log`, and move the completed split task to the monthly task archive.
