<!-- task=m-iop-hot-path-one-shot-execution/20+17,19_smoke_harness plan=2 tag=TEST milestone-task=hot-smoke -->

# Code Review Reference - TEST

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is mandatory.** Fill implementation-owned self-test evidence and leave active files in place. Do not run actual credentials in this child. Verdict/finalization is review-agent-only.

## Overview

date=2026-08-03
task=m-iop-hot-path-one-shot-execution/20+17,19_smoke_harness, plan=2, tag=TEST

## Archive Evidence Snapshot

- Plan/review 1 was superseded before implementation; it contains no implementation verdict/evidence.

## For the Review Agent

Verify harness/schema safety and deterministic self-test, archive to `code_review_cloud_G08_2.log` and `plan_local_G08_2.log`, then finalize by verdict. Preserve `milestone-task=hot-smoke` on PASS.

## Implementation Item Completion

| Item | Status |
|---|---|
| TEST-1 Harness and schema | [ ] |
| TEST-2 Credential-free harness evidence | [ ] |

## Implementation Checklist

- [ ] [TEST-1] Add a secret-safe Claude/Pi harness and explicit JSON manifest schema for the fixed 10-row matrix, source/runtime identity, observation, workspace, terminal, cleanup, and redaction evidence.
- [ ] [TEST-2] Add credential-free fake-agent/runtime self-tests for success, expected failure, cancellation, schema rejection, identity mismatch, redaction, and cleanup.
- [ ] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

- [x] Append verdict/routing signals and verify findings/dimensions.
- [x] Archive review/plan to suffix `2`; verify `.gitignore` managed block.
- [x] On PASS write `complete.log`, preserve metadata, archive child; on WARN/FAIL write directed state without completion.

## Deviations from Plan

_Implementer records actual deviations or `none`._

## Key Design Decisions

_Implementer records actual decisions._

## Reviewer Checkpoints

- Confirm exact Claude/Pi argv, fixed 2×5 rows, JSON schema, source/runtime fingerprint validation, disposable workspace, and child-only cancellation.
- Confirm missing/mismatched inputs exit 69 before provider invocation and no secret/raw value is echoed or serialized.
- Confirm self-test uses only fake agents/runtime and this child does not modify Makefile or perform actual external calls.

## Verification Results

### Syntax

Command: `bash -n scripts/e2e-hot-path-agents.sh`

_Paste actual stdout/stderr and exit status._

### Schema

Command: `jq -e '.type == "object" and (.required | index("cases")) and (.properties.cases.minItems == 10) and (.properties.cases.maxItems == 10)' scripts/fixtures/hot-path-agent-smoke-manifest.schema.json`

_Paste actual stdout/stderr and exit status._

### Self-test

Command: `./scripts/e2e-hot-path-agents.sh --self-test`

_Paste actual stdout/stderr and exit status._

### Common regression

Command: `go test -race -count=1 ./packages/go/streamgate ./packages/go/config ./apps/edge/internal/openai ./apps/edge/internal/service`

_Paste actual stdout/stderr and exit status._

### Diff

Command: `git diff --check`

_Paste actual stdout/stderr and exit status._

## Section Ownership

Implementer owns completion status, deviations, decisions, and outputs. Reviewer alone owns review-only actions and final result.

## Code Review Result

- Overall Verdict: FAIL
- Dimension Assessment:
  - Correctness: Fail — the planned harness and manifest schema do not exist, so none of the required smoke behavior is implemented.
  - Completeness: Fail — TEST-1, TEST-2, and all implementation-owned evidence fields remain incomplete.
  - Test Coverage: Fail — the credential-free fake-agent/runtime self-test is absent.
  - API Contract: Fail — the fixed 10-case evidence manifest contract is absent and cannot be checked against SDD scenario S16.
  - Code Quality: Pass — no in-scope implementation exists to introduce source-quality defects.
  - Implementation Deviation: Fail — the implementation is wholly absent from the two source paths claimed by the plan.
  - Verification Trust: Fail — fresh reviewer commands fail because the planned script and schema are missing.
- Findings:
  - Required — `scripts/e2e-hot-path-agents.sh:1`: add the planned secret-safe Claude/Pi harness, including the fixed 2×5 matrix, strict pre-provider validation, runtime/source identity checks, isolated workspaces, child-only cancellation, redaction, cleanup, and fake-agent/runtime self-test. Fresh review evidence: syntax exit 127 and self-test exit 127 because the file is absent.
  - Required — `scripts/fixtures/hot-path-agent-smoke-manifest.schema.json:1`: add the closed JSON schema required by TEST-1 and validate the exact 10-case manifest shape. Fresh review evidence: the schema command exits 2 because the file is absent.
  - Required — `agent-task/m-iop-hot-path-one-shot-execution/20+17,19_smoke_harness/CODE_REVIEW-cloud-G08.md:20`: complete TEST-1/TEST-2 and record actual syntax, schema, self-test, common regression, and diff outputs before requesting another review.
- Routing Signals:
  - `review_rework_count=1`
  - `evidence_integrity_failure=false`
- Next Step: Create a freshly routed follow-up PLAN/CODE_REVIEW pair for the missing in-repository implementation and deterministic verification.
