<!-- task=m-iop-hot-path-one-shot-execution/10+07,09_light_flow plan=3 tag=REVIEW_API milestone-task=light-flow -->

# Code Review Reference - REVIEW_API

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-08-03
task=m-iop-hot-path-one-shot-execution/10+07,09_light_flow, plan=3, tag=REVIEW_API

## Archive Evidence Snapshot

- Current pair after review finalization: `plan_cloud_G05_2.log` and `code_review_cloud_G05_2.log`; verdict `FAIL`, `review_rework_count=3`, `evidence_integrity_failure=true`.
- Required finding 1: `validateStageCorrelation` applies the logical-request token alphabet to `ProviderID`, although `NodeProviderConf.Validate` accepts every non-empty provider ID; a valid dotted provider route can therefore fail before local/review prompt construction.
- Required finding 2: the tunnel assertions remain optional when `PrepareProtocolTunnel` is nil and inspect raw JSON substrings instead of decoding the selected protocol's exact `messages` content.
- Affected files: `apps/edge/internal/openai/hot_path_stage_input.go` and `apps/edge/internal/openai/hot_path_light_test.go`.
- Fresh reviewer evidence: both item race tests, focused light/review race tests, common race tests, focused vet, formatting, and `git diff --check` exit 0; source/contract inspection contradicts the two checked completion claims above.
- Earlier loop evidence remains in `plan_cloud_G10_0.log`, `code_review_cloud_G10_0.log`, `plan_local_G05_1.log`, and `code_review_cloud_G05_1.log`; predecessors 07 and 09 remain satisfied by their exact archived `complete.log` files.

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G05.md` → `code_review_cloud_G05_3.log` and `PLAN-cloud-G05.md` → `plan_cloud_G05_3.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-iop-hot-path-one-shot-execution/10+07,09_light_flow/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and task group is `m-<milestone-slug>`, preserve the first-line `milestone-task` metadata in `complete.log` and report it for the runtime aggregation event. Roadmap state evaluation belongs to `sync-milestone-workstate`.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| REVIEW_API-1 Preserve contract-compatible opaque correlation values | [x] |
| REVIEW_API-2 Decode and require selected-protocol message payloads | [x] |

## Implementation Checklist

- [x] Preserve bounded opaque provider correlations with a deterministic line-safe prompt representation while keeping IOP-owned IDs strict.
- [x] Require decoded normalized, OpenAI Chat, and Anthropic Messages correlation/isolation evidence with no optional tunnel path.
- [x] Run focused, common race, vet, format, and diff verification with fresh test execution.
- [x] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [x] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [x] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [x] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G05_3.log`.
- [x] Archive active `PLAN-*-G??.md` to `plan_cloud_G05_3.log`.
- [x] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [x] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [x] If PASS, move active task directory `agent-task/m-iop-hot-path-one-shot-execution/10+07,09_light_flow/` to `agent-task/archive/YYYY/MM/m-iop-hot-path-one-shot-execution/10+07,09_light_flow/` and update this checklist at the final archive path.
- [x] If PASS and task group is `m-<milestone-slug>`, preserve and report `milestone-task` metadata for runtime aggregation, without modifying roadmap or directly calling `update-roadmap`.
- [x] If PASS for split work, remove empty active parent `agent-task/m-iop-hot-path-one-shot-execution/` or verify it was kept due to remaining siblings/files.
- [ ] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

None.

## Key Design Decisions

- Retained strict logical request ID validation for IOP-owned StageID and RunID while relaxing ResponseID, ProviderID, and Terminal validation to bounded opaque correlation check (non-empty, <=256 bytes, no control characters).
- Marshaled stage correlations as single-line JSON (`correlationPromptValue`) to guarantee deterministic line-safe prompt formatting free of prompt structure injection.
- Created `decodeSelectedTunnelPrompt` helper to make `PrepareProtocolTunnel` and `BuildBody` execution mandatory in light flow regression tests, decoding OpenAI Chat and Anthropic Messages payloads to verify the first user message content against `req.Run.Prompt`.

## Reviewer Checkpoints

- IOP-owned stage/run identities remain on the strict logical-request token predicate.
- Dotted/delimited provider-owned response, provider, and terminal values round-trip exactly in a bounded deterministic one-line representation; empty, control, and overlength values fail closed.
- Captured local/review requests require a non-nil preparation hook and selected-protocol body builder.
- Decoded Chat and Messages bodies contain the normalized prompt in the exact first user-message content; local carries selector-only correlation and review carries selector plus local correlation.
- Existing pass/repair flows retain fixed local/review stage identity and one cleanup transition.

## Verification Results

Paste actual stdout/stderr below each command. Do not summarize or reconstruct output. If a command changes, record the replacement and reason in `Deviations from Plan`.

### REVIEW_API-1 item verification

```bash
go test -race -count=1 ./apps/edge/internal/openai -run '^TestHotPathStageInputIsolation$'
```

_Actual stdout/stderr:_

```text
ok  	iop/apps/edge/internal/openai	1.068s
```

### REVIEW_API-2 item verification

```bash
go test -race -count=1 ./apps/edge/internal/openai -run 'TestHotPath(LightLocal|StageInput)'
```

_Actual stdout/stderr:_

```text
ok  	iop/apps/edge/internal/openai	1.149s
```

### Final verification

```bash
go test -race -count=1 ./apps/edge/internal/openai -run 'TestHotPath(Light|Review|StageInput)'
```

_Actual stdout/stderr:_

```text
ok  	iop/apps/edge/internal/openai	1.338s
```

```bash
go test -race -count=1 ./packages/go/streamgate ./packages/go/config ./apps/edge/internal/openai ./apps/edge/internal/service
```

_Actual stdout/stderr:_

```text
ok  	iop/packages/go/streamgate	1.998s
ok  	iop/packages/go/config	1.569s
ok  	iop/apps/edge/internal/openai	9.723s
ok  	iop/apps/edge/internal/service	7.091s
```

```bash
go vet ./apps/edge/internal/openai
```

_Actual stdout/stderr:_

```text

```

```bash
gofmt -d apps/edge/internal/openai/hot_path_stage_input.go apps/edge/internal/openai/hot_path_light_test.go
```

_Actual stdout/stderr:_

```text

```

```bash
git diff --check
```

_Actual stdout/stderr:_

```text

```

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |

## Code Review Result

- Overall Verdict: PASS
- Dimension Assessment:
  - Correctness: Pass
  - Completeness: Pass
  - Test Coverage: Pass
  - API Contract: Pass
  - Code Quality: Pass
  - Implementation Deviation: Pass
  - Verification Trust: Pass
  - Spec Conformance: Pass
- Findings: None.
- Routing Signals:
  - `review_rework_count=3`
  - `evidence_integrity_failure=false`
- Next Step: Write `complete.log`, archive the active pair and task directory, and emit milestone completion metadata for runtime aggregation.
