<!-- task=m-node-provider-execution-liveness-recovery/05+04_failure_wire_contract plan=2 tag=API milestone-task=failure-handoff -->

# Code Review Reference - API

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-08-05
task=m-node-provider-execution-liveness-recovery/05+04_failure_wire_contract, plan=2, tag=API

## Archive Evidence Snapshot

- Predecessor: `agent-task/archive/2026/08/m-node-provider-execution-liveness-recovery/04+03_health_evidence/complete.log`; final verdict PASS.
- Refined parent: `plan_local_G07_1.log` and `code_review_cloud_G07_1.log` in this directory; unimplemented, no verdict or implementation evidence.
- This child retains parent API-1 only. The dependent Node mapper child owns present/absent semantic round-trips.

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G07.md` → `code_review_cloud_G07_2.log` and `PLAN-local-G07.md` → `plan_local_G07_2.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-node-provider-execution-liveness-recovery/05+04_failure_wire_contract/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS, preserve the first-line `milestone-task` metadata in `complete.log` and report it for runtime aggregation. Roadmap state evaluation belongs to `sync-milestone-workstate`.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| API-1: Add the typed failure wire model | [x] |

## Implementation Checklist

- [x] API-1 adds one safe optional non-recursive failure message to both protobuf envelopes and the in-memory tunnel type without changing existing field numbers.
- [x] Regenerate checked-in Go and Dart bindings through repository workflows and prove all generated consumers compile.
- [x] Run generation, client, repository/package, vet, and diff verification with fresh output.
- [x] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [x] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [x] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [x] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G07_2.log`.
- [x] Archive active `PLAN-*-G??.md` to `plan_local_G07_2.log`.
- [x] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [x] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [x] If PASS, move active task directory `agent-task/m-node-provider-execution-liveness-recovery/05+04_failure_wire_contract/` to `agent-task/archive/YYYY/MM/m-node-provider-execution-liveness-recovery/05+04_failure_wire_contract/` and update this checklist at the final archive path.
- [x] If PASS, preserve and report `milestone-task` metadata for runtime aggregation, without modifying roadmap or directly calling `update-roadmap`.
- [x] If PASS for split work, remove empty active parent `agent-task/m-node-provider-execution-liveness-recovery/` or verify it was kept due to remaining siblings/files.
- [ ] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

None. Note that `protoc-gen-dart` was installed via `flutter pub global activate protoc_plugin` prior to running `make proto-dart` as indicated in the plan verification instructions.

## Key Design Decisions

- Added non-recursive `ExecutionFailure` message (`code`, `message`, `retryable`, `metadata`) to `proto/iop/runtime.proto`.
- Added optional `ExecutionFailure failure = 13;` field to `RunEvent` envelope.
- Added optional `ExecutionFailure failure = 15;` field to `ProviderTunnelFrame` envelope.
- Added optional `Failure *Failure` typed failure pointer with ownership commentary to in-memory `ProviderTunnelFrame` struct in `packages/go/execution/types.go`.
- Preserved backward compatibility by retaining all existing protobuf tag numbers and leaving failure population/mapping semantics to the dependent mapper child (`06+05_failure_wire_mapping`).

## Reviewer Checkpoints

- Confirm existing protobuf field numbers remain unchanged and the new failure is optional/non-recursive.
- Confirm generated Go and Dart descriptors match the schema and the in-memory tunnel pointer has clear ownership.
- Confirm this child does not populate failure fields or leak mapper/recovery scope.

## Verification Results

> Implementing agent: run each command exactly as written and paste its actual stdout/stderr under `Output`. Record any replacement command and reason in `Deviations from Plan`.

### Verification 1

Command:

```bash
make proto && make proto-dart
```

Output:

```
protoc \
	--go_out=. \
	--go_opt=module=iop \
	--proto_path=. \
	proto/iop/runtime.proto \
	proto/iop/node.proto \
	proto/iop/control.proto \
	proto/iop/job.proto
mkdir -p apps/client/lib/gen
protoc \
	--plugin=protoc-gen-dart=/config/.local/bin/protoc-gen-dart \
	--dart_out=apps/client/lib/gen \
	--proto_path=. \
	--proto_path=/config/.local/include \
	proto/iop/runtime.proto \
	proto/iop/node.proto \
	proto/iop/control.proto \
	proto/iop/job.proto
```

### Verification 2

Command:

```bash
make client-test
```

Output:

```
cd apps/client && flutter test
00:15 +44: All tests passed!
```

### Verification 3

Command:

```bash
go test -count=1 ./packages/go/execution ./apps/node/... ./apps/edge/internal/transport ./apps/control-plane/...
```

Output:

```
ok  	iop/packages/go/execution	0.273s
ok  	iop/apps/node/cmd/node	0.288s
ok  	iop/apps/node/internal/adapters	0.212s
?   	iop/apps/node/internal/adapters/mock	[no test files]
ok  	iop/apps/node/internal/adapters/ollama	0.094s
ok  	iop/apps/node/internal/adapters/openai_compat	0.259s
ok  	iop/apps/node/internal/adapters/vllm	0.198s
ok  	iop/apps/node/internal/bootstrap	1.621s
ok  	iop/apps/node/internal/node	1.311s
ok  	iop/apps/node/internal/router	0.561s
ok  	iop/apps/node/internal/store	0.122s
ok  	iop/apps/node/internal/transport	5.868s
ok  	iop/apps/edge/internal/transport	5.162s
ok  	iop/apps/control-plane/cmd/control-plane	3.381s
ok  	iop/apps/control-plane/internal/credentiallease	0.144s
ok  	iop/apps/control-plane/internal/credentialops	0.253s
ok  	iop/apps/control-plane/internal/credentialseal	0.126s
ok  	iop/apps/control-plane/internal/credentialstore	0.303s
ok  	iop/apps/control-plane/internal/wire	2.024s
```

### Verification 4

Command:

```bash
go vet ./packages/go/execution ./apps/node/... ./apps/edge/internal/transport ./apps/control-plane/...
```

Output:

```
(Clean output, exit code 0)
```

### Verification 5

Command:

```bash
go test -count=1 ./...
```

Output:

```
ok  	iop/apps/control-plane/cmd/control-plane	3.637s
ok  	iop/apps/control-plane/internal/credentiallease	0.258s
ok  	iop/apps/control-plane/internal/credentialops	0.376s
ok  	iop/apps/control-plane/internal/credentialseal	0.263s
ok  	iop/apps/control-plane/internal/credentialstore	0.440s
ok  	iop/apps/control-plane/internal/wire	2.125s
ok  	iop/apps/edge/cmd/edge	0.234s
ok  	iop/apps/edge/internal/authprojection	0.074s
ok  	iop/apps/edge/internal/bootstrap	0.598s
ok  	iop/apps/edge/internal/configrefresh	0.136s
ok  	iop/apps/edge/internal/controlplane	6.659s
ok  	iop/apps/edge/internal/edgecmd	0.145s
ok  	iop/apps/edge/internal/edgevalidate	0.082s
ok  	iop/apps/edge/internal/events	0.049s
ok  	iop/apps/edge/internal/input	0.113s
ok  	iop/apps/edge/internal/input/a2a	0.084s
ok  	iop/apps/edge/internal/node	0.086s
ok  	iop/apps/edge/internal/openai	7.489s
ok  	iop/apps/edge/internal/opsconsole	0.121s
ok  	iop/apps/edge/internal/service	5.956s
ok  	iop/apps/edge/internal/transport	4.866s
ok  	iop/apps/node/cmd/node	0.173s
ok  	iop/apps/node/internal/adapters	0.128s
?   	iop/apps/node/internal/adapters/mock	[no test files]
ok  	iop/apps/node/internal/adapters/ollama	0.065s
ok  	iop/apps/node/internal/adapters/openai_compat	0.204s
ok  	iop/apps/node/internal/adapters/vllm	0.185s
ok  	iop/apps/node/internal/bootstrap	1.535s
ok  	iop/apps/node/internal/node	1.032s
ok  	iop/apps/node/internal/router	0.539s
ok  	iop/apps/node/internal/store	0.084s
ok  	iop/apps/node/internal/transport	5.687s
?   	iop/apps/worker/cmd/worker	[no test files]
ok  	iop/packages/go/audit	0.035s
ok  	iop/packages/go/auth	10.057s
ok  	iop/packages/go/config	0.122s
ok  	iop/packages/go/credentiallease	0.090s
?   	iop/packages/go/events	[no test files]
ok  	iop/packages/go/execution	0.130s
ok  	iop/packages/go/hostsetup	0.055s
?   	iop/packages/go/jobs	[no test files]
?   	iop/packages/go/metadata	[no test files]
ok  	iop/packages/go/observability	0.131s
?   	iop/packages/go/policy	[no test files]
ok  	iop/packages/go/streamgate	0.920s
?   	iop/packages/go/version	[no test files]
?   	iop/proto/gen/iop	[no test files]
ok  	iop/scripts/inventory-query	0.023s
```

### Verification 6

Command:

```bash
git diff --check
```

Output:

```
(Clean output, exit code 0)
```

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |

## Code Review Result

- Overall Verdict: PASS
- Dimension Assessment:
  - Correctness: Pass — the schema change is additive, preserves every existing field number, and uses a non-recursive optional message on both envelopes.
  - Completeness: Pass — API-1 source, in-memory type, generated Go binding, and generated Dart binding outputs are complete for this foundation child.
  - Test Coverage: Pass — generation, Flutter tests, focused Go consumers, repository-wide Go tests, vet, and diff checks passed with fresh reviewer output.
  - API Contract: Pass — proto3 message presence preserves legacy absence, and both new fields use previously unused tag numbers.
  - Code Quality: Pass — generated files reproduce cleanly and the in-memory field documents the transport-mapper ownership boundary.
  - Implementation Deviation: Pass — no behavioral scope beyond the API-1 foundation was added; unchanged Dart enum/server companions are valid generator outputs.
  - Verification Trust: Pass — the reviewer reran every recorded command and confirmed matching successful results.
  - Spec Conformance: Pass — this contribution establishes the optional raw-free S04 wire shape while leaving population and round-trip semantics to the declared dependent mapper child.
- Findings:
  - Nit (fixed): `packages/go/execution/types.go:250` now states that transport mappers own serialization of the optional typed failure.
- Routing Signals:
  - `review_rework_count=0`
  - `evidence_integrity_failure=false`
- Next Step: PASS — write `complete.log`, archive the active pair and task directory, and emit milestone completion metadata for runtime aggregation.
