<!-- task=m-iop-agent-cli-runtime/26+19,21,22,23,25_parity_cutover plan=4 tag=REVIEW_REFACTOR -->

# Code Review Reference - REVIEW_REFACTOR

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-07-31
task=m-iop-agent-cli-runtime/26+19,21,22,23,25_parity_cutover, plan=4, tag=REVIEW_REFACTOR

## Roadmap Targets

- Milestone: `agent-roadmap/phase/automation-runtime-bridge/milestones/iop-agent-cli-runtime.md`
- Milestone link: [Milestone document](agent-roadmap/phase/automation-runtime-bridge/milestones/iop-agent-cli-runtime.md)
- Task ids:
  - `parity-cutover`: classify Python/Node behavior and cut production task-loop ownership to Go with zero unclassified/runtime dependency/duplicate
- Completion mode: check-on-pass

## Archive Evidence Snapshot

- Prior task: `agent-task/m-iop-agent-cli-runtime/26+19,21,22,23,25_parity_cutover`.
- Prior verdict: FAIL in `code_review_cloud_G08_3.log`; Required=2, Suggested=0, Nit=0.
- Prior plan: `plan_cloud_G08_3.log`.
- Required finding 1: `canonicalizeCandidateSeen` rejects a valid contained new-file path after 255 nonexistent parent components because its depth counter is not limited to symlink traversals.
- Required finding 2: disposed validation accepts a shortened `Disposal.ReferenceFiles` list after deletion and therefore loses checksum-bound historical evidence.
- Fresh reviewer evidence: formatting, focused, race, vet, parity, build, built validator/parity/dry-run, broad zero-match, and full Go suites passed with `/tmp` cache roots. One temporary reviewer reproducer deterministically failed both omitted variants and was removed.
- Roadmap carryover: approved SDD S13 and its Evidence Map still require symlink-resolved literal write-set containment plus disposition-complete, checksum-bound physical-disposal evidence.

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G08.md` → `code_review_cloud_G08_4.log` and `PLAN-cloud-G08.md` → `plan_cloud_G08_4.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-iop-agent-cli-runtime/26+19,21,22,23,25_parity_cutover/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and task group is `m-<milestone-slug>`, report completion event metadata. Roadmap state check and `update-roadmap` calls are runtime responsibilities.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| REVIEW_REFACTOR-1 Separate path depth from symlink traversal | [x] |
| REVIEW_REFACTOR-2 Preserve checksum-bound disposal history | [x] |

## Implementation Checklist

- [x] Decouple nonexistent suffix reconstruction from the symlink traversal budget and add deterministic deep-target regression coverage without weakening escape or loop rejection.
- [x] Require exact classified-reference/disposal inventory equality in retained and disposed states and add a disposed-state missing-history regression while preserving all nine live fixtures.
- [x] Run fresh formatting, focused, race, vet, parity, built-command, zero-match, and full Go verification with repository-external cache/tmp roots.
- [x] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [x] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [x] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [x] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G08_4.log`.
- [x] Archive active `PLAN-*-G??.md` to `plan_cloud_G08_4.log`.
- [x] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [x] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [x] If PASS, move active task directory `agent-task/m-iop-agent-cli-runtime/26+19,21,22,23,25_parity_cutover/` to `agent-task/archive/YYYY/MM/m-iop-agent-cli-runtime/26+19,21,22,23,25_parity_cutover/` and update this checklist at the final archive path.
- [x] If PASS and task group is `m-<milestone-slug>`, report completion event metadata for runtime, without modifying roadmap or directly calling `update-roadmap`.
- [x] If PASS for split work, remove empty active parent `agent-task/m-iop-agent-cli-runtime/` or verify it was kept due to remaining siblings/files.
- [ ] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

None.

## Key Design Decisions

- The symlink budget advances only when the candidate itself is a symlink that is followed. Recursive reconstruction of ordinary nonexistent parent components preserves the same physical-parent resolution without consuming that budget.
- Classified reference sources and disposal entries are compared as exact bidirectional sets before retained/disposed state validation. Sorted missing or extra keys make an inventory error deterministic.

## Reviewer Checkpoints

- The missing-suffix traversal does not consume the symlink-resolution budget.
- A contained literal target deeper than 255 nonexistent components normalizes successfully below platform path limits.
- Contained/external broken symlinks and real symlink loops retain their current pass/fail behavior.
- Classified Python `ReferenceSources` and `Disposal.ReferenceFiles` form the same exact deterministic inventory before either state branch.
- Disposed mode rejects a missing historical entry while accepting complete deletion with the unchanged inventory.
- The nine live retained fixtures remain unchanged and checksum-valid.
- SDD S13 and `iop.agent-cli-runtime` require no text change because the implementation now meets their existing evidence contract.

## Verification Results

### Deep PLAN target

```bash
TMPDIR=/tmp/t GOCACHE=/tmp/iop-s0-parity-fourth-gocache GOTMPDIR=/tmp/t \
  go test -count=1 ./apps/agent/internal/taskloop -run 'Test.*ValidatePlan'
```

```text
ok  	iop/apps/agent/internal/taskloop	0.012s
```

### Disposal history

```bash
TMPDIR=/tmp/t GOCACHE=/tmp/iop-s0-parity-fourth-gocache GOTMPDIR=/tmp/t \
  go test -count=1 ./apps/agent/internal/taskloop -run 'Test.*(Parity|Disposition|Disposal)'
```

```text
ok  	iop/apps/agent/internal/taskloop	0.019s
```

### Final verification

```bash
mkdir -p /tmp/iop-s0-parity-fourth-gocache /tmp/t
gofmt -w apps/agent/internal/taskloop/workflow.go apps/agent/internal/taskloop/workflow_test.go apps/agent/internal/taskloop/parity.go apps/agent/internal/taskloop/parity_test.go
TMPDIR=/tmp/t GOCACHE=/tmp/iop-s0-parity-fourth-gocache GOTMPDIR=/tmp/t go test -count=1 ./apps/agent/internal/taskloop -run 'TestValidatePlanWriteSetDeepNonexistentTarget|TestParityManifestDisposedRejectsMissingHistoricalInventory'
TMPDIR=/tmp/t GOCACHE=/tmp/iop-s0-parity-fourth-gocache GOTMPDIR=/tmp/t go test -count=1 ./apps/agent/internal/taskloop ./apps/agent/internal/command ./apps/agent/cmd/agent
TMPDIR=/tmp/t GOCACHE=/tmp/iop-s0-parity-fourth-gocache GOTMPDIR=/tmp/t go test -count=1 -race ./apps/agent/internal/taskloop ./apps/agent/internal/command ./apps/agent/cmd/agent
TMPDIR=/tmp/t GOCACHE=/tmp/iop-s0-parity-fourth-gocache GOTMPDIR=/tmp/t go vet ./apps/agent/internal/taskloop ./apps/agent/internal/command ./apps/agent/cmd/agent
TMPDIR=/tmp/t GOCACHE=/tmp/iop-s0-parity-fourth-gocache GOTMPDIR=/tmp/t make test-iop-agent-parity
TMPDIR=/tmp/t GOCACHE=/tmp/iop-s0-parity-fourth-gocache GOTMPDIR=/tmp/t make build-agent
build/bin/iop-agent task-loop validate-plan --workspace /config/workspace/iop-s0 agent-task/m-iop-agent-cli-runtime/26+19,21,22,23,25_parity_cutover/PLAN-cloud-G08.md
build/bin/iop-agent task-loop parity --disposal-manifest
build/bin/iop-agent task-loop --dry-run --task-group m-iop-agent-cli-runtime
rg -n --sort path 'python3 .*orchestrate-agent-task-loop|dispatch\.py --workspace|dispatch\.py' agent-ops/skills/common agent-ops/skills/project agent-ops/rules --glob '!**/tests/**' --glob '!agent-ops/skills/project/orchestrate-agent-task-loop/scripts/**'
TMPDIR=/tmp/t GOCACHE=/tmp/iop-s0-parity-fourth-gocache GOTMPDIR=/tmp/t go test -count=1 ./packages/go/... ./apps/agent/...
git diff --check
```

```text
preflight:
command -v go: /config/.local/bin/go
go version: go version go1.26.2 linux/arm64
go env GOROOT: /config/opt/go

gofmt: exit 0 (no stdout/stderr)
focused regression:
ok  	iop/apps/agent/internal/taskloop	0.007s

agent package suite:
ok  	iop/apps/agent/internal/taskloop	4.275s
ok  	iop/apps/agent/internal/command	0.012s
ok  	iop/apps/agent/cmd/agent	3.414s

race suite:
ok  	iop/apps/agent/internal/taskloop	10.123s
ok  	iop/apps/agent/internal/command	1.032s
ok  	iop/apps/agent/cmd/agent	8.742s
go vet: exit 0 (no stdout/stderr)
make test-iop-agent-parity: exit 0 (no stdout/stderr)

make build-agent:
mkdir -p build/bin
go build -trimpath -o build/bin/iop-agent ./apps/agent/cmd/agent

task-loop validate-plan: exit 0 (no stdout/stderr)

task-loop parity --disposal-manifest:
parity: ok
  schema_version: 1
  behaviors: 13
  disposal_state: retained
  disposal_files: 9
  deletion_gate: milestone-completion-transition
  ids: canonical-workspace-parallel-write,failure-classification-budget,node-runtime-consumer,observation-banner-output,ordered-target-selection,parallel-dispatch-scheduling,quota-probe-failover-promotion,restart-reconciliation-recovery,review-convergence,shared-checkout-write-claim,static-provider-model-capacity-tables,task-scan-dependency-ready,work-log-archive

task-loop --dry-run --task-group m-iop-agent-cli-runtime:
task-loop dry_run=true projects=1
  - project=workspace group=m-iop-agent-cli-runtime status=read-only next=26
  exit_code: 0

production-caller rg search: exit 1 as expected; no matches

full Go suite:
ok  	iop/packages/go/agentconfig	0.062s
ok  	iop/packages/go/agentguard	0.023s
ok  	iop/packages/go/agentpolicy	0.059s
ok  	iop/packages/go/agentprovider/catalog	0.103s

git diff --check: exit 0 (no stdout/stderr)
```

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Roadmap Targets | Fixed at stub creation from plan when present | Implementing agent must not modify; code-review copies it into `complete.log` as `Roadmap Completion` only on PASS |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |

## Code Review Result

- Overall Verdict: PASS
- Dimension Assessment:
  - Correctness: Pass — ordinary nonexistent suffix components no longer consume the symlink traversal budget, and disposed validation requires exact equality between the classified reference-source inventory and the checksum-bound disposal inventory.
  - Completeness: Pass — both inherited Required findings are closed in production code and deterministic regression coverage, while existing symlink escape, loop, retained, and disposed invariants remain enforced.
  - Test Coverage: Pass — focused tests cover a contained target deeper than the symlink budget and reject a truncated disposed history after complete fixture deletion; the surrounding PLAN, parity, cutover, package, and race suites also pass.
  - API Contract: Pass — `PlanWriteSet` preserves contained literal new-file admission with symlink-resolved physical containment, and the S13 disposal transition retains complete checksum-bound historical evidence.
  - Code Quality: Pass — the changes are focused, formatted, deterministic, and introduce no debug output, dead code, or unrelated production behavior.
  - Implementation Deviation: Pass — the implementation matches the planned four-file source/test scope and requires no roadmap, SDD, or contract text change.
  - Verification Trust: Pass — fresh reviewer execution reproduced the focused oracles and passed formatting, package, race, vet, parity, build, built-command, zero-match, and full Go verification with repository-external cache/tmp roots.
  - Spec Conformance: Pass — approved SDD S13 and the `iop.agent-cli-runtime` Evidence Map are satisfied for literal PLAN containment and disposition-complete physical-disposal evidence.
- Findings: None.
- Routing Signals:
  - `review_rework_count=3`
  - `evidence_integrity_failure=false`
- Next Step: Write `complete.log`, archive the active pair and task directory, and report the milestone completion event metadata without modifying the roadmap.
