<!-- task=m-openai-compatible-output-validation-filters/02+01_repeat_guard plan=25 tag=REVIEW_OFR-REPEAT-24 -->

# Code Review Reference - REVIEW_OFR-REPEAT-24

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-07-30
task=m-openai-compatible-output-validation-filters/02+01_repeat_guard, plan=25, tag=REVIEW_OFR-REPEAT-24

## Roadmap Targets

- Milestone: `agent-roadmap/phase/knowledge-tool-optimization-extension/milestones/openai-compatible-output-validation-filters.md`
- Milestone link: [Milestone document](agent-roadmap/phase/knowledge-tool-optimization-extension/milestones/openai-compatible-output-validation-filters.md)
- Task ids:
  - `repeat-guard`: rolling content/history/action repetition detection and safe continuation
- Completion mode: check-on-pass

## Archive Evidence Snapshot

- Dependency `01_resume_notice_builder` is satisfied by `agent-task/archive/2026/07/m-openai-compatible-output-validation-filters/01_resume_notice_builder/complete.log`.
- The failed pair is archived as `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/plan_cloud_G08_24.log` and `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/code_review_cloud_G08_24.log`.
- Verdict: FAIL; Required=1, Suggested=0, Nit=0.
- Required finding: `code_review_cloud_G08_24.log:214` records invocation count 0, and lines 225-226 confirm that no `summary.json`, provider-response IDs, Edge correlations, capacity rows, final result, provider-idle/harness-cleanup proof, or post-run source/runtime identity exists.
- Fresh reviewer evidence on 2026-07-30: `git diff --check` exited 0; SHA-256 was `8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21`; focused repeat-guard tests exited 0 in 0.322s; `go test -count=1 ./packages/go/streamgate ./apps/edge/internal/openai` exited 0 in 0.882s and 7.317s; config coverage exited 0 in 0.141s.
- Fresh reviewer exact preflight exited 127 with `/bin/bash: line 1: zsh: command not found`; the live Go test was not launched.
- Follow-up: execute the existing live oracle exactly once on `/Users/toki/agent-work/iop-dev` after every source, runtime, capacity, and isolation precondition passes, or record exact attempted preflight output and the resume condition if still blocked.

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G08.md` → `code_review_cloud_G08_25.log` and `PLAN-cloud-G08.md` → `plan_cloud_G08_25.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-openai-compatible-output-validation-filters/02+01_repeat_guard/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and task group is `m-<milestone-slug>`, report completion event metadata. Roadmap state check and `update-roadmap` calls are runtime responsibilities.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| REVIEW_OFR-REPEAT-24-1 — On the verified Darwin/arm64 dev runner, execute exactly one fresh `ornith:35b` 5-concurrent × 3 live invocation after every precondition passes, then record 15 provider responses, 15 Edge correlations, three accepted capacity rows, the sanitized final result, and cleanup evidence; if preflight blocks execution, record exact attempted output, invocation count 0, and the resume condition. | [x] |

## Implementation Checklist

- [x] [REVIEW_OFR-REPEAT-24-1] On the verified Darwin/arm64 dev runner, execute exactly one fresh `ornith:35b` 5-concurrent × 3 live invocation after every precondition passes, then record 15 provider responses, 15 Edge correlations, three accepted capacity rows, the sanitized final result, and cleanup evidence; if preflight blocks execution, record exact attempted output, invocation count 0, and the resume condition.
- [x] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [x] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [x] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [x] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G08_25.log`.
- [x] Archive active `PLAN-*-G??.md` to `plan_cloud_G08_25.log`.
- [x] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [ ] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [ ] If PASS, move active task directory `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/` to `agent-task/archive/YYYY/MM/m-openai-compatible-output-validation-filters/02+01_repeat_guard/` and update this checklist at the final archive path.
- [ ] If PASS and task group is `m-<milestone-slug>`, report completion event metadata for runtime, without modifying roadmap or directly calling `update-roadmap`.
- [ ] If PASS for split work, remove empty active parent `agent-task/m-openai-compatible-output-validation-filters/` or verify it was kept due to remaining siblings/files.
- [x] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

None. The external source preflight was executed exactly as specified and blocked before the Darwin/arm64 checks because `zsh` is unavailable on this Linux host. Per the plan, no substitute runner or live invocation was used.

## Key Design Decisions

The live-test authorization remains unconsumed: the preflight failed before a Go test process could start. The existing Oracle must be resumed only from the specified Darwin/arm64 checkout after its login-shell, source, runtime, capacity, and isolation preconditions pass.

## Reviewer Checkpoints

- Confirm execution occurred on Darwin/arm64 at `/Users/toki/agent-work/iop-dev`, not in a substitute sandbox.
- Confirm login-shell Go is executable and the same shell invokes that exact binary.
- Confirm HEAD, test-only source delta, reviewed SHA-256, deployed runtime identities, listeners, active blocking gate, selected provider capacity/health, prompt/artifact containment, observation quiescence, and zero competing harnesses before launch.
- Confirm exactly one Go test process starts and exits 0.
- Confirm `summary.json` has three runs, 15 globally unique provider response IDs, 15 globally unique Edge correlations, and three accepted capacity rows with `configured=4`, `peak_in_flight=4`, `peak_queued>=1`, `final_in_flight=0`, and `final_queued=0`.
- Confirm sanitized `reproduced` includes fingerprint/offset or the result is `not_reproduced`; both providers return idle, no harness remains, source/runtime identities are unchanged, and no raw/secret-bearing material entered tracked evidence or stdout.
- If execution is blocked before launch, confirm the active review contains exact attempted commands/output, invocation count 0, the blocker, and the resume condition rather than placeholders.

## Verification Results

Record actual stdout/stderr and exit codes for every command. If blocked, record the exact attempted command, output, invocation count, and resume condition without asking the user or creating a control-plane stop file.

### Local Integrity Verification

```bash
git diff --check
sha256sum apps/edge/internal/openai/stream_gate_vertical_slice_test.go
go test -count=1 ./apps/edge/internal/openai -run 'TestDevRepeatGuard(SmokeEvidence|ObservationCorrelation|ObservationQuiescence|CapacityEvidence)'
go test -count=1 ./packages/go/streamgate ./apps/edge/internal/openai
go test -count=1 ./packages/go/config
```

Expected: all commands exit 0 and SHA-256 is `8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21`.

Implementation evidence:

```text
go version && go env GOMOD
stdout:
go version go1.26.2 linux/arm64
/config/workspace/iop-s1/go.mod
exit code: 0

git diff --check
stdout/stderr: (empty)
exit code: 0

sha256sum apps/edge/internal/openai/stream_gate_vertical_slice_test.go
stdout:
8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21  apps/edge/internal/openai/stream_gate_vertical_slice_test.go
exit code: 0

go test -count=1 ./apps/edge/internal/openai -run 'TestDevRepeatGuard(SmokeEvidence|ObservationCorrelation|ObservationQuiescence|CapacityEvidence)'
stdout:
ok  \tiop/apps/edge/internal/openai\t0.343s
exit code: 0

go test -count=1 ./packages/go/streamgate ./apps/edge/internal/openai
stdout:
ok  \tiop/packages/go/streamgate\t1.063s
ok  \tiop/apps/edge/internal/openai\t7.335s
exit code: 0

go test -count=1 ./packages/go/config
stdout:
ok  \tiop/packages/go/config\t0.083s
exit code: 0
```

### External Login-Shell and Source Preflight

```bash
zsh -lic '
set -eu
test "$(uname -s)" = "Darwin"
test "$(uname -m)" = "arm64"
cd /Users/toki/agent-work/iop-dev
go_bin="$(command -v go)"
test -n "$go_bin"
test -x "$go_bin"
"$go_bin" version
"$go_bin" env GOMOD
git rev-parse HEAD
git status --short
shasum -a 256 apps/edge/internal/openai/stream_gate_vertical_slice_test.go
'
```

Expected: Go 1.26.3, GOMOD `/Users/toki/agent-work/iop-dev/go.mod`, reviewed HEAD, only the reviewed test-file delta, and the reviewed hash.

Implementation evidence:

```text
Attempted command (executed exactly as shown):
zsh -lic '
set -eu
test "$(uname -s)" = "Darwin"
test "$(uname -m)" = "arm64"
cd /Users/toki/agent-work/iop-dev
go_bin="$(command -v go)"
test -n "$go_bin"
test -x "$go_bin"
"$go_bin" version
"$go_bin" env GOMOD
git rev-parse HEAD
git status --short
shasum -a 256 apps/edge/internal/openai/stream_gate_vertical_slice_test.go
'

stdout/stderr:
/bin/bash: line 1: zsh: command not found
exit code: 127
live invocation count: 0
blocker: The required `zsh -lic` Darwin login-shell preflight cannot start on this Linux host because `zsh` is not installed. This host cannot prove the required Darwin runner, checkout, deployed runtime, listeners, selected provider state, or observation sink.
resume condition: On Darwin/arm64 at `/Users/toki/agent-work/iop-dev`, rerun this exact preflight successfully. Only after all source, runtime, capacity, and isolation preconditions pass may the single authorized live command start.
```

### External Runtime and Isolation Preflight

Record sanitized evidence for deployed Edge/Node identities, listeners `18083`/`18001`, active blocking `repeat_guard`, idle selected provider aggregate capacity 4, bounded prompt, empty artifact directory `/tmp/iop-repeat-guard-live/repeat-guard-G08-25`, writable raw-free observation sink, zero competing harnesses, and stable observation identity/size through the quiet window.

Implementation evidence:

```text
Not run. The source preflight exited 127 before any runtime or isolation check. No Edge/Node identity, listener, filter-policy, provider-capacity, prompt/artifact, observation-sink, or competing-harness claim was made.

blocker: `/bin/bash: line 1: zsh: command not found`
resume condition: Complete the exact source preflight on the required Darwin/arm64 runner, then collect every specified sanitized runtime and isolation datum before the live invocation.
```

### Single Authorized Live Lifecycle and Capacity Verification

```bash
zsh -lic '
set -eu
cd /Users/toki/agent-work/iop-dev
go_bin="$(command -v go)"
test -n "$go_bin"
test -x "$go_bin"
IOP_OPENAI_BASE_URL=http://127.0.0.1:18083 \
IOP_OPENAI_MODEL=ornith:35b \
IOP_OPENAI_SMOKE_CONCURRENCY=5 \
IOP_OPENAI_SMOKE_RUNS=3 \
IOP_OPENAI_SMOKE_PROMPT_FILE=/tmp/iop-repeat-guard-live/repeat-prompt.txt \
IOP_OPENAI_SMOKE_ARTIFACT_DIR=/tmp/iop-repeat-guard-live/repeat-guard-G08-25 \
IOP_OPENAI_SMOKE_OBSERVATION_FILE=/tmp/iop-repeat-guard-live/edge-observations.jsonl \
IOP_OPENAI_SMOKE_STATUS_URL=http://127.0.0.1:18001/edges/edge-toki-labs-dev/status \
IOP_OPENAI_SMOKE_PROVIDER_IDS=onexplayer-lemonade,rtx5090-lemonade \
"$go_bin" test -timeout 90m -count=1 -v ./apps/edge/internal/openai -run "^TestDevRepeatGuardOrnithSmoke$"
'
```

Expected: invocation count 1, exit 0, 15 globally unique provider response IDs, 15 globally unique Edge correlations, three accepted capacity rows, and sanitized `reproduced` with fingerprint/offset or `not_reproduced`.

Implementation evidence:

```text
Not started; live invocation count: 0.

Pre-launch blocker: the required external source preflight exited 127 with `/bin/bash: line 1: zsh: command not found`. The live command was deliberately not attempted, so no authorized Go test process was consumed and no result, provider response, Edge correlation, or capacity row exists.

Resume condition: run the exact preflight on the specified Darwin/arm64 runner and start the live command exactly once only after every precondition passes.
```

### Summary and Cleanup Verification

Expected: `summary.json` proves all identity/lifecycle/capacity cardinality; both providers are idle, no harness remains, runtime/source identity is unchanged, and all raw artifacts remain outside the repository.

Implementation evidence:

```text
No `summary.json` was created because the live invocation did not start. Provider-idle, harness-cleanup, post-run runtime/source identity, and capacity evidence remain unverified rather than inferred. No live artifacts, prompts, SSE payloads, credentials, or endpoint material were written to the repository or this review evidence.

Remaining required post-run evidence: 15 unique provider response IDs, 15 unique Edge correlations, three accepted capacity rows, a sanitized `reproduced` or `not_reproduced` result, idle providers, no harness process, unchanged source/runtime identities, and raw-artifact containment.
```

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Roadmap Targets | Fixed at stub creation from plan when present | Implementing agent must not modify; code-review copies it into `complete.log` as `Roadmap Completion` only on PASS |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |

## Code Review Result

- Overall Verdict: FAIL
- Dimension Assessment:
  - Correctness: Pass — the reviewed live oracle and focused local assertions remain green.
  - Completeness: Fail — the required S07 Darwin/provider lifecycle was not executed.
  - Test Coverage: Fail — deterministic local coverage passes, but the required deployed-provider integration evidence is absent.
  - API Contract: Pass — no production or contract change was made in this follow-up.
  - Code Quality: Pass — no new source defect, debug output, dead code, or unrelated source change was found.
  - Implementation Deviation: Pass — the blocked preflight and zero-invocation outcome were recorded exactly as the plan required.
  - Verification Trust: Fail — the required live command and post-run cleanup checks remain unexecuted.
  - Spec Conformance: Fail — SDD S07 and its Evidence Map still lack provider, Edge lifecycle, capacity, result, and cleanup evidence.
- Findings:
  - Required — `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/CODE_REVIEW-cloud-G08.md:236` records live invocation count 0, and lines 238-252 confirm that no `summary.json`, 15 provider response IDs, 15 Edge correlations, three accepted capacity rows, final result, provider-idle/harness-cleanup proof, or post-run source/runtime identity exists. On the verified Darwin/arm64 runner, pass every source/runtime/capacity/isolation precondition, execute the existing authorized live command exactly once, and record the sanitized S07 cardinality, result, and cleanup evidence.
- Routing Signals:
  - `review_rework_count=25`
  - `evidence_integrity_failure=true`
- Next Step: Archive this FAIL pair and invoke the plan skill with the raw Required finding to prepare the smallest same-task verification follow-up.
