<!-- task=m-openai-compatible-output-validation-filters/02+01_repeat_guard plan=33 tag=REVIEW_OFR-REPEAT-32 -->

# Code Review Reference — REVIEW_OFR-REPEAT-32

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-07-30
task=m-openai-compatible-output-validation-filters/02+01_repeat_guard, plan=33, tag=REVIEW_OFR-REPEAT-32

## Roadmap Targets

- Milestone: `agent-roadmap/phase/knowledge-tool-optimization-extension/milestones/openai-compatible-output-validation-filters.md`
- Milestone link: [Milestone document](agent-roadmap/phase/knowledge-tool-optimization-extension/milestones/openai-compatible-output-validation-filters.md)
- Task ids:
  - `repeat-guard`: rolling content/history/action repetition detection and safe continuation
- Completion mode: check-on-pass

## Archive Evidence Snapshot

- Dependency `01_resume_notice_builder` is satisfied by `agent-task/archive/2026/07/m-openai-compatible-output-validation-filters/01_resume_notice_builder/complete.log`.
- The failed pair is archived as `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/plan_cloud_G08_32.log` and `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/code_review_cloud_G08_32.log`.
- Verdict: FAIL; Required=1, Suggested=0, Nit=0.
- Required finding: `code_review_cloud_G08_32.log:219` records invocation count 0, and line 227 confirms that no `summary.json`, provider-response record, Edge-correlation record, capacity row, final live result, or cleanup evidence exists.
- Fresh reviewer evidence on 2026-07-30: `git diff --check` exited 0; SHA-256 was `8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21`; focused repeat-guard tests exited 0 in 0.337s; `go test -count=1 ./packages/go/streamgate ./apps/edge/internal/openai` exited 0 in 0.928s and 7.350s; config coverage exited 0 in 0.098s.
- Fresh reviewer exact preflight exited 127 with `/bin/bash: line 10: zsh: command not found`; the live Go test was not launched and the sole authorization was not consumed.
- Follow-up: execute the existing live oracle exactly once on `/Users/toki/agent-work/iop-dev` after every source, runtime, capacity, and isolation precondition passes, or record exact attempted preflight output and the resume condition if still blocked.

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G08.md` → `code_review_cloud_G08_33.log` and `PLAN-cloud-G08.md` → `plan_cloud_G08_33.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-openai-compatible-output-validation-filters/02+01_repeat_guard/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and task group is `m-<milestone-slug>`, report completion event metadata. Roadmap state check and `update-roadmap` calls are runtime responsibilities.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| REVIEW_OFR-REPEAT-32-1 — On the verified Darwin/arm64 dev runner, execute exactly one fresh `ornith:35b` 5-concurrent × 3 live invocation after every precondition passes, then record 15 provider responses, 15 Edge correlations, three accepted capacity rows, the sanitized final result, and cleanup evidence; if preflight blocks execution, record exact attempted output, invocation count 0, and the resume condition. | [x] |

## Implementation Checklist

- [x] [REVIEW_OFR-REPEAT-32-1] On the verified Darwin/arm64 dev runner, execute exactly one fresh `ornith:35b` 5-concurrent × 3 live invocation after every precondition passes, then record 15 provider responses, 15 Edge correlations, three accepted capacity rows, the sanitized final result, and cleanup evidence; if preflight blocks execution, record exact attempted output, invocation count 0, and the resume condition.
- [x] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [x] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [x] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [x] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G08_33.log`.
- [x] Archive active `PLAN-*-G??.md` to `plan_cloud_G08_33.log`.
- [x] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [ ] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [ ] If PASS, move active task directory `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/` to `agent-task/archive/YYYY/MM/m-openai-compatible-output-validation-filters/02+01_repeat_guard/` and update this checklist at the final archive path.
- [ ] If PASS and task group is `m-<milestone-slug>`, report completion event metadata for runtime, without modifying roadmap or directly calling `update-roadmap`.
- [ ] If PASS for split work, remove empty active parent `agent-task/m-openai-compatible-output-validation-filters/` or verify it was kept due to remaining siblings/files.
- [x] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

None. The required live invocation was not started because the exact external login-shell/source preflight failed before the authorization boundary. The plan explicitly requires recording the blocker and resume condition in this case.

## Key Design Decisions

No source, test, configuration, contract, specification, or deployed-runtime changes were made. The Darwin-only live oracle was not substituted with a Linux execution; its single authorized invocation remains unconsumed.

## Reviewer Checkpoints

- Confirm execution occurred on Darwin/arm64 at `/Users/toki/agent-work/iop-dev`, not in a substitute sandbox.
- Confirm `zsh` resolves, login-shell Go is executable, and the same shell invokes that exact binary.
- Confirm HEAD, test-only source delta, reviewed SHA-256, deployed runtime identities, listeners, active blocking gate, selected provider capacity/health, prompt/artifact containment, observation quiescence, and zero competing harnesses before launch.
- Confirm exactly one Go test process starts and exits 0.
- Confirm `summary.json` has three runs, 15 globally unique provider response IDs, 15 globally unique Edge correlations, and three accepted capacity rows with `configured=4`, `peak_in_flight=4`, `peak_queued>=1`, `final_in_flight=0`, and `final_queued=0`.
- Confirm sanitized `reproduced` includes fingerprint/offset or the result is `not_reproduced`; both providers return idle, no harness remains, source/runtime identities are unchanged, and no raw/secret-bearing material entered tracked evidence or stdout.
- If execution is blocked before launch, confirm the active review contains exact attempted commands/output, invocation count 0, the blocker, and the resume condition rather than placeholders.

## Verification Results

Record actual stdout/stderr and exit codes for every command. If blocked, record the exact attempted command, output, invocation count, and resume condition without asking the user or creating a control-plane stop file.

### Local Integrity Verification

```bash
git diff --check
sha256sum apps/edge/internal/openai/stream_gate_vertical_slice_test.go
go test -count=1 ./apps/edge/internal/openai -run 'TestDevRepeatGuard(SmokeEvidence|ObservationCorrelation|ObservationQuiescence|CapacityEvidence)'
go test -count=1 ./packages/go/streamgate ./apps/edge/internal/openai
go test -count=1 ./packages/go/config
```

Expected: all commands exit 0 and SHA-256 is `8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21`.

Implementation evidence:

Executed on the current Linux/arm64 checkout on 2026-07-30.

```text
$ git diff --check
exit=0

$ sha256sum apps/edge/internal/openai/stream_gate_vertical_slice_test.go
8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21  apps/edge/internal/openai/stream_gate_vertical_slice_test.go
exit=0

$ go test -count=1 ./apps/edge/internal/openai -run 'TestDevRepeatGuard(SmokeEvidence|ObservationCorrelation|ObservationQuiescence|CapacityEvidence)'
ok  \tiop/apps/edge/internal/openai\t0.317s
exit=0

$ go test -count=1 ./packages/go/streamgate ./apps/edge/internal/openai
ok  \tiop/packages/go/streamgate\t0.913s
ok  \tiop/apps/edge/internal/openai\t7.330s
exit=0

$ go test -count=1 ./packages/go/config
ok  \tiop/packages/go/config\t0.155s
exit=0
```

All deterministic local checks passed with fresh `-count=1` execution where applicable. Live invocation count: `0`.

### External Login-Shell and Source Preflight

```bash
command -v zsh
zsh -lic '
set -eu
test "$(uname -s)" = "Darwin"
test "$(uname -m)" = "arm64"
cd /Users/toki/agent-work/iop-dev
go_bin="$(command -v go)"
test -n "$go_bin"
test -x "$go_bin"
"$go_bin" version
"$go_bin" env GOMOD
git branch --show-current
git rev-parse HEAD
git status --short
shasum -a 256 apps/edge/internal/openai/stream_gate_vertical_slice_test.go
'
```

Expected: `zsh` resolves; Go 1.26.3; GOMOD `/Users/toki/agent-work/iop-dev/go.mod`; branch `feature/openai-compatible-output-validation-filters`; reviewed HEAD; only the reviewed test-file delta; reviewed hash.

Implementation evidence:

Executed the exact external preflight command on the current host:

```text
$ command -v zsh

$ zsh -lic '...'
/bin/bash: line 2: zsh: command not found
exit=127
```

The preflight stopped before any Darwin, source, Go, or deployed-runtime check and before the live Go test command could start. Live invocation count: `0`. Blocker: this host has no `zsh` and is not the required Darwin/arm64 runner rooted at `/Users/toki/agent-work/iop-dev`. Resume only on that runner after `zsh -lic` succeeds and every required source/runtime/isolation precondition is independently verified.

### Deployed Runtime, Capacity, and Isolation Preflight

Record sanitized deployed Edge/Node identities, listeners `18083` and `18001`, active blocking `repeat_guard`, selected provider IDs/health/idle aggregate capacity 4, prompt and artifact containment, writable raw-free observation sink, quiet-window result, and zero competing harnesses. Do not record endpoint secrets, credentials, prompt text, raw SSE, or model output.

Implementation evidence:

Not executed. The login-shell/source preflight failed with exit 127 before this stage, so the current host cannot verify Darwin deployed Edge/Node identities, listeners, blocking policy, provider health/capacity, prompt/artifact containment, observation-sink quiescence, or competing harnesses. Live invocation count: `0`. Resume only after a successful Darwin/arm64 login-shell/source preflight at `/Users/toki/agent-work/iop-dev`.

### Single Authorized Live Invocation

```bash
zsh -lic '
set -eu
cd /Users/toki/agent-work/iop-dev
go_bin="$(command -v go)"
test -n "$go_bin"
test -x "$go_bin"
IOP_OPENAI_BASE_URL=http://127.0.0.1:18083 \
IOP_OPENAI_MODEL=ornith:35b \
IOP_OPENAI_SMOKE_CONCURRENCY=5 \
IOP_OPENAI_SMOKE_RUNS=3 \
IOP_OPENAI_SMOKE_PROMPT_FILE=/tmp/iop-repeat-guard-live/repeat-prompt.txt \
IOP_OPENAI_SMOKE_ARTIFACT_DIR=/tmp/iop-repeat-guard-live/repeat-guard-review-33 \
IOP_OPENAI_SMOKE_OBSERVATION_FILE=/tmp/iop-repeat-guard-live/edge-observations.jsonl \
IOP_OPENAI_SMOKE_STATUS_URL=http://127.0.0.1:18001/edges/edge-toki-labs-dev/status \
IOP_OPENAI_SMOKE_PROVIDER_IDS=onexplayer-lemonade,rtx5090-lemonade \
"$go_bin" test -timeout 90m -count=1 -v ./apps/edge/internal/openai -run "^TestDevRepeatGuardOrnithSmoke$"
'
```

Expected: invocation count 1, exit 0, 15 globally unique provider response IDs, 15 globally unique Edge correlations, three accepted capacity rows, and sanitized `reproduced` with fingerprint/offset or `not_reproduced`.

Implementation evidence:

Not started. The sole authorized invocation remains unconsumed because the required preceding login-shell/source preflight exited 127. No `go test -timeout 90m ... TestDevRepeatGuardOrnithSmoke` process was launched. Live invocation count: `0`. Resume by completing all preconditions on the verified Darwin/arm64 runner, then start this exact command once and do not retry it after it starts.

### Summary and Cleanup Verification

Validate `summary.json`, selected-provider idle recovery, zero remaining harness process, unchanged source/runtime identities, and no tracked raw/secret-bearing evidence. Do not paste raw prompt, SSE, output, credentials, tokens, or private endpoint material.

Implementation evidence:

Not executed because no live invocation or artifact directory was created. No `summary.json`, provider-response record, Edge-correlation record, capacity row, final live result, or post-run cleanup evidence exists. Live invocation count: `0`. Resume after the single authorized Darwin invocation exits, then validate the sanitized summary and cleanup on that same isolated runner.

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Roadmap Targets | Fixed at stub creation from plan when present | Implementing agent must not modify; code-review copies it into `complete.log` as `Roadmap Completion` only on PASS |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |

## Code Review Result

- Overall Verdict: FAIL
- Dimension Assessment:
  - Correctness: Pass — no production, test, contract, specification, configuration, or deployed-runtime change was made in this verification-only follow-up, and the reviewed live harness still has the required evidence shape.
  - Completeness: Fail — the required S07 live invocation, sanitized summary, deployed-runtime evidence, and cleanup proof are absent.
  - Test Coverage: Pass — fresh focused repeat-guard, Stream Gate/OpenAI package, and config tests all exited 0.
  - API Contract: Pass — no API, wire, event, or config contract changed in this follow-up.
  - Code Quality: Pass — no source change was introduced by this follow-up, and `git diff --check` exited 0.
  - Implementation Deviation: Pass — the exact required preflight was attempted, and the plan explicitly required invocation count 0 plus blocker/resume evidence when preflight failed.
  - Verification Trust: Fail — the required live production-path command was not executed and no live artifacts exist.
  - Spec Conformance: Fail — SDD S07 requires three capacity+1 live runs with provider response, Edge correlation, capacity, result, and cleanup evidence.
- Findings:
  - Required — `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/code_review_cloud_G08_33.log:212`: the live invocation count is 0, and line 220 confirms that no `summary.json`, 15 provider responses, 15 Edge correlations, three accepted capacity rows, sanitized result, or cleanup evidence exists. Run the unchanged preflight on the required Darwin/arm64 runner, then execute the authorized live oracle exactly once only after every source, runtime, capacity, and isolation precondition passes; record the sanitized summary and cleanup proof required by SDD S07.
- Reviewer Verification:
  - `go version && go env GOMOD`: exit 0; `go1.26.2 linux/arm64`; `/config/workspace/iop-s1/go.mod`.
  - `git diff --check`: exit 0.
  - SHA-256: `8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21`.
  - Focused repeat-guard tests: exit 0; `ok iop/apps/edge/internal/openai 0.330s`.
  - Stream Gate/OpenAI packages: exit 0; `ok iop/packages/go/streamgate 0.919s`; `ok iop/apps/edge/internal/openai 7.336s`.
  - Config package: exit 0; `ok iop/packages/go/config 0.121s`.
  - Exact external preflight: `command -v zsh` exit 1; `zsh -lic ...` exit 127 with `zsh: command not found`; live invocation count remained 0.
- Routing Signals:
  - `review_rework_count=33`
  - `evidence_integrity_failure=true`
- Next Step: Archive this failed pair and invoke the plan skill for the smallest freshly routed follow-up that preserves the unconsumed one-time live authorization.
