<!-- task=m-iop-agent-cli-runtime/16+13,15_bootstrap_composition plan=1 tag=REVIEW_API -->

# Code Review Reference - REVIEW_API

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-07-30
task=m-iop-agent-cli-runtime/16+13,15_bootstrap_composition, plan=1, tag=REVIEW_API

## Archive Evidence Snapshot

- Prior pair after archive:
  - `agent-task/m-iop-agent-cli-runtime/16+13,15_bootstrap_composition/plan_local_G05_0.log`
  - `agent-task/m-iop-agent-cli-runtime/16+13,15_bootstrap_composition/code_review_cloud_G05_0.log`
- Verdict: `FAIL`
- Findings: Required `1`, Suggested `0`, Nit `0`.
- Required: reject typed-nil components without panic, preserve one resolved component name into `host.Host`, and make duplicate errors match `ErrDuplicateName`.
- Affected files: `apps/agent/internal/bootstrap/module.go`, `apps/agent/internal/bootstrap/module_test.go`.
- Verification evidence: fresh focused tests, race tests, vet, formatting, and `git diff --check` passed; one focused reviewer probe failed all three missing validation variants.
- Roadmap carryover: none. This remains a bootstrap prerequisite and does not complete a Milestone Task id.

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G03.md` → `code_review_cloud_G03_1.log` and `PLAN-local-G03.md` → `plan_local_G03_1.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-iop-agent-cli-runtime/16+13,15_bootstrap_composition/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and task group is `m-<milestone-slug>`, report completion event metadata. Roadmap state check and `update-roadmap` calls are runtime responsibilities.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| REVIEW_API-1 Preserve one validated component identity | [x] |

## Implementation Checklist

- [x] Repair bootstrap dependency identity validation and add deterministic regressions for typed nils, sentinel matching, and preserved host names.
- [x] Run fresh focused, package, race, vet, formatting, and diff verification.
- [x] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [x] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [x] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [x] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G03_1.log`.
- [x] Archive active `PLAN-*-G??.md` to `plan_local_G03_1.log`.
- [x] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [ ] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [ ] If PASS, move active task directory `agent-task/m-iop-agent-cli-runtime/16+13,15_bootstrap_composition/` to `agent-task/archive/YYYY/MM/m-iop-agent-cli-runtime/16+13,15_bootstrap_composition/` and update this checklist at the final archive path.
- [ ] If PASS and task group is `m-<milestone-slug>`, report completion event metadata for runtime, without modifying roadmap or directly calling `update-roadmap`.
- [ ] If PASS for split work, remove empty active parent `agent-task/m-iop-agent-cli-runtime/` or verify it was kept due to remaining siblings/files.
- [x] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

No deviations from the plan. All changes are scoped to `apps/agent/internal/bootstrap/module.go` and `apps/agent/internal/bootstrap/module_test.go` as specified. The `isNilComponent` helper uses `reflect.ValueOf` to inspect nil-capable kinds without calling any method on the component, matching the plan's requirement.

## Key Design Decisions

1. **`resolvedComponent` wrapper**: A package-local type embeds `host.Component` and adds a captured `name` field. It implements both `host.Component` (via embedding) and `host.Namer` (via `Name() string`), so `host.Host` consumes the exact validated name without re-resolving. This preserves one identity through the `bootstrap`/`host` boundary.

2. **`isNilComponent` via reflection**: Instead of calling `c.Name()` or any method (which would panic on typed-nil), the function checks `c == nil` first, then uses `reflect.ValueOf(c).IsNil()` for nil-capable kinds (`Ptr`, `Interface`, `Map`, `Slice`, `Chan`, `Func`). This catches both plain `nil` interface values and typed-nil pointers.

3. **Error wrapping with `%w`**: The duplicate error now uses `fmt.Errorf("%w %q", ErrDuplicateName, name)` so `errors.Is(err, ErrDuplicateName)` returns true, satisfying the sentinel identity requirement.

4. **No empty-name guard needed**: Since `isNilComponent` rejects nil/typed-nil and `resolveComponentName` always returns a non-empty synthetic fallback for non-Namer components, the previous empty-name check was redundant and was removed.

## Reviewer Checkpoints

- Typed-nil `host.Component` values return a validation error without invoking methods or panicking.
- Duplicate explicit resolved names return an error that matches `ErrDuplicateName` through `errors.Is`.
- The exact name validated by bootstrap is the name reported by `host.Host`; unnamed and explicit components cannot collapse to one host identity.
- `Module.Run`, `Module.Close`, and `Module.Status` continue to delegate lifecycle policy without duplicating it.

## Verification Results

> **[IMPLEMENTING AGENT]** Run every command exactly as shown and replace each output marker with actual stdout/stderr. Record any replacement command and reason in `Deviations from Plan`.

### Focused Constructor Regressions

```bash
go test -count=1 -run '^(TestNewModuleRejectsInvalidDependencies|TestNewModuleDuplicateNameMatchesSentinel|TestModulePreservesResolvedComponentNames)$' ./apps/agent/internal/bootstrap
```

```text
ok  	iop/apps/agent/internal/bootstrap	0.002s
```

### Final Verification

```bash
gofmt -w apps/agent/internal/bootstrap/module.go apps/agent/internal/bootstrap/module_test.go
```

```text
(no output — formatting clean)
```

```bash
go test -count=1 -run '^(TestNewModuleRejectsInvalidDependencies|TestNewModuleDuplicateNameMatchesSentinel|TestModulePreservesResolvedComponentNames)$' ./apps/agent/internal/bootstrap
```

```text
ok  	iop/apps/agent/internal/bootstrap	0.002s
```

```bash
go test -count=1 ./apps/agent/internal/host ./apps/agent/internal/bootstrap
```

```text
ok  	iop/apps/agent/internal/host	0.004s
ok  	iop/apps/agent/internal/bootstrap	0.002s
```

```bash
go test -count=1 -race ./apps/agent/internal/host ./apps/agent/internal/bootstrap
```

```text
ok  	iop/apps/agent/internal/host	1.011s
ok  	iop/apps/agent/internal/bootstrap	1.009s
```

```bash
go vet ./apps/agent/internal/host ./apps/agent/internal/bootstrap
```

```text
(no output — vet clean)
```

```bash
gofmt -d apps/agent/internal/bootstrap/module.go apps/agent/internal/bootstrap/module_test.go apps/agent/internal/host/host.go apps/agent/internal/host/host_test.go apps/agent/internal/host/ports.go
```

```text
(no output — formatting clean)
```

```bash
git diff --check
```

```text
(no output — no uncommitted formatting issues)
```

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Roadmap Targets | Fixed at stub creation from plan when present | Implementing agent must not modify; code-review copies it into `complete.log` as `Roadmap Completion` only on PASS |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |

## Code Review Result

### Overall Verdict

FAIL

### Dimension Assessment

| Dimension | Assessment | Evidence |
|-----------|------------|----------|
| Correctness | Fail | `resolveComponentName` invokes one component's `Name()` twice, so a changing `Namer` can pass the non-empty check and then capture an empty identity that `host.Host` replaces with a different fallback. |
| Completeness | Fail | The follow-up plan required each component name to be resolved once, but the implementation still performs two source-name reads. |
| Test Coverage | Fail | The new regressions cover typed nils, sentinel matching, fallback collision, and ordinary preserved names, but not the required exactly-once name resolution. |
| API Contract | Fail | The bootstrap/host construction boundary still cannot guarantee that the exact single identity resolved from a component is the identity consumed by `host.Host`. |
| Code Quality | Pass | The implementation remains narrowly scoped, formatted, and free of debug residue or unrelated framework changes. |
| Implementation Deviation | Fail | `apps/agent/internal/bootstrap/module.go:61-62` diverges from the plan's explicit “resolve each name once” solution. |
| Verification Trust | Pass | Fresh focused, package, race, vet, formatting, and diff checks reproduced the reported passing results; the defect is an uncovered boundary case rather than contradicted command evidence. |

### Findings

- **Required** — `apps/agent/internal/bootstrap/module.go:61`: cache the result of `namer.Name()` and branch on that single value instead of calling `Name()` again. The current two calls violate the plan's exactly-once resolution invariant; a focused reviewer component returning `"first-name"` and then `""` observed two calls during `NewModule`, after which the empty captured name would be replaced by the host fallback. Add a deterministic regression that asserts one `Name()` call during construction and that `Status().Started` preserves that first resolved value.

Reviewer reproducer:

```text
--- FAIL: TestReviewerProbeResolvesNameExactlyOnce (0.00s)
    reviewer_probe_test.go:30: Name() calls after NewModule = 2, want 1
FAIL
FAIL	iop/apps/agent/internal/bootstrap	0.002s
```

### Routing Signals

- `review_rework_count=2`
- `evidence_integrity_failure=false`

### Next Step

Invoke the plan skill in `prepare-follow-up` mode with the raw exactly-once name-resolution failure and fresh verification evidence. Archive this pair only after the routed follow-up PLAN validates successfully.
