<!-- task=m-iop-agent-cli-runtime/14+13_cli_config_fixtures plan=2 tag=REVIEW_API -->

# Code Review Reference - REVIEW_API

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-07-29
task=m-iop-agent-cli-runtime/14+13_cli_config_fixtures, plan=2, tag=REVIEW_API

## Archive Evidence Snapshot

- Prior plan: `agent-task/m-iop-agent-cli-runtime/14+13_cli_config_fixtures/plan_local_G06_1.log`
- Prior review: `agent-task/m-iop-agent-cli-runtime/14+13_cli_config_fixtures/code_review_cloud_G06_1.log`
- Verdict: FAIL
- Findings: Required=1, Suggested=0, Nit=0. The runtime fixture duplicates the provider catalog and omits executable profile arguments and modes.
- Affected files: `configs/iop-agent.runtime.yaml`, `apps/agent/internal/command/config_test.go`
- Verification evidence: fresh `go test -count=1 ./apps/agent/internal/command ./packages/go/agentconfig`, `go vet ./apps/agent/internal/command ./packages/go/agentconfig`, `gofmt -d`, secret/path scans, and untracked-file whitespace checks passed.
- Roadmap carryover: none. This strict subset remains Milestone-adjacent and must not mark `cli-surface` complete on PASS.

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G04.md` → `code_review_cloud_G04_2.log` and `PLAN-local-G04.md` → `plan_local_G04_2.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-iop-agent-cli-runtime/14+13_cli_config_fixtures/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and task group is `m-<milestone-slug>`, report completion event metadata. Roadmap state check and `update-roadmap` calls are runtime responsibilities.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| REVIEW_API-1 Separate catalog boundary | [x] |

## Implementation Checklist

- [x] Remove the embedded provider catalog and add regression assertions that runtime references resolve through the separate canonical catalog.
- [x] Run fresh focused and affected-package tests, vet, formatting, secret-key, and untracked-file whitespace checks.
- [x] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [x] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [x] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [x] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G04_2.log`.
- [x] Archive active `PLAN-*-G??.md` to `plan_local_G04_2.log`.
- [x] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [x] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [x] If PASS, move active task directory `agent-task/m-iop-agent-cli-runtime/14+13_cli_config_fixtures/` to `agent-task/archive/YYYY/MM/m-iop-agent-cli-runtime/14+13_cli_config_fixtures/` and update this checklist at the final archive path.
- [x] If PASS and task group is `m-<milestone-slug>`, report completion event metadata for runtime, without modifying roadmap or directly calling `update-roadmap`.
- [x] If PASS for split work, remove empty active parent `agent-task/m-iop-agent-cli-runtime/` or verify it was kept due to remaining siblings/files.
- [ ] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

None.

## Key Design Decisions

- Kept `configs/iop-agent.runtime.yaml` responsible only for runtime defaults, selection, isolation, and retention; executable provider profiles remain solely in `configs/iop-agent.providers.yaml`.
- The tracked fixture test loads the canonical catalog independently and validates every default, alias, selection default, and rule profile reference without changing production loader ownership.

## Reviewer Checkpoints

- `configs/iop-agent.runtime.yaml` contains no embedded provider catalog.
- The canonical catalog loads independently, and every runtime default, alias, selection default, and rule profile resolves through it.
- Both runtime documents remain secret-free and strict; validation does not mutate the repo-global fixture.
- Verification covers untracked planned files instead of relying only on `git diff --check`.

## Verification Results

### Formatting and focused tests

```bash
gofmt -w apps/agent/internal/command/config_test.go
go test -count=1 ./apps/agent/internal/command -run 'TestTrackedRuntimeExamplesLoad|TestValidateDoesNotMutateRepoConfig'
```

Output:

```text
ok  	iop/apps/agent/internal/command	0.006s
```

`gofmt` exited 0 with no output.

### Affected package regression and vet

```bash
go test -count=1 ./packages/go/agentconfig
go vet ./apps/agent/internal/command ./packages/go/agentconfig
```

Output:

```text
ok  	iop/packages/go/agentconfig	0.030s
```

`go vet` exited 0 with no output.

### Secret-key and untracked-file whitespace checks

```bash
! rg --sort path -n '^[[:space:]]*(token|password|secret|api_key|authorization)[[:space:]]*:' configs/iop-agent.runtime.yaml configs/iop-agent.local.example.yaml configs/iop-agent.providers.yaml
for file in configs/iop-agent.runtime.yaml configs/iop-agent.local.example.yaml apps/agent/internal/command/config_test.go; do
  output=$(git diff --no-index --check /dev/null "$file" 2>&1 || true)
  if [ -n "$output" ]; then
    printf '%s\n' "$output"
    exit 1
  fi
done
```

Output:

```text
(clean exit, code 0, no output)
```

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Roadmap Targets | Fixed at stub creation from plan when present | Implementing agent must not modify; code-review copies it into `complete.log` as `Roadmap Completion` only on PASS |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |

## Code Review Result

- Overall Verdict: PASS
- Dimension Assessment:
  - Correctness: Pass — the runtime fixture no longer embeds provider catalog data, the canonical catalog loads independently, and the configured profile references resolve to the expected canonical identities.
  - Completeness: Pass — the catalog-boundary correction and all implementation-owned verification items are complete.
  - Test coverage: Pass — the tracked-fixture regression test covers strict runtime loading, absence of an embedded catalog, canonical catalog loading, runtime profile-reference resolution, and read-only repo-global validation.
  - API contract: Pass — `configs/iop-agent.providers.yaml` remains the executable provider-profile source while the runtime fixture owns defaults, selection, isolation, and retention.
  - Code quality: Pass — the focused test is clear, deterministic, formatted, and free of debug or dead code.
  - Implementation deviation: Pass — no unplanned behavioral or scope changes were found.
  - Verification trust: Pass — fresh focused tests, affected-package tests, shared-package regression tests, vet, formatting, secret-key, and untracked-file whitespace checks passed in the review checkout.
- Findings: None.
- Routing Signals:
  - review_rework_count=1
  - evidence_integrity_failure=false
- Next Step: Archive the reviewed pair, write `complete.log`, and move the completed task to the dated archive.
