<!-- task=dispatcher_parallel_limit plan=0 tag=API -->

# Code Review Reference - API

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-07-30
task=dispatcher_parallel_limit, plan=0, tag=API

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G05.md` → `code_review_cloud_G05_0.log` and `PLAN-local-G05.md` → `plan_local_G05_0.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/dispatcher_parallel_limit/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and task group is `m-<milestone-slug>`, report completion event metadata. Roadmap state check and `update-roadmap` calls are runtime responsibilities.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| API-1 | [ ] |
| API-2 | [ ] |
| API-3 | [ ] |

## Implementation Checklist

- [ ] Add the non-negative `--max-parallel` CLI contract with `0` as the backward-compatible unlimited default.
- [ ] Enforce the global cap across worker, self-check, official review, and adopted external-active attempts while preserving review ordering, claim safety, and capacity-wait re-admission.
- [ ] Add deterministic unit and async regressions for unlimited, limits `1`/`2`, mixed roles, slot refill, external-active accounting, claim timing, review-preflight failure, and negative input.
- [ ] Update the dispatcher skill inputs, concurrency contract, examples, and verification checklist for the global limit.
- [ ] Run the focused and full final verification commands and record fresh output.
- [ ] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [ ] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [ ] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [ ] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G05_0.log`.
- [ ] Archive active `PLAN-*-G??.md` to `plan_local_G05_0.log`.
- [ ] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [ ] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [ ] If PASS, move active task directory `agent-task/dispatcher_parallel_limit/` to `agent-task/archive/YYYY/MM/dispatcher_parallel_limit/` and update this checklist at the final archive path.
- [ ] If PASS and task group is `m-<milestone-slug>`, report completion event metadata for runtime, without modifying roadmap or directly calling `update-roadmap`.
- [ ] If PASS for split work, remove empty active parent `agent-task/dispatcher_parallel_limit/` or verify it was kept due to remaining siblings/files.
- [ ] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

_Record any deviations from the plan and the rationale here._

## Key Design Decisions

_Record key design decisions here._

## Reviewer Checkpoints

- Confirm `--max-parallel` accepts `0` and positive integers, rejects negative values, and defaults to unlimited.
- Confirm the occupied count is the union of current asyncio tasks and adopted same-workspace external-active tasks.
- Confirm newly capacity-deferred tasks are waiting rather than blocked and do not acquire new claims, while prior lifecycle owners retain their claims and remain eligible after a slot returns without a complete rescan.
- Confirm capped dry-run previews one admission wave without persistent state changes.
- Confirm review-before-worker ordering and write-claim collision behavior remain intact.
- Confirm capped review shared-state preflight failure still allows an independent worker to use the released runtime slot.
- Confirm the final admission batch snapshot contains only tasks that will actually launch.
- Confirm provider-specific limits and Go `iop-agent` configuration were not changed.
- Confirm real provider processes are denied or mocked in tests.

## Verification Results

Paste actual stdout/stderr for every command below. If output is too long, record the deterministic saved output path and the exact command used to create it. A replacement command requires an entry in `Deviations from Plan`.

### API-1 Intermediate Verification

Command:

```bash
python3 -m py_compile agent-ops/skills/project/orchestrate-agent-task-loop/scripts/dispatch.py
python3 agent-ops/skills/project/orchestrate-agent-task-loop/scripts/dispatch.py --help | rg --fixed-strings -- '--max-parallel MAX_PARALLEL'
```

Expected: compilation succeeds and help lists the new option.

Actual output:

```text
_Fill with actual stdout/stderr._
```

### API-2 Intermediate Verification

Command:

```bash
python3 agent-ops/skills/project/orchestrate-agent-task-loop/tests/test_dispatch.py ParallelLimitSchedulingTest ReviewSchedulingTest WriteSetTest BlockerDrainTest DispatcherConvergenceSimulationTest
```

Expected: every focused test passes with no real subprocess/provider invocation.

Actual output:

```text
_Fill with actual stdout/stderr._
```

### API-3 Intermediate Verification

Command:

```bash
rg -n --sort path --fixed-strings 'max_parallel' agent-ops/skills/project/orchestrate-agent-task-loop/SKILL.md
rg -n --sort path --fixed-strings -- '--max-parallel' agent-ops/skills/project/orchestrate-agent-task-loop/SKILL.md
```

Expected: the input/contract and CLI example are both present.

Actual output:

```text
_Fill with actual stdout/stderr._
```

### Final Verification

Command:

```bash
python3 -m py_compile agent-ops/skills/project/orchestrate-agent-task-loop/scripts/dispatch.py
python3 agent-ops/skills/project/orchestrate-agent-task-loop/scripts/dispatch.py --help | rg --fixed-strings -- '--max-parallel MAX_PARALLEL'
python3 agent-ops/skills/project/orchestrate-agent-task-loop/tests/test_dispatch.py ParallelLimitSchedulingTest ReviewSchedulingTest WriteSetTest BlockerDrainTest DispatcherConvergenceSimulationTest
python3 -m unittest discover -s agent-ops/skills/project/orchestrate-agent-task-loop/tests -p 'test_*.py'
rg -n --sort path --fixed-strings 'max_parallel' agent-ops/skills/project/orchestrate-agent-task-loop/SKILL.md
rg -n --sort path --fixed-strings -- '--max-parallel' agent-ops/skills/project/orchestrate-agent-task-loop/SKILL.md
git diff --check
```

Expected: compilation and help checks pass; focused fake-runner regressions pass; the full dispatcher suite passes without a real provider process; documentation checks find the input and example; `git diff --check` prints nothing. Python test cache is not accepted as verification evidence.

Actual output:

```text
_Fill with actual stdout/stderr._
```

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Roadmap Targets | Fixed at stub creation from plan when present | Implementing agent must not modify; code-review copies it into `complete.log` as `Roadmap Completion` only on PASS |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |
