<!-- task=m-principal-provider-credential-slot-routing/02+01_credential_catalog plan=3 tag=REVIEW_API -->

# Code Review Reference - REVIEW_API

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-08-01
task=m-principal-provider-credential-slot-routing/02+01_credential_catalog, plan=3, tag=REVIEW_API

## Roadmap Targets

- Milestone: `agent-roadmap/phase/operational-observability-provider-management/milestones/principal-provider-credential-slot-routing.md`
- Milestone link: [Milestone document](agent-roadmap/phase/operational-observability-provider-management/milestones/principal-provider-credential-slot-routing.md)
- Task ids:
  - `slot-store`: principal-scoped provider credential slot ledger
  - `model-binding`: one route to one slot/profile/upstream-model tuple
- Completion mode: check-on-pass

## Archive Evidence Snapshot

- Closing pair: `agent-task/m-principal-provider-credential-slot-routing/02+01_credential_catalog/plan_cloud_G08_2.log`, `agent-task/m-principal-provider-credential-slot-routing/02+01_credential_catalog/code_review_cloud_G08_2.log`.
- Verdict: FAIL with two Required findings, zero Suggested findings, and zero Nits.
- Required repair: reject or deterministically deactivate incompatible active bindings during intermediate-catalog migration, and isolate credential routing from the exported mutable built-in profile snapshot.
- Fresh evidence: all planned focused, race, repeated, Control Plane regression, vet, predecessor, and diff commands passed. Two temporary reviewer regressions failed: `Open` preserved an incompatible legacy route as active, and deleting `openai` from `config.BuiltInProtocolProfiles` broke an otherwise valid `CreateRoute`. The temporary reviewer file was removed.
- Roadmap carryover: S04 `slot-store` and S05 `model-binding` remain incomplete until this follow-up passes.

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G08.md` → `code_review_cloud_G08_3.log` and `PLAN-cloud-G08.md` → `plan_cloud_G08_3.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-principal-provider-credential-slot-routing/02+01_credential_catalog/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and task group is `m-<milestone-slug>`, report completion event metadata. Roadmap state check and `update-roadmap` calls are runtime responsibilities.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| REVIEW_API-1 Fence incompatible active rows during catalog migration | [x] |
| REVIEW_API-2 Isolate credential routing from the mutable compatibility snapshot | [x] |

## Implementation Checklist

- [x] Fail closed when intermediate catalogs contain active slot/route bindings that violate the current vendor/credential-kind/profile-auth contract, while preserving valid migrated bindings with deterministic dialect-safe tests.
- [x] Resolve route compatibility from a credential-store-owned immutable profile catalog and prove exported compatibility-snapshot mutation cannot change route behavior.
- [x] Run fresh focused, repeated, race, Control Plane regression, predecessor, reviewer-artifact absence, and diff verification.
- [x] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [x] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [x] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [x] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G08_3.log`.
- [x] Archive active `PLAN-*-G??.md` to `plan_cloud_G08_3.log`.
- [x] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [ ] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [ ] If PASS, move active task directory `agent-task/m-principal-provider-credential-slot-routing/02+01_credential_catalog/` to `agent-task/archive/YYYY/MM/m-principal-provider-credential-slot-routing/02+01_credential_catalog/` and update this checklist at the final archive path.
- [ ] If PASS and task group is `m-<milestone-slug>`, report completion event metadata for runtime, without modifying roadmap or directly calling `update-roadmap`.
- [ ] If PASS for split work, remove empty active parent `agent-task/m-principal-provider-credential-slot-routing/` or verify it was kept due to remaining siblings/files.
- [x] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

None.

## Key Design Decisions

- Migration validates active routes after dialect-specific credential-slot migration and before `Open` exposes a store. An active route must retain its principal ownership, target an active slot, and resolve through the closed slot/profile compatibility rules.
- Active slots must retain at least one compatible non-revoked route. Validation returns `ErrIncompatibleProfile`-wrapped, secret-free errors and never reads or renders envelope ciphertext.
- Credential routing owns a package-private clone from `config.BuiltInProtocolProfileCatalog()`. Mutation of the exported compatibility snapshot cannot alter existing credential-store resolution.

## Reviewer Checkpoints

- Recreate a valid intermediate catalog and an incompatible active legacy binding; valid migration must reopen and the incompatible catalog must fail closed before a serving-ready store exists.
- Mutate the exported `config.BuiltInProtocolProfiles` compatibility snapshot and confirm credential route resolution still uses its private process-owned catalog.
- Inspect both dialect migration ordering for idempotent compatibility validation and redacted errors.
- Re-run focused/repeated regressions, package race, Control Plane regression, predecessor count, and reviewer-artifact absence checks.

## Verification Results

Paste actual stdout/stderr beneath every command; do not summarize or reconstruct it.

### REVIEW_API-1

`GOTMPDIR=/config/workspace/iop-s0/.cache/go-build GOCACHE=/config/workspace/iop-s0/.cache/go-cache go test -count=1 ./apps/control-plane/internal/credentialstore -run 'CredentialSlotMigration'`

```text
ok  	iop/apps/control-plane/internal/credentialstore	0.539s
```

### REVIEW_API-2

`GOTMPDIR=/config/workspace/iop-s0/.cache/go-build GOCACHE=/config/workspace/iop-s0/.cache/go-cache go test -count=1 ./apps/control-plane/internal/credentialstore -run 'ImmutableProfileCatalog|Compatibility'`

```text
ok  	iop/apps/control-plane/internal/credentialstore	0.161s
```

### Final Verification

1. `test "$(find agent-task/archive -type f -path '*/m-principal-provider-credential-slot-routing/01_principal_store/complete.log' -print | wc -l)" -eq 1`
2. `mkdir -p .cache/go-build .cache/go-cache`
3. `GOTMPDIR=/config/workspace/iop-s0/.cache/go-build GOCACHE=/config/workspace/iop-s0/.cache/go-cache go vet ./apps/control-plane/internal/credentialstore`
4. `GOTMPDIR=/config/workspace/iop-s0/.cache/go-build GOCACHE=/config/workspace/iop-s0/.cache/go-cache go test -count=1 ./apps/control-plane/internal/credentialstore -run 'CredentialSlotMigration|ImmutableProfileCatalog|Compatibility'`
5. `GOTMPDIR=/config/workspace/iop-s0/.cache/go-build GOCACHE=/config/workspace/iop-s0/.cache/go-cache go test -count=25 ./apps/control-plane/internal/credentialstore -run 'MigrationRejectsIncompatible|ImmutableProfileCatalog'`
6. `GOTMPDIR=/config/workspace/iop-s0/.cache/go-build GOCACHE=/config/workspace/iop-s0/.cache/go-cache go test -count=1 -race ./apps/control-plane/internal/credentialstore`
7. `GOTMPDIR=/config/workspace/iop-s0/.cache/go-build GOCACHE=/config/workspace/iop-s0/.cache/go-cache go test -count=1 ./apps/control-plane/...`
8. `test ! -e apps/control-plane/internal/credentialstore/reviewer_probe_test.go`
9. `git diff --check`

1. `test "$(find agent-task/archive -type f -path '*/m-principal-provider-credential-slot-routing/01_principal_store/complete.log' -print | wc -l)" -eq 1`

```text
```

2. `mkdir -p .cache/go-build .cache/go-cache`

```text
```

3. `GOTMPDIR=/config/workspace/iop-s0/.cache/go-build GOCACHE=/config/workspace/iop-s0/.cache/go-cache go vet ./apps/control-plane/internal/credentialstore`

```text
```

4. `GOTMPDIR=/config/workspace/iop-s0/.cache/go-build GOCACHE=/config/workspace/iop-s0/.cache/go-cache go test -count=1 ./apps/control-plane/internal/credentialstore -run 'CredentialSlotMigration|ImmutableProfileCatalog|Compatibility'`

```text
ok  	iop/apps/control-plane/internal/credentialstore	0.386s
```

5. `GOTMPDIR=/config/workspace/iop-s0/.cache/go-build GOCACHE=/config/workspace/iop-s0/.cache/go-cache go test -count=25 ./apps/control-plane/internal/credentialstore -run 'MigrationRejectsIncompatible|ImmutableProfileCatalog'`

```text
ok  	iop/apps/control-plane/internal/credentialstore	4.076s
```

6. `GOTMPDIR=/config/workspace/iop-s0/.cache/go-build GOCACHE=/config/workspace/iop-s0/.cache/go-cache go test -count=1 -race ./apps/control-plane/internal/credentialstore`

```text
ok  	iop/apps/control-plane/internal/credentialstore	4.911s
```

7. `GOTMPDIR=/config/workspace/iop-s0/.cache/go-build GOCACHE=/config/workspace/iop-s0/.cache/go-cache go test -count=1 ./apps/control-plane/...`

```text
ok  	iop/apps/control-plane/cmd/control-plane	2.251s
ok  	iop/apps/control-plane/internal/credentialstore	3.116s
ok  	iop/apps/control-plane/internal/wire	1.532s
```

8. `test ! -e apps/control-plane/internal/credentialstore/reviewer_probe_test.go`

```text
```

9. `git diff --check`

```text
```

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Roadmap Targets | Fixed at stub creation from plan when present | Implementing agent must not modify; code-review copies it into `complete.log` as `Roadmap Completion` only on PASS |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |

## Code Review Result

- Overall Verdict: FAIL
- Dimension Assessment:
  - Correctness: Fail
  - Completeness: Fail
  - Test coverage: Fail
  - API contract: Fail
  - Code quality: Pass
  - Implementation deviation: Fail
  - Verification trust: Pass
  - Spec conformance: Fail
- Findings:
  - Required — `apps/control-plane/internal/credentialstore/schema.go:384` and `apps/control-plane/internal/credentialstore/slot.go:365`: the new startup validator rejects every active route whose slot is not `active`, but the supported `DisableSlot` and `RevokeSlot` transitions change only the slot row and leave its route rows active. A fresh `TestReviewerSlotLifecycleRemainsReopenable` probe created an active route, disabled or revoked its slot, closed the store, and then failed both reopen attempts with `ErrIncompatibleProfile: active migrated route has an unavailable slot`. Reconcile migration validation with the durable slot/route lifecycle—either transition dependent routes atomically or validate effective bindings without treating a deliberately inactive slot as corrupt—and add disable/revoke/reopen regressions that preserve fail-closed reactivation and serving behavior. The temporary reviewer probe was removed.
- Routing Signals:
  - `review_rework_count=3`
  - `evidence_integrity_failure=false`
- Next Step: Invoke the plan skill with these raw findings, archive this pair, and continue with the freshly routed follow-up pair.
