<!-- task=m-iop-owned-single-request-agent-execution/19+18_work_stage plan=0 tag=API milestone-task=work-stage -->

# Code Review Reference - API

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> Execute the plan's selected root cause, scope, files, and dependency decisions as written. Do not choose another owner, narrow/expand the write boundary, or replace a fix with another verification attempt.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-08-07
task=m-iop-owned-single-request-agent-execution/19+18_work_stage, plan=0, tag=API

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G08.md` → `code_review_cloud_G08_0.log` and `PLAN-cloud-G08.md` → `plan_cloud_G08_0.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-iop-owned-single-request-agent-execution/19+18_work_stage/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS, preserve `milestone-task=work-stage` in `complete.log` and report it for runtime aggregation. Roadmap state evaluation belongs to `sync-milestone-workstate`.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| API-1 Correlate provider tool continuations per request | [ ] |
| API-2 Drive the S09 Work provider/tool loop | [ ] |
| API-3 Keep the service coordinator contract intact | [ ] |
| API-4 Record Work as implemented but inactive | [ ] |

## Implementation Checklist

- [ ] Add a concurrent request-safe internal tool continuation bridge that correlates one provider call to one coordinator result and unregisters on every success, failure, timeout, and cancel path.
- [ ] Implement the ornith-fast Work runner to read PLAN, expose only admitted IOP workspace tools, drive ordered provider/tool continuations, and return bounded completion and verification evidence.
- [ ] Add S09 fixtures for write+verify completion, every Work request's high-option absence, identity/correlation isolation, malformed/multiple tool calls, limits, cancellation, and provider/tool failures under `-race`.
- [ ] Update the current implementation spec and run dependency, focused race, service compatibility, broader Edge, vet, deterministic option search, and diff checks without production activation.
- [ ] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [ ] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [ ] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [ ] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G08_0.log`.
- [ ] Archive active `PLAN-*-G??.md` to `plan_cloud_G08_0.log`.
- [ ] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [ ] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [ ] If PASS, move active task directory `agent-task/m-iop-owned-single-request-agent-execution/19+18_work_stage/` to `agent-task/archive/YYYY/MM/m-iop-owned-single-request-agent-execution/19+18_work_stage/` and update this checklist at the final archive path.
- [ ] If PASS, preserve and report `milestone-task=work-stage` for runtime aggregation, without modifying roadmap or directly calling `update-roadmap`.
- [ ] If PASS for split work, remove empty active parent `agent-task/m-iop-owned-single-request-agent-execution/` or verify it was kept due to remaining siblings/files.
- [ ] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

_Record any deviations from the plan and the rationale here._

## Key Design Decisions

_Record key design decisions here._

## Reviewer Checkpoints

- Verify the bridge keys every waiter by immutable request/stage/tool identities, never blocks while holding its map lock, consumes one result, and unregisters on all exits.
- Verify every Work dispatch stays on frozen ornith-fast admission, omits effective `reasoning_effort`, exposes only the admitted IOP operations, and rejects caller tools or credentials as authority.
- Verify provider tool calls and coordinator results retain exact correlation across reordering, duplicate/stale results, cancellation, budget failure, and concurrent requests.
- Verify completion and verification evidence are strict and bounded, production activation remains absent, and the spec leaves Review/repair, activation, and S12 qualification deferred.

## Verification Results

Paste actual stdout/stderr for every command. If a command changes, record the replacement and reason in `Deviations from Plan` before pasting its output.

### 1. Dependency evidence

`test -f agent-task/m-iop-owned-single-request-agent-execution/18+17_plan_stage/complete.log`

Expected: exit zero before implementation or review.

```text
_Paste actual output here._
```

### 2. Focused Work race tests

`go test -race ./apps/edge/internal/openai -run 'TestSingleRequestWork(Stage|ToolBridge)' -count=1`

Expected: S09, continuation correlation, cancellation, and failure fixtures pass without races.

```text
_Paste actual output here._
```

### 3. Service compatibility

`go test ./apps/edge/internal/service -run 'TestSingleRequest(InternalToolLoop|Cleanup)' -count=1`

Expected: existing coordinator/tool/cleanup invariants pass freshly.

```text
_Paste actual output here._
```

### 4. Vet and Edge regression

`go vet ./apps/edge/internal/openai && go test ./apps/edge/... -count=1`

Expected: OpenAI vets cleanly and broader Edge regression passes.

```text
_Paste actual output here._
```

### 5. Work option isolation

`rg --sort path -n 'reasoning_effort' apps/edge/internal/openai/single_request_work_stage.go apps/edge/internal/openai/single_request_work_stage_test.go`

Expected: production code contains only explicit rejection/omission logic and tests prove no effective Work request field.

```text
_Paste actual output here._
```

### 6. No incomplete production activation

`rg --sort path -n 'SetSingleRequestExecutor|NewSingleRequestExecutor' apps/edge --glob '*.go'`

Expected: no production composite installation exists yet.

```text
_Paste actual output here._
```

### 7. Spec synchronization

`rg --sort path -n 'ornith-fast|Work stage|Review|not installed|deferred' agent-spec/runtime/edge-node-execution.md`

Expected: Work is implemented while Review/repair, activation, and external qualification remain deferred.

```text
_Paste actual output here._
```

### 8. Diff hygiene

`git diff --check`

Expected: exit zero with no output.

```text
_Paste actual output here._
```

External note: actual provider/Claude full-cycle evidence remains owned by SDD S12 `claude-smoke` after the composite runner is complete.

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |
