<!-- task=m-iop-hot-path-one-shot-execution/17+14,15,16_endpoint_error_matrix plan=3 tag=REVIEW_REVIEW_API milestone-task=error-cancel -->

# Code Review Reference - REVIEW_REVIEW_API

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-08-04
task=m-iop-hot-path-one-shot-execution/17+14,15,16_endpoint_error_matrix, plan=3, tag=REVIEW_REVIEW_API

## Archive Evidence Snapshot

- `agent-task/m-iop-hot-path-one-shot-execution/17+14,15,16_endpoint_error_matrix/code_review_cloud_G09_2.log`: FAIL. Required finding: `hotPathStageReleaseSink.Release` labels every release error as `caller_cancel`; a fresh valid tool-fragment reproduction with a failing public tool ID allocator returned `{Kind:caller_cancel, Source:caller_write, StageID:local}` even though no endpoint write was attempted.
- `agent-task/m-iop-hot-path-one-shot-execution/17+14,15,16_endpoint_error_matrix/plan_cloud_G08_2.log`: focused production writer-disconnect plan. Its positive Anthropic/Chat × direct/local/review/repair runtime matrix and all targeted/common/full Edge, race, vet, formatting, and diff checks passed; preserve that exact-stage, one-`CANCEL_RUN`, wire-silent behavior.

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G07.md` → `code_review_cloud_G07_3.log` and `PLAN-cloud-G07.md` → `plan_cloud_G07_3.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-iop-hot-path-one-shot-execution/17+14,15,16_endpoint_error_matrix/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and task group is `m-<milestone-slug>`, preserve the first-line `milestone-task` metadata in `complete.log` and report it for the runtime aggregation event. Roadmap state evaluation belongs to `sync-milestone-workstate`.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| REVIEW_REVIEW_API-1 — Callback-write classification boundary | [x] |

## Implementation Checklist

- [x] [REVIEW_REVIEW_API-1] Type only endpoint release-callback failures as wire-silent caller cancellation, preserve pre-callback identity/runtime error classification, add a deterministic stage-runtime negative control, and pass the full scoped regression suite.
- [x] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [x] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [x] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [x] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G07_3.log`.
- [x] Archive active `PLAN-*-G??.md` to `plan_cloud_G07_3.log`.
- [x] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [x] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [x] If PASS, move active task directory `agent-task/m-iop-hot-path-one-shot-execution/17+14,15,16_endpoint_error_matrix/` to `agent-task/archive/YYYY/MM/m-iop-hot-path-one-shot-execution/17+14,15,16_endpoint_error_matrix/` and update this checklist at the final archive path.
- [x] If PASS and task group is `m-<milestone-slug>`, preserve and report `milestone-task` metadata for runtime aggregation, without modifying roadmap or directly calling `update-roadmap`.
- [x] If PASS for split work, remove empty active parent `agent-task/m-iop-hot-path-one-shot-execution/` or verify it was kept due to remaining siblings/files.
- [ ] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

None.

## Key Design Decisions

- `hotPathReleaseCallbackError` wraps only an error returned by `hotPathReleaseCallback` and preserves its cause through `Unwrap`.
- `hotPathStageReleaseSink.Release` maps only that marker to `caller_cancel/caller_write`; every earlier `releaseDeltaRecorded` failure returns unchanged for normal stage-runtime classification.
- The regression uses a valid tool fragment with a deterministic failing public tool-ID allocator. It verifies no release callback invocation, an uncommitted public terminal, one active-stage abort, and `provider_error/stage_runtime` selection.

## Reviewer Checkpoints

- Confirm only errors returned by the progressive endpoint release callback become `caller_cancel/caller_write`; tool identity allocation and all other pre-callback release/runtime failures must retain normal runtime classification.
- Confirm the existing Anthropic Messages and Chat Completions writer-disconnect matrix across direct/local/review/repair remains wire-silent, aborts the exact active stage once, issues one `CANCEL_RUN`, and releases no late or terminal bytes.
- Confirm `TestHotPathNonWriterReleaseFailureRetainsRuntimeDisposition` drives the production stage runtime with a valid tool fragment and failing tool ID allocator, selects `provider_error/stage_runtime`, invokes no endpoint release callback, leaves caller-cancel terminal commitment unset, and aborts the active attempt exactly once.
- Confirm targeted and common race suites, full Edge regression, vet, formatting, and diff validation pass with fresh output.

## Verification Results

For each command below, paste the actual stdout/stderr and exit status. Do not summarize or reconstruct output. If a command changes, record the replacement and reason under `Deviations from Plan`.

### Targeted callback-boundary and endpoint regressions

Command:

```bash
go test -race -count=1 ./apps/edge/internal/openai -run 'TestHotPath(EndpointTerminalMatrix|EndpointDisconnectDuringWriteCancelsActiveStage|NonWriterReleaseFailureRetainsRuntimeDisposition|CancelCompleteRace)|Test(ChatStreamSession|AnthropicNative|StreamChatCompletion)'
```

Output:

```text
ok  	iop/apps/edge/internal/openai	2.082s
```

Exit status: 0

### Common race regression

Command:

```bash
go test -race -count=1 ./packages/go/streamgate ./packages/go/config ./apps/edge/internal/openai ./apps/edge/internal/service
```

Output:

```text
ok  	iop/packages/go/streamgate	2.258s
ok  	iop/packages/go/config	1.872s
ok  	iop/apps/edge/internal/openai	16.738s
ok  	iop/apps/edge/internal/service	7.190s
```

Exit status: 0

### Full Edge regression

Command:

```bash
TMPDIR=/config/workspace/iop-s0 go test -count=1 ./apps/edge/...
```

Output:

```text
ok  	iop/apps/edge/cmd/edge	1.887s
ok  	iop/apps/edge/internal/authprojection	0.192s
ok  	iop/apps/edge/internal/bootstrap	41.622s
ok  	iop/apps/edge/internal/configrefresh	1.442s
ok  	iop/apps/edge/internal/controlplane	7.021s
ok  	iop/apps/edge/internal/edgecmd	0.878s
ok  	iop/apps/edge/internal/edgevalidate	0.241s
ok  	iop/apps/edge/internal/events	0.154s
ok  	iop/apps/edge/internal/input	0.438s
ok  	iop/apps/edge/internal/input/a2a	0.339s
ok  	iop/apps/edge/internal/node	0.341s
ok  	iop/apps/edge/internal/openai	15.289s
ok  	iop/apps/edge/internal/opsconsole	0.401s
ok  	iop/apps/edge/internal/service	6.974s
ok  	iop/apps/edge/internal/transport	5.381s
```

Exit status: 0

### Edge vet

Command:

```bash
go vet ./apps/edge/...
```

Output:

```text

```

Exit status: 0

### Formatting

Command:

```bash
gofmt -d apps/edge/internal/openai/hot_path_terminal_control.go apps/edge/internal/openai/cancellation_routes_test.go
```

Output:

```text

```

Exit status: 0

### Diff validation

Command:

```bash
git diff --check
```

Output:

```text

```

Exit status: 0

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |

## Code Review Result

- Overall Verdict: PASS
- Dimension Assessment:
  - Correctness: Pass — only errors returned by the endpoint release callback receive the caller-cancel disposition; pre-callback release preparation errors retain their runtime classification.
  - Completeness: Pass — the callback marker, release-sink boundary, runtime disposition propagation, and exact active-stage cancellation behavior satisfy the scoped implementation item.
  - Test Coverage: Pass — the production-path writer-disconnect matrix covers both endpoints and all four stage labels, while the deterministic tool-ID allocation failure is a negative control for the pre-callback boundary.
  - API Contract: Pass — caller disconnect remains wire-silent with one `CANCEL_RUN`, while internal release/runtime failures remain endpoint-standard provider errors as required by S13.
  - Code Quality: Pass — the unexported marker is localized to the callback boundary, preserves the original cause through `Unwrap`, and does not widen endpoint or runtime APIs.
  - Implementation Deviation: Pass — the implementation matches the active plan and changes only the declared production, regression, and review artifact files.
  - Verification Trust: Pass — fresh reviewer execution reproduced all targeted, race, full Edge, vet, formatting, and diff results with exit status 0.
  - Spec Conformance: Pass — the implementation and evidence satisfy S13 and the `error-cancel` Evidence Map requirement without introducing a custom terminal status.
- Findings: None.
- Routing Signals:
  - `review_rework_count=2`
  - `evidence_integrity_failure=false`
- Next Step: Archive the completed pair, write `complete.log`, and emit milestone completion metadata for runtime aggregation.
