<!-- task=m-node-provider-execution-liveness-recovery/03+02_health_classification plan=1 tag=API milestone-task=health-classification -->

# Code Review Reference - API

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-08-03
task=m-node-provider-execution-liveness-recovery/03+02_health_classification, plan=1, tag=API

## Archive Evidence Snapshot

- Prior plan: `agent-task/m-node-provider-execution-liveness-recovery/03+02_health_probe_contract/plan_cloud_G08_0.log`.
- Prior review stub: `agent-task/m-node-provider-execution-liveness-recovery/03+02_health_probe_contract/code_review_cloud_G08_0.log`.
- Prior verdict: none; implementation and implementation-owned evidence had not started.
- Required carryover: adapter transport/HTTP/decode errors are inconclusive, not unavailable; expose them and consume a typed fail-closed classifier before terminal enrichment.

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G08.md` → `code_review_cloud_G08_0.log` and `PLAN-cloud-G08.md` → `plan_cloud_G08_0.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-node-provider-execution-liveness-recovery/03+02_health_classification/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS, preserve first-line `milestone-task=health-classification` metadata in `complete.log` and report it for runtime aggregation. Roadmap state evaluation belongs to `sync-milestone-workstate`.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| API-1 — bounded target-aware classifier | [ ] |
| API-2 — connection sequence and terminal enrichment | [ ] |
| TEST-1 — classification/sequence/isolation evidence | [ ] |
| DOC-1 — Node health evidence contracts | [ ] |

## Implementation Checklist

- [ ] [API-1] Add an independent bounded target-aware probe classifier with fail-closed unknown semantics.
- [ ] [API-2] Generate connection-scoped monotonic observation sequence and enrich both stall terminal variants atomically.
- [ ] [TEST-1] Verify all probe outcomes, sequence scope, identity evidence, terminal invariants, and no progress reset deterministically.
- [ ] [DOC-1] Update the matching execution spec and execution/Edge-Node wire contracts for Node-produced health evidence and the explicit Edge ownership exclusion.
- [ ] Run every command in Final Verification and record exact results in `CODE_REVIEW-cloud-G08.md`.
- [ ] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [ ] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [ ] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [ ] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G08_0.log`.
- [ ] Archive active `PLAN-*-G??.md` to `plan_cloud_G08_0.log`.
- [ ] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [ ] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [ ] If PASS, move active task directory `agent-task/m-node-provider-execution-liveness-recovery/03+02_health_classification/` to `agent-task/archive/YYYY/MM/m-node-provider-execution-liveness-recovery/03+02_health_classification/` and update this checklist at the final archive path.
- [ ] If PASS and task group is `m-node-provider-execution-liveness-recovery`, preserve and report `milestone-task` metadata for runtime aggregation, without modifying roadmap or directly calling `update-roadmap`.
- [ ] If PASS for split work, remove empty active parent `agent-task/m-node-provider-execution-liveness-recovery/` or verify it was kept due to remaining siblings/files.
- [ ] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

_Record any deviations from the plan and the rationale here._

## Key Design Decisions

_Record key design decisions here._

## Reviewer Checkpoints

- Verify the `02+01_stall_watchdog` predecessor completion log is PASS; its declared `+01` dependency supplies the activity contract, and this implementation enriches rather than re-owns timer/fence behavior.
- Confirm the probe context is independent from canceled execution context, bounded, exact-target-aware, and never calls observer progress/reset.
- Confirm available -> request-stalled, only a valid exact-target unavailable/absent result -> provider-unhealthy, and network/HTTP/decode/unsupported/timeout/error/unknown/identity-inconclusive -> health-unknown.
- Confirm returned provider metadata cannot override Node-owned adapter/target identity or leak raw provider detail.
- Confirm one shared atomic sequence per Session, unique under concurrent run/tunnel observations, reset on a new Session, and omitted for nil-session internal calls.
- Confirm terminal/fence count, retryable behavior, and late-event fencing remain unchanged from the predecessor.
- Confirm contracts explicitly leave reception-generation binding, stale validation, Edge health overlay, recovery, and retry to later milestone tasks.

## Verification Results

### `go version && go env GOMOD`

_Implementing agent: record exit status and concise output._

### `go test -count=1 ./packages/go/execution ./packages/go/streamgate ./packages/go/config`

_Implementing agent: record exit status and concise output._

### `go test -count=1 ./packages/go/execution ./apps/node/...`

_Implementing agent: record exit status and concise output._

### `go test -count=1 ./packages/go/execution ./apps/node/internal/node ./apps/node/internal/transport ./apps/node/internal/adapters/ollama ./apps/node/internal/adapters/vllm ./apps/node/internal/adapters/openai_compat`

_Implementing agent: record exit status and concise output._

### `go test -count=10 ./packages/go/execution ./apps/node/internal/node ./apps/node/internal/transport`

_Implementing agent: record exit status and concise output._

### `go test -race -count=3 ./packages/go/execution ./apps/node/internal/node ./apps/node/internal/transport ./apps/node/internal/adapters/ollama ./apps/node/internal/adapters/vllm ./apps/node/internal/adapters/openai_compat`

_Implementing agent: record exit status and concise output._

### `go vet ./packages/go/execution ./apps/node/internal/node ./apps/node/internal/transport ./apps/node/internal/adapters/ollama ./apps/node/internal/adapters/vllm ./apps/node/internal/adapters/openai_compat`

_Implementing agent: record exit status and concise output._

### `go test -count=1 ./...`

_Implementing agent: record exit status and concise output._

### `./scripts/e2e-smoke.sh`

_Implementing agent: record exit status and concise output, or the exact environment-only blocker._

### `IOP_DEV_RECONNECT_BIND_TIMEOUT=45 ./scripts/dev/edge-node-reconnect-diagnostic.sh`

_Implementing agent: record exit status and concise output._

### `make readability-audit`

_Implementing agent: record exit status and concise output._

### `git diff --check`

_Implementing agent: record exit status and concise output._

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |
