<!-- task=m-iop-agent-cli-runtime/15+13_host_lifecycle plan=2 tag=REVIEW_REVIEW_API -->

# Code Review Reference - REVIEW_REVIEW_API

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-07-30
task=m-iop-agent-cli-runtime/15+13_host_lifecycle, plan=2, tag=REVIEW_REVIEW_API

## Archive Evidence Snapshot

- Prior plan: `agent-task/m-iop-agent-cli-runtime/15+13_host_lifecycle/plan_local_G04_1.log`
- Prior review: `agent-task/m-iop-agent-cli-runtime/15+13_host_lifecycle/code_review_cloud_G04_1.log`
- Verdict: FAIL
- Findings: Required 1, Suggested 0, Nit 0. `TestHostStopCancelsInProgressStart` waits for both lifecycle goroutines before reading `Status().Stopped`, so the planned no-premature-terminal invariant is not verified.
- Affected files: `apps/agent/internal/host/host_test.go`
- Verification evidence: fresh focused, full-package, race, vet, formatting, and diff checks passed; source inspection confirms the prior deadlock is fixed, but the regression has no cleanup-in-progress observation point.
- Roadmap carryover: this remains a compatibility prerequisite for the active IOP Agent CLI Runtime Milestone and does not complete a Roadmap Task id.

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G04.md` → `code_review_cloud_G04_2.log` and `PLAN-cloud-G03.md` → `plan_cloud_G03_2.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-iop-agent-cli-runtime/15+13_host_lifecycle/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and task group is `m-<milestone-slug>`, report completion event metadata. Roadmap state check and `update-roadmap` calls are runtime responsibilities.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| REVIEW_REVIEW_API-1 Cleanup-order evidence | [x] |

## Implementation Checklist

- [x] Add a deterministic cleanup gate to `TestHostStopCancelsInProgressStart`, assert `Status().Stopped` remains false while started-prefix cleanup is blocked, then preserve the existing terminal, identity, trace, and idempotency assertions.
- [x] Run fresh focused repetition, full-package, race, vet, formatting, and diff verification.
- [x] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [x] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [x] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [x] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G04_2.log`.
- [x] Archive active `PLAN-*-G??.md` to `plan_cloud_G03_2.log`.
- [x] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [x] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [x] If PASS, move active task directory `agent-task/m-iop-agent-cli-runtime/15+13_host_lifecycle/` to `agent-task/archive/YYYY/MM/m-iop-agent-cli-runtime/15+13_host_lifecycle/` and update this checklist at the final archive path.
- [x] If PASS and task group is `m-<milestone-slug>`, report completion event metadata for runtime, without modifying roadmap or directly calling `update-roadmap`.
- [x] If PASS for split work, remove empty active parent `agent-task/m-iop-agent-cli-runtime/` or verify it was kept due to remaining siblings/files.
- [ ] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

None. Implementation followed PLAN-cloud-G03.md without deviation.

## Key Design Decisions

Added `stopStarted` and `stopRelease` synchronization channels along with a `sync.Once`-guarded `releaseStop` helper to `fakeComponent` in `apps/agent/internal/host/host_test.go`. Extended `TestHostStopCancelsInProgressStart` to assert that `Status().Stopped` remains false while started-prefix rollback cleanup is blocked by `stopRelease`. Used a `defer releaseStop()` helper so test goroutines are never stranded if an assertion fails.

## Reviewer Checkpoints

- The ready component's `Stop` callback signals entry and remains blocked until the test releases it.
- `Status().Stopped` is false while that callback is blocked and true only after cleanup completes.
- Existing cancellation identity, exact started-prefix trace, terminal state, and repeated-stop checks remain intact.
- Production host source and shared runtime contracts remain unchanged.

## Verification Results

Paste actual stdout/stderr for every command below. If a command changes, record the replacement and reason in `Deviations from Plan`.

### REVIEW_REVIEW_API-1 Focused Verification

```bash
gofmt -w apps/agent/internal/host/*.go
go test -count=20 -run '^TestHostStopCancelsInProgressStart$' ./apps/agent/internal/host
```

```text
ok  	iop/apps/agent/internal/host	0.002s
```

### Final Verification

```bash
gofmt -w apps/agent/internal/host/*.go
go test -count=20 -run '^TestHostStopCancelsInProgressStart$' ./apps/agent/internal/host
go test -count=1 ./apps/agent/internal/host
go test -count=1 -race ./apps/agent/internal/host
go vet ./apps/agent/internal/host
git diff --check
```

```text
ok  	iop/apps/agent/internal/host	0.002s
ok  	iop/apps/agent/internal/host	0.002s
ok  	iop/apps/agent/internal/host	1.007s
```

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Roadmap Targets | Fixed at stub creation from plan when present | Implementing agent must not modify; code-review copies it into `complete.log` as `Roadmap Completion` only on PASS |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |

## Code Review Result

- Overall Verdict: PASS
- Dimension Assessment:
  - Correctness: Pass
  - Completeness: Pass
  - Test coverage: Pass
  - API contract: Pass
  - Code quality: Pass
  - Implementation deviation: Pass
  - Verification trust: Pass
- Findings: None
- Routing Signals:
  - `review_rework_count=2`
  - `evidence_integrity_failure=false`
- Next Step: Archive the active pair, write `complete.log`, and move the completed split task to the monthly task archive.
