<!-- task=m-iop-owned-single-request-agent-execution/25+23,24_claude_smoke_qualification plan=1 tag=TEST milestone-task=error-cancel,claude-smoke -->

# Code Review Reference - TEST

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> Execute the plan's selected root cause, scope, files, and dependency decisions as written. Do not choose another owner, narrow/expand the write boundary, or replace a fix with another verification attempt.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-08-07
task=m-iop-owned-single-request-agent-execution/25+23,24_claude_smoke_qualification, plan=1, tag=TEST

## Archive Evidence Snapshot

- Prior plan: `agent-task/m-iop-owned-single-request-agent-execution/25+23,24_claude_smoke_qualification/plan_cloud_G08_0.log`; prior pristine review stub: `agent-task/m-iop-owned-single-request-agent-execution/25+23,24_claude_smoke_qualification/code_review_cloud_G08_0.log`.
- No implementation evidence or official verdict existed. Self-review found that the prior evidence path lived inside the active task directory and would break every contract/spec citation when a PASS archived that directory; it also omitted the matching input-surface spec.
- This replan writes the manifest to `agent-test/evidence/iop-owned-single-request-agent-execution/claude-smoke-evidence.json`, adds `agent-spec/input/openai-compatible-surface.md`, and declares `error-cancel,claude-smoke` evidence contribution so task 23's production change is not treated as full-cycle qualified before this external run. Task 23 remains the sole deterministic S11 error matrix owner.

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G08.md` → `code_review_cloud_G08_1.log` and `PLAN-cloud-G08.md` → `plan_cloud_G08_1.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-iop-owned-single-request-agent-execution/25+23,24_claude_smoke_qualification/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS, preserve `milestone-task=error-cancel,claude-smoke` in `complete.log` and report it for runtime aggregation. Roadmap evaluation belongs to `sync-milestone-workstate`.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| TEST-1 | [ ] |
| TEST-2 | [ ] |
| TEST-3 | [ ] |

## Implementation Checklist

- [ ] Resolve completed task-23/task-24 dependencies, run the harness self-test, and record a full authorized runner/Mac Node/source/binary/config/runtime/port/workspace/credential-name preflight before invocation.
- [ ] Invoke actual Claude exactly once through the harness and atomically produce `agent-test/evidence/iop-owned-single-request-agent-execution/claude-smoke-evidence.json` proving ingress one, Plan/Work/Review order and timing, terminal one, and final workspace verification.
- [ ] Validate the manifest and redaction contract, preserve all raw/secret material outside tracked artifacts, and do not auto-retry or substitute fake/stale evidence.
- [ ] After evidence PASS only, update the Anthropic outer contract and both matching current implementation specs from deferred to qualified with the stable exact evidence path and bounded limits.
- [ ] Run common SDD, proto, document/evidence, and diff verification freshly; if external execution is unavailable, record blocker evidence and stop for official review classification.
- [ ] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [ ] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [ ] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [ ] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G08_1.log`.
- [ ] Archive active `PLAN-*-G??.md` to `plan_cloud_G08_1.log`.
- [ ] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [ ] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [ ] If PASS, move active task directory `agent-task/m-iop-owned-single-request-agent-execution/25+23,24_claude_smoke_qualification/` to `agent-task/archive/YYYY/MM/m-iop-owned-single-request-agent-execution/25+23,24_claude_smoke_qualification/` and update this checklist at the final archive path.
- [ ] If PASS, preserve and report `milestone-task=error-cancel,claude-smoke` for runtime aggregation, without modifying roadmap or directly calling `update-roadmap`.
- [ ] If PASS for split work, remove empty active parent only if no siblings/files remain.
- [ ] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

_Record any deviations from the plan and the rationale here._

## Key Design Decisions

_Record key design decisions here._

## Reviewer Checkpoints

- Confirm tasks 23 and 24 each have exactly one PASS completion log and the actual runtime/harness match those reviewed sources.
- Confirm preflight proves authorized source/binary/config/runtime/provider/log/metrics/Mac workspace/CLI/secret-name identity before invocation.
- Confirm the harness invoked actual Claude once, never auto-retried, and atomically wrote the exact stable manifest.
- Confirm ingress=1, ordered Plan/Work/Review, timing, terminal=1, workspace verification, runtime identity, and zero forbidden matches validate without raw/secret material.
- Confirm all three living owners cite the stable evidence path and limit claims to the recorded run; confirm task archive movement cannot invalidate the citation.
- Confirm task 23 remains the deterministic S11 matrix owner and this packet supplies only its full-cycle integration contribution plus S12 qualification.

## Verification Results

Paste actual stdout/stderr for every command. If output is too long, record the exact command and saved output path; summaries are insufficient.

### 1. Dependency gate

Command:

```sh
bash -c 'set -euo pipefail; shopt -s nullglob; for index in 23 24; do candidates=(agent-task/m-iop-owned-single-request-agent-execution/${index}_*/complete.log agent-task/m-iop-owned-single-request-agent-execution/${index}+*/complete.log agent-task/archive/*/*/m-iop-owned-single-request-agent-execution/${index}_*/complete.log agent-task/archive/*/*/m-iop-owned-single-request-agent-execution/${index}+*/complete.log); printf "%s\n" "${candidates[@]}"; ((${#candidates[@]} == 1)); done'
```

Output:

_Fill with actual output._

### 2. Credential-free harness self-test

Command:

```sh
make test-single-request-claude-smoke-self-test
```

Output:

_Fill with actual output._

### 3. Authorized external preflight

Command:

```sh
mkdir -p agent-test/evidence/iop-owned-single-request-agent-execution && IOP_SINGLE_REQUEST_SMOKE_OUTPUT='agent-test/evidence/iop-owned-single-request-agent-execution/claude-smoke-evidence.json' make test-single-request-claude-smoke-preflight
```

Output:

_Fill with actual output._

### 4. One actual Claude invocation

Command:

```sh
IOP_SINGLE_REQUEST_SMOKE_OUTPUT='agent-test/evidence/iop-owned-single-request-agent-execution/claude-smoke-evidence.json' make test-single-request-claude-smoke
```

Output:

_Fill with actual output._

### 5. Stable manifest validation

Command:

```sh
./scripts/e2e-single-request-claude.sh --validate-manifest agent-test/evidence/iop-owned-single-request-agent-execution/claude-smoke-evidence.json
```

Output:

_Fill with actual output._

### 6. Approved SDD common suite

Command:

```sh
go test -race -count=1 ./packages/go/config ./packages/go/streamgate ./apps/edge/internal/openai ./apps/edge/internal/service ./apps/node/internal/node ./apps/node/internal/transport ./apps/node/internal/workspace
```

Output:

_Fill with actual output._

### 7. Protobuf reproducibility

Command:

```sh
make proto && git diff --exit-code -- proto/gen/iop
```

Output:

_Fill with actual output._

### 8. Stable bounded qualification search

Command:

```sh
rg --sort path -n 'agent-test/evidence/iop-owned-single-request-agent-execution/claude-smoke-evidence.json|S11|S12|claude-smoke|ingress|Plan|Work|Review|stage|total|terminal|workspace|single run|single-run|qualified' agent-contract/outer/anthropic-compatible-api.md agent-spec/runtime/edge-node-execution.md agent-spec/input/openai-compatible-surface.md agent-test/evidence/iop-owned-single-request-agent-execution/claude-smoke-evidence.json
```

Output:

_Fill with actual output._

### 9. Diff hygiene

Command:

```sh
git diff --check
```

Output:

_Fill with actual output._

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as prior-loop context; read only the cited archive files when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |
