<!-- task=m-openai-compatible-output-validation-filters/02+01_repeat_guard plan=7 tag=REVIEW_OFR-REPEAT-6 -->

# Code Review Reference - REVIEW_OFR-REPEAT-6

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-07-29
task=m-openai-compatible-output-validation-filters/02+01_repeat_guard, plan=7, tag=REVIEW_OFR-REPEAT-6

## Roadmap Targets

- Milestone: `agent-roadmap/phase/knowledge-tool-optimization-extension/milestones/openai-compatible-output-validation-filters.md`
- Milestone link: [Milestone document](agent-roadmap/phase/knowledge-tool-optimization-extension/milestones/openai-compatible-output-validation-filters.md)
- Task ids:
  - `repeat-guard`: rolling content/history/action repetition detection and safe continuation
- Completion mode: check-on-pass

## Archive Evidence Snapshot

- Predecessor dependency: `agent-task/archive/2026/07/m-openai-compatible-output-validation-filters/01_resume_notice_builder/complete.log` records PASS and satisfies subtask `+01`.
- Earlier failed loops: `plan_cloud_G10_0.log` / `code_review_cloud_G10_0.log`, `plan_cloud_G10_1.log` / `code_review_cloud_G10_1.log`, `plan_cloud_G10_2.log` / `code_review_cloud_G10_2.log`, `plan_cloud_G10_3.log` / `code_review_cloud_G10_3.log`, and `plan_cloud_G10_5.log` / `code_review_cloud_G10_5.log`.
- Plan-contract correction: `plan_cloud_G10_4.log` and `code_review_cloud_G10_4.log`.
- Immediate prior pair: `plan_cloud_G10_6.log` and `code_review_cloud_G10_6.log`; verdict FAIL.
- Fresh reviewer evidence: local focused race checks pass, while the reviewed tree and dev runner still use different refs, selected capacity is 3 rather than 4, and the fixed prompt/observation inputs are absent.
- Required follow-up: publish the exact reviewed work through an authorized clean-ref workflow, rebuild/redeploy/restart every participating runtime from that ref, restore both selected providers, provision worker-owned inputs, and record 15 unique SSE-derived correlations plus three accepted `4/4/>=1/0/0` capacity rows.

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G10.md` → `code_review_cloud_G10_7.log` and `PLAN-cloud-G10.md` → `plan_cloud_G10_7.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-openai-compatible-output-validation-filters/02+01_repeat_guard/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and task group is `m-<milestone-slug>`, report completion event metadata. Roadmap state check and `update-roadmap` calls are runtime responsibilities.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| REVIEW_OFR-REPEAT-6-1 — Clean same-ref live lifecycle and capacity evidence with worker-owned external raw artifacts | [ ] |

## Implementation Checklist

- [ ] [REVIEW_OFR-REPEAT-6-1] Produce the clean same-ref `ornith:35b` 5-concurrent × 3 lifecycle and capacity evidence with matching runtime identities, worker-owned external raw artifacts, and sanitized results.
- [x] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [x] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [x] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [x] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G10_7.log`.
- [x] Archive active `PLAN-*-G??.md` to `plan_cloud_G10_7.log`.
- [x] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [ ] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [ ] If PASS, move active task directory `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/` to `agent-task/archive/YYYY/MM/m-openai-compatible-output-validation-filters/02+01_repeat_guard/` and update this checklist at the final archive path.
- [ ] If PASS and task group is `m-<milestone-slug>`, report completion event metadata for runtime, without modifying roadmap or directly calling `update-roadmap`.
- [ ] If PASS for split work, remove empty active parent `agent-task/m-openai-compatible-output-validation-filters/` or verify it was kept due to remaining siblings/files.
- [x] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

No scope deviation was introduced. The mandatory clean same-ref preflight
failed, so the live command was intentionally not run. No production, test,
contract, spec, configuration, or raw-evidence file was changed by this
follow-up.

## Key Design Decisions

- Preserved the existing dirty reviewed worktree and did not create a commit,
  push a ref, clean-sync a shared runner, deploy binaries, or restart shared
  runtimes from this verification-only action.
- Treated the runner's stored Node binaries as artifacts only, not as proof of
  the binaries or processes running on the two participating provider Nodes.
- Kept raw live inputs and outputs outside the workspace. Because the
  worker-owned prompt and observation inputs were absent, no raw live artifact
  was created.

## Reviewer Checkpoints

- Confirm one clean reviewed ref identifies the source, Edge binary, every participating Node binary, deployment/restart, process start time, listener ports, and selected provider status.
- Reject stale or mixed source/build/process identities and any live summary produced before the clean same-ref preflight passes.
- Confirm the exact live command exits 0 with 15 unique SSE-derived correlations and exactly three capacity rows satisfying `4/4/>=1/0/0`.
- Confirm raw prompt, SSE, output, credentials, and tokens remain only in the worker-owned `/tmp/iop-repeat-guard-live/` directory; tracked artifacts and stdout remain sanitized.
- Confirm no production, test, contract, spec, or config change was introduced by this verification-only follow-up.

## Verification Results

### Clean Same-Ref Identity Preflight

Record the authorized clean ref, clean runner status, Edge and every participating Node checksum/version, deployment/restart record, process start times, listener ports, provider identities, configured capacity, and readiness of the fixed worker-owned prompt/observation inputs. If any identity is stale, mixed, or unavailable, record the exact attempted preflight output, blocker, and resume condition and do not run the live command.

Implementation evidence:

```text
$ git status --short --branch | sed -n '1p'
## feature/openai-compatible-output-validation-filters...origin/feature/openai-compatible-output-validation-filters [ahead 1]

$ git rev-parse HEAD
da506ba71d360e5bd3224a9070fa9ce945944ab5

$ git diff --name-only | wc -l
32

$ git ls-remote --heads origin feature/openai-compatible-output-validation-filters
f4604919c0464c8b811cc9eb29203b4f9180bf6c	refs/heads/feature/openai-compatible-output-validation-filters
exit 0

Conclusion: the exact reviewed source is HEAD
da506ba71d360e5bd3224a9070fa9ce945944ab5 plus a dirty tracked worktree. The
remote feature tip is f4604919c0464c8b811cc9eb29203b4f9180bf6c, so neither
ref identifies the exact reviewed tree.

Current-checkout inventory preflight:
- env=dev
- runner=toki@toki-labs.com
- runner workdir=/Users/toki/agent-work/iop-dev
- model=ornith:35b
- expected aggregate capacity=4
- providers=onexplayer-lemonade (capacity 3),
  rtx5090-lemonade (capacity 1)

Authorized runner read-only preflight:
Darwin arm64
## main...origin/main
source=e24207916a8ac83169a398af6458256a0f1332e0

3547f03aee10b2834362a9808b672ca54ebbf2c4e32067f02bd84d6fa6f00a85  build/dev-runtime/bin/edge
build/dev-runtime/bin/edge mtime=2026-07-23T23:53:27Z size=22442066
e2107da218fd3f1c0d0f9f5446ecd54cf095edbc3c8d6020daa651acc0905177  build/dev-runtime/bin/iop-node
build/dev-runtime/bin/iop-node mtime=2026-07-23T23:53:28Z size=27298770
facdc08bd181007c3c5cf63664b8e6272d569d888f7e81c182eef9f4f867a879  build/dev-runtime/bin/iop-node-linux-arm64
build/dev-runtime/bin/iop-node-linux-arm64 mtime=2026-07-23T23:53:31Z size=26416382
ea75b41733a8a61afd6ee156d43575889ef8d20a5ca6706724d4e605f388f698  build/dev-runtime/bin/iop-node-windows-amd64.exe
build/dev-runtime/bin/iop-node-windows-amd64.exe mtime=2026-07-23T23:53:33Z size=28636672

$ ./build/dev-runtime/bin/edge version
0.1.0
$ ./build/dev-runtime/bin/iop-node version
0.1.0

LISTENER 18083 OPEN
LISTENER 18084 OPEN
LISTENER 19093 OPEN
PROMPT_READY no
OBSERVATION_READY no
EDGE_PID 1319
Fri Jul 24 05:35:43 2026     ./bin/edge --config edge.yaml serve
cwd=/Users/toki/agent-work/iop-dev/build/dev-runtime

Control Plane selected-provider status:
EDGE_CONNECTED unknown
provider=onexplayer-lemonade node=onexplayer-lemonade-node status=available health=healthy capacity=3 in_flight=0 queued=0
provider=rtx5090-lemonade node=rtx5090-lemonade-node status=unavailable health=offline capacity=0 in_flight=0 queued=0
SELECTED_FOUND 2

The stored Node artifacts are stale relative to the reviewed tree and do not
prove the source, checksum, deployment/restart, or process start identity of
either participating provider Node.

Exact blockers:
1. No clean remotely addressable ref is evidenced to identify the exact
   reviewed tree.
2. The clean runner and running Edge use a different source ref and stale
   artifacts; no same-ref participating Node process identity is available.
3. rtx5090-lemonade is offline, leaving selected aggregate capacity at 3
   instead of 4.
4. The non-empty prompt and observation inputs are absent from the fixed
   worker-owned paths.

Resume condition:
Use the authorized workflow to publish the exact reviewed tree as one clean
ref; clean-sync the runner to that ref; rebuild, redeploy, and restart the Edge
and both participating Nodes from it; record matching source, checksum,
version, deployment/restart, process start, and listener identity; restore both
providers for aggregate capacity 4; and provision the non-empty prompt and
regular observation file under /tmp/iop-repeat-guard-live/. Rerun this
preflight before invoking the live command exactly once.
```

### Fresh Local Guard Verification

```bash
go version && go env GOMOD
git diff --check
go test -race -count=1 ./packages/go/streamgate -run '^TestRequestRuntimeTerminalFailureFidelity/fatal_filter_overrides_success_terminal$'
go test -race -count=1 ./apps/edge/internal/openai -run 'Test(DevRepeatGuardObservationCorrelation|DevRepeatGuardCapacityEvidence)'
```

Expected: all commands exit 0; focused evidence is fresh and uncached.

Implementation evidence:

```text
$ go version && go env GOMOD
go version go1.26.2 linux/arm64
/config/workspace/iop-s1/go.mod
exit 0

$ git diff --check
(no stdout/stderr)
exit 0

$ go test -race -count=1 ./packages/go/streamgate -run '^TestRequestRuntimeTerminalFailureFidelity/fatal_filter_overrides_success_terminal$'
ok  	iop/packages/go/streamgate	1.037s
exit 0

$ go test -race -count=1 ./apps/edge/internal/openai -run 'Test(DevRepeatGuardObservationCorrelation|DevRepeatGuardCapacityEvidence)'
ok  	iop/apps/edge/internal/openai	1.352s
exit 0
```

### Clean Same-Ref Live Lifecycle and Capacity Evidence

After the authorized clean sync/rebuild/redeploy/restart and identity proof:

```bash
IOP_OPENAI_BASE_URL=http://127.0.0.1:18083 \
IOP_OPENAI_MODEL=ornith:35b \
IOP_OPENAI_SMOKE_CONCURRENCY=5 \
IOP_OPENAI_SMOKE_RUNS=3 \
IOP_OPENAI_SMOKE_PROMPT_FILE=/tmp/iop-repeat-guard-live/repeat-prompt.txt \
IOP_OPENAI_SMOKE_ARTIFACT_DIR=/tmp/iop-repeat-guard-live/repeat-guard \
IOP_OPENAI_SMOKE_OBSERVATION_FILE=/tmp/iop-repeat-guard-live/edge-observations.jsonl \
IOP_OPENAI_SMOKE_STATUS_URL=http://127.0.0.1:18001/edges/edge-toki-labs-dev/status \
IOP_OPENAI_SMOKE_PROVIDER_IDS=onexplayer-lemonade,rtx5090-lemonade \
go test -count=1 -v ./apps/edge/internal/openai -run '^TestDevRepeatGuardOrnithSmoke$'
```

Expected: exit 0; exactly 15 unique sanitized request correlations and three capacity rows satisfying `4/4/>=1/0/0`, with no raw prompt/output/token in tracked files or stdout.

Implementation evidence:

```text
Status: NOT RUN.

The mandatory clean same-ref identity preflight failed for the exact blockers
recorded above. The live command was therefore not invoked. No prompt, raw SSE,
output, observation, credential, token, or generated summary artifact was
created or copied into this workspace.
```

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Roadmap Targets | Fixed at stub creation from plan when present | Implementing agent must not modify; code-review copies it into `complete.log` as `Roadmap Completion` only on PASS |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |

## Code Review Result

- Overall Verdict: FAIL
- Dimension Assessment:
  - Correctness: Pass
  - Completeness: Fail
  - Test coverage: Fail
  - API contract: Pass
  - Code quality: Pass
  - Implementation deviation: Pass
  - Verification trust: Pass
  - Spec conformance: Fail
- Findings:
  - Required — `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/CODE_REVIEW-cloud-G10.md:55`, `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/CODE_REVIEW-cloud-G10.md:252`, and `agent-roadmap/phase/knowledge-tool-optimization-extension/milestones/openai-compatible-output-validation-filters.md:78`: REVIEW_OFR-REPEAT-6-1 remains unchecked and the required clean same-ref `ornith:35b` capacity+1 live verification is explicitly `NOT RUN`. Fresh reviewer checks confirm that the reviewed local tree is not represented by the remote feature ref, the clean dev runner remains on another ref with stale runtime artifacts, selected capacity is 3 because `rtx5090-lemonade` is offline, and both fixed worker-owned inputs are absent. Publish the exact reviewed tree through an authorized clean-ref workflow, clean-sync and rebuild/redeploy/restart every participating Edge and Node from that ref, restore both selected providers, provision the worker-owned inputs, run the fixed 5-concurrent × 3 command, and record only sanitized identities, 15 unique SSE-derived correlations, and three accepted `4/4/>=1/0/0` capacity rows.
- Routing Signals: `review_rework_count=7`, `evidence_integrity_failure=false`
- Next Step: Archive this failed pair and create the routed follow-up PLAN/CODE_REVIEW pair for the same task path.
