<!-- task=m-iop-hot-path-one-shot-execution/20+17,19_smoke_harness plan=5 tag=REVIEW_REVIEW_REVIEW_TEST milestone-task=hot-smoke -->

# Code Review Reference - REVIEW_REVIEW_REVIEW_TEST

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-08-05
task=m-iop-hot-path-one-shot-execution/20+17,19_smoke_harness, plan=5, tag=REVIEW_REVIEW_REVIEW_TEST

## Archive Evidence Snapshot

- `agent-task/m-iop-hot-path-one-shot-execution/20+17,19_smoke_harness/plan_cloud_G09_4.log` and `agent-task/m-iop-hot-path-one-shot-execution/20+17,19_smoke_harness/code_review_cloud_G09_4.log` close plan 4 with `FAIL`: one Required finding, zero Suggested findings, and zero Nits.
- Fresh review evidence: syntax, fixed-schema inspection, credential-free `--self-test`, and `git diff --check` exited 0. The common race-enabled package regression exited 1 because `Server.artifactFrontiers`, `Server.requestCoordinator`, `Server.lightFlows`, and `chatHotPathPolicy` are undefined in the shared checkout.
- The harness implementation itself received no new correctness finding. `review_rework_count=3`; `evidence_integrity_failure=false` because the implementation's recorded outputs matched fresh review execution.
- Split prerequisites remain satisfied by `agent-task/archive/2026/08/m-iop-hot-path-one-shot-execution/17+14,15,16_endpoint_error_matrix/complete.log` and `agent-task/archive/2026/08/m-iop-hot-path-one-shot-execution/19+17,18_observation_lifecycle/complete.log`.

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G03.md` → `code_review_cloud_G03_5.log` and `PLAN-cloud-G03.md` → `plan_cloud_G03_5.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-iop-hot-path-one-shot-execution/20+17,19_smoke_harness/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and task group is `m-<milestone-slug>`, preserve the first-line `milestone-task` metadata in `complete.log` and report it for the runtime aggregation event. Roadmap state evaluation belongs to `sync-milestone-workstate`.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| REVIEW_REVIEW_REVIEW_TEST-1 Mandatory integrated verification | [ ] |

## Implementation Checklist

- [ ] [REVIEW_REVIEW_REVIEW_TEST-1] Revalidate the unchanged fail-closed harness and close every SDD common verification command after the shared Edge checkout compiles consistently.
- [x] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [x] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [x] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [x] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G03_5.log`.
- [x] Archive active `PLAN-*-G??.md` to `plan_cloud_G03_5.log`.
- [x] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [ ] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [ ] If PASS, move active task directory `agent-task/m-iop-hot-path-one-shot-execution/20+17,19_smoke_harness/` to `agent-task/archive/YYYY/MM/m-iop-hot-path-one-shot-execution/20+17,19_smoke_harness/` and update this checklist at the final archive path.
- [ ] If PASS and task group is `m-<milestone-slug>`, preserve and report `milestone-task` metadata for runtime aggregation, without modifying roadmap or directly calling `update-roadmap`.
- [ ] If PASS for split work, remove empty active parent `agent-task/m-iop-hot-path-one-shot-execution/` or verify it was kept due to remaining siblings/files.
- [x] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

No scope deviation from PLAN-cloud-G03.md. This verification-only follow-up changed no harness, schema, production Edge/Node, config, Makefile, deployment, or credential files. Four of the five Final Verification commands exit 0 with fresh evidence. The SDD common regression (item REVIEW_REVIEW_REVIEW_TEST-1) is left incomplete because the shared `apps/edge/internal/openai` checkout is still compile-inconsistent on the current dirty shared worktree (HEAD `25c5517`, branch `feature/iop-hot-path-one-shot-execution`).

Blocker evidence (fresh execution):

- `go test -race -count=1 ./packages/go/streamgate ./packages/go/config ./apps/edge/internal/openai ./apps/edge/internal/service` exits 1 at compile time.
- `iop/packages/go/streamgate`, `iop/packages/go/config`, and `iop/apps/edge/internal/service` report `ok` race-enabled.
- `iop/apps/edge/internal/openai` fails to build: `s.artifactFrontiers undefined`, `s.requestCoordinator undefined`, `s.lightFlows undefined`, and `undefined: chatHotPathPolicy` (truncated by the compiler after `too many errors`).
- Source inspection of the current shared checkout confirms `apps/edge/internal/openai/server.go:58` `type Server struct` omits the Hot Path fields and `server.go:99` `func NewServer` omits their initialization, while the removed/renamed symbols are still referenced by the dependent Hot Path implementation files (`artifact_pair.go`, `hot_path_cleanup.go`, `request_coordinator_ttl.go`, `request_identity_ingress.go`, `hot_path_direct.go`, `hot_path_dispatch.go`, `hot_path_light.go`, `normalized_sse.go`).
- `./scripts/e2e-hot-path-agents.sh --self-test` passes the fail-closed harness oracle; both shell/schema integrity checks and `git diff --check` exit 0.

Resume condition: the owning production task must restore a compile-consistent `apps/edge/internal/openai` checkout (re-add `Server.artifactFrontiers`, `Server.requestCoordinator`, `Server.lightFlows`, their `NewServer` initialization, and `chatHotPathPolicy`, or consistently update every dependent reference). After that checkout compiles, re-run only the SDD common regression command above; the remaining four Final Verification commands are already green in this evidence record. Until then the integrated verification item stays incomplete and must not be PASS evidence.

## Key Design Decisions

- No harness or production source change was made. The follow-up intentionally limits its surface to running the mandatory verification set and recording fresh evidence, exactly as PLAN-cloud-G03.md scopes it.
- The harness self-test was revalidated with credential-free, fake-agent-only execution: the unchanged fail-closed invariants (exact argv, fixed 2x5 matrix, schema rejection, identity mismatch exit 69, observation evidence enforcement, terminal/scenario contradiction, child-only cancellation, cleanup/orphan classification, secret absence) all pass.
- The integrated SDD regression is left incomplete rather than marked complete because a shared-worktree compile failure is blocker evidence, not PASS evidence, per PLAN-cloud-G03.md Final Verification. The compile gap is owned by the concurrent production work; this task does not repair, revert, or overwrite those shared production changes.
- The split predecessors (17, 19) remain satisfied by their archived `complete.log` records, so this loop's only open evidence gap is the compile-coupled `apps/edge/internal/openai` integration test.

## Reviewer Checkpoints

- Confirm the implementing agent did not change harness, schema, production Edge/Node, config, Makefile, deployment, or credential files for this verification-only follow-up.
- Confirm all five Final Verification commands ran with fresh output and exited 0; a shared-worktree compiler failure is blocker evidence, not PASS.
- Confirm the recorded common regression output matches the same checkout used for shell/schema/self-test/diff evidence.
- Confirm PASS preserves `milestone-task=hot-smoke` only as contribution metadata and does not claim the downstream credentialed S16 run.

## Verification Results

### Harness syntax

Command: `bash -n scripts/e2e-hot-path-agents.sh`

```text
(no stdout/stderr)
EXIT=0
```

### Fixed manifest schema

Command: `jq -e '(.properties.cases.prefixItems | length) == 10 and .properties.cases.items == false and ([.properties.cases.prefixItems[].properties.id.const] | length == 10) and ([.properties.cases.prefixItems[].properties.id.const] | unique | length == 10)' scripts/fixtures/hot-path-agent-smoke-manifest.schema.json`

```text
true
EXIT=0
```

### Credential-free behavioral oracle

Command: `./scripts/e2e-hot-path-agents.sh --self-test`

```text
[e2e-hot-path-agents] assertion PASS: positive do_run exits 0
[e2e-hot-path-agents] assertion PASS: produced manifest validates against supplied fixture
[e2e-hot-path-agents] assertion PASS: ten unique case ids
[e2e-hot-path-agents] assertion PASS: raw argv/stdout capture deleted
[e2e-hot-path-agents] assertion PASS: direct cases terminal=success
[e2e-hot-path-agents] assertion PASS: write-unavailable terminal=provider_error
[e2e-hot-path-agents] assertion PASS: timeout-cancel terminal=cancelled
[e2e-hot-path-agents] assertion PASS: process exit status is captured from wait
[e2e-hot-path-agents] assertion PASS: light-pass/repair cleanup=removed
[e2e-hot-path-agents] assertion PASS: timeout-cancel cleanup=orphan
[e2e-hot-path-agents] assertion PASS: timeout-cancel child_only target
[e2e-hot-path-agents] assertion PASS: redaction matches == 0 on manifest
[e2e-hot-path-agents] assertion PASS: redaction detects leaked sentinel
[e2e-hot-path-agents] assertion PASS: all surviving harness artifacts are redacted
[e2e-hot-path-agents] assertion PASS: workspace digest changes on content-only edit
[e2e-hot-path-agents] assertion PASS: 9-case manifest rejected
[e2e-hot-path-agents] assertion PASS: forbidden-field manifest rejected
[e2e-hot-path-agents] assertion PASS: bad-enum manifest rejected
[e2e-hot-path-agents] assertion PASS: 11-case duplicate manifest rejected
[e2e-hot-path-agents] assertion PASS: distinct-row duplicate id rejected
[e2e-hot-path-agents] assertion PASS: id-agent mismatch rejected
[e2e-hot-path-agents] assertion PASS: id-scenario mismatch rejected
[e2e-hot-path-agents] assertion PASS: terminal-event contradiction rejected
[e2e-hot-path-agents] assertion PASS: cancellation relation mismatch rejected
[e2e-hot-path-agents] assertion PASS: alternate fixture changes acceptance rejected
[e2e-hot-path-agents] assertion PASS: malformed nine-row fixture rejected
[e2e-hot-path-agents] validation failed: claude_binary_sha256: identity mismatch
[e2e-hot-path-agents] assertion PASS: runtime identity mismatch rejected before invocation
[e2e-hot-path-agents] assertion PASS: source identity mismatch rejected before invocation
[e2e-hot-path-agents] assertion PASS: missing observation evidence rejected before manifest output
[e2e-hot-path-agents] assertion PASS: mismatched observation request correlation rejected before manifest output
[e2e-hot-path-agents] assertion PASS: immediate exit with no native output rejected before manifest output
[e2e-hot-path-agents] assertion PASS: missing native terminal rejected before manifest output
[e2e-hot-path-agents] assertion PASS: terminal and scenario contradiction rejected before manifest output
[e2e-hot-path-agents] assertion PASS: content-insensitive cleanup contradiction rejected before manifest output
[e2e-hot-path-agents] assertion PASS: timeout without triggered child cancellation rejected before manifest output
[e2e-hot-path-agents] assertion PASS: preflight ok
[e2e-hot-path-agents] self-test PASSED: exact argv, fixed 2x5 matrix, schema rejection,
[e2e-hot-path-agents]   identity mismatch exit 69 before invocation, secret absence,
[e2e-hot-path-agents]   child-only cancellation, cleanup/orphan classification, and full
[e2e-hot-path-agents]   cleanup verified with fake agents/runtime only.
EXIT=0
```

### SDD common regression

Command: `go test -race -count=1 ./packages/go/streamgate ./packages/go/config ./apps/edge/internal/openai ./apps/edge/internal/service`

```text
# iop/apps/edge/internal/openai [iop/apps/edge/internal/openai.test]
apps/edge/internal/openai/artifact_pair.go:369:19: s.artifactFrontiers undefined (type *Server has no field or method artifactFrontiers)
apps/edge/internal/openai/artifact_pair.go:369:59: s.requestCoordinator undefined (type *Server has no field or method requestCoordinator)
apps/edge/internal/openai/artifact_pair.go:378:7: s.lightFlows undefined (type *Server has no field or method lightFlows)
apps/edge/internal/openai/artifact_pair.go:379:15: s.lightFlows undefined (type *Server has no field or method lightFlows)
apps/edge/internal/openai/artifact_pair.go:403:19: s.requestCoordinator undefined (type *Server has no field or method requestCoordinator)
apps/edge/internal/openai/hot_path_cleanup.go:390:15: undefined: chatHotPathPolicy
apps/edge/internal/openai/hot_path_cleanup.go:468:7: s.lightFlows undefined (type *Server has no field or method lightFlows)
apps/edge/internal/openai/hot_path_cleanup.go:469:5: s.lightFlows undefined (type *Server has no field or method lightFlows)
apps/edge/internal/openai/hot_path_cleanup.go:471:8: s.requestCoordinator undefined (type *Server has no field or method requestCoordinator)
apps/edge/internal/openai/hot_path_cleanup.go:485:4: s.lightFlows undefined (type *Server has no field or method lightFlows)
apps/edge/internal/openai/hot_path_cleanup.go:485:4: too many errors
ok  	iop/packages/go/streamgate	1.984s
ok  	iop/packages/go/config	1.486s
FAIL	iop/apps/edge/internal/openai [build failed]
ok  	iop/apps/edge/internal/service	6.992s
FAIL
EXIT=1
```

Status: BLOCKED. Three of the four packages (`streamgate`, `config`, `service`) compile and pass the race-enabled tests. The `apps/edge/internal/openai` package fails at compile build because the shared production checkout removes Hot Path `Server` state while dependent files still reference them. This matches the plan's documented blocker; harness/production source was not modified by this task.

### Diff integrity

Command: `git diff --check`

```text
(no stdout/stderr)
EXIT=0
```

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |

## Code Review Result

- Overall Verdict: FAIL
- Dimension Assessment:
  - Correctness: Pass
  - Completeness: Fail
  - Test Coverage: Fail
  - API Contract: Fail
  - Code Quality: Pass
  - Implementation Deviation: Pass
  - Verification Trust: Pass
  - Spec Conformance: Fail
- Findings:
  - Required — `agent-task/m-iop-hot-path-one-shot-execution/20+17,19_smoke_harness/CODE_REVIEW-cloud-G03.md:45`: `REVIEW_REVIEW_REVIEW_TEST-1` remains incomplete because the SDD-mandated common race regression exits 1. Fresh reviewer execution reproduced that `apps/edge/internal/openai/server.go:58-71` omits `artifactFrontiers`, `requestCoordinator`, and `lightFlows`, `NewServer` at `apps/edge/internal/openai/server.go:99-104` omits their initialization, and dependent Hot Path files still reference those fields while `chatHotPathPolicy` is undefined. Restore a compile-consistent shared `apps/edge/internal/openai` checkout in the owning production task, rerun `go test -race -count=1 ./packages/go/streamgate ./packages/go/config ./apps/edge/internal/openai ./apps/edge/internal/service`, require exit 0, and complete the integrated verification item before this harness task can pass.
- Routing Signals:
  - review_rework_count=4
  - evidence_integrity_failure=false
- Next Step: Invoke the plan skill in `prepare-follow-up` mode with this raw finding and fresh verification output, rerun isolated task routing, archive the current pair, and materialize the routed follow-up pair. Do not write `complete.log`.
