<!-- task=m-openai-compatible-output-validation-filters/02+01_repeat_guard plan=13 tag=REVIEW_OFR-REPEAT-12 -->

# Code Review Reference - REVIEW_OFR-REPEAT-12

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-07-29
task=m-openai-compatible-output-validation-filters/02+01_repeat_guard, plan=13, tag=REVIEW_OFR-REPEAT-12

## Roadmap Targets

- Milestone: `agent-roadmap/phase/knowledge-tool-optimization-extension/milestones/openai-compatible-output-validation-filters.md`
- Milestone link: [Milestone document](agent-roadmap/phase/knowledge-tool-optimization-extension/milestones/openai-compatible-output-validation-filters.md)
- Task ids:
  - `repeat-guard`: rolling content/history/action repetition detection and safe continuation
- Completion mode: check-on-pass

## Archive Evidence Snapshot

- Dependency `01_resume_notice_builder` remains satisfied by `agent-task/archive/2026/07/m-openai-compatible-output-validation-filters/01_resume_notice_builder/complete.log`.
- The current failed pair will be archived as `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/plan_cloud_G08_12.log` and `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/code_review_cloud_G08_12.log`.
- Required finding: `code_review_cloud_G08_12.log:233` records invocation count 0, no 15 provider responses, no 15 Edge correlations, no three accepted capacity rows, and no sanitized `reproduced`/`not_reproduced` summary.
- Trusted evidence: reviewed ref `d1e32b6e06f7153a4db5a5a08b7026d6dd49fcfb`; test-file SHA-256 `8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21`; fresh `git diff --check` and focused repeat-guard evidence tests exited 0 on 2026-07-29.
- Required follow-up: use `/Users/toki/agent-work/iop-dev` on the Darwin/arm64 dev runner, resolve Go from the same login shell used for the test, prove the reviewed runtime/source/isolation state, and consume exactly one live authorization.

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G08.md` → `code_review_cloud_G08_13.log` and `PLAN-cloud-G08.md` → `plan_cloud_G08_13.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-openai-compatible-output-validation-filters/02+01_repeat_guard/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and task group is `m-<milestone-slug>`, report completion event metadata. Roadmap state check and `update-roadmap` calls are runtime responsibilities.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| REVIEW_OFR-REPEAT-12-1 — On the verified Darwin/arm64 dev runner, prove the exact login-shell Go/source/runtime/isolation preconditions and execute exactly one fresh `ornith:35b` 5-concurrent × 3 live invocation that yields 15 provider responses, 15 Edge correlations, three accepted capacity rows, and a sanitized final result. | [ ] |

## Implementation Checklist

- [ ] [REVIEW_OFR-REPEAT-12-1] On the verified Darwin/arm64 dev runner, prove the exact login-shell Go/source/runtime/isolation preconditions and execute exactly one fresh `ornith:35b` 5-concurrent × 3 live invocation that yields 15 provider responses, 15 Edge correlations, three accepted capacity rows, and a sanitized final result.
- [x] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [x] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [x] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [x] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G08_13.log`.
- [x] Archive active `PLAN-*-G??.md` to `plan_cloud_G08_13.log`.
- [x] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [ ] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [ ] If PASS, move active task directory `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/` to `agent-task/archive/YYYY/MM/m-openai-compatible-output-validation-filters/02+01_repeat_guard/` and update this checklist at the final archive path.
- [ ] If PASS and task group is `m-<milestone-slug>`, report completion event metadata for runtime, without modifying roadmap or directly calling `update-roadmap`.
- [ ] If PASS for split work, remove empty active parent `agent-task/m-openai-compatible-output-validation-filters/` or verify it was kept due to remaining siblings/files.
- [x] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

No source, test, contract, spec, or tracked config was changed; this plan is verification-only and every plan command was run verbatim.

Environment deviation: the plan requires the S07 live lifecycle/capacity run on the Darwin/arm64 dev runner at `/Users/toki/agent-work/iop-dev`. This implementation host is Linux/aarch64 (`uname -s` = `Linux`, `uname -m` = `aarch64`) with no `/Users/toki/agent-work/iop-dev`, no `zsh`, and unreachable loopback listeners `18083`/`18001`. The external login-shell preflight and the single authorized live invocation therefore could not be executed here. Local integrity verification was completed and passed. The S07 external result remains outstanding and is recorded below as a blocker, matching the twelfth review's finding (`code_review_cloud_G08_12.log:233`, invocation count 0). No live authorization was consumed because a preflight failure consumes none.

## Key Design Decisions

- Treated the task as verification-only: no source/test/spec/contract/config mutation, preserving the reviewed test-file delta (SHA-256 `8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21`) and HEAD `d1e32b6e06f7153a4db5a5a08b7026d6dd49fcfb`.
- Ran the local integrity trio first to confirm reviewed integrity before any external attempt; all three exited 0.
- Probed the external preconditions read-only (`uname`, path existence, `zsh` presence, TCP loopback reachability) instead of invoking `zsh -lic`, because the host is not Darwin/arm64. This guarantees the sole live authorization is not consumed by a doomed launch, per the plan's rule that a preflight failure consumes no authorization.
- Kept all raw prompt/SSE/output/credential/token/endpoint material out of tracked evidence; only sanitized command results are recorded.

## Reviewer Checkpoints

- Confirm execution occurred on Darwin/arm64 at `/Users/toki/agent-work/iop-dev`, not in a substitute sandbox or stand-in runtime.
- Confirm the login shell resolves a non-empty executable Go path and the same shell invokes that exact path.
- Confirm HEAD, test-only source delta, and reviewed SHA-256 match; no production, contract, spec, config, or deployed-runtime mutation was introduced.
- Confirm deployed Edge/Node identities, listeners, active blocking gate, selected provider health/idle state, capacities 3 and 1, prompt/artifact containment, observation quiescence, and zero competing harnesses before launch.
- Confirm exactly one Go test process is launched and exits 0.
- Confirm `summary.json` contains three runs, 15 globally unique provider response IDs, 15 globally unique Edge correlations, and three accepted capacity rows with `configured=4`, `peak_in_flight=4`, `peak_queued>=1`, `final_in_flight=0`, and `final_queued=0`.
- Confirm the sanitized result is `reproduced` with fingerprint/offset or `not_reproduced`, both providers return idle, no harness remains, and no raw prompt/SSE/output/credential/token enters tracked evidence or stdout.

## Verification Results

### Local Integrity Verification

```bash
git diff --check
sha256sum apps/edge/internal/openai/stream_gate_vertical_slice_test.go
go test -count=1 ./apps/edge/internal/openai -run 'TestDevRepeatGuard(SmokeEvidence|ObservationCorrelation|ObservationQuiescence|CapacityEvidence)'
```

Expected: all commands exit 0 and the SHA-256 is `8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21`.

Implementation evidence:

```text
Host: Linux/aarch64; Go 1.26.2; GOMOD /config/workspace/iop-s1/go.mod; HEAD d1e32b6e06f7153a4db5a5a08b7026d6dd49fcfb (2026-07-29).

$ git diff --check
(no output)
exit=0

$ sha256sum apps/edge/internal/openai/stream_gate_vertical_slice_test.go
8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21  apps/edge/internal/openai/stream_gate_vertical_slice_test.go
exit=0   # matches the reviewed SHA-256

$ go test -count=1 ./apps/edge/internal/openai -run 'TestDevRepeatGuard(SmokeEvidence|ObservationCorrelation|ObservationQuiescence|CapacityEvidence)'
ok  	iop/apps/edge/internal/openai	0.327s
exit=0
```

### External Login-Shell Go and Source Preflight

```bash
zsh -lic '
set -eu
test "$(uname -s)" = "Darwin"
test "$(uname -m)" = "arm64"
cd /Users/toki/agent-work/iop-dev
go_bin="$(command -v go)"
test -n "$go_bin"
test -x "$go_bin"
"$go_bin" version
"$go_bin" env GOMOD
git rev-parse HEAD
git status --short
shasum -a 256 apps/edge/internal/openai/stream_gate_vertical_slice_test.go
'
```

Expected: Go `1.26.3`, GOMOD `/Users/toki/agent-work/iop-dev/go.mod`, HEAD `d1e32b6e06f7153a4db5a5a08b7026d6dd49fcfb`, only the reviewed test-file source delta, and the reviewed SHA-256.

Implementation evidence:

```text
BLOCKED — the current implementation host is Linux/aarch64, not the required Darwin/arm64 dev runner. The `zsh -lic` login-shell preflight was not started; no live authorization consumed.

Read-only probes on the current host:
$ uname -s                              -> Linux    (expected Darwin)
$ uname -m                              -> aarch64   (expected arm64)
$ test -d /Users/toki/agent-work/iop-dev -> ABSENT
$ command -v zsh                        -> ABSENT
127.0.0.1:18083 (OpenAI listener)       -> UNREACHABLE
127.0.0.1:18001 (status listener)       -> UNREACHABLE

Resume condition: execute on the Darwin/arm64 dev runner rooted at /Users/toki/agent-work/iop-dev, resolving login-shell Go 1.26.3 (GOMOD /Users/toki/agent-work/iop-dev/go.mod), with HEAD d1e32b6e06f7153a4db5a5a08b7026d6dd49fcfb, only the reviewed test-file source delta and SHA-256 8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21, and listeners 18083/18001 reachable.
```

### External Runtime and Isolation Preflight

Record sanitized evidence for:

- deployed Edge and participating Node binary/process/listener/source identities at the reviewed ref;
- active blocking `repeat_guard` for `ornith:35b` and the configured raw-free observation sink;
- healthy idle `onexplayer-lemonade` capacity 3 and `rtx5090-lemonade` capacity 1;
- bounded non-empty prompt, zero competing harness/manual source, an absent or empty `/tmp/iop-repeat-guard-live/repeat-guard-G08-13`, and unchanged observation identity/size through the immediate quiet window.

Expected: every precondition passes before the authorized Go test process starts. A preflight failure stops without consuming the live authorization.

Implementation evidence:

```text
BLOCKED / NOT REACHED — the Darwin/arm64 host precondition failed in the login-shell preflight above, so no deployed runtime exists on this host to evaluate. The following could not be checked here: deployed Edge/Node binary/process/listener/source identities at the reviewed ref; active blocking repeat_guard for ornith:35b and the raw-free observation sink; healthy idle onexplayer-lemonade (capacity 3) and rtx5090-lemonade (capacity 1); bounded non-empty prompt; zero competing harness; absent/empty /tmp/iop-repeat-guard-live/repeat-guard-G08-13; observation quiescence. No live authorization consumed.

Resume condition: after the Darwin/arm64 login-shell preflight passes, prove every deployed runtime/isolation precondition listed above before launch.
```

### Single Authorized Live Lifecycle and Capacity Verification

```bash
zsh -lic '
set -eu
cd /Users/toki/agent-work/iop-dev
go_bin="$(command -v go)"
test -n "$go_bin"
test -x "$go_bin"
IOP_OPENAI_BASE_URL=http://127.0.0.1:18083 \
IOP_OPENAI_MODEL=ornith:35b \
IOP_OPENAI_SMOKE_CONCURRENCY=5 \
IOP_OPENAI_SMOKE_RUNS=3 \
IOP_OPENAI_SMOKE_PROMPT_FILE=/tmp/iop-repeat-guard-live/repeat-prompt.txt \
IOP_OPENAI_SMOKE_ARTIFACT_DIR=/tmp/iop-repeat-guard-live/repeat-guard-G08-13 \
IOP_OPENAI_SMOKE_OBSERVATION_FILE=/tmp/iop-repeat-guard-live/edge-observations.jsonl \
IOP_OPENAI_SMOKE_STATUS_URL=http://127.0.0.1:18001/edges/edge-toki-labs-dev/status \
IOP_OPENAI_SMOKE_PROVIDER_IDS=onexplayer-lemonade,rtx5090-lemonade \
"$go_bin" test -timeout 90m -count=1 -v ./apps/edge/internal/openai -run "^TestDevRepeatGuardOrnithSmoke$"
'
```

Expected: invocation count 1, exit 0, 15 unique provider response IDs, 15 unique Edge correlations, three accepted capacity rows, and sanitized `reproduced` with fingerprint/offset or `not_reproduced`.

Implementation evidence:

```text
BLOCKED / NOT STARTED — invocation count 0. The environment-gated live test TestDevRepeatGuardOrnithSmoke was not launched because the Darwin/arm64 dev-runner preflight failed on this Linux/aarch64 host. No Go test process started, so there are no provider response IDs, no Edge correlations, no capacity rows, and no reproduced/not_reproduced result. The sole live authorization remains unconsumed (a preflight failure consumes none).

Resume condition: on the verified Darwin/arm64 dev runner, after all preflights pass, launch exactly once with the command above and require exit 0, 15 globally unique provider response IDs, 15 globally unique Edge correlations, three accepted capacity rows, and a sanitized reproduced (with fingerprint/offset) or not_reproduced result.
```

### Summary and Cleanup Verification

Expected: `summary.json` proves the required identity/lifecycle/capacity cardinality; both providers are idle, no harness remains, runtime/source identity is unchanged, and all raw artifacts remain outside the repository.

Implementation evidence:

```text
BLOCKED / NOT APPLICABLE — no live run occurred, so no summary.json was produced and no artifact/observation cleanup was required. /tmp/iop-repeat-guard-live/repeat-guard-G08-13 was neither created nor written on this host. Reviewed source/runtime identity is unchanged (HEAD d1e32b6e06f7153a4db5a5a08b7026d6dd49fcfb; test-file SHA-256 8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21). No raw prompt/SSE/output/credential/token entered tracked evidence or stdout.

Resume condition: after the single authorized live run on the dev runner, validate summary.json cardinality (three runs, 15 unique provider response IDs, 15 unique Edge correlations, three accepted capacity rows), prove both providers idle and no harness remains, and confirm all raw artifacts stay outside the repository.
```

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Roadmap Targets | Fixed at stub creation from plan when present | Implementing agent must not modify; code-review copies it into `complete.log` as `Roadmap Completion` only on PASS |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |

## Code Review Result

- Overall Verdict: FAIL
- Dimension Assessment:
  - Correctness: Pass — the reviewed test-only delta retains the expected SHA-256 and the focused deterministic repeat-guard evidence tests pass.
  - Completeness: Fail — `REVIEW_OFR-REPEAT-12-1` remains unchecked and the required Darwin/arm64 live invocation was not started.
  - Test Coverage: Fail — SDD S07 still has no integrated 5-concurrent × 3 provider-pool lifecycle/capacity result.
  - API Contract: Pass — no API or contract source changed in this verification-only loop, and the reviewed local evidence remains consistent with the OpenAI-compatible contract.
  - Code Quality: Pass — `git diff --check` passes and this loop introduced no source change or artifact drift that obscures review.
  - Implementation Deviation: Fail — the plan required one verified dev-runner invocation, but the implementation stopped after the current Linux/aarch64 host failed the external preflight.
  - Verification Trust: Pass — the recorded invocation count of 0, environment blocker, source hash, and focused test result agree with fresh reviewer evidence.
  - Spec Conformance: Fail — SDD S07 requires at least three capacity+1 live runs with sanitized lifecycle, correlation, capacity, and final-result evidence, which is absent.
- Findings:
  - Required — `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/CODE_REVIEW-cloud-G08.md:213`: execute `TestDevRepeatGuardOrnithSmoke` exactly once on the verified Darwin/arm64 runner after all preconditions pass, then record the 15 globally unique provider response IDs, 15 globally unique Edge correlations, three accepted capacity rows, sanitized `reproduced`/`not_reproduced` result, and post-run cleanup evidence. Invocation count 0 cannot satisfy the plan or SDD S07.
- Routing Signals:
  - `review_rework_count=13`
  - `evidence_integrity_failure=false`
- Next Step: Invoke the plan skill in `prepare-follow-up` mode with this raw finding and fresh verification evidence, then archive this pair and materialize the freshly routed follow-up pair.
