<!-- task=m-openai-compatible-output-validation-filters/02+01_repeat_guard plan=16 tag=REVIEW_OFR-REPEAT-15 -->

# Code Review Reference - REVIEW_OFR-REPEAT-15

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-07-29
task=m-openai-compatible-output-validation-filters/02+01_repeat_guard, plan=16, tag=REVIEW_OFR-REPEAT-15

## Roadmap Targets

- Milestone: `agent-roadmap/phase/knowledge-tool-optimization-extension/milestones/openai-compatible-output-validation-filters.md`
- Milestone link: [Milestone document](agent-roadmap/phase/knowledge-tool-optimization-extension/milestones/openai-compatible-output-validation-filters.md)
- Task ids:
  - `repeat-guard`: rolling content/history/action repetition detection and safe continuation
- Completion mode: check-on-pass

## Archive Evidence Snapshot

- Dependency `01_resume_notice_builder` is satisfied by `agent-task/archive/2026/07/m-openai-compatible-output-validation-filters/01_resume_notice_builder/complete.log`.
- The failed pair will be archived as `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/plan_cloud_G08_15.log` and `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/code_review_cloud_G08_15.log`.
- Verdict: FAIL; Required=1, Suggested=0, Nit=0.
- Required finding: `code_review_cloud_G08_15.log` records invocation count 0 and therefore no 15 provider response IDs, 15 Edge correlations, three accepted capacity rows, or sanitized final result.
- Trusted local evidence on 2026-07-29: `git diff --check` exited 0; SHA-256 was `8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21`; the focused repeat-guard evidence test command exited 0.
- Follow-up: execute the existing live oracle exactly once on `/Users/toki/agent-work/iop-dev` after every identity, runtime, capacity, and isolation precondition passes.

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G08.md` → `code_review_cloud_G08_16.log` and `PLAN-cloud-G08.md` → `plan_cloud_G08_16.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-openai-compatible-output-validation-filters/02+01_repeat_guard/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and task group is `m-<milestone-slug>`, report completion event metadata. Roadmap state check and `update-roadmap` calls are runtime responsibilities.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| REVIEW_OFR-REPEAT-15-1 — On the verified Darwin/arm64 dev runner, execute exactly one fresh `ornith:35b` 5-concurrent × 3 live invocation after every precondition passes, then record 15 provider responses, 15 Edge correlations, three accepted capacity rows, the sanitized final result, and cleanup evidence. | [ ] |

## Implementation Checklist

- [ ] [REVIEW_OFR-REPEAT-15-1] On the verified Darwin/arm64 dev runner, execute exactly one fresh `ornith:35b` 5-concurrent × 3 live invocation after every precondition passes, then record 15 provider responses, 15 Edge correlations, three accepted capacity rows, the sanitized final result, and cleanup evidence.
- [x] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [x] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [x] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [x] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G08_16.log`.
- [x] Archive active `PLAN-*-G??.md` to `plan_cloud_G08_16.log`.
- [x] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [ ] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [ ] If PASS, move active task directory `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/` to `agent-task/archive/YYYY/MM/m-openai-compatible-output-validation-filters/02+01_repeat_guard/` and update this checklist at the final archive path.
- [ ] If PASS and task group is `m-<milestone-slug>`, report completion event metadata for runtime, without modifying roadmap or directly calling `update-roadmap`.
- [ ] If PASS for split work, remove empty active parent `agent-task/m-openai-compatible-output-validation-filters/` or verify it was kept due to remaining siblings/files.
- [x] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

- The external S07 live invocation (`REVIEW_OFR-REPEAT-15-1`) was not executed. This follows the plan's stated current-host blocker rather than deviating from its intent: the plan restricts the live run to the Darwin/arm64 runner at `/Users/toki/agent-work/iop-dev` and instructs "Do not start the live command here." This checkout is Linux/aarch64 with no `zsh`, no runner root, and no deployed loopback listeners, so the launch preconditions cannot pass.
- Command substitution for blocker evidence only: the exact `zsh -lic '...'` preflight blocks could not be invoked because `zsh` is absent (`command not found`, exit 127). No command text was changed for anything that ran; instead each preflight guard condition (`uname -s`, `uname -m`, `test -d` runner root, loopback listeners `18083`/`18001`) was evaluated directly in bash purely to record concrete, sanitized proof of the blocker. The exact `zsh -lic` preflight and live commands remain unmodified for the Darwin runner.
- The local integrity commands were run exactly as written and passed.

## Key Design Decisions

- This is a verification-only follow-up. No production source, test, contract, spec, tracked config, or deployed runtime was modified; only this review artifact's implementation-owned evidence fields were filled. The reviewed test-only delta and its SHA-256 are unchanged.
- The single live authorization was preserved: because no `go test` invocation was started, no authorization was consumed, and one fresh run remains available on the Darwin runner. A blocked/failed preflight consumes no authorization, and a started invocation must never be retried.
- No raw/secret-bearing material (prompt, SSE, provider output, credentials, tokens, endpoints) was generated or written to tracked evidence or stdout. The blocker evidence is limited to host identity, absent paths, and closed loopback ports.
- Blocker is recorded, not escalated: per the implementing-agent contract, the exact blocker, attempted commands/output, and resume conditions are recorded in implementation-owned fields only. No user prompt, control-plane stop file, next-state classification, log rename, `complete.log`, or archive move was performed; finalization is left to the review agent.

## Reviewer Checkpoints

- Confirm execution occurred on Darwin/arm64 at `/Users/toki/agent-work/iop-dev`, not in a substitute sandbox.
- Confirm login-shell Go is executable and the same shell invokes that exact binary.
- Confirm HEAD, test-only source delta, reviewed SHA-256, deployed runtime identities, listeners, active blocking gate, selected provider capacity/health, prompt/artifact containment, observation quiescence, and zero competing harnesses before launch.
- Confirm exactly one Go test process starts and exits 0.
- Confirm `summary.json` has three runs, 15 globally unique provider response IDs, 15 globally unique Edge correlations, and three accepted capacity rows with `configured=4`, `peak_in_flight=4`, `peak_queued>=1`, `final_in_flight=0`, and `final_queued=0`.
- Confirm sanitized `reproduced` includes fingerprint/offset or the result is `not_reproduced`; both providers return idle, no harness remains, source/runtime identities are unchanged, and no raw/secret-bearing material entered tracked evidence or stdout.

## Verification Results

Record actual stdout/stderr and exit codes for every command. If blocked, record the exact attempted command, output, and resume condition without asking the user or creating a control-plane stop file.

### Local Integrity Verification

```bash
git diff --check
sha256sum apps/edge/internal/openai/stream_gate_vertical_slice_test.go
go test -count=1 ./apps/edge/internal/openai -run 'TestDevRepeatGuard(SmokeEvidence|ObservationCorrelation|ObservationQuiescence|CapacityEvidence)'
```

Expected: all commands exit 0 and SHA-256 is `8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21`.

Implementation evidence:

PASS. Executed on the current checkout (Linux/aarch64, Go `go1.26.2`, HEAD `d1e32b6e06f7153a4db5a5a08b7026d6dd49fcfb`) on 2026-07-29. All three commands are host-agnostic and completed successfully.

```text
$ git diff --check
EXIT=0

$ sha256sum apps/edge/internal/openai/stream_gate_vertical_slice_test.go
8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21  apps/edge/internal/openai/stream_gate_vertical_slice_test.go
EXIT=0

$ go test -count=1 ./apps/edge/internal/openai -run 'TestDevRepeatGuard(SmokeEvidence|ObservationCorrelation|ObservationQuiescence|CapacityEvidence)'
ok  	iop/apps/edge/internal/openai	0.371s
EXIT=0
```

`-v` confirms all four focused deterministic evidence groups ran fresh (`-count=1`) and passed; no group filtered to zero:

```text
--- PASS: TestDevRepeatGuardSmokeEvidence (0.01s)          [8 subtests PASS]
--- PASS: TestDevRepeatGuardObservationCorrelation (0.00s) [13 subtests PASS]
--- PASS: TestDevRepeatGuardObservationQuiescence (0.00s)  [3 subtests PASS]
--- PASS: TestDevRepeatGuardCapacityEvidence (0.31s)       [13 subtests PASS]
PASS
ok  	iop/apps/edge/internal/openai	0.331s
EXIT=0
```

Result: `git diff --check` exit 0; reviewed SHA-256 matches exactly; focused deterministic evidence exit 0. Local S03/S04/S09-S12 coverage is intact and the reviewed test-only delta is unchanged.

### External Login-Shell and Source Preflight

```bash
zsh -lic '
set -eu
test "$(uname -s)" = "Darwin"
test "$(uname -m)" = "arm64"
cd /Users/toki/agent-work/iop-dev
go_bin="$(command -v go)"
test -n "$go_bin"
test -x "$go_bin"
"$go_bin" version
"$go_bin" env GOMOD
git rev-parse HEAD
git status --short
shasum -a 256 apps/edge/internal/openai/stream_gate_vertical_slice_test.go
'
```

Expected: Go `1.26.3`, GOMOD `/Users/toki/agent-work/iop-dev/go.mod`, reviewed HEAD, only the reviewed test-file delta, and the reviewed hash.

Implementation evidence:

BLOCKED — host mismatch. The current host is Linux/aarch64, not the Darwin/arm64 dev runner this preflight requires. The exact `zsh -lic '...'` block could not be invoked because the login shell it targets (`zsh`) is not installed, and its first two guards (`uname -s = Darwin`, `uname -m = arm64`) fail on this host. To produce concrete blocker evidence without starting anything live, each guard condition was evaluated directly (2026-07-29):

```text
$ command -v zsh; zsh -lic 'true'
zsh: ABSENT (preflight login shell unavailable)
/bin/bash: zsh: command not found
zsh invoke EXIT=127

$ uname -s   -> Linux   (guard requires Darwin -> FAIL)
$ uname -m   -> aarch64 (guard requires arm64  -> FAIL)
$ test -d /Users/toki/agent-work/iop-dev
/Users/toki/agent-work/iop-dev: ABSENT (cd target missing -> FAIL)
```

The reviewed source identity that IS verifiable on this host is unchanged: Go `go1.26.2` (login-shell resolution of `1.26.3` is deferred to the runner), HEAD `d1e32b6e06f7153a4db5a5a08b7026d6dd49fcfb`, and the test-file SHA-256 `8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21` (see Local Integrity Verification).

Resume condition: re-run this exact `zsh -lic` block unchanged on the Darwin/arm64 runner rooted at `/Users/toki/agent-work/iop-dev`, expecting Go `1.26.3`, GOMOD `/Users/toki/agent-work/iop-dev/go.mod`, reviewed HEAD, the reviewed-only test-file delta, and the reviewed hash.

### External Runtime and Isolation Preflight

Record sanitized evidence for deployed Edge/Node identities, listeners `18083`/`18001`, active blocking `repeat_guard`, idle provider capacities 3 and 1, bounded prompt, empty artifact directory `/tmp/iop-repeat-guard-live/repeat-guard-G08-16`, writable raw-free observation sink, zero competing harnesses, and stable observation identity/size through the quiet window.

Implementation evidence:

BLOCKED — no deployed runtime on this host. The deployed Edge/Node runtime, gate, and provider pool this preflight inspects are absent because this is not the Darwin/arm64 dev runner. The required loopback listeners are not present (2026-07-29):

```text
provider base 127.0.0.1:18083 -> CLOSED/absent
Edge status 127.0.0.1:18001   -> CLOSED/absent
```

With both listeners down there is nothing to query for deployed Edge/Node identity, active blocking `repeat_guard`, or idle provider capacities `3` and `1`; those checks cannot even begin. No artifact directory, prompt file, or observation sink was created on this host, since the runtime/isolation preconditions gate that setup and none can pass here. No live harness process was started (see next section).

Resume condition: on the Darwin/arm64 runner, confirm listeners `18083`/`18001` are open, deployed Edge/Node identities match the reviewed binaries, the blocking `repeat_guard` gate is active, both selected providers are idle with capacities `3` and `1`, the prompt is a bounded non-empty file, `/tmp/iop-repeat-guard-live/repeat-guard-G08-16` is empty and new, the observation sink is writable and raw-free, zero competing harnesses run, and the observation file is stable in identity and size through the quiet window — all before launch.

### Single Authorized Live Lifecycle and Capacity Verification

```bash
zsh -lic '
set -eu
cd /Users/toki/agent-work/iop-dev
go_bin="$(command -v go)"
test -n "$go_bin"
test -x "$go_bin"
IOP_OPENAI_BASE_URL=http://127.0.0.1:18083 \
IOP_OPENAI_MODEL=ornith:35b \
IOP_OPENAI_SMOKE_CONCURRENCY=5 \
IOP_OPENAI_SMOKE_RUNS=3 \
IOP_OPENAI_SMOKE_PROMPT_FILE=/tmp/iop-repeat-guard-live/repeat-prompt.txt \
IOP_OPENAI_SMOKE_ARTIFACT_DIR=/tmp/iop-repeat-guard-live/repeat-guard-G08-16 \
IOP_OPENAI_SMOKE_OBSERVATION_FILE=/tmp/iop-repeat-guard-live/edge-observations.jsonl \
IOP_OPENAI_SMOKE_STATUS_URL=http://127.0.0.1:18001/edges/edge-toki-labs-dev/status \
IOP_OPENAI_SMOKE_PROVIDER_IDS=onexplayer-lemonade,rtx5090-lemonade \
"$go_bin" test -timeout 90m -count=1 -v ./apps/edge/internal/openai -run "^TestDevRepeatGuardOrnithSmoke$"
'
```

Expected: invocation count 1, exit 0, 15 globally unique provider response IDs, 15 globally unique Edge correlations, three accepted capacity rows, and sanitized `reproduced` with fingerprint/offset or `not_reproduced`.

Implementation evidence:

NOT STARTED — invocation count 0. The single live authorization was deliberately NOT consumed. The plan and this checkout both forbid launching the live command on this host ("Current-host blocker: Linux/aarch64, no `/Users/toki/agent-work/iop-dev`, no `zsh`, and no deployed loopback listeners. Do not start the live command here."), and both external preflights above are BLOCKED, so the launch precondition ("after every precondition passes") is not met.

- invocation_count = 0
- exit code = n/a (no `go test` process started)
- provider_responses = 0; edge_correlations = 0; capacity_runs = 0
- final result = n/a (no `summary.json` produced)

Because no invocation started, the sole authorization remains available and unconsumed for a single fresh run on the Darwin runner. A failed/blocked preflight consumes no authorization.

Resume condition: only after both preflights pass on the Darwin/arm64 runner, launch the exact `TestDevRepeatGuardOrnithSmoke` command above with `IOP_OPENAI_SMOKE_ARTIFACT_DIR=/tmp/iop-repeat-guard-live/repeat-guard-G08-16` exactly once (no retry once started), then record invocation count 1, exit 0, 15 unique provider response IDs, 15 unique Edge correlations, three accepted capacity rows, and the sanitized `reproduced`/`not_reproduced` result. Fresh execution is required; Go test cache output is not acceptable.

### Summary and Cleanup Verification

Expected: `summary.json` proves all identity/lifecycle/capacity cardinality; both providers are idle, no harness remains, runtime/source identity is unchanged, and all raw artifacts remain outside the repository.

Implementation evidence:

N/A — no live invocation ran, so no `summary.json` exists to validate and there is no post-run provider/harness state to clean up. No raw prompt, SSE, provider output, credentials, tokens, or endpoint material was generated on this host, and none entered the repository or stdout. Source/runtime identity that is verifiable here is unchanged (HEAD `d1e32b6e06f7153a4db5a5a08b7026d6dd49fcfb`; test-file SHA-256 `8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21`; `git diff --check` exit 0).

Resume condition: after the single authorized run on the Darwin runner, validate `summary.json` for three runs, 15 globally unique provider response IDs, 15 globally unique Edge correlations, and three accepted capacity rows (`configured=4`, `peak_in_flight=4`, `peak_queued>=1`, `final_in_flight=0`, `final_queued=0`); confirm both providers return idle, no harness process remains, runtime/source identities are unchanged, and all raw artifacts stay under `/tmp/iop-repeat-guard-live/` outside the repository.

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Roadmap Targets | Fixed at stub creation from plan when present | Implementing agent must not modify; code-review copies it into `complete.log` as `Roadmap Completion` only on PASS |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |

## Code Review Result

- Overall Verdict: FAIL
- Dimension Assessment:
  - Correctness: Pass — the reviewed test-only delta retains the expected SHA-256, the focused repeat-guard evidence tests pass, and the full local Stream Gate/OpenAI package profile passes.
  - Completeness: Fail — `REVIEW_OFR-REPEAT-15-1` remains unchecked and the required Darwin/arm64 live invocation was not started.
  - Test Coverage: Fail — SDD S07 still has no integrated 5-concurrent × 3 provider-pool lifecycle/capacity result.
  - API Contract: Pass — no API or contract source changed in this verification-only loop, and the reviewed local evidence remains consistent with the OpenAI-compatible contract.
  - Code Quality: Pass — `git diff --check` passes and this loop introduced no source change or artifact drift that obscures review.
  - Implementation Deviation: Fail — the plan required one verified dev-runner invocation, but implementation stopped after the current Linux/aarch64 host failed the external preflight.
  - Verification Trust: Pass — the recorded invocation count of 0, environment blocker, source hash, and focused test result agree with fresh reviewer evidence.
  - Spec Conformance: Fail — SDD S07 requires at least three capacity+1 live runs with sanitized lifecycle, correlation, capacity, and final-result evidence, which is absent.
- Findings:
  - Required — `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/CODE_REVIEW-cloud-G08.md:229`: execute `TestDevRepeatGuardOrnithSmoke` exactly once on the verified Darwin/arm64 runner after all preconditions pass, then record the 15 globally unique provider response IDs, 15 globally unique Edge correlations, three accepted capacity rows, sanitized `reproduced`/`not_reproduced` result, and post-run cleanup evidence. Invocation count 0 cannot satisfy the plan or SDD S07.
- Routing Signals:
  - `review_rework_count=16`
  - `evidence_integrity_failure=false`
- Next Step: Invoke the plan skill in `prepare-follow-up` mode with this raw finding and fresh verification evidence, then archive this pair and materialize the freshly routed follow-up pair.
