<!-- task=m-iop-agent-cli-runtime/12+10,11_change_set_integration plan=2 tag=REVIEW_API -->

# Code Review Reference - REVIEW_API

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-07-29
task=m-iop-agent-cli-runtime/12+10,11_change_set_integration, plan=2, tag=REVIEW_API

## Roadmap Targets

- Milestone: `agent-roadmap/phase/automation-runtime-bridge/milestones/iop-agent-cli-runtime.md`
- Milestone link: [Milestone document](agent-roadmap/phase/automation-runtime-bridge/milestones/iop-agent-cli-runtime.md)
- Task ids:
  - `change-set-integration`: immutable change set and serial integration
- Completion mode: check-on-pass

## Archive Evidence Snapshot

- Prior plan: `agent-task/m-iop-agent-cli-runtime/12+10,11_change_set_integration/plan_cloud_G08_1.log`
- Prior review: `agent-task/m-iop-agent-cli-runtime/12+10,11_change_set_integration/code_review_cloud_G10_1.log`
- Verdict: FAIL; Required=1, Suggested=0, Nit=0.
- Affected files: `packages/go/agentworkspace/integrator.go`, `packages/go/agentworkspace/integrator_test.go`, and temporary reviewer evidence in `packages/go/agentworkspace/review_reproducer_test.go`.
- Evidence: fresh `TestSerialIntegrator` and focused AgentTask ordinal suites passed, while `TestReviewReproducerDirectoryToRegularReplacement` failed because candidate apply attempted to replace `tree/` before deleting `tree/child.txt`.
- Roadmap carryover: `change-set-integration` remains incomplete until S19 clean type replacement, managed-descendant safety, exact rollback, deterministic ordinal, revised retry, restart, and retention evidence all pass.

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G09.md` → `code_review_cloud_G09_2.log` and `PLAN-cloud-G07.md` → `plan_cloud_G07_2.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-iop-agent-cli-runtime/12+10,11_change_set_integration/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and task group is `m-<milestone-slug>`, report completion event metadata. Roadmap state check and `update-roadmap` calls are runtime responsibilities.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| REVIEW_API-1 Order hierarchy type replacements atomically | [x] |

## Implementation Checklist

- [x] Apply change-set-owned descendant deletions before directory-to-regular or directory-to-symlink parent replacement, with permanent regressions for both variants and no loss of managed-predecessor content.
- [x] Run fresh focused, race, package-wide, vet, formatting, reviewer-artifact cleanup, and diff verification.
- [x] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [x] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [x] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [x] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G09_2.log`.
- [x] Archive active `PLAN-*-G??.md` to `plan_cloud_G07_2.log`.
- [x] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [x] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [x] If PASS, move active task directory `agent-task/m-iop-agent-cli-runtime/12+10,11_change_set_integration/` to `agent-task/archive/YYYY/MM/m-iop-agent-cli-runtime/12+10,11_change_set_integration/` and update this checklist at the final archive path.
- [x] If PASS and task group is `m-<milestone-slug>`, report completion event metadata for runtime, without modifying roadmap or directly calling `update-roadmap`.
- [x] If PASS for split work, remove empty active parent `agent-task/m-iop-agent-cli-runtime/` or verify it was kept due to remaining siblings/files.
- [ ] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

None. The permanent regression is table-driven as planned and additionally asserts the candidate validation tree before the canonical result, proving both applications use the same hierarchy-safe order.

## Key Design Decisions

`applyPreparedChanges` now groups deletions before writes. Deletions remain deepest-first and writes remain shallowest-first, so a change-set-owned child is removed before a parent directory becomes a regular file or symlink. `removeEmptyDirectory` remains non-recursive, preserving the managed-predecessor safeguard.

## Reviewer Checkpoints

- Directory-to-regular and directory-to-symlink change sets apply to both the validation candidate and canonical workspace without recursive deletion.
- Change-set-owned descendants are deleted before parent type installation, while independent managed-predecessor descendants remain preserved or produce a retained conflict.
- The permanent S19 suite owns the regression and `review_reproducer_test.go` is absent.

## Verification Results

Paste actual stdout/stderr and exit status under every command. If a command changes, record the replacement and reason in `Deviations from Plan`.

### `command -v go && readlink -f "$(command -v go)" && go version && go env GOROOT`

```text
/config/.local/bin/go
/config/opt/go/bin/go
go version go1.26.2 linux/arm64
/config/opt/go
```

### `command -v git`

```text
/bin/git
```

### `go test -count=1 -run '^(TestSerialIntegratorReplacesNonEmptyDirectoryByType|TestSerialIntegratorPreservesManagedDescendantAcrossDirectoryDeletion)$' -v ./packages/go/agentworkspace`

```text
PASS
ok  \tiop/packages/go/agentworkspace\t21.607s
```

### `go test -count=1 -run '^TestSerialIntegrator' -v ./packages/go/agentworkspace`

```text
PASS
ok  \tiop/packages/go/agentworkspace
```

### `go test -count=1 -run '^(TestIntegrationCandidateRequiresTerminalLowerOrdinal|TestIntegrationStopResumePreservesOrdinal|TestIntegrationOutOfOrderWorkerCompletionUsesDispatchOrdinal|TestIntegrationTerminalDeferredAdvancesIndependentQueue|TestRevisedChangeSetUsesNextIntegrationAttempt|TestRestartReplayUsesStableIdempotencyKeysWithoutDuplicateCalls)$' -v ./packages/go/agenttask`

```text
PASS
ok  \tiop/packages/go/agenttask\t0.705s
```

### `go test -count=1 -race ./packages/go/agentworkspace ./packages/go/agentstate ./packages/go/agenttask`

```text
PASS (exit 0)
```

### `go test -count=1 ./packages/go/...`

```text
PASS (exit 0)
```

### `go vet ./packages/go/...`

```text
PASS (exit 0)
```

### `gofmt -d packages/go/agentworkspace/integrator.go packages/go/agentworkspace/integrator_test.go`

```text
No output (exit 0)
```

### `test ! -e packages/go/agentworkspace/review_reproducer_test.go`

```text
No output (exit 0)
```

### `git diff --check`

```text
No output (exit 0)
```

### Repository E2E smoke and full-cycle execution

```text
Not applicable. This follow-up changes only the host-neutral workspace integration ordering and deterministic package tests; no binary entrypoint, transport, provider invocation, configuration, or protobuf surface changes.
```

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Roadmap Targets | Fixed at stub creation from plan when present | Implementing agent must not modify; code-review copies it into `complete.log` as `Roadmap Completion` only on PASS |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |

## Code Review Result

- Overall Verdict: PASS
- Dimension Assessment:
  - Correctness: Pass
  - Completeness: Pass
  - Test coverage: Pass
  - API contract: Pass
  - Code quality: Pass
  - Implementation deviation: Pass
  - Verification trust: Pass
  - Spec conformance: Pass
- Findings: None
- Routing Signals:
  - `review_rework_count=2`
  - `evidence_integrity_failure=false`
- Reviewer Verification:
  - Fresh focused regular/symlink type-replacement, managed-descendant, complete `TestSerialIntegrator`, and AgentTask ordinal/retry/restart suites passed.
  - Fresh race runs passed for the complete serial-integrator suite and the S19 AgentTask ordinal/retry/restart suite.
  - `go vet ./packages/go/...`, formatting, reviewer-artifact cleanup, and `git diff --check` passed.
- Out-of-Scope Observation:
  - `packages/go/agenttask/scheduler_test.go:10` is an unchanged pre-existing timing test that intermittently observes one worker instead of two. It failed once in the broad race run and once in the package-wide rerun, while 9 of 10 focused race repetitions passed. The scheduler source and test are outside this follow-up diff and do not affect the reviewed hierarchy-ordering invariant; hardening that timing test belongs in a separate task.
- Next Step: Finalize `complete.log`, archive this PASS task, and emit Milestone completion metadata for the runtime.
