<!-- task=m-principal-provider-credential-slot-routing/07+01,02,05_secret_material plan=0 tag=API -->

# Code Review Reference - API

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-08-01
task=m-principal-provider-credential-slot-routing/07+01,02,05_secret_material, plan=0, tag=API

## Roadmap Targets

- Milestone: `agent-roadmap/phase/operational-observability-provider-management/milestones/principal-provider-credential-slot-routing.md`
- Milestone link: [Milestone 문서](agent-roadmap/phase/operational-observability-provider-management/milestones/principal-provider-credential-slot-routing.md)
- Task ids:
  - `secret-at-rest`: provider raw token envelope encryption과 외부 key source
- Completion mode: check-on-pass

## Archive Evidence Snapshot

- `agent-task/archive/2026/08/m-principal-provider-credential-slot-routing/01_principal_store/complete.log`: principal/token durable ledger와 restart persistence PASS.
- `agent-task/archive/2026/08/m-principal-provider-credential-slot-routing/02+01_credential_catalog/complete.log`: slot/revision/envelope metadata와 lifecycle PASS; concrete key source는 후속 범위로 남았다.
- `agent-task/archive/2026/08/m-principal-provider-credential-slot-routing/05+01,02_management_core/complete.log`: principal-scoped management core, zeroization과 secret-blind failure surface PASS; production sealer/wire는 없었다.
- 위 세 파일의 Required finding은 없었고, 이 계획은 해당 저장·서비스 계약을 확장하되 archive를 다시 탐색하지 않는다.

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G09.md` → `code_review_cloud_G09_0.log` and `PLAN-cloud-G08.md` → `plan_cloud_G08_0.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-principal-provider-credential-slot-routing/07+01,02,05_secret_material/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and task group is `m-principal-provider-credential-slot-routing`, report completion event metadata. Roadmap state check and `update-roadmap` calls are runtime responsibilities.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| API-1 Versioned authenticated keyring | [ ] |
| API-2 Slot-bound sealing and durable inspection | [ ] |
| API-3 Production startup injection | [ ] |

## Implementation Checklist

- [ ] Implement a versioned AES-256-GCM keyring with canonical principal/slot/kind AAD, external key-file loading, decrypt support, and plaintext cleanup.
- [ ] Allocate the stable slot id before sealing, persist only authenticated envelope fields, and preserve create/rotate CAS and failure-no-mutation behavior.
- [ ] Wire the keyring into Control Plane config/startup and host-local credential commands without logging key paths, values, plaintext, or ciphertext.
- [ ] Add fresh encryption, tamper, key-version, restart, database-inspection, and secret-scan verification.
- [ ] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [ ] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [ ] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [ ] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G09_0.log`.
- [ ] Archive active `PLAN-*-G??.md` to `plan_cloud_G08_0.log`.
- [ ] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [ ] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [ ] If PASS, move active task directory `agent-task/m-principal-provider-credential-slot-routing/07+01,02,05_secret_material/` to `agent-task/archive/YYYY/MM/m-principal-provider-credential-slot-routing/07+01,02,05_secret_material/` and update this checklist at the final archive path.
- [ ] If PASS and task group is `m-principal-provider-credential-slot-routing`, report completion event metadata for runtime, without modifying roadmap or directly calling `update-roadmap`.
- [ ] If PASS for split work, remove empty active parent `agent-task/m-principal-provider-credential-slot-routing/` or verify it was kept due to remaining siblings/files.
- [ ] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

_Record any deviations from the plan and the rationale here._

## Key Design Decisions

_Record key design decisions here._

## Reviewer Checkpoints

- Confirm key material enters only from the external file, never tracked YAML/DB/log/error.
- Confirm create-time AAD contains the final stable slot id and rotation uses the same principal/slot/kind.
- Confirm AES-GCM nonce uniqueness, tamper rejection, exact key-version lookup and restart decrypt.
- Confirm seal/config failures do not create or advance slot rows and plaintext buffers are cleaned.
- Confirm DB inspection and final scan evidence contain no raw test/provider secret.

## Verification Results

Paste actual stdout/stderr below each command. Do not summarize or reconstruct it. A replacement command requires a matching `Deviations from Plan` entry.

### API-1

```bash
go test -count=1 ./apps/control-plane/internal/credentialseal ./apps/control-plane/internal/credentialstore
```

_Actual output:_

### API-2

```bash
go test -count=1 ./apps/control-plane/internal/credentialstore ./apps/control-plane/internal/credentialops
```

_Actual output:_

### API-3

```bash
go test -count=1 ./apps/control-plane/cmd/control-plane
```

_Actual output:_

### Final Verification

```bash
command -v go && go version && go env GOROOT
git status --short --branch
go test -count=1 ./apps/control-plane/internal/credentialseal ./apps/control-plane/internal/credentialstore ./apps/control-plane/internal/credentialops
go test -count=1 ./apps/control-plane/cmd/control-plane
go vet ./apps/control-plane/...
rg --sort path -n --hidden --glob '!agent-task/archive/**' --glob '!*.sops.yaml' --glob '!PLAN-*.md' --glob '!CODE_REVIEW-*.md' 'BEGIN AGE PRIVATE KEY|active_key_value[[:space:]]*:[[:space:]]*[^<$]' apps/control-plane configs agent-task/m-principal-provider-credential-slot-routing/07+01,02,05_secret_material
```

_Actual output:_

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Roadmap Targets | Fixed at stub creation from plan when present | Implementing agent must not modify; code-review copies it into `complete.log` as `Roadmap Completion` only on PASS |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |
