<!-- task=m-iop-owned-single-request-agent-execution/14+05,12,13_observation_timing plan=5 tag=REVIEW_API milestone-task=cleanup-observation -->

# Code Review Reference - REVIEW_API

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> Execute the plan's selected root cause, scope, files, and dependency decisions as written. Do not choose another owner, narrow/expand the write boundary, or replace a fix with another verification attempt.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-08-07
task=m-iop-owned-single-request-agent-execution/14+05,12,13_observation_timing, plan=5, tag=REVIEW_API

## Archive Evidence Snapshot

- Closed pair: `agent-task/m-iop-owned-single-request-agent-execution/14+05,12,13_observation_timing/plan_cloud_G07_4.log` and `agent-task/m-iop-owned-single-request-agent-execution/14+05,12,13_observation_timing/code_review_cloud_G07_4.log`.
- Verdict: FAIL with Required R7, zero Suggested findings, and zero Nit findings.
- Affected behavior: stage-deadline ownership when tool admission races the stage timer callback.
- Fresh reviewer verification: packet 05/12/13 checks passed; the focused observation race passed in 1.239s; the service package passed in 6.411s; vet and `git diff --check` passed. A temporary mutex-ordering lifecycle reproducer was removed after failing in 0.08s with `terminal error class="internal_tool_budget", want timeout`.
- Roadmap carryover: `milestone-task=cleanup-observation`; approved SDD scenario S07 requires linked raw-free timing and outcome evidence.

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G06.md` → `code_review_cloud_G06_5.log` and `PLAN-cloud-G06.md` → `plan_cloud_G06_5.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-iop-owned-single-request-agent-execution/14+05,12,13_observation_timing/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and task group is `m-<milestone-slug>`, preserve the first-line `milestone-task` metadata in `complete.log` and report it for the runtime aggregation event. Roadmap state evaluation belongs to `sync-milestone-workstate`.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| REVIEW_API-1 Preserve deadline ownership at tool admission | [x] |

## Implementation Checklist

- [x] Preserve `ErrSingleRequestInternalToolBudget` for callers while classifying an elapsed stage deadline at tool admission as `timeout`; retain `internal_tool_budget` for iteration and output exhaustion.
- [x] Add a deterministic mutex-ordering lifecycle regression that queues tool admission before releasing the coordinator lock after the stage deadline, and retain the existing non-time budget control.
- [x] Run dependency, focused race, package, vet, and whitespace verification with cache bypass where supported.
- [x] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [x] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [x] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [x] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G06_5.log`.
- [x] Archive active `PLAN-*-G??.md` to `plan_cloud_G06_5.log`.
- [x] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [x] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [x] If PASS, move active task directory `agent-task/m-iop-owned-single-request-agent-execution/14+05,12,13_observation_timing/` to `agent-task/archive/YYYY/MM/m-iop-owned-single-request-agent-execution/14+05,12,13_observation_timing/` and update this checklist at the final archive path.
- [x] If PASS and task group is `m-<milestone-slug>`, preserve and report `milestone-task` metadata for runtime aggregation, without modifying roadmap or directly calling `update-roadmap`.
- [x] If PASS for split work, remove empty active parent `agent-task/m-iop-owned-single-request-agent-execution/` or verify it was kept due to remaining siblings/files.
- [ ] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

None.

## Key Design Decisions

- Separated elapsed-deadline classification from resource admission budget limits in `prepareInternalWorkspaceToolLocked` (`apps/edge/internal/service/single_request_tool_loop.go`).
- Explicitly returned `singleRequestErrorClassTimeout` alongside `ErrSingleRequestInternalToolBudget` for tool admission requests where the stage deadline has elapsed, while returning empty error class for resource budget (iteration/output) limits.
- Updated `SubmitEnvelope` in `apps/edge/internal/service/single_request.go` to pass the explicit `errorClass` from `prepareInternalWorkspaceToolLocked` to `failLockedWithErrorClass(err, errorClass)`.
- Extended `TestSingleRequestObservationDeadlineClassifications` in `apps/edge/internal/service/single_request_observation_test.go` with a deterministic mutex-ordering regression (`expired stage deadline at tool admission is observed as timeout`) using `admissionRaceExecutor` implementing `SingleRequestToolContinuation`.

## Reviewer Checkpoints

- Confirm an elapsed stage deadline returned by tool admission preserves the caller-visible budget sentinel but reaches `failLockedWithErrorClass` as `timeout`.
- Confirm iteration and output exhaustion still reach the unqualified budget classifier and remain `internal_tool_budget`.
- Confirm the mutex-ordering regression proves admission can win ahead of the delayed timer callback without a data race or flaky sleep-only owner assumption.
- Confirm no API, wire, config, adapter, observation sink, living-spec, or external-smoke scope was added.

## Verification Results

Paste actual stdout/stderr for every command; record replacements under deviations.

### 1. Packet 05 dependency

`test -f agent-task/m-iop-owned-single-request-agent-execution/05+03_single_ingress/complete.log || test "$(compgen -G 'agent-task/archive/*/*/m-iop-owned-single-request-agent-execution/05+03_single_ingress/complete.log' | wc -l)" -eq 1`

```text
(exit code 0)
```

### 2. Packet 12 dependency

`test -f agent-task/m-iop-owned-single-request-agent-execution/12+05,06,08,11_internal_tool_loop/complete.log || test "$(compgen -G 'agent-task/archive/*/*/m-iop-owned-single-request-agent-execution/12+05,06,08,11_internal_tool_loop/complete.log' | wc -l)" -eq 1`

```text
(exit code 0)
```

### 3. Packet 13 dependency

`test -f agent-task/m-iop-owned-single-request-agent-execution/13+12_workspace_cleanup/complete.log || test "$(compgen -G 'agent-task/archive/*/*/m-iop-owned-single-request-agent-execution/13+12_workspace_cleanup/complete.log' | wc -l)" -eq 1`

```text
(exit code 0)
```

### 4. Focused deadline race

`go test -race ./apps/edge/internal/service -run '^TestSingleRequestObservationDeadlineClassifications$' -count=1`

```text
ok  	iop/apps/edge/internal/service	1.248s
```

### 5. Package regression

`go test ./apps/edge/internal/service -count=1`

```text
ok  	iop/apps/edge/internal/service	6.428s
```

### 6. Vet

`go vet ./apps/edge/internal/service`

```text
(exit code 0)
```

### 7. Whitespace

`git diff --check`

```text
(exit code 0)
```

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |

## Code Review Result

- Overall Verdict: PASS
- Dimension Assessment:
  - Correctness: Pass
  - Completeness: Pass
  - Test Coverage: Pass
  - API Contract: Pass
  - Code Quality: Pass
  - Implementation Deviation: Pass
  - Verification Trust: Pass
  - Spec Conformance: Pass
- Findings: None.
- Routing Signals:
  - `review_rework_count=4`
  - `evidence_integrity_failure=false`
- Next Step: Archive the active pair, write `complete.log`, move the task to the monthly archive, and report the milestone completion event metadata.
