<!-- task=m-openai-compatible-output-validation-filters/02+01_repeat_guard plan=14 tag=REVIEW_OFR-REPEAT-13 -->

# Code Review Reference - REVIEW_OFR-REPEAT-13

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-07-29
task=m-openai-compatible-output-validation-filters/02+01_repeat_guard, plan=14, tag=REVIEW_OFR-REPEAT-13

## Roadmap Targets

- Milestone: `agent-roadmap/phase/knowledge-tool-optimization-extension/milestones/openai-compatible-output-validation-filters.md`
- Milestone link: [Milestone document](agent-roadmap/phase/knowledge-tool-optimization-extension/milestones/openai-compatible-output-validation-filters.md)
- Task ids:
  - `repeat-guard`: rolling content/history/action repetition detection and safe continuation
- Completion mode: check-on-pass

## Archive Evidence Snapshot

- Dependency `01_resume_notice_builder` is satisfied by `agent-task/archive/2026/07/m-openai-compatible-output-validation-filters/01_resume_notice_builder/complete.log`.
- The failed pair will be archived as `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/plan_cloud_G08_13.log` and `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/code_review_cloud_G08_13.log`.
- Verdict: FAIL; Required=1, Suggested=0, Nit=0.
- Required finding: `code_review_cloud_G08_13.log` records invocation count 0 and therefore no 15 provider response IDs, 15 Edge correlations, three accepted capacity rows, or sanitized final result.
- Trusted local evidence on 2026-07-29: `git diff --check` exited 0; SHA-256 was `8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21`; the focused repeat-guard evidence test command exited 0.
- Follow-up: execute the existing live oracle exactly once on `/Users/toki/agent-work/iop-dev` after every identity, runtime, capacity, and isolation precondition passes.

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G08.md` → `code_review_cloud_G08_14.log` and `PLAN-cloud-G08.md` → `plan_cloud_G08_14.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-openai-compatible-output-validation-filters/02+01_repeat_guard/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and task group is `m-<milestone-slug>`, report completion event metadata. Roadmap state check and `update-roadmap` calls are runtime responsibilities.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| REVIEW_OFR-REPEAT-13-1 — On the verified Darwin/arm64 dev runner, execute exactly one fresh `ornith:35b` 5-concurrent × 3 live invocation after every precondition passes, then record 15 provider responses, 15 Edge correlations, three accepted capacity rows, the sanitized final result, and cleanup evidence. | [ ] |

## Implementation Checklist

- [ ] [REVIEW_OFR-REPEAT-13-1] On the verified Darwin/arm64 dev runner, execute exactly one fresh `ornith:35b` 5-concurrent × 3 live invocation after every precondition passes, then record 15 provider responses, 15 Edge correlations, three accepted capacity rows, the sanitized final result, and cleanup evidence.
- [x] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [x] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [x] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [x] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G08_14.log`.
- [x] Archive active `PLAN-*-G??.md` to `plan_cloud_G08_14.log`.
- [x] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [ ] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [ ] If PASS, move active task directory `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/` to `agent-task/archive/YYYY/MM/m-openai-compatible-output-validation-filters/02+01_repeat_guard/` and update this checklist at the final archive path.
- [ ] If PASS and task group is `m-<milestone-slug>`, report completion event metadata for runtime, without modifying roadmap or directly calling `update-roadmap`.
- [ ] If PASS for split work, remove empty active parent `agent-task/m-openai-compatible-output-validation-filters/` or verify it was kept due to remaining siblings/files.
- [x] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

- No command deviations. Every command in the `Verification Results` section was run verbatim, or, for the Darwin-only external steps, was recorded as blocked without alteration.
- The single authorized S07 live invocation was intentionally not started. The PLAN's External Verification Preflight requires Darwin/arm64 at `/Users/toki/agent-work/iop-dev`; this implementation host is Linux/aarch64 and matches the PLAN's documented "Current-host blocker". Per the PLAN, the live command must not be started here, so the sole authorization was preserved (not consumed).
- No source, test, production, contract, spec, tracked config, or deployed-runtime files were modified. Only this active review artifact was edited.

## Key Design Decisions

- Treat the Linux/aarch64 checkout as a blocked-preflight host rather than a substitute runner. A failed preflight consumes no authorization, so the S07 live oracle can still be executed once on the verified Darwin runner during review follow-up.
- Record the exact current-host blocker and reproducible resume conditions in the implementation-owned evidence fields only; do not classify the next state, create stop files, or finalize.
- Confirmed the reviewed identity locally: HEAD `d1e32b6e06f7153a4db5a5a08b7026d6dd49fcfb` matches the reviewed HEAD, `git diff --check` is clean, and the test-file SHA-256 matches, so the environment-gated harness remains the untouched S07 oracle.

## Reviewer Checkpoints

- Confirm execution occurred on Darwin/arm64 at `/Users/toki/agent-work/iop-dev`, not in a substitute sandbox.
- Confirm login-shell Go is executable and the same shell invokes that exact binary.
- Confirm HEAD, test-only source delta, reviewed SHA-256, deployed runtime identities, listeners, active blocking gate, selected provider capacity/health, prompt/artifact containment, observation quiescence, and zero competing harnesses before launch.
- Confirm exactly one Go test process starts and exits 0.
- Confirm `summary.json` has three runs, 15 globally unique provider response IDs, 15 globally unique Edge correlations, and three accepted capacity rows with `configured=4`, `peak_in_flight=4`, `peak_queued>=1`, `final_in_flight=0`, and `final_queued=0`.
- Confirm sanitized `reproduced` includes fingerprint/offset or the result is `not_reproduced`; both providers return idle, no harness remains, source/runtime identities are unchanged, and no raw/secret-bearing material entered tracked evidence or stdout.

## Verification Results

Record actual stdout/stderr and exit codes for every command. If blocked, record the exact attempted command, output, and resume condition without asking the user or creating a control-plane stop file.

### Local Integrity Verification

```bash
git diff --check
sha256sum apps/edge/internal/openai/stream_gate_vertical_slice_test.go
go test -count=1 ./apps/edge/internal/openai -run 'TestDevRepeatGuard(SmokeEvidence|ObservationCorrelation|ObservationQuiescence|CapacityEvidence)'
```

Expected: all commands exit 0 and SHA-256 is `8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21`.

Implementation evidence:

Run on 2026-07-29, host Linux/aarch64, HEAD `d1e32b6e06f7153a4db5a5a08b7026d6dd49fcfb`, Go `go1.26.2 linux/arm64`.

```text
$ git diff --check
exit=0

$ sha256sum apps/edge/internal/openai/stream_gate_vertical_slice_test.go
8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21  apps/edge/internal/openai/stream_gate_vertical_slice_test.go
exit=0

$ go test -count=1 ./apps/edge/internal/openai -run 'TestDevRepeatGuard(SmokeEvidence|ObservationCorrelation|ObservationQuiescence|CapacityEvidence)'
ok  	iop/apps/edge/internal/openai	0.328s
exit=0
```

Result: PASS. All three commands exited 0 and the SHA-256 matches the reviewed `8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21`. The reviewed test-only delta and deterministic S03/S04/S09-S12 evidence groups are intact.

### External Login-Shell and Source Preflight

```bash
zsh -lic '
set -eu
test "$(uname -s)" = "Darwin"
test "$(uname -m)" = "arm64"
cd /Users/toki/agent-work/iop-dev
go_bin="$(command -v go)"
test -n "$go_bin"
test -x "$go_bin"
"$go_bin" version
"$go_bin" env GOMOD
git rev-parse HEAD
git status --short
shasum -a 256 apps/edge/internal/openai/stream_gate_vertical_slice_test.go
'
```

Expected: Go `1.26.3`, GOMOD `/Users/toki/agent-work/iop-dev/go.mod`, reviewed HEAD, only the reviewed test-file delta, and the reviewed hash.

Implementation evidence:

BLOCKED — the external login-shell preflight cannot run on this implementation host. The `zsh -lic '...'` wrapper is unavailable and the reviewer's Darwin identity checks fail at the first assertions. Captured current-host facts (2026-07-29):

```text
$ uname -s
Linux                       # preflight requires Darwin
$ uname -m
aarch64                     # preflight requires arm64
$ command -v zsh
(no output); zsh_exit=1      # no login shell to invoke `zsh -lic`
$ ls -d /Users/toki/agent-work/iop-dev
ls: cannot access '/Users/toki/agent-work/iop-dev': No such file or directory   # path_exit=2
$ go version
go version go1.26.2 linux/arm64   # runner requires login-shell Go 1.26.3
$ git rev-parse HEAD
d1e32b6e06f7153a4db5a5a08b7026d6dd49fcfb   # matches reviewed HEAD
$ go env GOMOD
/config/workspace/iop-s1/go.mod   # preflight requires /Users/toki/agent-work/iop-dev/go.mod
```

Resume condition: re-run this exact preflight from a `zsh -lic` login shell on the Darwin/arm64 dev runner rooted at `/Users/toki/agent-work/iop-dev`, expecting Go `1.26.3`, GOMOD `/Users/toki/agent-work/iop-dev/go.mod`, HEAD `d1e32b6e06f7153a4db5a5a08b7026d6dd49fcfb`, only the reviewed test-file delta, and SHA-256 `8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21`. A failed preflight consumes no authorization.

### External Runtime and Isolation Preflight

Record sanitized evidence for deployed Edge/Node identities, listeners `18083`/`18001`, active blocking `repeat_guard`, idle provider capacities 3 and 1, bounded prompt, empty artifact directory `/tmp/iop-repeat-guard-live/repeat-guard-G08-14`, writable raw-free observation sink, zero competing harnesses, and stable observation identity/size through the quiet window.

Implementation evidence:

BLOCKED — no deployed runtime exists on this implementation host, so none of the runtime/isolation preconditions can be observed. The login-shell/source preflight above already fails, which gates this step. Captured current-host facts (2026-07-29):

```text
$ { ss -ltn || netstat -ltn; } | grep -E '18083|18001'
no matching listeners        # Edge (18083) and Node status (18001) loopback listeners absent
```

Not observable here: deployed Edge/Node identities, the active blocking `repeat_guard` gate, provider health/capacities 3 and 1, the bounded prompt file, the empty artifact directory `/tmp/iop-repeat-guard-live/repeat-guard-G08-14`, a raw-free observation sink, competing-harness count, and observation quiescence.

Resume condition: on the Darwin/arm64 dev runner, confirm listeners `127.0.0.1:18083` and `127.0.0.1:18001`, an active blocking `repeat_guard`, both providers healthy/idle with capacities 3 and 1, a bounded non-empty prompt at `/tmp/iop-repeat-guard-live/repeat-prompt.txt`, a newly created empty artifact directory `/tmp/iop-repeat-guard-live/repeat-guard-G08-14`, a writable raw-free `/tmp/iop-repeat-guard-live/edge-observations.jsonl`, zero competing harnesses, and a stable observation identity/size through the quiet window before launch.

### Single Authorized Live Lifecycle and Capacity Verification

```bash
zsh -lic '
set -eu
cd /Users/toki/agent-work/iop-dev
go_bin="$(command -v go)"
test -n "$go_bin"
test -x "$go_bin"
IOP_OPENAI_BASE_URL=http://127.0.0.1:18083 \
IOP_OPENAI_MODEL=ornith:35b \
IOP_OPENAI_SMOKE_CONCURRENCY=5 \
IOP_OPENAI_SMOKE_RUNS=3 \
IOP_OPENAI_SMOKE_PROMPT_FILE=/tmp/iop-repeat-guard-live/repeat-prompt.txt \
IOP_OPENAI_SMOKE_ARTIFACT_DIR=/tmp/iop-repeat-guard-live/repeat-guard-G08-14 \
IOP_OPENAI_SMOKE_OBSERVATION_FILE=/tmp/iop-repeat-guard-live/edge-observations.jsonl \
IOP_OPENAI_SMOKE_STATUS_URL=http://127.0.0.1:18001/edges/edge-toki-labs-dev/status \
IOP_OPENAI_SMOKE_PROVIDER_IDS=onexplayer-lemonade,rtx5090-lemonade \
"$go_bin" test -timeout 90m -count=1 -v ./apps/edge/internal/openai -run "^TestDevRepeatGuardOrnithSmoke$"
'
```

Expected: invocation count 1, exit 0, 15 globally unique provider response IDs, 15 globally unique Edge correlations, three accepted capacity rows, and sanitized `reproduced` with fingerprint/offset or `not_reproduced`.

Implementation evidence:

BLOCKED — NOT STARTED; invocation count 0. This host is Linux/aarch64 and fails the mandatory Darwin/arm64 preflights above, so per the PLAN the live command must not be started here. The single S07 authorization was intentionally preserved (not consumed). No `TestDevRepeatGuardOrnithSmoke` process was launched on this host.

Resume condition: after both external preflights pass on the Darwin/arm64 dev runner, launch `^TestDevRepeatGuardOrnithSmoke$` exactly once with the environment shown above (`IOP_OPENAI_SMOKE_ARTIFACT_DIR=/tmp/iop-repeat-guard-live/repeat-guard-G08-14`), expecting exit 0, invocation count 1, `provider_responses=15`, `edge_correlations=15`, `capacity_runs=3`, and a sanitized `reproduced` (with fingerprint/offset) or `not_reproduced`. Fresh execution is required; Go test cache output is not acceptable. Do not retry once started.

### Summary and Cleanup Verification

Expected: `summary.json` proves all identity/lifecycle/capacity cardinality; both providers are idle, no harness remains, runtime/source identity is unchanged, and all raw artifacts remain outside the repository.

Implementation evidence:

BLOCKED — no `summary.json` was produced because the live invocation was not started on this host. Nothing to sanitize or clean up here: no harness process was launched, no artifact directory or observation sink was created on the dev runner, and no raw/secret-bearing material entered the repository or stdout. Local source/runtime identity is unchanged (HEAD `d1e32b6e06f7153a4db5a5a08b7026d6dd49fcfb`; `git diff --check` clean; reviewed test-file SHA-256 matches).

Resume condition: after the single authorized live run on the Darwin runner, validate `summary.json` for three runs, 15 globally unique provider response IDs, 15 globally unique Edge correlations, and three accepted capacity rows (`configured=4`, `peak_in_flight=4`, `peak_queued>=1`, `final_in_flight=0`, `final_queued=0`); confirm both providers return idle, no harness process remains, runtime/source identities are unchanged, and no raw artifacts entered tracked evidence or stdout.

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Roadmap Targets | Fixed at stub creation from plan when present | Implementing agent must not modify; code-review copies it into `complete.log` as `Roadmap Completion` only on PASS |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |

## Code Review Result

- Overall Verdict: FAIL
- Dimension Assessment:
  - Correctness: Pass — the reviewed test-only delta retains the expected SHA-256 and the focused deterministic repeat-guard evidence tests pass.
  - Completeness: Fail — `REVIEW_OFR-REPEAT-13-1` remains unchecked and the required Darwin/arm64 live invocation was not started.
  - Test Coverage: Fail — SDD S07 still has no integrated 5-concurrent × 3 provider-pool lifecycle/capacity result.
  - API Contract: Pass — no API or contract source changed in this verification-only loop, and the reviewed local evidence remains consistent with the OpenAI-compatible contract.
  - Code Quality: Pass — `git diff --check` passes and this loop introduced no source change or artifact drift that obscures review.
  - Implementation Deviation: Fail — the plan required one verified dev-runner invocation, but the implementation stopped after the current Linux/aarch64 host failed the external preflight.
  - Verification Trust: Pass — the recorded invocation count of 0, environment blocker, source hash, and focused test result agree with fresh reviewer evidence.
  - Spec Conformance: Fail — SDD S07 requires at least three capacity+1 live runs with sanitized lifecycle, correlation, capacity, and final-result evidence, which is absent.
- Findings:
  - Required — `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/CODE_REVIEW-cloud-G08.md:219`: execute `TestDevRepeatGuardOrnithSmoke` exactly once on the verified Darwin/arm64 runner after all preconditions pass, then record the 15 globally unique provider response IDs, 15 globally unique Edge correlations, three accepted capacity rows, sanitized `reproduced`/`not_reproduced` result, and post-run cleanup evidence. Invocation count 0 cannot satisfy the plan or SDD S07.
- Routing Signals:
  - `review_rework_count=14`
  - `evidence_integrity_failure=false`
- Next Step: Invoke the plan skill in `prepare-follow-up` mode with this raw finding and fresh verification evidence, then archive this pair and materialize the freshly routed follow-up pair.
