<!-- task=m-iop-owned-single-request-agent-execution/25+23,24_claude_smoke_qualification plan=0 tag=TEST milestone-task=claude-smoke -->

# Code Review Reference - TEST

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> Execute the plan's selected root cause, scope, files, and dependency decisions as written. Do not choose another owner, narrow/expand the write boundary, or replace a fix with another verification attempt.
> If implementation is blocked, record the exact blocker, attempted commands/output, declared execution target, authorization state, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-08-07
task=m-iop-owned-single-request-agent-execution/25+23,24_claude_smoke_qualification, plan=0, tag=TEST

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G08.md` → `code_review_cloud_G08_0.log` and `PLAN-cloud-G08.md` → `plan_cloud_G08_0.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-iop-owned-single-request-agent-execution/25+23,24_claude_smoke_qualification/`. If WARN/FAIL or external execution is unavailable, fully write the next filesystem state required by the code-review skill.
4. If PASS, preserve first-line `milestone-task=claude-smoke` metadata in `complete.log` and report it for runtime aggregation. Roadmap state evaluation belongs to `sync-milestone-workstate`.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| TEST-1 Preflight one authorized runtime identity | [ ] |
| TEST-2 Capture one actual Claude/Mac run | [ ] |
| TEST-3 Record qualification without overstating scope | [ ] |

## Implementation Checklist

- [ ] Resolve completed task-23/task-24 dependencies, run the harness self-test, and record a full authorized runner/Mac Node/source/binary/config/runtime/port/workspace/credential-name preflight before invocation.
- [ ] Invoke actual Claude exactly once through the harness and produce the deterministic redacted `claude-smoke-evidence.json` proving ingress one, Plan/Work/Review order and timing, terminal one, and final workspace verification.
- [ ] Validate the manifest and redaction contract, preserve all raw/secret material outside tracked artifacts, and do not auto-retry or substitute fake/stale evidence.
- [ ] After evidence PASS only, update the Anthropic outer contract and current implementation spec from S12 deferred to qualified with the exact evidence path and limits.
- [ ] Run common SDD, proto, document/evidence, and diff verification freshly; if external execution is unavailable, record blocker evidence and stop for official review classification.
- [ ] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [ ] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`, or apply the official `external-execution` gate when required evidence cannot run.
- [ ] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [ ] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G08_0.log`.
- [ ] Archive active `PLAN-*-G??.md` to `plan_cloud_G08_0.log`.
- [ ] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [ ] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [ ] If PASS, move active task directory `agent-task/m-iop-owned-single-request-agent-execution/25+23,24_claude_smoke_qualification/` to `agent-task/archive/YYYY/MM/m-iop-owned-single-request-agent-execution/25+23,24_claude_smoke_qualification/` and update this checklist at the final archive path.
- [ ] If PASS, preserve and report `milestone-task=claude-smoke` metadata for runtime aggregation, without modifying roadmap or directly calling `update-roadmap`.
- [ ] If PASS for split work, remove empty active parent `agent-task/m-iop-owned-single-request-agent-execution/` or verify it was kept due to remaining siblings/files.
- [ ] If WARN/FAIL or external-execution, write the next filesystem state matching the code-review verdict/gate and do not write `complete.log`.

## Deviations from Plan

_Record any deviations, external blocker facts, authorization state, attempted commands/output, and the exact resume condition here._

## Key Design Decisions

_Record key design decisions here._

## Reviewer Checkpoints

- [ ] TEST-1 resolved one task-23 and one task-24 completion, then proved authorized runner/Mac Node/source/binary/config/runtime/port/provider/log/metric/workspace/CLI/secret-name identity before invocation.
- [ ] TEST-2 contains one schema-valid actual run, not fake/manual/stale evidence, with ingress delta one, ordered Plan/Work/Review timing, terminal one, and verified workspace result.
- [ ] TEST-2 retained no raw prompt/output/provider payload, endpoint/model/path/config value, header, credential, or secret in tracked files and performed no automatic retry.
- [ ] TEST-3 updated current docs only after evidence validation and limits every claim to the recorded runtime/single run.
- [ ] If external execution was unavailable, the official reviewer—not the implementer—classified the external-execution state from exact evidence.

## Verification Results

Paste actual stdout/stderr for every attempted command. If a command changes, record the replacement and reason in `Deviations from Plan` first. Never paste secret/raw values; if external execution is unavailable, preserve the exact sanitized blocker and resume condition.

### TEST-1 intermediate

```sh
make test-single-request-claude-smoke-self-test
```

Then run Final Verification command 3 on the authorized runner controlling the Mac Node.

Output: _Paste actual sanitized stdout/stderr and exit status._

### TEST-2 intermediate

Run Final Verification commands 4 and 5 exactly once for the run identity.

Output: _Paste actual sanitized stdout/stderr and exit status._

### TEST-3 intermediate

```sh
rg --sort path -n 'S12|claude-smoke|ingress|Plan|Work|Review|stage|total|terminal|workspace|single run|single-run|qualified' agent-contract/outer/anthropic-compatible-api.md agent-spec/runtime/edge-node-execution.md agent-task/m-iop-owned-single-request-agent-execution/25+23,24_claude_smoke_qualification/claude-smoke-evidence.json
```

Output: _Paste actual stdout/stderr and exit status._

### Final 1 — dependencies

```sh
bash -c 'set -euo pipefail; shopt -s nullglob; for index in 23 24; do candidates=(agent-task/m-iop-owned-single-request-agent-execution/${index}_*/complete.log agent-task/m-iop-owned-single-request-agent-execution/${index}+*/complete.log agent-task/archive/*/*/m-iop-owned-single-request-agent-execution/${index}_*/complete.log agent-task/archive/*/*/m-iop-owned-single-request-agent-execution/${index}+*/complete.log); printf "%s\n" "${candidates[@]}"; ((${#candidates[@]} == 1)); done'
```

Output: _Paste actual stdout/stderr and exit status._

### Final 2 — harness self-test

```sh
make test-single-request-claude-smoke-self-test
```

Output: _Paste actual stdout/stderr and exit status._

### Final 3 — external preflight

```sh
IOP_SINGLE_REQUEST_SMOKE_OUTPUT='agent-task/m-iop-owned-single-request-agent-execution/25+23,24_claude_smoke_qualification/claude-smoke-evidence.json' make test-single-request-claude-smoke-preflight
```

Output: _Paste actual sanitized stdout/stderr and exit status._

### Final 4 — one actual invocation

```sh
IOP_SINGLE_REQUEST_SMOKE_OUTPUT='agent-task/m-iop-owned-single-request-agent-execution/25+23,24_claude_smoke_qualification/claude-smoke-evidence.json' make test-single-request-claude-smoke
```

Output: _Paste actual sanitized stdout/stderr and exit status; do not auto-retry._

### Final 5 — manifest validation

```sh
./scripts/e2e-single-request-claude.sh --validate-manifest agent-task/m-iop-owned-single-request-agent-execution/25+23,24_claude_smoke_qualification/claude-smoke-evidence.json
```

Output: _Paste actual stdout/stderr and exit status._

### Final 6 — common SDD suite

```sh
go test -race -count=1 ./packages/go/config ./packages/go/streamgate ./apps/edge/internal/openai ./apps/edge/internal/service ./apps/node/internal/node ./apps/node/internal/transport ./apps/node/internal/workspace
```

Output: _Paste actual stdout/stderr and exit status._

### Final 7 — proto reproducibility

```sh
make proto && git diff --exit-code -- proto/gen/iop
```

Output: _Paste actual stdout/stderr and exit status._

### Final 8 — bounded qualification claims

```sh
rg --sort path -n 'S12|claude-smoke|ingress|Plan|Work|Review|stage|total|terminal|workspace|single run|single-run|qualified' agent-contract/outer/anthropic-compatible-api.md agent-spec/runtime/edge-node-execution.md agent-task/m-iop-owned-single-request-agent-execution/25+23,24_claude_smoke_qualification/claude-smoke-evidence.json
```

Output: _Paste actual stdout/stderr and exit status._

### Final 9 — diff

```sh
git diff --check
```

Output: _Paste actual stdout/stderr and exit status._

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |
