<!-- task=m-iop-hot-path-one-shot-execution/20+17,19_smoke_harness plan=7 tag=REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_TEST milestone-task=hot-smoke -->

# Close the Hot Path harness common regression after shared Edge recovery

## For the Implementing Agent

Run every checklist item and fill the implementation-owned sections of `CODE_REVIEW-cloud-G03.md` with fresh stdout/stderr. Keep the active PLAN/CODE_REVIEW files in place and report ready for review. If the shared Edge checkout is still compile-inconsistent, record the exact blocker, attempted commands/output, and resume condition in implementation-owned evidence fields and leave the verification item incomplete. Do not ask the user, call user-input tools, create control-plane stop files, classify the next state, archive logs, or write `complete.log`; finalization is owned by the code-review skill.

## Background

The deterministic harness syntax, fixed schema, credential-free oracle, and diff integrity remain green. Official review reproduced the remaining blocker: the SDD-mandated common Go regression cannot compile because the shared `apps/edge/internal/openai` checkout removes Hot Path `Server` state while dependent files still reference it. This follow-up changes no harness or production source; it closes only the mandatory integrated verification after the owning production work restores compile consistency.

## Archive Evidence Snapshot

- `agent-task/m-iop-hot-path-one-shot-execution/20+17,19_smoke_harness/plan_cloud_G03_6.log` and `agent-task/m-iop-hot-path-one-shot-execution/20+17,19_smoke_harness/code_review_cloud_G03_6.log` close plan 6 with `FAIL`: one Required finding, zero Suggested findings, and zero Nits.
- Fresh review evidence: syntax, fixed-schema inspection, credential-free `--self-test`, and `git diff --check` exited 0. The common race-enabled package regression exited 1 because `Server.artifactFrontiers`, `Server.requestCoordinator`, `Server.lightFlows`, and `chatHotPathPolicy` are undefined in the shared checkout.
- The harness implementation received no new correctness finding. `review_rework_count=5`; `evidence_integrity_failure=false` because the implementation's recorded outputs matched fresh review execution.
- Split prerequisites remain satisfied by `agent-task/archive/2026/08/m-iop-hot-path-one-shot-execution/17+14,15,16_endpoint_error_matrix/complete.log` and `agent-task/archive/2026/08/m-iop-hot-path-one-shot-execution/19+17,18_observation_lifecycle/complete.log`.

## Analysis

### Files Read

- `agent-task/m-iop-hot-path-one-shot-execution/20+17,19_smoke_harness/PLAN-cloud-G03.md`
- `agent-task/m-iop-hot-path-one-shot-execution/20+17,19_smoke_harness/CODE_REVIEW-cloud-G03.md`
- `agent-task/m-iop-hot-path-one-shot-execution/20+17,19_smoke_harness/plan_cloud_G03_5.log`
- `agent-task/m-iop-hot-path-one-shot-execution/20+17,19_smoke_harness/code_review_cloud_G03_5.log`
- `apps/edge/internal/openai/server.go`
- `apps/edge/internal/openai/artifact_pair.go`
- `apps/edge/internal/openai/hot_path_cleanup.go`
- `agent-roadmap/current.md`
- `agent-roadmap/phase/knowledge-tool-optimization-extension/PHASE.md`
- `agent-roadmap/phase/knowledge-tool-optimization-extension/milestones/iop-hot-path-one-shot-execution.md`
- `agent-roadmap/sdd/knowledge-tool-optimization-extension/iop-hot-path-one-shot-execution/SDD.md`
- `agent-spec/runtime/stream-evidence-gate.md`
- `agent-spec/input/openai-compatible-surface.md`
- `agent-contract/outer/openai-compatible-api.md`
- `agent-contract/outer/anthropic-compatible-api.md`
- `agent-ops/rules/project/domain/testing/rules.md`
- `agent-ops/rules/project/domain/edge/rules.md`
- `agent-test/local/rules.md`
- `agent-test/local/testing-smoke.md`
- `agent-test/local/edge-smoke.md`
- `agent-task/archive/2026/08/m-iop-hot-path-one-shot-execution/17+14,15,16_endpoint_error_matrix/complete.log`
- `agent-task/archive/2026/08/m-iop-hot-path-one-shot-execution/19+17,18_observation_lifecycle/complete.log`

### SDD Criteria

- SDD: `agent-roadmap/sdd/knowledge-tool-optimization-extension/iop-hot-path-one-shot-execution/SDD.md`; status `[승인됨]`; SDD lock released; no `USER_REVIEW.md`.
- First-line contribution remains `milestone-task=hot-smoke`; the targeted Acceptance Scenario is S16.
- S16 and its Evidence Map require actual Claude/Pi streaming evidence plus workspace before/after evidence. This child remains the deterministic fail-closed harness prerequisite and does not claim the downstream credentialed S16 run.
- The SDD common completion verification explicitly requires `go test -race -count=1 ./packages/go/streamgate ./packages/go/config ./apps/edge/internal/openai ./apps/edge/internal/service` and `git diff --check`. The checklist closes only that missing integrated verification while preserving the already reviewed harness behavior.

### Verification Context

- No verification handoff was supplied. Repository-native fallback comes from the testing and Edge domain rules, `agent-test/local/rules.md`, `testing-smoke.md`, `edge-smoke.md`, the approved SDD, the two outer contracts, and fresh reviewer commands.
- Workdir is `/config/workspace/iop-s0`; the available toolchain is Go `go1.26.2 linux/arm64`, Bash, jq, GNU coreutils, and the current dirty shared worktree. No credential, provider, network, deployment, or installed Claude/Pi execution is required or permitted.
- Fresh reviewer results: shell syntax, schema shape, the credential-free self-test, and diff integrity exited 0. The common regression exited 1 at compile time with missing Hot Path `Server` fields and `chatHotPathPolicy`.
- Precondition: the owner of the concurrent production changes must restore a compile-consistent `apps/edge/internal/openai` checkout. This task must not repair, revert, or overwrite those shared production changes.
- External Verification Preflight: not applicable. Actual credentialed Claude/Pi execution remains owned by the downstream smoke evidence run.
- Confidence is high because the exact mandatory command and compiler output were reproduced on the current checkout with cache disabled.

### Test Coverage Gaps

- The credential-free harness oracle remains green and prior official review found no unresolved harness behavior defect.
- No new behavior is introduced by this follow-up. The only open evidence gap is that the SDD common package regression cannot build against the current shared Edge source.

### Symbol References

- This follow-up renames or removes no symbol.
- The shared diff removes `Server.artifactFrontiers`, `Server.requestCoordinator`, `Server.lightFlows`, their `NewServer` initialization, and `chatHotPathPolicy` while existing Hot Path implementation and tests still reference them. The owning production task must make that checkout internally consistent.

### Split Judgment

- Keep one verification-only plan. A PASS requires the already reviewed harness oracle and the SDD common race regression to be green in the same checkout; splitting them would allow completion without mandatory integration evidence.
- Predecessor 17 is satisfied by `agent-task/archive/2026/08/m-iop-hot-path-one-shot-execution/17+14,15,16_endpoint_error_matrix/complete.log`.
- Predecessor 19 is satisfied by `agent-task/archive/2026/08/m-iop-hot-path-one-shot-execution/19+17,18_observation_lifecycle/complete.log`.

### Scope Rationale

- Modify only the active review evidence. Do not change `scripts/e2e-hot-path-agents.sh`, its schema, production Edge/Node code, config, Makefile, deployment, credentials, or tracked smoke output.
- The shared Edge compile repair belongs to its production owner. This task resumes only after that state is consistent and records fresh verification.

### Final Routing

- `evaluation_mode=isolated-reassessment`; finalizer=`finalize-task-policy.sh pair`.
- Build closures are all true. Scores are 1/0/0/1/1, grade G03, base route `local-fit`, final route `recovery-boundary`, lane `cloud`, filename `PLAN-cloud-G03.md`.
- Review closures are all true. Scores are 1/0/0/1/1, grade G03, route `official-review`, lane `cloud`, filename `CODE_REVIEW-cloud-G03.md`.
- `large_indivisible_context=false`; positive loop risks are `boundary_contract` and `variant_product` (2). `review_rework_count=5`; `evidence_integrity_failure=false`; the recovery boundary matches and the risk boundary does not.
- No capability gap exists. The remaining check is deterministic and repository-local once the shared production owner restores compile consistency.

## Implementation Checklist

- [ ] [REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_TEST-1] Revalidate the unchanged fail-closed harness and close every SDD common verification command after the shared Edge checkout compiles consistently.
- [ ] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

### [REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_TEST-1] Close mandatory integrated verification

**Problem:** `agent-task/m-iop-hot-path-one-shot-execution/20+17,19_smoke_harness/code_review_cloud_G03_6.log` remains incomplete. Fresh review reproduced the required command's exit 1 because `apps/edge/internal/openai/server.go:68` omits Hot Path fields and `apps/edge/internal/openai/server.go:100` omits their initialization while dependent production files still reference them.

**Solution:** Do not edit shared production or harness source in this task. After the production owner restores compile consistency, rerun the complete deterministic verification set and require every command to exit 0. If the common regression still fails, record the exact fresh output and resume condition without marking this item complete.

Before:

```text
go test -race -count=1 ./packages/go/streamgate ./packages/go/config ./apps/edge/internal/openai ./apps/edge/internal/service
FAIL iop/apps/edge/internal/openai [build failed]
exit=1
```

After:

```text
go test -race -count=1 ./packages/go/streamgate ./packages/go/config ./apps/edge/internal/openai ./apps/edge/internal/service
ok ... all four packages
exit=0
```

**Modified Files and Checklist:**

- [ ] Keep `scripts/e2e-hot-path-agents.sh`, `scripts/fixtures/hot-path-agent-smoke-manifest.schema.json`, and all production files unchanged by this task.
- [ ] Run every Final Verification command with fresh output and fill `agent-task/m-iop-hot-path-one-shot-execution/20+17,19_smoke_harness/CODE_REVIEW-cloud-G03.md`.

**Test Strategy:** Add no new test. The embedded credential-free self-test already covers the reviewed harness invariants, and the existing race-enabled package command is the SDD-required integration oracle. Cached Go output is not accepted because the command uses `-count=1`.

**Verification:** Every command in Final Verification exits 0. A shared-worktree compiler error remains a blocker, never PASS evidence.

## Dependencies and Execution Order

1. Predecessor 17 is complete at `agent-task/archive/2026/08/m-iop-hot-path-one-shot-execution/17+14,15,16_endpoint_error_matrix/complete.log`.
2. Predecessor 19 is complete at `agent-task/archive/2026/08/m-iop-hot-path-one-shot-execution/19+17,18_observation_lifecycle/complete.log`.
3. The owning production task restores a compile-consistent `apps/edge/internal/openai` checkout; then run REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_TEST-1.

## Modified Files Summary

| File | Item |
|---|---|
| `agent-task/m-iop-hot-path-one-shot-execution/20+17,19_smoke_harness/CODE_REVIEW-cloud-G03.md` | REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_TEST-1 |

## Final Verification

```bash
bash -n scripts/e2e-hot-path-agents.sh
jq -e '(.properties.cases.prefixItems | length) == 10 and .properties.cases.items == false and ([.properties.cases.prefixItems[].properties.id.const] | length == 10) and ([.properties.cases.prefixItems[].properties.id.const] | unique | length == 10)' scripts/fixtures/hot-path-agent-smoke-manifest.schema.json
./scripts/e2e-hot-path-agents.sh --self-test
go test -race -count=1 ./packages/go/streamgate ./packages/go/config ./apps/edge/internal/openai ./apps/edge/internal/service
git diff --check
```

Expected: every command exits 0 with fresh evidence. If the shared Edge checkout still fails to compile, preserve the exact output and leave the implementation item incomplete.

After completing all code changes, fill implementation-owned sections in `CODE_REVIEW-*-G??.md`.
