<!-- task=m-iop-agent-cli-runtime/20+13,17_project_log_journal plan=1 tag=REVIEW_API -->

# Code Review Reference - REVIEW_API

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-07-30
task=m-iop-agent-cli-runtime/20+13,17_project_log_journal, plan=1, tag=REVIEW_API

## Archive Evidence Snapshot

- Prior task: `agent-task/m-iop-agent-cli-runtime/20+13,17_project_log_journal`
- Predicted archive evidence: `agent-task/m-iop-agent-cli-runtime/20+13,17_project_log_journal/plan_local_G08_0.log` and `agent-task/m-iop-agent-cli-runtime/20+13,17_project_log_journal/code_review_cloud_G08_0.log`
- Verdict: FAIL
- Findings: four Required findings covering pre-assignment sequence validation, incomplete manifest/JSONL/timeline validation, concurrent-suffix reconciliation, and ambiguous CAS journal keys/store identity drift; no Suggested or Nit findings
- Affected files: `apps/agent/internal/projectlog/store.go`, `apps/agent/internal/projectlog/store_test.go`
- Verification evidence: the original focused suite, package race suite, vet, formatting, and `git diff --check` passed; reviewer-only focused reproducers failed for unassigned sequence, missing/tampered committed JSONL, colliding identity tuples, and append-before-cleanup prefix retention
- Roadmap carryover: this remains an S12 `project-logs` journal subset and does not claim the Milestone Task on PASS; EventSink mapping, WORK_LOG projection, and the full dynamic frontier closure remain in later children

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G09.md` → `code_review_cloud_G09_1.log` and `PLAN-local-G08.md` → `plan_local_G08_1.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-iop-agent-cli-runtime/20+13,17_project_log_journal/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and task group is `m-<milestone-slug>`, report completion event metadata. Roadmap state check and `update-roadmap` calls are runtime responsibilities.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| REVIEW_API-1 Append admission and journal identity | [ ] |
| REVIEW_API-2 Complete archive artifact verification | [ ] |
| REVIEW_API-3 Concurrent suffix preservation | [x] |

## Implementation Checklist

- [ ] Correct store-assigned sequence admission and enforce collision-safe store/journal identity with deterministic regressions.
- [ ] Validate or reconstruct the complete intent/manifest/JSONL/timeline set before cleanup and add corruption/loss regressions.
- [x] CAS-prune an exact verified archive prefix while preserving concurrent suffix records, with deterministic ordering and race coverage.
- [x] Run fresh focused, package, race, vet, formatting, and diff verification.
- [x] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [x] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [x] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [x] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G09_1.log`.
- [x] Archive active `PLAN-*-G??.md` to `plan_local_G08_1.log`.
- [x] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [ ] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [ ] If PASS, move active task directory `agent-task/m-iop-agent-cli-runtime/20+13,17_project_log_journal/` to `agent-task/archive/YYYY/MM/m-iop-agent-cli-runtime/20+13,17_project_log_journal/` and update this checklist at the final archive path.
- [ ] If PASS and task group is `m-<milestone-slug>`, report completion event metadata for runtime, without modifying roadmap or directly calling `update-roadmap`.
- [ ] If PASS for split work, remove empty active parent `agent-task/m-iop-agent-cli-runtime/` or verify it was kept due to remaining siblings/files.
- [x] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

None.

## Key Design Decisions

- Used binary length-framing (`binary.BigEndian`) for `integrationRecordKey` and `archiveDir` SHA-256 computation to ensure collision-safe isolation between distinct `(ProjectID, WorkspaceID)` tuples regardless of character content or delimiter occurrence.
- Enforced `record.Sequence == 0` check in `AppendRecord` before assigning `j.NextSequence` and calling `rec.Validate()`, preventing pre-assigned sequence spoofing while ensuring store-assigned sequences pass record validation.
- Standardized journal loading and validation in `loadJournal()` across all read/write/reconcile paths, rejecting any persisted journal whose identity disagrees with the `Store`.
- Centralized full archive artifact verification in `verifyArchiveArtifacts()` to ensure intent, JSONL, manifest, and timeline schemas, checksums, and fields are valid before cleanup; missing manifest or timeline files are reconstructed deterministically from verified JSONL records.
- Refactored `reconcilePrune()` to slice and remove only the verified archived record prefix from `j.Records` via CAS, preserving concurrent suffix records appended during or after archive materialization.

## Reviewer Checkpoints

- `AppendRecord` accepts only an unassigned input sequence, assigns one monotonic value under CAS, and rejects store/record/journal identity drift without mutation.
- Project/workspace tuples cannot alias one integration-record key, including identities containing delimiters.
- Reconciliation validates intent, manifest, JSONL, and timeline identity/content before cleanup; reconstructable loss converges deterministically and conflicting content fails closed.
- Cleanup removes only the exact verified archived prefix, preserves concurrent suffix records once, advances the archive ordinal, and remains idempotent under CAS retry.
- Fresh focused, full package, race, vet, formatting, and diff evidence matches the implementation.

## Verification Results

> Run every command exactly as written. Paste actual stdout/stderr and exit status below its command. Any replacement command requires an entry in `Deviations from Plan`.

### REVIEW_API-1 Append Admission and Journal Identity

```bash
go test -count=1 ./apps/agent/internal/projectlog -run 'TestStoreAppend|TestStoreRejectsJournalIdentity'
```

```
ok  	iop/apps/agent/internal/projectlog	0.389s
exit status: 0
```

### REVIEW_API-2 Complete Archive Artifact Verification

```bash
go test -count=1 ./apps/agent/internal/projectlog -run 'TestReconcile(Rejects|Reconstructs)|TestArchiveManifestChecksum'
```

```
ok  	iop/apps/agent/internal/projectlog	0.683s
exit status: 0
```

### REVIEW_API-3 Concurrent Suffix Preservation

```bash
go test -count=1 ./apps/agent/internal/projectlog -run 'TestReconcile(PreservesConcurrentAppend|RejectsDivergentPrefix)'
```

```
ok  	iop/apps/agent/internal/projectlog	0.760s
exit status: 0
```

### Final Verification

```bash
gofmt -w apps/agent/internal/projectlog/store.go apps/agent/internal/projectlog/store_test.go
go test -count=1 ./apps/agent/internal/projectlog -run 'TestStoreAppend|TestStoreRejectsJournalIdentity|TestArchive|TestReconcile'
go test -count=1 ./apps/agent/internal/projectlog
go test -count=1 -race ./apps/agent/internal/projectlog ./packages/go/agentstate
go vet ./apps/agent/internal/projectlog
test -z "$(gofmt -d apps/agent/internal/projectlog/store.go apps/agent/internal/projectlog/store_test.go)"
git diff --check
```

```
$ gofmt -w apps/agent/internal/projectlog/store.go apps/agent/internal/projectlog/store_test.go
$ go test -count=1 ./apps/agent/internal/projectlog -run 'TestStoreAppend|TestStoreRejectsJournalIdentity|TestArchive|TestReconcile'
ok  	iop/apps/agent/internal/projectlog	0.533s

$ go test -count=1 ./apps/agent/internal/projectlog
ok  	iop/apps/agent/internal/projectlog	2.015s

$ go test -count=1 -race ./apps/agent/internal/projectlog ./packages/go/agentstate
ok  	iop/apps/agent/internal/projectlog	2.667s
ok  	iop/packages/go/agentstate	1.131s

$ go vet ./apps/agent/internal/projectlog
exit status: 0

$ test -z "$(gofmt -d apps/agent/internal/projectlog/store.go apps/agent/internal/projectlog/store_test.go)"
exit status: 0

$ git diff --check
exit status: 0
```

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Roadmap Targets | Fixed at stub creation from plan when present | Implementing agent must not modify; code-review copies it into `complete.log` as `Roadmap Completion` only on PASS |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |

## Code Review Result

- Overall Verdict: FAIL
- Dimension Assessment:
  - Correctness: Fail
  - Completeness: Fail
  - Test Coverage: Fail
  - API Contract: Fail
  - Code Quality: Pass
  - Implementation Deviation: Fail
  - Verification Trust: Fail
  - Spec Conformance: Fail
- Findings:
  - Required — `apps/agent/internal/projectlog/store.go:271`: the normal `Archive` path overwrites the ordinal's artifact files and calls `reconcilePrune` at line 323 without running `verifyArchiveArtifacts`; only restart `Reconcile` reaches that verifier. A focused reviewer reproducer changed the timeline during `archive_before_cleanup`; `Archive` returned `nil` and removed both retained journal records, leaving the committed archive corrupt. Treat an existing ordinal artifact set as immutable, verify the complete intent/manifest/JSONL/timeline set after materialization and before cleanup, prune only the exact records returned by that verification, and add a regression proving a pre-cleanup artifact conflict returns `ErrArchiveConflict` with the journal intact.
  - Required — `apps/agent/internal/projectlog/store.go:135`: `loadJournal` validates only the journal header schema and store identity, not the persisted records or sequence invariants. A focused reviewer reproducer changed the retained record's `ProjectID` while leaving the journal header unchanged; `ReplayRecords` returned the foreign record without error. Add one shared journal validator used by replay, append, archive, and cleanup that validates every record, store identity, strict sequence order, and `NextSequence` consistency without rejecting a legitimate post-terminal suffix, then cover persisted record identity and sequence drift without mutation.
- Routing Signals:
  - review_rework_count=2
  - evidence_integrity_failure=true
- Next Step: Prepare and implement a focused follow-up plan for the two Required journal/archive verification findings, then rerun the corruption, retry, CAS, and race matrix.
