<!-- task=m-iop-agent-cli-runtime/17+13_project_log_records plan=2 tag=REVIEW_API -->

# Code Review Reference - REVIEW_API

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-07-29
task=m-iop-agent-cli-runtime/17+13_project_log_records, plan=2, tag=REVIEW_API

## Archive Evidence Snapshot

- Task path: `agent-task/m-iop-agent-cli-runtime/17+13_project_log_records`
- Archived plan: `agent-task/m-iop-agent-cli-runtime/17+13_project_log_records/plan_local_G08_1.log`
- Archived review: `agent-task/m-iop-agent-cli-runtime/17+13_project_log_records/code_review_cloud_G08_1.log`
- Verdict: `FAIL`
- Findings: 3 Required, 0 Suggested, 0 Nit.
- Affected files: `apps/agent/internal/projectlog/record.go`, `apps/agent/internal/projectlog/record_test.go`.
- Verification evidence:
  - Fresh focused/package tests, vet, formatting, and `git diff --check` passed.
  - A reviewer-only temporary test failed because locator identity drift, an oversized/arbitrary route-quota projection, and a cross-project archive record were all accepted. The temporary test was removed after capture.
- Roadmap carryover: this packet is a strict S12 `project-logs` subset and intentionally has no `Roadmap Targets`; PASS must not check the Milestone Task.

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G04.md` → `code_review_cloud_G04_2.log` and `PLAN-local-G04.md` → `plan_local_G04_2.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-iop-agent-cli-runtime/17+13_project_log_records/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS, report the `m-iop-agent-cli-runtime` completion event with `roadmap-completion=none`; roadmap state check and update calls are runtime responsibilities.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| REVIEW_API-1 Strict record evidence | [x] |
| REVIEW_API-2 Bound archive manifests | [x] |

## Implementation Checklist

- [x] Enforce strict record, locator, route, and shared safe-quota invariants with normal and negative matrix coverage.
- [x] Bind archive manifests to exact project/workspace membership, ordered sequences, and terminal closure with regression coverage.
- [x] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [x] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [x] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [x] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G04_2.log`.
- [x] Archive active `PLAN-*-G??.md` to `plan_local_G04_2.log`.
- [x] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [ ] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [ ] If PASS, move active task directory `agent-task/m-iop-agent-cli-runtime/17+13_project_log_records/` to `agent-task/archive/YYYY/MM/m-iop-agent-cli-runtime/17+13_project_log_records/` and update this checklist at the final archive path.
- [ ] If PASS, report completion event metadata for runtime with `roadmap-completion=none`, without modifying roadmap or directly calling `update-roadmap`.
- [ ] If PASS, remove empty active parent `agent-task/m-iop-agent-cli-runtime/` or verify it was kept due to remaining siblings/files.
- [x] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

None.

## Key Design Decisions

- Replaced free-form quota status fields with the sealed shared `agentpolicy.QuotaObservation` JSON boundary; valid, stale, and canonical corrupt evidence remain safe while unsealed projections are rejected.
- Route evidence now carries bounded provider/model/profile/rule identities, pinned profile/config/selection revisions, and a lowercase reason code.
- Record validation closes event/state/blocker enums, terminal-state agreement, and complete locator kind/revision/parent identity.
- Archive construction validates record membership, strictly increasing sequence, terminal placement, and caller/final-record terminal agreement before hashing; manifest validation enforces exact lowercase SHA-256 shape and unique bounded work-unit IDs.

## Reviewer Checkpoints

- Core record enums, state revision, route identities, and route reason codes are strict and bounded.
- Quota evidence uses the existing sealed shared projection and cannot admit provider-native raw output.
- Every locator kind/revision/identity is valid and matches its enclosing record.
- Archive construction rejects cross-project/workspace records, duplicate or descending sequences, and non-terminal or early-terminal inputs before hashing.
- Regression tests cover every reviewer probe plus decoded manifest shape and retain the existing sensitive/unbounded matrix.

## Verification Results

Paste actual stdout/stderr for every command. If a command changes, record the replacement and reason under `Deviations from Plan`.

### REVIEW_API-1 Focused Record Matrix

```bash
go test -count=1 ./apps/agent/internal/projectlog -run 'TestRecord'
```

Output:

```text
ok  	iop/apps/agent/internal/projectlog	0.005s
```

### REVIEW_API-2 Focused Archive Matrix

```bash
go test -count=1 ./apps/agent/internal/projectlog -run 'TestArchive'
```

Output:

```text
ok  	iop/apps/agent/internal/projectlog	0.008s
```

### Formatting

```bash
gofmt -w apps/agent/internal/projectlog/record.go apps/agent/internal/projectlog/record_test.go
test -z "$(gofmt -d apps/agent/internal/projectlog/record.go apps/agent/internal/projectlog/record_test.go)"
```

Output:

```text
(clean exit, code 0, no output)
```

### Fresh Package and Shared Projection Tests

```bash
go test -count=1 ./apps/agent/internal/projectlog -run 'TestRecord|TestArchive'
go test -count=1 ./apps/agent/internal/projectlog ./packages/go/agentpolicy
```

Output:

```text
ok  	iop/apps/agent/internal/projectlog	0.008s
ok  	iop/apps/agent/internal/projectlog	0.004s
ok  	iop/packages/go/agentpolicy	0.009s
```

### Static Checks

```bash
go vet ./apps/agent/internal/projectlog
git diff --check
```

Output:

```text
(clean exit, code 0, no output)
```

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Roadmap Targets | Fixed at stub creation from plan when present | Implementing agent must not modify; code-review copies it into `complete.log` as `Roadmap Completion` only on PASS |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |

## Code Review Result

- Overall Verdict: FAIL
- Dimension Assessment:
  - Correctness: Fail
  - Completeness: Fail
  - Test coverage: Fail
  - API contract: Fail
  - Code quality: Pass
  - Implementation deviation: Fail
  - Verification trust: Pass
- Findings:
  - Required — `apps/agent/internal/projectlog/record.go:160`: `ProjectLogRecord.Validate` verifies the shared quota projection seal only by marshaling it, but does not apply the record's bounded and sensitive-identity rules to the sealed projection's exported `Adapter` and `Target`. A reviewer-only regression probe created valid sealed observations through `status.NormalizeQuotaSnapshot`; both an adapter longer than `MaxIDLength` and a `Bearer provider-secret` target were accepted. Preserve the canonical corrupt observation, validate every identity carried by valid/stale quota observations with the project-log boundary rules, and add regression cases for oversized and sensitive sealed identities.
- Routing Signals:
  - `review_rework_count=2`
  - `evidence_integrity_failure=false`
- Next Step: Create a freshly routed WARN/FAIL follow-up plan from these raw findings and verification results; do not write `complete.log`.
