<!-- task=m-node-provider-execution-liveness-recovery/05+04_failure_wire plan=1 tag=API milestone-task=failure-handoff -->

# Code Review Reference - API

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-08-05
task=m-node-provider-execution-liveness-recovery/05+04_failure_wire, plan=1, tag=API

## Archive Evidence Snapshot

- Predecessor: `agent-task/archive/2026/08/m-node-provider-execution-liveness-recovery/04+03_health_evidence/complete.log`; final verdict PASS, no remaining nits or follow-up.
- Carryover: Node emits the stable health/fence metadata and connection-scoped monotonic `health_observation_seq`; normalized and tunnel paths passed focused, package, race, vet, repository, smoke, and reconnect verification.
- Affected foundation: `packages/go/execution`, Node liveness mappers, Provider Execution Runtime contract, Edge-Node Runtime Wire contract, and the living execution spec.
- Self-review source: `plan_local_G06_0.log` and `code_review_cloud_G06_0.log` in this task directory. They contain an unimplemented plan/stub pair and no official verdict, Required/Suggested/Nit finding, code change, or verification evidence.
- Replan carryover: preserve the optional raw-free failure envelope scope. The prior pair omitted the repository-wide generated-consumer compile check and a deterministic Edge -> Node -> provider full-cycle, and its copied archive snapshot drifted between PLAN and review; this pair repairs those material evidence gaps.


## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G07.md` → `code_review_cloud_G07_1.log` and `PLAN-local-G07.md` → `plan_local_G07_1.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-node-provider-execution-liveness-recovery/05+04_failure_wire/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and task group is `m-node-provider-execution-liveness-recovery`, preserve the first-line `milestone-task` metadata in `complete.log` and report it for the runtime aggregation event. Roadmap state evaluation belongs to `sync-milestone-workstate`.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| API-1: Add the typed failure wire model | [ ] |
| API-2: Preserve typed failures across both Node paths | [ ] |

## Implementation Checklist

- [ ] API-1 adds one safe optional non-recursive failure message to the protobuf/runtime models and regenerates checked-in Go and Dart bindings without changing existing field numbers.
- [ ] API-2 maps the typed failure on normalized and tunnel terminals, adds absent/present raw-free round-trip tests, and synchronizes the runtime/wire contracts and living spec.
- [ ] Run protobuf generation, focused, repository/package, client, race, vet, provider-only smoke, fake-provider full-cycle, and diff verification commands and confirm fresh uncached PASS output.
- [ ] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [ ] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [ ] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [ ] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G07_1.log`.
- [ ] Archive active `PLAN-*-G??.md` to `plan_local_G07_1.log`.
- [ ] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [ ] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [ ] If PASS, move active task directory `agent-task/m-node-provider-execution-liveness-recovery/05+04_failure_wire/` to `agent-task/archive/YYYY/MM/m-node-provider-execution-liveness-recovery/05+04_failure_wire/` and update this checklist at the final archive path.
- [ ] If PASS and task group is `m-node-provider-execution-liveness-recovery`, preserve and report `milestone-task` metadata for runtime aggregation, without modifying roadmap or directly calling `update-roadmap`.
- [ ] If PASS for split work, remove empty active parent `agent-task/m-node-provider-execution-liveness-recovery/` or verify it was kept due to remaining siblings/files.
- [ ] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

_Record any deviations from the plan and the rationale here._

## Key Design Decisions

_Record key design decisions here._

## Reviewer Checkpoints

- Confirm protobuf field numbers remain append-only, generated Go/Dart descriptors match, and optional absence preserves legacy clients.
- Confirm normalized and tunnel `response_stalled` envelopes clone only stable allowlisted failure metadata and never include raw output or `recovery_eligible`.
- Confirm focused round-trips, repository-wide consumers, provider smoke, and fake-provider full-cycle all pass with fresh output.

## Verification Results

> Implementing agent: run each command exactly as written and paste its actual stdout/stderr under `Output`. Record any replacement command and reason in `Deviations from Plan`.

### Verification 1

Command:

```bash
make proto && make proto-dart
```

Output:

_Paste actual stdout/stderr here._

### Verification 2

Command:

```bash
go test -count=1 ./apps/node/internal/node -run '^(TestRuntimeEventToProtoPreservesTypedFailure|TestStallMetadata.*)$' && go test -count=1 ./apps/edge/internal/transport -run '^(TestEdgeParserMap_.*)$'
```

Output:

_Paste actual stdout/stderr here._

### Verification 3

Command:

```bash
make client-test
```

Output:

_Paste actual stdout/stderr here._

### Verification 4

Command:

```bash
go test -count=1 ./packages/go/execution ./apps/node/... ./apps/edge/internal/transport ./apps/control-plane/...
```

Output:

_Paste actual stdout/stderr here._

### Verification 5

Command:

```bash
go test -race -count=1 ./packages/go/execution ./apps/node/internal/node ./apps/edge/internal/transport
```

Output:

_Paste actual stdout/stderr here._

### Verification 6

Command:

```bash
go vet ./packages/go/execution ./apps/node/... ./apps/edge/internal/transport ./apps/control-plane/...
```

Output:

_Paste actual stdout/stderr here._

### Verification 7

Command:

```bash
go test -count=1 ./...
```

Output:

_Paste actual stdout/stderr here._

### Verification 8

Command:

```bash
./scripts/e2e-smoke.sh
```

Output:

_Paste actual stdout/stderr here._

### Verification 9

Command:

```bash
IOP_VLLM_MODE=fake ./scripts/e2e-openai-vllm.sh
```

Output:

_Paste actual stdout/stderr here._

### Verification 10

Command:

```bash
git diff --check
```

Output:

_Paste actual stdout/stderr here._
---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |
