<!-- task=m-openai-compatible-output-validation-filters/02+01_repeat_guard plan=41 tag=REVIEW_OFR-REPEAT-40 -->

# Code Review Reference - REVIEW_OFR-REPEAT-40

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-07-30
task=m-openai-compatible-output-validation-filters/02+01_repeat_guard, plan=41, tag=REVIEW_OFR-REPEAT-40

## Roadmap Targets

- Milestone: `agent-roadmap/phase/knowledge-tool-optimization-extension/milestones/openai-compatible-output-validation-filters.md`
- Milestone link: [Milestone document](agent-roadmap/phase/knowledge-tool-optimization-extension/milestones/openai-compatible-output-validation-filters.md)
- Task ids:
  - `repeat-guard`: rolling content/history/action repetition detection and safe continuation
- Completion mode: check-on-pass

## Archive Evidence Snapshot

- Dependency `01_resume_notice_builder` is satisfied by `agent-task/archive/2026/07/m-openai-compatible-output-validation-filters/01_resume_notice_builder/complete.log`.
- The failed pair is archived as `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/plan_cloud_G08_40.log` and `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/code_review_cloud_G08_40.log`.
- Verdict: FAIL; Required=1, Suggested=0, Nit=0.
- Required finding: `code_review_cloud_G08_40.log:255` records invocation count 0, and line 265 confirms that no `summary.json`, provider-response record, Edge-correlation record, capacity row, final live result, or cleanup evidence exists.
- Fresh reviewer evidence on 2026-07-30: `git diff --check` exited 0; SHA-256 was `8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21`; focused repeat-guard tests exited 0 in 0.327s; `go test -count=1 ./packages/go/streamgate ./apps/edge/internal/openai` exited 0 in 1.004s and 7.327s; config coverage exited 0 in 0.260s.
- Fresh reviewer exact preflight: `command -v zsh` exited 1 and `zsh -lic ...` exited 127 with `zsh: command not found`; the target checkout was absent, and listeners `18001` and `18083` returned HTTP `000`, the live Go test was not launched, and the sole authorization was not consumed.
- Follow-up: execute the existing live oracle exactly once on `/Users/toki/agent-work/iop-dev` after every source, runtime, capacity, and isolation precondition passes, or record exact attempted preflight output and the resume condition if still blocked.

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G08.md` → `code_review_cloud_G08_41.log` and `PLAN-cloud-G08.md` → `plan_cloud_G08_41.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-openai-compatible-output-validation-filters/02+01_repeat_guard/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and task group is `m-<milestone-slug>`, report completion event metadata. Roadmap state check and `update-roadmap` calls are runtime responsibilities.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| REVIEW_OFR-REPEAT-40-1 — On the verified Darwin/arm64 dev runner, execute exactly one fresh `ornith:35b` 5-concurrent × 3 live invocation after every precondition passes, then record 15 provider responses, 15 Edge correlations, three accepted capacity rows, the sanitized final result, and cleanup evidence; if preflight blocks execution, record exact attempted output, invocation count 0, and the resume condition. | [x] |

## Implementation Checklist

- [x] [REVIEW_OFR-REPEAT-40-1] On the verified Darwin/arm64 dev runner, execute exactly one fresh `ornith:35b` 5-concurrent × 3 live invocation after every precondition passes, then record 15 provider responses, 15 Edge correlations, three accepted capacity rows, the sanitized final result, and cleanup evidence; if preflight blocks execution, record exact attempted output, invocation count 0, and the resume condition.
- [x] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [x] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [x] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [x] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G08_41.log`.
- [x] Archive active `PLAN-*-G??.md` to `plan_cloud_G08_41.log`.
- [x] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [ ] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [ ] If PASS, move active task directory `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/` to `agent-task/archive/YYYY/MM/m-openai-compatible-output-validation-filters/02+01_repeat_guard/` and update this checklist at the final archive path.
- [ ] If PASS and task group is `m-<milestone-slug>`, report completion event metadata for runtime, without modifying roadmap or directly calling `update-roadmap`.
- [ ] If PASS for split work, remove empty active parent `agent-task/m-openai-compatible-output-validation-filters/` or verify it was kept due to remaining siblings/files.
- [x] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

- None. No plan command was altered. The plan's blocked-path branch was followed exactly: the local integrity commands ran verbatim and passed, the external Darwin/arm64 login-shell and deployed-runtime preflights ran verbatim and failed on this Linux/aarch64 host, so the single authorized live invocation was never launched and invocation count 0 with the exact blocker and resume condition is recorded below.
- No production source, test, contract, spec, tracked configuration, or deployed-runtime file was modified. Only this active review evidence artifact was edited.

## Key Design Decisions

- Verification-only follow-up. No design decisions were made because no code, test, config, or spec changed; the reviewed test-file delta and SHA-256 `8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21` are unchanged.
- The S07 live oracle (`TestDevRepeatGuardOrnithSmoke`) requires a Darwin/arm64 runner at `/Users/toki/agent-work/iop-dev` reachable via a `zsh` login shell with the deployed Edge/Node runtime and provider capacity. This host cannot satisfy or substitute for that runner, so the sole authorization was deliberately not consumed; a failed preflight consumes no authorization.

## Reviewer Checkpoints

- Confirm execution occurred on Darwin/arm64 at `/Users/toki/agent-work/iop-dev`, not in a substitute sandbox.
- Confirm `zsh` resolves, login-shell Go is executable, and the same shell invokes that exact binary.
- Confirm HEAD, test-only source delta, reviewed SHA-256, deployed runtime identities, listeners, active blocking gate, selected provider capacity/health, prompt/artifact containment, observation quiescence, and zero competing harnesses before launch.
- Confirm exactly one Go test process starts and exits 0.
- Confirm `summary.json` has three runs, 15 globally unique provider response IDs, 15 globally unique Edge correlations, and three accepted capacity rows with `configured=4`, `peak_in_flight=4`, `peak_queued>=1`, `final_in_flight=0`, and `final_queued=0`.
- Confirm sanitized `reproduced` includes fingerprint/offset or the result is `not_reproduced`; both providers return idle, no harness remains, source/runtime identities are unchanged, and no raw/secret-bearing material entered tracked evidence or stdout.
- If execution is blocked before launch, confirm the active review contains exact attempted commands/output, invocation count 0, the blocker, and the resume condition rather than placeholders.

## Verification Results

Record actual stdout/stderr and exit codes for every command. If blocked, record the exact attempted command, output, invocation count, and resume condition without asking the user or creating a control-plane stop file.

### Local Integrity Verification

```bash
git diff --check
sha256sum apps/edge/internal/openai/stream_gate_vertical_slice_test.go
go test -count=1 ./apps/edge/internal/openai -run 'TestDevRepeatGuard(SmokeEvidence|ObservationCorrelation|ObservationQuiescence|CapacityEvidence)'
go test -count=1 ./packages/go/streamgate ./apps/edge/internal/openai
go test -count=1 ./packages/go/config
```

Expected: all commands exit 0 and SHA-256 is `8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21`.

Implementation evidence:

Executed 2026-07-30 on branch `feature/openai-compatible-output-validation-filters`, HEAD `d1e32b6e06f7153a4db5a5a08b7026d6dd49fcfb`, Linux/aarch64. All commands ran fresh with `-count=1`; every command exited 0.

```text
$ git diff --check
exit=0

$ sha256sum apps/edge/internal/openai/stream_gate_vertical_slice_test.go
8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21  apps/edge/internal/openai/stream_gate_vertical_slice_test.go
exit=0

$ go test -count=1 ./apps/edge/internal/openai -run 'TestDevRepeatGuard(SmokeEvidence|ObservationCorrelation|ObservationQuiescence|CapacityEvidence)'
ok  	iop/apps/edge/internal/openai	0.319s
exit=0

$ go test -count=1 ./packages/go/streamgate ./apps/edge/internal/openai
ok  	iop/packages/go/streamgate	0.888s
ok  	iop/apps/edge/internal/openai	7.313s
exit=0

$ go test -count=1 ./packages/go/config
ok  	iop/packages/go/config	0.054s
exit=0
```

Result: PASS. SHA-256 matches the reviewed hash; `git diff --check` clean; all deterministic S03/S04/S09-S12 evidence groups and the package/config baselines exited 0.

Reconfirmation on the same host again exited 0: focused coverage `0.318s`; `streamgate` and OpenAI packages `0.896s` and `7.329s`; config coverage `0.089s`.

### External Login-Shell and Source Preflight

```bash
command -v zsh
zsh -lic '
set -eu
test "$(uname -s)" = "Darwin"
test "$(uname -m)" = "arm64"
cd /Users/toki/agent-work/iop-dev
go_bin="$(command -v go)"
test -n "$go_bin"
test -x "$go_bin"
"$go_bin" version
"$go_bin" env GOMOD
git branch --show-current
git rev-parse HEAD
git status --short
shasum -a 256 apps/edge/internal/openai/stream_gate_vertical_slice_test.go
'
```

Expected: `zsh` resolves; Go 1.26.3; GOMOD `/Users/toki/agent-work/iop-dev/go.mod`; branch `feature/openai-compatible-output-validation-filters`; reviewed HEAD; only the reviewed test-file delta; reviewed hash.

Implementation evidence:

BLOCKED. This host is Linux/aarch64 (`uname -s`=`Linux`, `uname -m`=`aarch64`) with no `zsh`, so the Darwin/arm64 login-shell preflight cannot start. No further preflight step (Go resolution, GOMOD, branch/HEAD, or reviewed-hash check inside the login shell) was reached.

```text
$ command -v zsh
exit=1

$ zsh -lic '<Darwin/arm64 source preflight>'
/bin/bash: line 23: zsh: command not found
exit=127
```

- `command -v zsh` returned no path and exited 1.
- The `zsh -lic ...` invocation exited 127 with `zsh: command not found`; the login shell never ran, so `uname`, `cd /Users/toki/agent-work/iop-dev`, Go resolution, `go version`, `go env GOMOD`, `git branch --show-current`, `git rev-parse HEAD`, `git status --short`, and `shasum -a 256 ...` were never executed on the target.
- Reconfirmation reported `uname -s`=`Linux`, `uname -m`=`aarch64`, `command -v zsh` exit 1, and the same login-shell preflight exit 127.
- A failed preflight consumes no authorization; the sole live authorization remains unconsumed.

### Deployed Runtime, Capacity, and Isolation Preflight

Record sanitized deployed Edge/Node identities, listeners `18083` and `18001`, active blocking `repeat_guard`, selected provider IDs/health/idle aggregate capacity 4, prompt and artifact containment, writable raw-free observation sink, quiet-window result, and zero competing harnesses. Do not record endpoint secrets, credentials, prompt text, raw SSE, or model output.

Implementation evidence:

BLOCKED. The deployed-runtime/isolation preflight cannot be evaluated from this host: the target checkout is absent and the deployed listeners are unreachable, so Edge/Node identities, provider health/capacity, prompt/artifact containment, observation sink, and the quiet window cannot be proven or substituted here.

```text
$ test -d /Users/toki/agent-work/iop-dev
absent (exit=1)

$ curl -s -o /dev/null -w "http_code=%{http_code}" --max-time 5 http://127.0.0.1:18001/edges/edge-toki-labs-dev/status
http_code=000    curl_exit=7 (Failed to connect / connection refused)

$ curl -s -o /dev/null -w "http_code=%{http_code}" --max-time 5 http://127.0.0.1:18083/
http_code=000    curl_exit=7 (Failed to connect / connection refused)

$ pgrep -af 'TestDevRepeatGuardOrnithSmoke'
(only match is the search command's own shell process line; no Go live-test harness is running)
```

- Target checkout `/Users/toki/agent-work/iop-dev` is absent on this host.
- Control-plane status listener `18001` and Edge OpenAI listener `18083` both return HTTP `000` (curl exit 7, no connection), so no deployed runtime, active `repeat_guard` gate, or provider capacity state is observable.
- No competing `TestDevRepeatGuardOrnithSmoke` harness process exists (the sole `pgrep` match is the search command's own shell line).
- A self-excluding recheck, `pgrep -af '[T]estDevRepeatGuardOrnithSmoke'`, produced no output and exited 1; no live harness is running.
- Deployed Edge/Node identities, selected provider IDs/health/idle aggregate capacity 4, prompt/artifact containment, and the raw-free observation sink remain unverified because none of the target runtime is reachable from this host.

### Single Authorized Live Invocation

```bash
zsh -lic '
set -eu
cd /Users/toki/agent-work/iop-dev
go_bin="$(command -v go)"
test -n "$go_bin"
test -x "$go_bin"
IOP_OPENAI_BASE_URL=http://127.0.0.1:18083 \
IOP_OPENAI_MODEL=ornith:35b \
IOP_OPENAI_SMOKE_CONCURRENCY=5 \
IOP_OPENAI_SMOKE_RUNS=3 \
IOP_OPENAI_SMOKE_PROMPT_FILE=/tmp/iop-repeat-guard-live/repeat-prompt.txt \
IOP_OPENAI_SMOKE_ARTIFACT_DIR=/tmp/iop-repeat-guard-live/repeat-guard-review-41 \
IOP_OPENAI_SMOKE_OBSERVATION_FILE=/tmp/iop-repeat-guard-live/edge-observations.jsonl \
IOP_OPENAI_SMOKE_STATUS_URL=http://127.0.0.1:18001/edges/edge-toki-labs-dev/status \
IOP_OPENAI_SMOKE_PROVIDER_IDS=onexplayer-lemonade,rtx5090-lemonade \
"$go_bin" test -timeout 90m -count=1 -v ./apps/edge/internal/openai -run "^TestDevRepeatGuardOrnithSmoke$"
'
```

Expected: invocation count 1, exit 0, 15 globally unique provider response IDs, 15 globally unique Edge correlations, three accepted capacity rows, and sanitized `reproduced` with fingerprint/offset or `not_reproduced`.

Implementation evidence:

NOT LAUNCHED. Invocation count 0. `TestDevRepeatGuardOrnithSmoke` was never started because the login-shell/source preflight and the deployed-runtime/isolation preflight both failed above (no `zsh`, absent target checkout, listeners `18001`/`18083` at HTTP `000`). The launch command was not run; the sole live authorization remains unconsumed. No `summary.json`, provider-response record, Edge-correlation record, capacity row, or final live result was produced.

Blocker: this Linux/aarch64 host has no `zsh` login shell, does not contain the Darwin/arm64 target checkout `/Users/toki/agent-work/iop-dev`, and cannot reach the deployed Edge/control-plane listeners; it cannot execute or substitute for the S07 live oracle.

Resume condition: on the Darwin/arm64 runner at `/Users/toki/agent-work/iop-dev`, once `zsh` resolves a login-shell Go 1.26.3 with GOMOD `/Users/toki/agent-work/iop-dev/go.mod`, branch `feature/openai-compatible-output-validation-filters` at the reviewed HEAD with only the reviewed test-file delta and SHA-256 `8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21`, the deployed Edge/Node runtime is up with listeners `18083`/`18001` healthy, the active blocking `repeat_guard` gate and idle selected providers (`onexplayer-lemonade`, `rtx5090-lemonade`) present aggregate capacity 4, a bounded non-empty prompt file exists, the new empty artifact dir `/tmp/iop-repeat-guard-live/repeat-guard-review-41` and a writable raw-free observation sink are in place, and zero competing harnesses are running — launch `TestDevRepeatGuardOrnithSmoke` exactly once and record the 15/15/3 evidence, sanitized final result, and cleanup.

### Summary and Cleanup Verification

Validate `summary.json`, selected-provider idle recovery, zero remaining harness process, unchanged source/runtime identities, and no tracked raw/secret-bearing evidence. Do not paste raw prompt, SSE, output, credentials, tokens, or private endpoint material.

Implementation evidence:

NOT APPLICABLE — no invocation occurred, so there is no `summary.json` and no provider/observation state to validate or clean up.

- `test -e /tmp/iop-repeat-guard-live/repeat-guard-review-41/summary.json` exited 1: no `summary.json` exists (invocation count 0), and no review artifact was written there.
- No `TestDevRepeatGuardOrnithSmoke` harness process was started or remains (`pgrep` shows only the search command's own shell line).
- The local source identity is unchanged: branch `feature/openai-compatible-output-validation-filters`, HEAD `d1e32b6e06f7153a4db5a5a08b7026d6dd49fcfb`, reviewed test-file SHA-256 `8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21`, `git diff --check` clean. Deployed runtime identity remains unverified because the target is unreachable.
- No raw prompt, SSE, model output, credential, token, or private-endpoint material entered any tracked artifact or stdout.

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Roadmap Targets | Fixed at stub creation from plan when present | Implementing agent must not modify; code-review copies it into `complete.log` as `Roadmap Completion` only on PASS |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |

## Code Review Result

- Overall Verdict: FAIL
- Dimension Assessment:
  - Correctness: Pass
  - Completeness: Fail
  - Test coverage: Fail
  - API contract: Pass
  - Code quality: Pass
  - Implementation deviation: Pass
  - Verification trust: Fail
  - Spec conformance: Fail
- Findings:
  - Required — `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/CODE_REVIEW-cloud-G08.md:240`: the SDD S07 live oracle was not launched, so invocation count remains 0 and there is no `summary.json`, no 15 provider-response identities, no 15 Edge lifecycle correlations, no three accepted capacity rows, no sanitized final result, and no post-run cleanup evidence. On the required Darwin/arm64 runner, satisfy every source/runtime/capacity/isolation precondition, execute `TestDevRepeatGuardOrnithSmoke` exactly once, and record the required 15/15/3 result and cleanup evidence.
- Routing Signals: `review_rework_count=41`, `evidence_integrity_failure=true`
- Next Step: Invoke the plan skill for a freshly routed FAIL follow-up that preserves the single live authorization and obtains the missing S07 evidence on the required Darwin/arm64 runner.
