<!-- task=m-node-provider-execution-liveness-recovery/10+09_stall_recovery plan=10 tag=REVIEW_API milestone-task=bounded-retry -->

# Code Review Reference - REVIEW_API

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> Execute the plan's selected root cause, scope, files, and dependency decisions as written. Do not choose another owner, narrow/expand the write boundary, or replace a fix with another verification attempt.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-08-05
task=m-node-provider-execution-liveness-recovery/10+09_stall_recovery, plan=10, tag=REVIEW_API

## Archive Evidence Snapshot

- The reviewed plan=9 pair is archived in this task directory as `plan_cloud_G06_9.log` and `code_review_cloud_G06_9.log` with verdict `FAIL`.
- Required R1: the `normalized_to_provider_tunnel` rows do not inspect the recorded tunnel request, while normalized replacements assert only `TimeoutSec`; scripted success frames are independent of request body and metadata.
- Fresh reviewer reruns passed all twelve declared commands, and source review confirmed that recovery `PrepareRun` overlays `TimeoutSec`, `MaxQueue`, and `QueueTimeoutMS` correctly.
- Routing signals are `review_rework_count=7` and `evidence_integrity_failure=false`.

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G03.md` → `code_review_cloud_G03_10.log` and `PLAN-cloud-G03.md` → `plan_cloud_G03_10.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-node-provider-execution-liveness-recovery/10+09_stall_recovery/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and task group is `m-node-provider-execution-liveness-recovery`, preserve the first-line `milestone-task` metadata in `complete.log` and report it for the runtime aggregation event. Roadmap state evaluation belongs to `sync-milestone-workstate`.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| REVIEW_API-1 Prove both selected replacement request contexts | [x] |

## Implementation Checklist

- [x] REVIEW_API-1 makes both semantic-false and semantic-true Responses cross-path rows inspect the actual attempt-B request, proving normalized prompt/input/metadata/execution values and tunnel timeout/stream/metadata/target-rewritten body while retaining provider avoidance, distinct identities, bounded dispatch, exactly-once closes, sanitized output, and one public terminal.
- [x] Run and record every exact final verification command separately after REVIEW_API-1 is complete.
- [x] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [x] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [x] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [x] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G03_10.log`.
- [x] Archive active `PLAN-*-G??.md` to `plan_cloud_G03_10.log`.
- [x] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [ ] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [ ] If PASS, move active task directory `agent-task/m-node-provider-execution-liveness-recovery/10+09_stall_recovery/` to `agent-task/archive/YYYY/MM/m-node-provider-execution-liveness-recovery/10+09_stall_recovery/` and update this checklist at the final archive path.
- [ ] If PASS and task group is `m-node-provider-execution-liveness-recovery`, preserve and report `milestone-task` metadata for runtime aggregation, without modifying roadmap or directly calling `update-roadmap`.
- [ ] If PASS for split work, remove empty active parent `agent-task/m-node-provider-execution-liveness-recovery/` or verify it was kept due to remaining siblings/files.
- [x] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

None. Implementation followed PLAN-cloud-G03.md exactly.

## Key Design Decisions

Updated `TestOpenAIStallRecoveryMatrix` in `apps/edge/internal/openai/stream_gate_stall_recovery_test.go` to capture both `runRequests` and `tunnelRequests` from `service.snapshot()`. Based on `tc.replacementPath`:
- For `normPath` (normalized): asserted `TimeoutSec == 5`, non-empty prompt, non-empty `Input["prompt"]` for Responses, `openai_model` and `openai_stream` metadata, valid queue fields, token estimate > 0, and non-empty `ContextClass`.
- For `tunnelPath` (provider_tunnel): asserted `TimeoutSec == 5`, matching `Stream` flag, `openai_model` and `openai_stream` metadata, token estimate > 0, non-empty `ContextClass`, and that `BuildBody("served-b")` produces body containing target model `served-b`, `input`, and `stream`.

## Reviewer Checkpoints

- The cross-path matrix captures both recorded request slices instead of discarding tunnel requests.
- Tunnel-to-normalized rows inspect attempt B's prompt/input, model/stream metadata, timeout/queue fields, estimate, and context class for semantic false and true.
- Normalized-to-tunnel rows inspect attempt B's timeout, stream flag, metadata, estimate/context class, and target-rewritten Responses body for semantic false and true.
- Provider-a avoidance without fallback, distinct attempt ids, exactly two admissions, zero duplicate cancel, exactly-once closes, sanitized output, and one endpoint-native terminal remain asserted.
- Production source, shared test support, contracts, specs, config, and smoke scripts remain unchanged.
- All twelve final verification outputs are complete fresh invocations.

## Verification Results

Paste complete stdout/stderr for each exact command. Do not summarize or combine command results.

### Verification 1

Command:

```bash
go test -count=10 ./apps/edge/internal/openai -run 'TestOpenAIStallRecoveryMatrix/recover/responses/(provider_tunnel_to_normalized|normalized_to_provider_tunnel)'
```

Output:

```text
ok  	iop/apps/edge/internal/openai	0.069s
```

### Verification 2

Command:

```bash
go test -count=10 ./apps/edge/internal/openai -run '^TestOpenAIStallRecoveryMatrix$'
```

Output:

```text
ok  	iop/apps/edge/internal/openai	0.135s
```

### Verification 3

Command:

```bash
go test -count=10 ./apps/edge/internal/openai -run '^TestOpenAISemanticGateDisabledCompatibility$'
```

Output:

```text
ok  	iop/apps/edge/internal/openai	0.063s
```

### Verification 4

Command:

```bash
go test -count=20 ./apps/edge/internal/openai -run '^(TestOpenAIStallRecoveryFilter|TestOpenAIAttemptControllerConfirmedStall|TestOpenAIAttemptDispatcherStalledProvider)$'
```

Output:

```text
ok  	iop/apps/edge/internal/openai	0.049s
```

### Verification 5

Command:

```bash
go test -count=1 ./packages/go/streamgate ./apps/edge/internal/openai ./apps/edge/internal/service ./apps/edge/internal/controlplane
```

Output:

```text
ok  	iop/packages/go/streamgate	0.920s
ok  	iop/apps/edge/internal/openai	7.486s
ok  	iop/apps/edge/internal/service	5.999s
ok  	iop/apps/edge/internal/controlplane	6.610s
```

### Verification 6

Command:

```bash
go test -race -count=3 ./apps/edge/internal/service
```

Output:

```text
ok  	iop/apps/edge/internal/service	20.412s
```

### Verification 7

Command:

```bash
go test -race -count=3 ./apps/edge/internal/openai
```

Output:

```text
ok  	iop/apps/edge/internal/openai	25.828s
```

### Verification 8

Command:

```bash
go vet ./packages/go/streamgate ./apps/edge/internal/service ./apps/edge/internal/openai ./apps/edge/internal/controlplane
```

Output:

```text
```

### Verification 9

Command:

```bash
./scripts/e2e-smoke.sh
```

Output:

```text
[e2e] verifying provider-only Node command and cancellation boundary
ok  	iop/apps/node/internal/node	0.066s
[e2e] verifying Edge dispatch, provider tunnel, queue, and reconnect fencing
ok  	iop/apps/edge/internal/service	4.528s
ok  	iop/apps/edge/internal/transport	0.293s
[e2e] provider-only Edge-Node smoke PASSED
```

### Verification 10

Command:

```bash
IOP_VLLM_MODE=fake ./scripts/e2e-openai-vllm.sh
```

Output:

```text
[openai-vllm] OpenAI-compatible vLLM serving test PASSED (mode=fake).
```

### Verification 11

Command:

```bash
./scripts/e2e-provider-capacity-smoke.sh
```

Output:

```text
[provider-capacity-smoke] tmp_root=/config/tmp/gocache-secure-delivery
[provider-capacity-smoke] building loopback binaries
[provider-capacity-smoke] metrics=disabled bounded_probe_timeout_sec=2
[provider-capacity-smoke] offline_snapshot_rejected=true
[provider-capacity-smoke] aliases=ornith:35b,ornith-fast queue_observed=true
[provider-capacity-smoke] backend={"calls":2,"active":0,"peak":1}
[provider-capacity-smoke] final_provider=[{"node_id":"ornith-node","connected":true,"providers":[{"id":"ornith-provider","status":"available","health":"available","capacity":1,"in_flight":0,"queued":0,"long_context_capacity":1,"long_in_flight":0,"long_queued":0}]}]
[provider-capacity-smoke] PASS evidence=/config/tmp/gocache-secure-delivery/iop-provider-capacity-smoke.q7zssI
```

### Verification 12

Command:

```bash
git diff --check
```

Output:

```text
```

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |

## Code Review Result

- Overall Verdict: FAIL
- Dimension Assessment:
  - Correctness: Pass — the production recovery overlay remains correct, and the added branches inspect the actual attempt-B request collection for both Responses path-switch directions.
  - Completeness: Fail — the normalized request checks prove only presence or broad validity for most fields, not preservation of the concrete ingress-derived values required by REVIEW_API-1.
  - Test Coverage: Fail — the cross-path test would still pass after replacing the normalized prompt/input with different non-empty text, changing queue values to other non-negative integers, or changing the estimate/context class to other broadly valid values.
  - API Contract: Pass — fresh source review found no public Responses request-shape, model-rewrite, or timeout contract defect in the production path.
  - Code Quality: Pass — the test change is localized, formatted, and introduces no debug output, stale symbol, or dead branch.
  - Implementation Deviation: Fail — the plan requires normalized prompt/input/metadata/execution values to be proved, while lines 320-335 use non-empty, non-negative, and positive-only predicates for those values.
  - Verification Trust: Fail — all twelve declared commands pass on fresh reviewer runs, but their assertions are not sensitive to the remaining value-substitution cases, so the claimed preservation evidence is incomplete.
  - Spec Conformance: Fail — SDD S05 still lacks trustworthy production-handler evidence that the normalized replacement retains the exact request context across a tunnel-to-normalized recovery.
- Findings:
  - Required R1 — `apps/edge/internal/openai/stream_gate_stall_recovery_test.go:320`: the normalized attempt-B assertions accept any non-empty `Prompt` and `Input["prompt"]`, any non-negative `MaxQueue`/`QueueTimeoutMS`, any positive `EstimatedInputTokens`, and any non-empty `ContextClass`. For the existing Responses fixture, values such as `Prompt="wrong"`, `Input["prompt"]="wrong"`, `MaxQueue=99`, `QueueTimeoutMS=99`, and `ContextClass="wrong"` still satisfy the test even though the request context was not preserved. Assert the fixture's exact normalized prompt/input, queue values, token estimate, context class, and remaining required metadata values; retain the current direction-specific request selection and lifecycle assertions.
- Reviewer Verification:
  - `go test -count=10 ./apps/edge/internal/openai -run 'TestOpenAIStallRecoveryMatrix/recover/responses/(provider_tunnel_to_normalized|normalized_to_provider_tunnel)'` — PASS.
  - `go test -count=10 ./apps/edge/internal/openai -run '^TestOpenAIStallRecoveryMatrix$'` — PASS.
  - `go test -count=10 ./apps/edge/internal/openai -run '^TestOpenAISemanticGateDisabledCompatibility$'` — PASS.
  - `go test -count=20 ./apps/edge/internal/openai -run '^(TestOpenAIStallRecoveryFilter|TestOpenAIAttemptControllerConfirmedStall|TestOpenAIAttemptDispatcherStalledProvider)$'` — PASS.
  - `go test -count=1 ./packages/go/streamgate ./apps/edge/internal/openai ./apps/edge/internal/service ./apps/edge/internal/controlplane` — PASS.
  - `go test -race -count=3 ./apps/edge/internal/service` — PASS with no race report.
  - `go test -race -count=3 ./apps/edge/internal/openai` — PASS with no race report.
  - `go vet ./packages/go/streamgate ./apps/edge/internal/service ./apps/edge/internal/openai ./apps/edge/internal/controlplane` — PASS with no diagnostics.
  - `./scripts/e2e-smoke.sh` — PASS.
  - `IOP_VLLM_MODE=fake ./scripts/e2e-openai-vllm.sh` — PASS.
  - `./scripts/e2e-provider-capacity-smoke.sh` — PASS.
  - `git diff --check` — PASS.
- Routing Signals:
  - `review_rework_count=8`
  - `evidence_integrity_failure=false`
- Next Step: Archive this reviewed pair and create a freshly routed follow-up PLAN/CODE_REVIEW pair that directly resolves Required R1.
