<!-- task=m-iop-agent-cli-runtime/20+13,17_project_log_journal plan=2 tag=REVIEW_API -->

# Code Review Reference - REVIEW_API

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-07-30
task=m-iop-agent-cli-runtime/20+13,17_project_log_journal, plan=2, tag=REVIEW_API

## Archive Evidence Snapshot

- Prior task: `agent-task/m-iop-agent-cli-runtime/20+13,17_project_log_journal`
- Predicted current-loop evidence: `agent-task/m-iop-agent-cli-runtime/20+13,17_project_log_journal/plan_local_G08_1.log` and `agent-task/m-iop-agent-cli-runtime/20+13,17_project_log_journal/code_review_cloud_G09_1.log`
- Verdict: FAIL
- Findings: two Required findings covering missing persisted-record/sequence validation and missing normal-path artifact verification before journal cleanup; no Suggested or Nit findings
- Affected files: `apps/agent/internal/projectlog/store.go`, `apps/agent/internal/projectlog/store_test.go`
- Verification evidence: the focused suite, package suite, race suite, vet, formatting, and `git diff --check` passed; one reviewer-only focused reproducer proved that a pre-cleanup timeline conflict still prunes the journal and that a foreign persisted record replays without error
- Roadmap carryover: this remains an S12 `project-logs` journal subset and does not claim the Milestone Task on PASS; EventSink mapping, WORK_LOG projection, and the complete dynamic frontier remain in later children

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G09.md` → `code_review_cloud_G09_2.log` and `PLAN-cloud-G09.md` → `plan_cloud_G09_2.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-iop-agent-cli-runtime/20+13,17_project_log_journal/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and task group is `m-<milestone-slug>`, report completion event metadata. Roadmap state check and `update-roadmap` calls are runtime responsibilities.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| REVIEW_API-1 Persisted journal validation | [x] |
| REVIEW_API-2 Pre-prune archive verification | [x] |

## Implementation Checklist

- [x] Validate every persisted journal record and sequence invariant through shared load/cleanup validation, with deterministic no-mutation regressions.
- [x] Verify or reuse the complete immutable archive artifact set before cleanup and reject pre-cleanup or retry conflicts without pruning, with deterministic regressions.
- [x] Run fresh focused, package, race, vet, formatting, and diff verification.
- [x] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [x] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [x] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [x] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G09_2.log`.
- [x] Archive active `PLAN-*-G??.md` to `plan_cloud_G09_2.log`.
- [x] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [ ] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [ ] If PASS, move active task directory `agent-task/m-iop-agent-cli-runtime/20+13,17_project_log_journal/` to `agent-task/archive/YYYY/MM/m-iop-agent-cli-runtime/20+13,17_project_log_journal/` and update this checklist at the final archive path.
- [ ] If PASS and task group is `m-<milestone-slug>`, report completion event metadata for runtime, without modifying roadmap or directly calling `update-roadmap`.
- [ ] If PASS for split work, remove empty active parent `agent-task/m-iop-agent-cli-runtime/` or verify it was kept due to remaining siblings/files.
- [x] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

None.

Verification preflight resolved `/config/.local/bin/go` to `/config/opt/go/bin/go`, reported `go version go1.26.2 linux/arm64`, and used `GOROOT=/config/opt/go`. The targeted files are untracked within the intentionally dirty shared checkout described by the plan.

## Key Design Decisions

- Added one store-owned journal validator behind `loadJournal` so replay, append, archive, and prune all reject unsupported journal or record schemas, foreign record identities, unsafe `NextSequence` values, non-contiguous retained sequences, and stale next-sequence state before returning evidence or attempting CAS mutation.
- Revalidated the journal after assigning an append sequence so sequence exhaustion cannot persist a journal that a subsequent load would reject.
- Checked for any existing artifact at the next archive ordinal before fresh materialization. Existing ordinals are verified and reconciled as immutable retry state instead of being overwritten.
- Verified the complete intent, JSONL, timeline, and manifest set after the normal archive materialization hook, then pruned only the verified intent and records returned by that verifier.
- Preserved the existing contract and schemas. The change strengthens fail-closed validation and exactly-once cleanup behavior without changing `ProjectLogRecord`, `ArchiveManifest`, or `agentstate.Store`.

## Reviewer Checkpoints

- Every journal load rejects malformed retained records, foreign store identity, and invalid sequence/`NextSequence` state before replay or CAS mutation.
- Journal validation permits a legitimate concurrent suffix after a terminal archived prefix and cleanup still preserves that suffix exactly once.
- Normal Archive and retry paths verify or reuse the complete immutable intent/manifest/JSONL/timeline set before cleanup and never overwrite a conflicting committed ordinal.
- Fresh focused, package, race, vet, formatting, and diff evidence matches the implementation.

## Verification Results

> Run every command exactly as written. Paste actual stdout/stderr and exit status below its command. Any replacement command requires an entry in `Deviations from Plan`.

### REVIEW_API-1 Persisted Journal Validation

```bash
go test -count=1 ./apps/agent/internal/projectlog -run 'TestStore(Append|RejectsJournalIdentity|RejectsPersistedJournalDrift)'
```

```text
ok  	iop/apps/agent/internal/projectlog	0.049s
exit status: 0
```

### REVIEW_API-2 Pre-Prune Archive Verification

```bash
go test -count=1 ./apps/agent/internal/projectlog -run 'TestArchive(RejectsPreCleanupArtifactDrift|RetryReusesCommittedArtifacts)|TestReconcilePreservesConcurrentAppend'
```

```text
ok  	iop/apps/agent/internal/projectlog	0.122s
exit status: 0
```

### Final Verification

```bash
gofmt -w apps/agent/internal/projectlog/store.go apps/agent/internal/projectlog/store_test.go
go test -count=1 ./apps/agent/internal/projectlog -run 'TestStoreAppend|TestStoreRejectsJournalIdentity|TestStoreRejectsPersistedJournalDrift|TestArchive|TestReconcile'
go test -count=1 ./apps/agent/internal/projectlog
go test -count=1 -race ./apps/agent/internal/projectlog ./packages/go/agentstate
go vet ./apps/agent/internal/projectlog
test -z "$(gofmt -d apps/agent/internal/projectlog/store.go apps/agent/internal/projectlog/store_test.go)"
git diff --check
```

```text
$ gofmt -w apps/agent/internal/projectlog/store.go apps/agent/internal/projectlog/store_test.go
exit status: 0

$ go test -count=1 ./apps/agent/internal/projectlog -run 'TestStoreAppend|TestStoreRejectsJournalIdentity|TestStoreRejectsPersistedJournalDrift|TestArchive|TestReconcile'
ok  	iop/apps/agent/internal/projectlog	0.541s
exit status: 0

$ go test -count=1 ./apps/agent/internal/projectlog
ok  	iop/apps/agent/internal/projectlog	0.469s
exit status: 0

$ go test -count=1 -race ./apps/agent/internal/projectlog ./packages/go/agentstate
ok  	iop/apps/agent/internal/projectlog	2.080s
ok  	iop/packages/go/agentstate	1.064s
exit status: 0

$ go vet ./apps/agent/internal/projectlog
exit status: 0

$ test -z "$(gofmt -d apps/agent/internal/projectlog/store.go apps/agent/internal/projectlog/store_test.go)"
exit status: 0

$ git diff --check
exit status: 0
```

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Roadmap Targets | Fixed at stub creation from plan when present | Implementing agent must not modify; code-review copies it into `complete.log` as `Roadmap Completion` only on PASS |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |

## Code Review Result

- Overall Verdict: FAIL
- Dimension Assessment:
  - Correctness: Fail
  - Completeness: Fail
  - Test Coverage: Fail
  - API Contract: Fail
  - Code Quality: Pass
  - Implementation Deviation: Fail
  - Verification Trust: Fail
  - Spec Conformance: Fail
- Findings:
  - Required — `apps/agent/internal/projectlog/store.go:280`: `Archive` checks `archiveArtifactsExist` before creating the ordinal, but fresh materialization later overwrites intent, JSONL, timeline, and manifest paths through `writeAtomically`/`os.Rename` without an exclusive ordinal claim. A deterministic reviewer reproducer placed two `Archive` calls past that preflight: the second call verified and pruned the journal, then the first overwrote the committed manifest and returned `ErrArchiveConflict`, leaving zero journal records and an ordinal that `verifyArchiveArtifacts` rejects. Make ordinal creation/retry mutually exclusive or use an atomic create/fencing protocol so only one writer can materialize an ordinal and every concurrent caller verifies/reuses immutable bytes; add a deterministic concurrent-archive regression that requires both callers to converge, retains no corrupt artifact set, and never prunes before the winning set is durably immutable.
  - Required — `apps/agent/internal/projectlog/store.go:463`: malformed persisted intent JSON returns the raw `json.Unmarshal` error instead of the plan-required typed `ErrArchiveConflict`/`ErrArchiveIncomplete`. A reviewer pre-cleanup reproducer wrote `{not-json`; `Archive` preserved the journal but failed `errors.Is(err, ErrArchiveConflict)`. Wrap malformed existing intent content as `ErrArchiveConflict` and add a no-mutation regression for syntactically malformed intent, alongside the existing schema-drift case.
- Routing Signals:
  - review_rework_count=3
  - evidence_integrity_failure=true
- Next Step: Prepare and implement a focused follow-up plan for atomic immutable ordinal ownership and typed malformed-intent rejection, then rerun the concurrent archive, corruption, retry, CAS, and race matrix.
