<!-- task=m-iop-owned-single-request-agent-execution/23+22_error_cancel plan=1 tag=API milestone-task=error-cancel -->

# Code Review Reference - API

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> Execute the plan's selected root cause, scope, files, and dependency decisions as written. Do not choose another owner, narrow/expand the write boundary, or replace a fix with another verification attempt.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-08-07
task=m-iop-owned-single-request-agent-execution/23+22_error_cancel, plan=1, tag=API

## Archive Evidence Snapshot

- Prior plan: `agent-task/m-iop-owned-single-request-agent-execution/23+22_error_cancel/plan_cloud_G10_0.log`; prior pristine review stub: `agent-task/m-iop-owned-single-request-agent-execution/23+22_error_cancel/code_review_cloud_G10_0.log`.
- No implementation evidence or official verdict existed. Self-review found two semantic plan defects: Edge HTTP terminal ownership was incorrectly assigned to the host-neutral execution-runtime contract, and the current `/v1/messages` input-surface spec was omitted.
- This replan preserves the production/test boundary and S11 matrix, removes `agent-contract/inner/execution-runtime.md` from the write set, and adds `agent-spec/input/openai-compatible-surface.md`.

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G10.md` → `code_review_cloud_G10_1.log` and `PLAN-cloud-G10.md` → `plan_cloud_G10_1.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-iop-owned-single-request-agent-execution/23+22_error_cancel/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS, preserve the first-line `milestone-task=error-cancel` metadata in `complete.log` and report it for runtime aggregation. Roadmap evaluation belongs to `sync-milestone-workstate`.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| API-1 | [ ] |
| API-2 | [ ] |
| API-3 | [ ] |
| API-4 | [ ] |

## Implementation Checklist

- [ ] Add a closed, copy-safe single-request terminal disposition that distinguishes `end_turn`, `length`, sanitized error classes, and caller cancellation while preserving exactly-once cleanup/acknowledgement.
- [ ] Classify provider/tool timeout, stage/request budgets, repetition/no-progress, malformed calls, context/output limits, and disconnect in the completed stage/composite path without retry, fallback, partial-success, generic StreamGate admission, or retained waiters.
- [ ] Project the closed disposition consistently through buffered and SSE Anthropic responses and add the complete S11 one-ingress/one-terminal race matrix.
- [ ] Synchronize the Anthropic outer contract and both matching current implementation specs with the implemented error/cancel/length policy.
- [ ] Run dependency, focused race, compatibility, full SDD, proto, deterministic symbol/document, and diff verification freshly.
- [ ] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [ ] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [ ] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [ ] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G10_1.log`.
- [ ] Archive active `PLAN-*-G??.md` to `plan_cloud_G10_1.log`.
- [ ] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [ ] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [ ] If PASS, move active task directory `agent-task/m-iop-owned-single-request-agent-execution/23+22_error_cancel/` to `agent-task/archive/YYYY/MM/m-iop-owned-single-request-agent-execution/23+22_error_cancel/` and update this checklist at the final archive path.
- [ ] If PASS, preserve and report `milestone-task=error-cancel` for runtime aggregation, without modifying roadmap or directly calling `update-roadmap`.
- [ ] If PASS for split work, remove empty active parent only if no siblings/files remain.
- [ ] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

_Record any deviations from the plan and the rationale here._

## Key Design Decisions

_Record key design decisions here._

## Reviewer Checkpoints

- Confirm task-22 has exactly one completion log and completed symbols were reread before edits.
- Confirm the closed terminal disposition is copy-safe/raw-free and the first winner survives cleanup and write acknowledgement races.
- Confirm timeout/budget/repetition/malformed/context/output/cancel rows cause no fallback, partial result, generic StreamGate admission, second ingress, later provider dispatch, or retained waiter.
- Confirm buffered and SSE mappings are identical and disconnect remains silent.
- Confirm `agent-contract/inner/execution-runtime.md` and Edge-Node wire/proto remain unchanged, while outer Anthropic contract and both current specs match the implementation.

## Verification Results

Paste actual stdout/stderr for every command. If output is too long, record the exact command and saved output path; summaries are insufficient.

### 1. Dependency gate

Command:

```sh
bash -c 'set -euo pipefail; shopt -s nullglob; candidates=(agent-task/m-iop-owned-single-request-agent-execution/22_*/complete.log agent-task/m-iop-owned-single-request-agent-execution/22+*/complete.log agent-task/archive/*/*/m-iop-owned-single-request-agent-execution/22_*/complete.log agent-task/archive/*/*/m-iop-owned-single-request-agent-execution/22+*/complete.log); printf "%s\n" "${candidates[@]}"; ((${#candidates[@]} == 1))'
```

Output:

_Fill with actual output._

### 2. S11 focused race matrix

Command:

```sh
go test -race ./apps/edge/internal/service ./apps/edge/internal/openai -run 'Test(SingleRequestTerminalDisposition|SingleRequestQualityGate|AnthropicSingleRequestErrorCancelMatrix|SingleRequestAnthropicStreamTerminalDisposition)' -count=1
```

Output:

_Fill with actual output._

### 3. Service compatibility race tests

Command:

```sh
go test -race ./apps/edge/internal/service -run 'TestSingleRequest(InternalToolLoop|Cleanup|Observation|EnvelopeOrdering|StageBudget)' -count=1
```

Output:

_Fill with actual output._

### 4. Edge vet and package regressions

Command:

```sh
go vet ./apps/edge/internal/service ./apps/edge/internal/openai && go test ./apps/edge/... -count=1
```

Output:

_Fill with actual output._

### 5. Approved SDD common suite

Command:

```sh
go test -race -count=1 ./packages/go/config ./packages/go/streamgate ./apps/edge/internal/openai ./apps/edge/internal/service ./apps/node/internal/node ./apps/node/internal/transport ./apps/node/internal/workspace
```

Output:

_Fill with actual output._

### 6. Protobuf reproducibility

Command:

```sh
make proto && git diff --exit-code -- proto/gen/iop
```

Output:

_Fill with actual output._

### 7. Contract/spec policy search

Command:

```sh
rg --sort path -n 'end_turn|max_tokens|invalid_request_error|api_error|disconnect|no second|second request|S11|error-cancel' agent-contract/outer/anthropic-compatible-api.md agent-spec/runtime/edge-node-execution.md agent-spec/input/openai-compatible-surface.md
```

Output:

_Fill with actual output._

### 8. Terminal symbol search

Command:

```sh
rg --sort path -n 'SingleRequestTerminal|SingleRequestResult|singleRequestAnthropic.*Policy' apps/edge/internal/service apps/edge/internal/openai --glob '*.go'
```

Output:

_Fill with actual output._

### 9. Diff hygiene

Command:

```sh
git diff --check
```

Output:

_Fill with actual output._

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as prior-loop context; read only the cited archive files when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |
