<!-- task=m-iop-owned-single-request-agent-execution/23+22_error_cancel plan=2 tag=API milestone-task=error-cancel -->

# Code Review Reference - API

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> Execute the plan's selected root cause, scope, files, and dependency decisions as written. Do not choose another owner, narrow/expand the write boundary, or replace a fix with another verification attempt.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-08-07
task=m-iop-owned-single-request-agent-execution/23+22_error_cancel, plan=2, tag=API

## Archive Evidence Snapshot

- Immediate prior plan: `agent-task/m-iop-owned-single-request-agent-execution/23+22_error_cancel/plan_cloud_G10_1.log`; immediate prior pristine review stub: `agent-task/m-iop-owned-single-request-agent-execution/23+22_error_cancel/code_review_cloud_G10_1.log`. The earlier semantic snapshot remains in the matching `_0.log` files.
- No implementation evidence or official verdict existed. Fresh source review found that the prior result-only DTO could not carry classified failure/cancel semantics because current failed/cancelled progress has no result.
- This replan preserves the corrected write boundary and S11 matrix, and requires one validated raw-free terminal candidate on envelope/result/progress for all terminal paths.

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G10.md` → `code_review_cloud_G10_2.log` and `PLAN-cloud-G10.md` → `plan_cloud_G10_2.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-iop-owned-single-request-agent-execution/23+22_error_cancel/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS, preserve the first-line `milestone-task=error-cancel` metadata in `complete.log` and report it for runtime aggregation. Roadmap evaluation belongs to `sync-milestone-workstate`.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| API-1 | [x] |
| API-2 | [x] |
| API-3 | [x] |
| API-4 | [x] |

## Implementation Checklist

- [x] Add a closed, copy-safe single-request terminal disposition on envelope/result/progress that distinguishes `end_turn`, `length`, sanitized error classes, and caller cancellation while preserving exactly-once cleanup/acknowledgement.
- [x] Classify provider/tool timeout, stage/request budgets, repetition/no-progress, malformed calls, context/output limits, and disconnect in the completed stage/composite path without retry, fallback, partial-success, generic StreamGate admission, or retained waiters.
- [x] Project the closed disposition consistently through buffered and SSE Anthropic responses and add the complete S11 one-ingress/one-terminal race matrix.
- [x] Synchronize the Anthropic outer contract and both matching current implementation specs with the implemented error/cancel/length policy.
- [x] Run dependency, focused race, compatibility, full SDD, proto, deterministic symbol/document, and diff verification freshly.
- [x] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [x] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [x] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [x] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G10_2.log`.
- [x] Archive active `PLAN-*-G??.md` to `plan_cloud_G10_2.log`.
- [x] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [ ] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [ ] If PASS, move active task directory `agent-task/m-iop-owned-single-request-agent-execution/23+22_error_cancel/` to `agent-task/archive/YYYY/MM/m-iop-owned-single-request-agent-execution/23+22_error_cancel/` and update this checklist at the final archive path.
- [ ] If PASS, preserve and report `milestone-task=error-cancel` for runtime aggregation, without modifying roadmap or directly calling `update-roadmap`.
- [ ] If PASS for split work, remove empty active parent only if no siblings/files remain.
- [x] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

- There was no implementation-scope deviation.
- Final Verification command 6 was run exactly and exited 1 because the inherited worktree already contains the task-17 `proto/iop/runtime.proto` and `proto/gen/iop/runtime.pb.go` artifact-wire changes relative to `HEAD`. This task did not edit the protobuf source or add a wire field. `make proto` reproduced the inherited generated file byte-for-byte: `proto/gen/iop/runtime.pb.go` was SHA-256 `5c9d6c580ecf9c9fba857787b5d2757757d7289b267b44074bf6c2108b4cc1a9` both before and after generation. The exact failed command output is preserved in `verification-6-protobuf.log`; the predecessor changes were not reverted, staged, or otherwise mutated to manufacture a clean `git diff` result.
- Commands 7 and 8 produced long deterministic search output, so their complete stdout and exit status are preserved in `verification-7-contract-spec.log` and `verification-8-terminal-symbols.log` as permitted by this review stub.

## Key Design Decisions

- The service owns a closed `SingleRequestTerminalDisposition` with four kinds and nine raw-free error classes. Envelope validation accepts classified failure/cancel candidates, final results carry success/length, and legacy zero-value results normalize only to `end_turn`.
- Terminal progress clones and freezes the first public disposition. Cleanup may convert an unpublished success/length to `error/workspace_cleanup`; acknowledgement failure or cancellation after freeze changes only internal completion and cannot publish a conflicting terminal.
- A provider/output limit may finalize `length` directly from Plan or Work, because the limit terminates that stage before the normal successor. The exception is terminal-kind-specific: `end_turn` still cannot skip the Plan -> Work -> Review lifecycle.
- Stage code returns a typed package-local failure containing only the closed disposition and a stable package sentinel. Raw provider, decoder, workspace, and tool errors are not retained by the terminal carrier.
- The request-local no-progress guard stores only fixed SHA-256 fingerprints of canonical tool action/result pairs, ignores correlation IDs and duration, and stops at the first repeated pair within the same stage. The existing coordinator remains the sole budget/lifecycle owner and the generic StreamGate is not involved.
- Buffered and SSE projectors share `singleRequestAnthropicPolicy`: `end_turn`, privacy-safe `max_tokens`, validation/context `invalid_request_error`, other failures `api_error`, and silent caller cancellation. Both projectors reject second-terminal writes.
- Existing observation labels were not widened. Rich terminal classes map back into the pre-existing bounded observation vocabulary, and the Edge-Node protobuf wire remains outside this task.

## Reviewer Checkpoints

- Confirm task-22 has exactly one completion log and completed symbols were reread before edits.
- Confirm the closed terminal disposition reaches finalizing, failed, and cancelled progress, is copy-safe/raw-free, allows only cleanup conversion before freeze, and survives post-freeze/write-acknowledgement races.
- Confirm timeout/budget/repetition/malformed/context/output/cancel rows cause no fallback, partial result, generic StreamGate admission, second ingress, later provider dispatch, or retained waiter.
- Confirm buffered and SSE mappings are identical and disconnect remains silent.
- Confirm `agent-contract/inner/execution-runtime.md` and Edge-Node wire/proto remain unchanged, while outer Anthropic contract and both current specs match the implementation.

## Verification Results

Paste actual stdout/stderr for every command. If output is too long, record the exact command and saved output path; summaries are insufficient.

### 1. Dependency gate

Command:

```sh
bash -c 'set -euo pipefail; shopt -s nullglob; candidates=(agent-task/m-iop-owned-single-request-agent-execution/22_*/complete.log agent-task/m-iop-owned-single-request-agent-execution/22+*/complete.log agent-task/archive/*/*/m-iop-owned-single-request-agent-execution/22_*/complete.log agent-task/archive/*/*/m-iop-owned-single-request-agent-execution/22+*/complete.log); printf "%s\n" "${candidates[@]}"; ((${#candidates[@]} == 1))'
```

Output:

```text
agent-task/archive/2026/08/m-iop-owned-single-request-agent-execution/22+21_executor_activation/complete.log
```

### 2. S11 focused race matrix

Command:

```sh
go test -race ./apps/edge/internal/service ./apps/edge/internal/openai -run 'Test(SingleRequestTerminalDisposition|SingleRequestQualityGate|AnthropicSingleRequestErrorCancelMatrix|SingleRequestAnthropicStreamTerminalDisposition)' -count=1
```

Output:

```text
ok  	iop/apps/edge/internal/service	1.049s
ok  	iop/apps/edge/internal/openai	1.088s
```

### 3. Service compatibility race tests

Command:

```sh
go test -race ./apps/edge/internal/service -run 'TestSingleRequest(InternalToolLoop|Cleanup|Observation|EnvelopeOrdering|StageBudget)' -count=1
```

Output:

```text
ok  	iop/apps/edge/internal/service	1.339s
```

### 4. Edge vet and package regressions

Command:

```sh
go vet ./apps/edge/internal/service ./apps/edge/internal/openai && go test ./apps/edge/... -count=1
```

Output:

```text
ok  	iop/apps/edge/cmd/edge	0.139s
ok  	iop/apps/edge/internal/authprojection	0.025s
ok  	iop/apps/edge/internal/bootstrap	0.448s
ok  	iop/apps/edge/internal/configrefresh	0.086s
ok  	iop/apps/edge/internal/controlplane	6.615s
ok  	iop/apps/edge/internal/edgecmd	0.095s
ok  	iop/apps/edge/internal/edgevalidate	0.057s
ok  	iop/apps/edge/internal/events	0.042s
ok  	iop/apps/edge/internal/input	0.086s
ok  	iop/apps/edge/internal/input/a2a	0.069s
ok  	iop/apps/edge/internal/node	0.058s
ok  	iop/apps/edge/internal/openai	8.168s
ok  	iop/apps/edge/internal/opsconsole	0.055s
ok  	iop/apps/edge/internal/service	6.513s
ok  	iop/apps/edge/internal/transport	4.788s
```

### 5. Approved SDD common suite

Command:

```sh
go test -race -count=1 ./packages/go/config ./packages/go/streamgate ./apps/edge/internal/openai ./apps/edge/internal/service ./apps/node/internal/node ./apps/node/internal/transport ./apps/node/internal/workspace
```

Output:

```text
ok  	iop/packages/go/config	1.806s
ok  	iop/packages/go/streamgate	1.939s
ok  	iop/apps/edge/internal/openai	12.215s
ok  	iop/apps/edge/internal/service	7.590s
ok  	iop/apps/node/internal/node	3.594s
ok  	iop/apps/node/internal/transport	6.615s
ok  	iop/apps/node/internal/workspace	5.790s
```

### 6. Protobuf reproducibility

Command:

```sh
make proto && git diff --exit-code -- proto/gen/iop
```

Output:

Full stdout/stderr and `exit=1` are saved at:

```text
agent-task/m-iop-owned-single-request-agent-execution/23+22_error_cancel/verification-6-protobuf.log
```

The command regenerated the inherited task-17 artifact-wire output without changing its bytes. Before and after SHA-256 for `proto/gen/iop/runtime.pb.go`:

```text
5c9d6c580ecf9c9fba857787b5d2757757d7289b267b44074bf6c2108b4cc1a9  proto/gen/iop/runtime.pb.go
```

### 7. Contract/spec policy search

Command:

```sh
rg --sort path -n 'end_turn|max_tokens|invalid_request_error|api_error|disconnect|no second|second request|S11|error-cancel' agent-contract/outer/anthropic-compatible-api.md agent-spec/runtime/edge-node-execution.md agent-spec/input/openai-compatible-surface.md
```

Output:

Full stdout and `exit=0` are saved at:

```text
agent-task/m-iop-owned-single-request-agent-execution/23+22_error_cancel/verification-7-contract-spec.log
```

### 8. Terminal symbol search

Command:

```sh
rg --sort path -n 'SingleRequestTerminal|SingleRequestResult|singleRequestAnthropic.*Policy' apps/edge/internal/service apps/edge/internal/openai --glob '*.go'
```

Output:

Full stdout and `exit=0` are saved at:

```text
agent-task/m-iop-owned-single-request-agent-execution/23+22_error_cancel/verification-8-terminal-symbols.log
```

### 9. Diff hygiene

Command:

```sh
git diff --check
```

Output:

```text
(no output; exit=0)
```

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as prior-loop context; read only the cited archive files when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |

## Code Review Result

- Overall Verdict: FAIL
- Dimension Assessment:
  - Correctness: Fail — three terminal classifications disagree with the closed S11 policy.
  - Completeness: Fail — the required request-budget and upstream-error matrix is incomplete.
  - Test coverage: Fail — focused regressions for live-context provider cancellation, generic upstream HTTP 400, and actual request wall-clock expiry are absent.
  - API contract: Fail — provider failures can be suppressed as caller cancellation or exposed as caller context errors, and request budget exhaustion is emitted as timeout.
  - Code quality: Pass — no task-scoped debug residue, dead code, or formatting defect was found.
  - Implementation deviation: Fail — the implemented classifications and evidence do not satisfy the plan's complete S11 terminal matrix.
  - Verification trust: Fail — fresh focused reproducers contradict the claimed complete matrix even though the submitted commands themselves ran as recorded.
  - Spec conformance: Fail — the S11 budget/error/cancel terminal distinctions are not preserved for the three cases below.
- Findings:
  - Required R1 — `apps/edge/internal/openai/single_request_quality_gate.go:72`, `apps/edge/internal/openai/single_request_quality_gate.go:116`, and the fallback at `apps/edge/internal/openai/single_request_executor.go:122` classify any raw `context.Canceled` error as caller cancellation even when the supplied request context is still live. A focused call to `providerFailure(context.Background(), context.Canceled, ...)` produced `{Kind:cancelled ErrorClass:}` instead of the required provider failure, which can silently suppress a real provider/internal error at the Anthropic surface. Classify cancellation only from an authoritatively cancelled request/stage context or an owned service cancellation sentinel; keep a raw `context.Canceled` from a live context in the provider/internal error class, and add buffered/SSE regression coverage proving it is not silently dropped.
  - Required R2 — `apps/edge/internal/openai/single_request_provider_stage.go:138` maps every upstream HTTP 400 response to `errProviderStageContextLimit`. A focused `RESPONSE_START` status-400 frame was classified as `{Kind:error ErrorClass:context}`, so an ordinary provider rejection is projected as caller-facing `invalid_request_error` rather than the contract's sanitized `api_error`. Reserve context-limit classification for deterministic context-limit evidence such as HTTP 413 or an explicit closed provider signal; keep generic 400 responses as provider failures and add a status matrix regression.
  - Required R3 — `apps/edge/internal/service/single_request.go:293` and `apps/edge/internal/service/single_request.go:772` handle expiry of the immutable request wall-clock context with `singleRequestErrorClassTimeout`; `apps/edge/internal/openai/single_request_executor.go:76` can also race the service owner by submitting a stage timeout after its parent request context expires. A focused request with `WallClockMS=10` and a blocked executor produced `{Kind:error ErrorClass:timeout}` instead of `{Kind:error ErrorClass:budget}`. Make the service the sole owner of parent request-context termination, emit the closed budget class for request wall-clock exhaustion, and add a real request-budget regression that proves exactly one terminal outcome, no later provider/tool work, and no retained waiter while preserving an independently expired stage/provider timeout as `timeout`.
- Routing Signals:
  - `review_rework_count=1`
  - `evidence_integrity_failure=true`
- Next Step: Prepare and implement a `REVIEW_API` follow-up plan for Required R1, R2, and R3; do not write `complete.log`.
