<!-- task=m-iop-owned-single-request-agent-execution/25+23,24_claude_smoke_qualification plan=28 tag=REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_API milestone-task=workspace-binding,claude-smoke -->

# Code Review Reference - Gemini thought-signature boundary and eleventh qualification

## Overview

date=2026-08-08
task=m-iop-owned-single-request-agent-execution/25+23,24_claude_smoke_qualification, plan=28

## Archive Evidence Snapshot

- Prior pair: `plan_cloud_G10_27.log` / `code_review_cloud_G10_27.log`; verdict `FAIL`, Required R28/R29.
- Ten prior guards are immutable; the tenth evidence proves one ingress and one Gemini tunnel before Plan malformed rejection.

## Implementation Item Completion

| Item | Status |
|---|---|
| signature-envelope | [x] |
| private-replay | [x] |
| local-remote-validation | [x] |
| eleventh-call | [x] |
| publication | [x] |

## Implementation Checklist

- [x] Add and test exact Gemini signature admission, discard, and Review-only replay.
- [x] Pass local/remote ordinary/race/harness/diff checks.
- [x] Rebuild/restart managed Edge and refresh readiness evidence.
- [x] Execute/finalize exactly one eleventh guard with no retry.
- [x] Publish only complete S12 success evidence; the failed run published no partial artifact or manifest.
- [x] Fill implementation fields and stop for official review.

## Review-Only Checklist

- [x] Append one verdict and routing signals.
- [x] Verify R28/R29, signature privacy/replay, cardinality, and S12 publication.
- [x] Archive and materialize next state.

## Deviations from Plan

- The first certificate refresh attempt stopped before mutation because non-interactive SSH did not include Go in `PATH`; the retry used the declared `/opt/homebrew/bin/go`. The first two readiness attempts also stopped before any request because SOPS already returned a raw scalar and a zero Claude-process count made a `pipefail` pipeline non-zero. Fixed-format checks proved ingress `0`, provider tunnels `6`, zero started guards, and no output remained throughout.
- The regenerated disposable two-hour CA and three leaf certificates required restarting the isolated Control Plane, Edge, and Node. Seven `.pre-plan28-cert` backups remain; the canonical dev checkout and processes were not mutated.
- `sole-live-11` passed Gemini Plan after the thought-signature repair, then failed Work because the managed Mac Node received `no route to host` for the declared RTX5090 Ornith endpoint. The call was not retried. Subsequent independent status showed the RTX stack ready, and Mac health/model probes returned HTTP 200 with the expected Ornith model.

## Key Design Decisions

- Admit only `extra_content.google.thought_signature` with exact nested typed decoding. Null, empty/whitespace, wrong-type, unknown, and duplicate nested members fail closed.
- Discard Plan and terminal Review signatures. Retain a Review tool-call signature only in request-local memory and replay it beside the originating tool call in the immediately resumed Gemini request; Work remains Google-extension-free.
- Keep private provider metadata out of artifacts, final output, tool results, and structured observations through exact result/body assertions and sentinel-based tests.
- Treat `sole-live-11.rc-69` as immutable evidence. The closed diagnostics retain only fixed failure classification and structured counts; raw provider/model content was deleted by the redaction wrapper.

## Verification Results

- Local implementation validation: OpenAI ordinary `8.347s`, service ordinary `8.204s`; harness self-test passed; artifact lifecycle race x10 passed `1.522s`; focused race passed OpenAI `1.907s`, service `3.366s`; scoped diff check passed.
- Isolated dev validation: OpenAI ordinary `8.812s`, service ordinary `9.128s`; artifact lifecycle race x10 passed `2.018s`; focused race passed OpenAI `2.633s`, service `3.630s`; remote diff and harness self-test passed.
- Managed Edge rebuilt as `sha256:40710518141435208027d0e88d5b3812fb4d074401ab21b7fbe333f50f5fe250`; config check and runtime-evidence binding passed. Disposable TLS was regenerated with leaf validity through `2026-08-08T13:49:48Z`; Control Plane, Edge, and Node restarted as PIDs `35448`, `35464`, and `35476` and reconnected.
- Provider-free readiness passed: supported count-token beta HTTP 200, unsupported beta HTTP 400, ingress `0 -> 0`, provider tunnels `6 -> 6`, Claude processes `0 -> 0`, ten finalized guards, zero started guards, and no result/manifest.
- Eleventh execution: one harness invocation only; guard `sole-live-11.rc-69`; ingress `0 -> 1`; provider tunnels `6 -> 8`; Claude processes `0 -> 0`; request success 1, Plan success 1, Work provider error 1, cleanup success 1, terminal provider error 1; no workspace result or manifest.
- Fresh official-review checks passed: `git diff --check`; focused OpenAI tests `0.320s`; focused service tests `2.124s`. RTX5090 `Status` reports ready/healthy/exact profile/listener/Edge connection, and current Mac probes return HTTP 200 for health and `/v1/models` with the expected Ornith model.

## Code Review Result

### Overall Verdict

FAIL

### Dimension Assessment

| Dimension | Assessment | Evidence |
|---|---|---|
| Correctness | Pass | The exact Gemini thought-signature codec, discard boundary, and Review-only replay are implemented and the real Plan stage now succeeds. |
| Completeness | Fail | Work did not complete, so Review, verified workspace output, successful terminal, and the S12 manifest remain absent. |
| Test coverage | Pass | Local/remote ordinary, race, harness, exact nested negative, resumed-body, leakage, and fresh focused reviewer tests pass. |
| API contract | Pass | The implementation follows the documented Gemini OpenAI-compatible thought-signature shape without extending Work or public artifacts. |
| Code quality | Pass | Provider-private state is narrowly typed, request-local, and absent from public/durable surfaces. |
| Implementation deviation | Pass | TLS/readiness corrections were provider-free and bounded; the one live invocation was not retried. |
| Verification trust | Pass | Guard, ingress, tunnel, process, structured observation, artifact absence, RTX status, and current health/model probes agree. |
| Spec conformance | Fail | SDD S12 still requires ordered successful Plan/Work/Review, verified workspace mutation, terminal success, and one schema-valid manifest. |

### Findings

- Required R29 — S12 success evidence is still missing. `sole-live-11` proves the Gemini Plan compatibility repair but closes with a Work provider error because the Mac-to-RTX5090 route returned `no route to host`. Before one new non-retriable guard, require current RTX `Status` readiness plus Mac HTTP 200 health and exact Ornith `/v1/models` admission in the same immediate preflight; then execute Claude only through the isolated IOP endpoint and publish only a complete schema-valid manifest.

### Routing Signals

- `evaluation_mode=isolated-reassessment`
- `verdict=FAIL`
- `review_rework_count=27`
- `evidence_integrity_failure=false`
- `next_state=plan`
- `finalizer=finalize-task-policy.sh`
- `finalizer_mode=pair`
- build route `worker/cloud/G10`; review route `review/cloud/G10`

### Next Step

- Invoke the plan skill with Required R29 and the changed external precondition; route and materialize one follow-up pair before archiving this pair.
