<!-- task=m-iop-hot-path-one-shot-execution/17+15,16_hot_smoke plan=0 tag=TEST milestone-task=hot-smoke -->

# Code Review Reference - TEST

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If blocked, record exact preflight output and resume condition only.
> Do not ask the user, call user-input tools, classify the next state, archive files, or write `complete.log`.
> Finalization is review-agent-only.

## Overview

date=2026-08-03
task=m-iop-hot-path-one-shot-execution/17+15,16_hot_smoke, plan=0, tag=TEST

## For the Review Agent

> **[REVIEW AGENT ONLY]** Compare implementation/output against the plan. Exit 69 or absent actual Claude/Pi evidence cannot PASS S16. Implementers must not finalize.

1. Append verdict and routing signals.
2. Archive `CODE_REVIEW-cloud-G08.md` → `code_review_cloud_G08_0.log` and `PLAN-local-G08.md` → `plan_local_G08_0.log`.
3. If PASS, write `complete.log` and move to `agent-task/archive/YYYY/MM/m-iop-hot-path-one-shot-execution/17+15,16_hot_smoke/`; otherwise write the directed next state.
4. Preserve/report `milestone-task=hot-smoke` on PASS.
5. Complete the review-only checklist at the final location.

## Implementation Item Completion

| Item | Status |
|---|---|
| TEST-1 Agent smoke harness | [ ] |
| TEST-2 Make integration and actual evidence | [ ] |

## Implementation Checklist

- [ ] [TEST-1] Add a secret-safe Claude/Pi Hot Path harness with deterministic preflight, scenario matrix, raw-free manifest, workspace before/after, and credential-free self-test.
- [ ] [TEST-2] Add separate self-test, external-preflight, and actual Make targets; run local/common verification, then run the actual two-protocol smoke or record the exact external blocker and resume command.
- [ ] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

- [ ] Append one PASS/WARN/FAIL verdict and verified routing signals.
- [ ] Verify verdict, dimensions, and finding classifications match.
- [ ] Archive `CODE_REVIEW-cloud-G08.md` to `code_review_cloud_G08_0.log`.
- [ ] Archive `PLAN-local-G08.md` to `plan_local_G08_0.log`.
- [ ] Verify the `.gitignore` managed block.
- [ ] On PASS write standard `complete.log` and leave no active `.md` files.
- [ ] On PASS move the task directory to dated archive and update this checklist there.
- [ ] On PASS preserve/report `milestone-task=hot-smoke` without editing roadmap directly.
- [ ] Remove active parent only if empty.
- [ ] On WARN/FAIL write the next state and no `complete.log`.

## Deviations from Plan

_Implementer records actual deviations or `none`._

## Key Design Decisions

_Implementer records actual decisions._

## Reviewer Checkpoints

- Verify self-test cannot substitute for the required actual Claude/Pi 10-case run.
- Verify runtime/model/CLI/workspace preflight, child-only cancellation, workspace before/after and artifact cleanup/orphan evidence.
- Verify matching source fingerprint, runtime binary/config/fixture evidence, four deterministic scenario aliases, and request-correlated observation log input.
- Inspect manifest/logs for native visible events and zero raw secret matches; verify no shared process/config was mutated.

## Verification Results

### Local syntax/self-test/preflight

Commands:

```bash
bash -n scripts/e2e-hot-path-agents.sh
./scripts/e2e-hot-path-agents.sh --self-test
make test-hot-path-agent-smoke-self-test
```

_Paste actual stdout/stderr and exit status for each._

### SDD common

Command: `go test -race -count=1 ./packages/go/streamgate ./packages/go/config ./apps/edge/internal/openai ./apps/edge/internal/service`

_Paste actual stdout/stderr and exit status._

### External actual smoke

Commands:

```bash
test -n "${IOP_HOT_SMOKE_BASE_URL:-}" && test -n "${IOP_HOT_SMOKE_DIRECT_MODEL:-}" && test -n "${IOP_HOT_SMOKE_PASS_MODEL:-}" && test -n "${IOP_HOT_SMOKE_REPAIR_MODEL:-}" && test -n "${IOP_HOT_SMOKE_SLOW_MODEL:-}" && test -n "${IOP_HOT_SMOKE_PI_PROVIDER:-}" && test -n "${PI_CODING_AGENT_DIR:-}" && test -n "${ANTHROPIC_API_KEY:-}" && test -n "${IOP_HOT_SMOKE_RUNTIME_EVIDENCE:-}" && test -n "${IOP_HOT_SMOKE_OBSERVATION_FILE:-}" && test -n "${IOP_HOT_SMOKE_WORKSPACE_PARENT:-}" && test -n "${IOP_HOT_SMOKE_OUTPUT:-}"
IOP_HOT_SMOKE_SOURCE_FINGERPRINT="$(git ls-files --cached --others --exclude-standard -- apps/edge packages/go/streamgate packages/go/config go.mod go.sum | LC_ALL=C sort | while IFS= read -r path; do printf '%s\0%s\n' "$path" "$(git hash-object --no-filters "$path")"; done | git hash-object --stdin)"
export IOP_HOT_SMOKE_SOURCE_FINGERPRINT
jq -e --arg fingerprint "$IOP_HOT_SMOKE_SOURCE_FINGERPRINT" '.source_fingerprint == $fingerprint and (.binary_sha256 | type == "string" and length > 0) and (.config_sha256 | type == "string" and length > 0) and (.fixture_revision | type == "string" and length > 0)' "${IOP_HOT_SMOKE_RUNTIME_EVIDENCE}"
make test-hot-path-agent-smoke-preflight
make test-hot-path-agent-smoke
jq -e '.schema_version == 1 and (.cases | length == 10) and all(.cases[]; .verdict == "pass") and (.redaction.secret_matches == 0)' "${IOP_HOT_SMOKE_OUTPUT}"
```

_Paste actual output and manifest path. Exit 69 is blocker evidence, not PASS._

### Diff

Command: `git diff --check`

_Paste actual stdout/stderr and exit status._

---

> **[IMPLEMENTING AGENT — BEFORE SAVING]** Fill every implementation-owned section and leave review-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---|---|---|
| Header, Overview, Review Agent Instructions | Fixed | Implementer must not modify or finalize |
| Implementation Item Completion, Implementation Checklist | Implementer checks only | Text/order stays fixed |
| Review-Only Checklist | Review agent | Implementer must not modify |
| Deviations, Key Design Decisions | Implementer | Record actual content |
| Reviewer Checkpoints | Fixed | Reviewer verifies |
| Verification Results | Implementer fills output | Command changes require deviation |
| Code Review Result | Review agent appends | Not included in stub |
