<!-- task=m-iop-hot-path-one-shot-execution/20+17,19_smoke_harness plan=11 tag=REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_TEST milestone-task=hot-smoke -->

# Code Review Reference - REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_TEST

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-08-05
task=m-iop-hot-path-one-shot-execution/20+17,19_smoke_harness, plan=11, tag=REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_TEST

## Archive Evidence Snapshot

- The current pair will archive as `agent-task/m-iop-hot-path-one-shot-execution/20+17,19_smoke_harness/plan_cloud_G03_10.log` and `agent-task/m-iop-hot-path-one-shot-execution/20+17,19_smoke_harness/code_review_cloud_G03_10.log`.
- The current review verdict is `FAIL` with two Required findings, zero Suggested findings, and zero Nits.
- Fresh verification: `bash -n`, the fixed-schema `jq` assertion, `./scripts/e2e-hot-path-agents.sh --self-test`, and `git diff --check` exit 0. The SDD common regression exits 1 because `packages/go/config` and `apps/edge/internal/openai` do not compile.
- `review_rework_count=9`; `evidence_integrity_failure=true` because the active review's exact compiler output and cited `Server`-field blocker do not match the current source and fresh output.
- The contribution remains `milestone-task=hot-smoke`; the SDD contribution is S16. This deterministic harness task does not claim the separate credentialed Claude/Pi streaming evidence.

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G03.md` → `code_review_cloud_G03_11.log` and `PLAN-cloud-G03.md` → `plan_cloud_G03_11.log`.
3. If PASS, write `complete.log` and move the active task directory to `agent-task/archive/YYYY/MM/m-iop-hot-path-one-shot-execution/20+17,19_smoke_harness/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and task group is `m-<milestone-slug>`, preserve the first-line `milestone-task` metadata in `complete.log` and report it for runtime aggregation. Roadmap state evaluation belongs to `sync-milestone-workstate`.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

## Implementation Item Completion

| Item | Status |
|------|---------|
| REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_TEST-1 Mandatory integrated verification | [ ] |
| Fill implementation-owned sections in CODE_REVIEW-*-G??.md | [ ] |

## Implementation Checklist

- [ ] [REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_TEST-1] Rerun the unchanged fail-closed harness and the SDD common regression from one current checkout, replacing the stale blocker transcript with exact output.
- [ ] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [ ] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [ ] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [ ] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G03_11.log`.
- [ ] Archive active `PLAN-*-G??.md` to `plan_cloud_G03_11.log`.
- [ ] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [ ] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [ ] If PASS, move active task directory `agent-task/m-iop-hot-path-one-shot-execution/20+17,19_smoke_harness/` to `agent-task/archive/YYYY/MM/m-iop-hot-path-one-shot-execution/20+17,19_smoke_harness/` and update this checklist at the final archive path.
- [ ] If PASS and task group is `m-<milestone-slug>`, preserve and report `milestone-task` metadata for runtime aggregation, without modifying roadmap or directly calling `update-roadmap`.
- [ ] If PASS for split work, remove empty active parent `agent-task/m-iop-hot-path-one-shot-execution/` or verify it was kept due to remaining siblings/files.
- [ ] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

_Record the exact current-checkout blocker, attempted commands, output, and resume condition. Do not edit shared production/config/test source._

## Key Design Decisions

_Record that this follow-up is verification-only and preserves the ownership boundary._

## Reviewer Checkpoints

- Confirm the implementing agent did not change the harness, schema, production Edge/Node, config, protocol, Makefile, deployment, credential, or tracked smoke-output files.
- Confirm all five Final Verification commands ran from the same checkout with fresh output; the common compiler failure is blocker evidence, not PASS evidence.
- Confirm the next transcript reflects current source, including the current `Server` fields at `server.go:72-74,109-111`, rather than the stale prior diagnosis.
- Confirm PASS, if reached, preserves `milestone-task=hot-smoke` only as contribution metadata and does not claim the downstream credentialed S16 run.

## Verification Results

Paste actual stdout/stderr and exit status for every command below. Do not summarize or reconstruct output. Run all commands from `/config/workspace/iop-s0`.

### Harness syntax

Command: `bash -n scripts/e2e-hot-path-agents.sh`

~~~text
<implementer: paste exact stdout/stderr and exit status>
~~~

### Fixed manifest schema

Command: `jq -e '(.properties.cases.prefixItems | length) == 10 and .properties.cases.items == false and ([.properties.cases.prefixItems[].properties.id.const] | length == 10) and ([.properties.cases.prefixItems[].properties.id.const] | unique | length == 10)' scripts/fixtures/hot-path-agent-smoke-manifest.schema.json`

~~~text
<implementer: paste exact stdout/stderr and exit status>
~~~

### Credential-free behavioral oracle

Command: `./scripts/e2e-hot-path-agents.sh --self-test`

~~~text
<implementer: paste exact stdout/stderr and exit status>
~~~

### SDD common regression

Command: `go test -race -count=1 ./packages/go/streamgate ./packages/go/config ./apps/edge/internal/openai ./apps/edge/internal/service`

~~~text
<implementer: paste exact stdout/stderr and exit status>
~~~

### Diff integrity

Command: `git diff --check`

~~~text
<implementer: paste exact stdout/stderr and exit status>
~~~

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |
