<!-- task=m-iop-agent-cli-runtime/20+13,17_project_log_journal plan=4 tag=REVIEW_API -->

# Code Review Reference - REVIEW_API

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-07-30
task=m-iop-agent-cli-runtime/20+13,17_project_log_journal, plan=4, tag=REVIEW_API

## Archive Evidence Snapshot

- Prior task: `agent-task/m-iop-agent-cli-runtime/20+13,17_project_log_journal`
- Predicted current-loop evidence: `agent-task/m-iop-agent-cli-runtime/20+13,17_project_log_journal/plan_cloud_G09_3.log` and `agent-task/m-iop-agent-cli-runtime/20+13,17_project_log_journal/code_review_cloud_G09_3.log`
- Verdict: FAIL
- Findings: one Required finding for checksum-consistent malformed JSONL escaping typed archive-conflict classification; no Suggested or Nit findings
- Affected files: `apps/agent/internal/projectlog/store.go`, `apps/agent/internal/projectlog/store_test.go`
- Verification evidence: all declared focused, package, race, vet, formatting, and diff commands passed; a reviewer-only focused reproducer returned `projectlog: decode jsonl: ...` and failed `errors.Is(err, ErrArchiveConflict)`
- Roadmap carryover: this remains an S12 `project-logs` journal subset and does not claim the Milestone Task on PASS; EventSink mapping, WORK_LOG projection, and the complete dynamic frontier remain in later children

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G05.md` → `code_review_cloud_G05_4.log` and `PLAN-cloud-G05.md` → `plan_cloud_G05_4.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-iop-agent-cli-runtime/20+13,17_project_log_journal/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and task group is `m-<milestone-slug>`, report completion event metadata. Roadmap state check and `update-roadmap` calls are runtime responsibilities.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| REVIEW_API-1 Typed malformed-JSONL conflict | [x] |

## Implementation Checklist

- [x] Wrap checksum-admitted malformed JSONL decode failures with `ErrArchiveConflict` while retaining decoder detail, and add deterministic Archive/Reconcile no-mutation regressions.
- [x] Run fresh focused, package, race, vet, formatting, and diff verification.
- [x] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [x] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [x] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [x] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G05_4.log`.
- [x] Archive active `PLAN-*-G??.md` to `plan_cloud_G05_4.log`.
- [x] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [x] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [x] If PASS, move active task directory `agent-task/m-iop-agent-cli-runtime/20+13,17_project_log_journal/` to `agent-task/archive/YYYY/MM/m-iop-agent-cli-runtime/20+13,17_project_log_journal/` and update this checklist at the final archive path.
- [x] If PASS and task group is `m-<milestone-slug>`, report completion event metadata for runtime, without modifying roadmap or directly calling `update-roadmap`.
- [x] If PASS for split work, remove empty active parent `agent-task/m-iop-agent-cli-runtime/` or verify it was kept due to remaining siblings/files.
- [ ] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

None.

## Key Design Decisions

Wrapped `decodeJSONL` failures with `ErrArchiveConflict` while retaining underlying decode error details via `fmt.Errorf("%w: decode jsonl: %v", ErrArchiveConflict, err)`. This ensures that checksum-admitted malformed JSONL payloads fail with typed `ErrArchiveConflict` in both `Archive` and `Reconcile`, preventing unclassified decode errors while preserving full error context and retaining evidence byte-for-byte.

## Reviewer Checkpoints

- Checksum-admitted syntactically malformed JSONL returns typed `ErrArchiveConflict` from both Archive and Reconcile while retaining decoder detail.
- Archive and Reconcile leave all four artifact bytes plus the exact journal payload/revision unchanged on this corruption path.
- Fresh focused, package, race, vet, formatting, and diff evidence matches the implementation.

## Verification Results

> Run every command exactly as written. Paste actual stdout/stderr and exit status below its command. Any replacement command requires an entry in `Deviations from Plan`.

### REVIEW_API-1 Typed Malformed-JSONL Conflict

```bash
go test -count=1 ./apps/agent/internal/projectlog -run 'Test(Archive|Reconcile)RejectsMalformedJSONLWithMatchingIntentChecksum'
```

```text
ok  	iop/apps/agent/internal/projectlog	0.074s
```

### Final Verification

```bash
gofmt -w apps/agent/internal/projectlog/store.go apps/agent/internal/projectlog/store_test.go
go test -count=1 ./apps/agent/internal/projectlog -run 'TestStore|TestArchive|TestReconcile'
go test -count=1 ./apps/agent/internal/projectlog
go test -count=1 -race ./apps/agent/internal/projectlog ./packages/go/agentstate
go vet ./apps/agent/internal/projectlog
test -z "$(gofmt -d apps/agent/internal/projectlog/store.go apps/agent/internal/projectlog/store_test.go)"
git diff --check
```

```text
$ gofmt -w apps/agent/internal/projectlog/store.go apps/agent/internal/projectlog/store_test.go
(exit status 0)

$ go test -count=1 ./apps/agent/internal/projectlog -run 'TestStore|TestArchive|TestReconcile'
ok  	iop/apps/agent/internal/projectlog	0.538s

$ go test -count=1 ./apps/agent/internal/projectlog
ok  	iop/apps/agent/internal/projectlog	0.690s

$ go test -count=1 -race ./apps/agent/internal/projectlog ./packages/go/agentstate
ok  	iop/apps/agent/internal/projectlog	2.087s
ok  	iop/packages/go/agentstate	1.074s

$ go vet ./apps/agent/internal/projectlog
(exit status 0)

$ test -z "$(gofmt -d apps/agent/internal/projectlog/store.go apps/agent/internal/projectlog/store_test.go)"
(exit status 0)

$ git diff --check
(exit status 0)
```

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Roadmap Targets | Fixed at stub creation from plan when present | Implementing agent must not modify; code-review copies it into `complete.log` as `Roadmap Completion` only on PASS |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |

## Code Review Result

- Overall Verdict: PASS
- Dimension Assessment:
  - Correctness: Pass
  - Completeness: Pass
  - Test Coverage: Pass
  - API Contract: Pass
  - Code Quality: Pass
  - Implementation Deviation: Pass
  - Verification Trust: Pass
  - Spec Conformance: Pass
- Findings: None.
- Routing Signals:
  - review_rework_count=4
  - evidence_integrity_failure=false
- Next Step: Write the terminal completion record, archive the active pair and task directory, and emit the milestone-linked runtime completion metadata without changing the roadmap.
