<!-- task=m-iop-owned-single-request-agent-execution/25+23,24_claude_smoke_qualification plan=24 tag=REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_API milestone-task=workspace-binding,claude-smoke -->

# Code Review Reference - Seventh guarded Claude-through-IOP execution

> **[IMPLEMENTING AGENT — READ FIRST]** Execute exactly one authorized seventh live call after fresh provider-free readiness, fill every implementation-owned section, and stop. Never retry, append a verdict, archive files, or infer success from partial evidence.

## Overview

date=2026-08-08
task=m-iop-owned-single-request-agent-execution/25+23,24_claude_smoke_qualification, plan=24, tag=REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_REVIEW_API

## Archive Evidence Snapshot

- Prior pair: `plan_cloud_G10_23.log` / `code_review_cloud_G10_23.log`; verdict `FAIL`, Required R18.
- Resolved external stop: `user_review_9.log`; exactly one seventh guarded execution is authorized with no retry.
- Six prior guards are immutable; disposable CP/Edge/Node are `47248/81305/47260` at plan start.

## For the Review Agent

Verify readiness preceded guard creation, exactly one seventh call occurred, child retry zero was active, privacy/cardinality are closed, and publication matches the terminal outcome. Append one verdict and materialize its required next state.

## Implementation Item Completion

| Item | Status |
|---|---|
| readiness | [x] |
| sole-call | [x] |
| cardinality | [x] |
| publication | [x] |

## Implementation Checklist

- [x] Reconfirm exact runtime identity, certificate, catalog, frozen/unsupported count-token shapes, preflight, zero ingress/process, six finalized guards, and absent artifacts.
- [x] Atomically create only `sole-live-7.started` after every readiness gate passes.
- [x] Run the Claude-through-IOP harness exactly once with fresh config, child retry zero, and in-memory SOPS caller; never retry.
- [x] Finalize the guard as `sole-live-7.rc-N` and capture only closed result/cardinality evidence.
- [x] Publish manifest and success-only owners only on complete S12 PASS; otherwise leave them untouched.
- [x] Fill implementation-owned review sections and stop for official review.

## Review-Only Checklist

- [ ] Append one verdict and verified routing signals.
- [ ] Verify repaired child scope, sole-call evidence, S12 output, privacy, and no-retry cardinality.
- [ ] Archive the active pair and materialize the verdict's next state.

## Deviations from Plan

- The seventh invocation returned before accepted ingress. The durable guard was finalized as `sole-live-7.rc-69`; no retry or success publication occurred.
- Post-run review found that the wrapper supplied `runtime/edge.log`, which is process stdout, while the configured structured service logger writes `runtime/edge-runtime.log`. The harness accepted the regular but semantically incompatible file, so the seventh failure boundary was not retained in its observation snapshot.

## Key Design Decisions

- Treat the seventh guard as consumed even though ingress remained zero. A failed invocation is never reusable.
- Do not infer a provider, stage, or request rejection from the generic Claude `api-error`: the correct structured log has no event in the seventh time window and the raw CLI capture was deleted by the bounded harness cleanup.
- Leave all S12 success-only owners untouched. The user's later task-scoped authorization permits continued guarded IOP execution, but only after the observation source and expiring disposable TLS are repaired and provider-free readiness passes again.

## Verification Results

- Fresh readiness passed before guard creation: catalog `200`, frozen count-token `200`, unsupported neighbor `400`, ingress `0 -> 0`, provider/stage delta `0`, six finalized guards, zero Claude processes, and absent result/manifest.
- Exactly one harness `--run` was invoked with a fresh config, in-memory SOPS caller, `CLAUDE_CODE_DISABLE_EXPERIMENTAL_BETAS=1`, and child `CLAUDE_CODE_MAX_RETRIES=0`. It returned status 1 / closed class `api-rejected` / reason `api-error`; wrapper exit was 69.
- `sole-live-7.started` was atomically finalized as `sole-live-7.rc-69`. Invocation count was 1, wrapper retry count 0, ingress remained `0 -> 0`, provider-tunnel delta remained 0, Claude process count returned `0 -> 0`, and no workspace result or manifest exists.
- The real structured log is `runtime/edge-runtime.log`; it has no record in the seventh window. `runtime/edge.log` stopped at the fleet restart and contains only process/Fx output. A provider-free invalid-caller Claude probe with the same executable, fresh config, managed CA, and IOP base reached the expected 401 in 1.6 seconds, proving the current executable/config/TLS route can reach IOP without provider generation.

---

> Implementer: fill every implementation-owned field, then stop for official review.

## Code Review Result

### Overall Verdict

FAIL

### Dimension Assessment

| Dimension | Assessment | Evidence |
|---|---|---|
| Correctness | Fail | The seventh invocation ended before accepted ingress and produced no S12 execution. |
| Completeness | Fail | No ordered stage sequence, workspace result, terminal, or manifest exists. |
| Test coverage | Fail | Readiness/cardinality are closed, but the harness accepted the wrong observation stream and therefore did not preserve the live failure boundary. |
| API contract | Pass | No partial evidence was promoted and no success-only owner was changed. |
| Code quality | Fail | `--observation-file` validates only file shape, not that it is the structured Edge service log required by manifest construction. |
| Implementation deviation | Pass | The failed call was closed as a consumed guard with no retry or publication. |
| Verification trust | Fail | Guard/process/ingress evidence agrees, but the selected observation file cannot support event-level conclusions. |
| Spec conformance | Fail | SDD S12 still requires ingress exactly 1 and the full Gemini -> Ornith-fast -> Gemini path with verified output and one terminal. |

### Findings

- Required R19 — `scripts/e2e-single-request-claude.sh:849`: require the observation source to contain bounded structured Edge events before snapshotting, reject process stdout such as `edge.log`, add a negative self-test, and use `runtime/edge-runtime.log` for the disposable runtime. Preserve prefix/identity rotation checks.
- Required R20 — `scripts/e2e-single-request-claude.sh:841`: the disposable leaf expires at `2026-08-08 10:51:48 UTC`, too close for another multi-stage call. Refresh only the disposable managed TLS with recoverable backups, restart/reconnect the managed fleet, refresh runtime identity if necessary, and require a sufficient validity margin before another guard.
- Required R21 — `scripts/e2e-single-request-claude.sh:833`: generic Claude connection/TLS failures collapse into `api-rejected/api-error`. Add closed `connection-error` and `tls-certificate` classifications with redaction-preserving self-tests so a pre-ingress failure remains actionable without retaining raw model/CLI output.
- Required R22 — `agent-roadmap/sdd/knowledge-tool-optimization-extension/iop-owned-single-request-agent-execution/SDD.md:119`: after R19-R21 and all provider-free gates pass, use the user's explicit task-scoped authorization to create a distinct `sole-live-8` guard and perform one new Claude-through-IOP harness invocation. No direct provider call or automatic retry; publish only complete schema-valid S12 evidence.

### Routing Signals

- `evaluation_mode=isolated-reassessment`
- `verdict=FAIL`
- `review_rework_count=23`
- `evidence_integrity_failure=true`
- `next_state=plan`
- `finalizer=finalize-task-policy.sh`
- `finalizer_mode=pair`
- build route `worker/cloud/G10`; review route `review/cloud/G10`
