<!-- task=m-iop-hot-path-one-shot-execution/05+02,04_request_coordinator plan=5 tag=REVIEW_API milestone-task=request-identity -->

# Code Review Reference - REVIEW_API

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-08-03
task=m-iop-hot-path-one-shot-execution/05+02,04_request_coordinator, plan=5, tag=REVIEW_API

## Archive Evidence Snapshot

- Closing pair: `agent-task/m-iop-hot-path-one-shot-execution/05+02,04_request_coordinator/plan_cloud_G06_4.log` and `agent-task/m-iop-hot-path-one-shot-execution/05+02,04_request_coordinator/code_review_cloud_G06_4.log`; verdict `FAIL`.
- Required finding: validate every committed Chat and Anthropic turn, including historical issued-ID uniqueness, tool-call/result pairing, and supported Anthropic content blocks, before hashing the prefix or committed lineage.
- Fresh evidence: every planned dependency, focused, race, vet, format, and diff command passed, but one reviewer-only test showed acceptance of duplicate historical issued IDs for both endpoints, an orphan historical Chat tool result, and an unknown historical Anthropic assistant block. The temporary test was removed after capture.
- Dependencies: `agent-task/archive/2026/08/m-iop-hot-path-one-shot-execution/02+01_preset_generation/complete.log` and `agent-task/archive/2026/08/m-iop-hot-path-one-shot-execution/04+02,03_preset_model_authorization/complete.log` are the exact completed predecessors.
- Roadmap carryover: `milestone-task=request-identity`; approved SDD scenario S05 and its Evidence Map remain the acceptance source.

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G05.md` → `code_review_cloud_G05_5.log` and `PLAN-cloud-G05.md` → `plan_cloud_G05_5.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-iop-hot-path-one-shot-execution/05+02,04_request_coordinator/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and task group is `m-<milestone-slug>`, preserve the first-line `milestone-task` metadata in `complete.log` and report it for the runtime aggregation event. Roadmap state evaluation belongs to `sync-milestone-workstate`.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| REVIEW_API-1 Validate complete Chat tool history | [x] |
| REVIEW_API-2 Validate complete Anthropic tool history | [x] |

## Implementation Checklist

- [x] Validate every Chat assistant tool-call/result turn before hashing, reject duplicate or replayed issued IDs and orphan/partial/duplicate/unknown tool results throughout committed history, and add valid plus malformed multi-turn regression coverage.
- [x] Decode and validate every Anthropic message block before hashing, reject duplicate or replayed tool-use IDs and mismatched/partial/duplicate/unsupported tool-result turns throughout committed history, and add valid plus malformed multi-turn regression coverage.
- [x] Run archived dependency, focused, common race including config, vet, formatting, and diff verification exactly as written.
- [x] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [x] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [x] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [x] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G05_5.log`.
- [x] Archive active `PLAN-*-G??.md` to `plan_cloud_G05_5.log`.
- [x] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [x] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [x] If PASS, move active task directory `agent-task/m-iop-hot-path-one-shot-execution/05+02,04_request_coordinator/` to `agent-task/archive/YYYY/MM/m-iop-hot-path-one-shot-execution/05+02,04_request_coordinator/` and update this checklist at the final archive path.
- [x] If PASS and task group is `m-<milestone-slug>`, preserve and report `milestone-task` metadata for runtime aggregation, without modifying roadmap or directly calling `update-roadmap`.
- [x] If PASS for split work, remove empty active parent `agent-task/m-iop-hot-path-one-shot-execution/` or verify it was kept due to remaining siblings/files.
- [ ] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

None. Updated test fixtures in `request_coordinator_test.go` to strict endpoint representations per plan checklist instructions.

## Key Design Decisions

- Integrated full sequence tool history validation into `validateChatMessages` and `validateAnthropicMessages` in `request_lineage.go`. Both initial and continuation request lineage constructors now enforce valid historical turns before returning digests.
- Maintained exact `json.RawMessage` byte representations for canonical JSON fingerprinting (`fingerprintCanonicalJSON`), preserving large-integer and field-order fidelity.
- Enforced global issued ID uniqueness, role-appropriate tool-use/tool-result block placement, and exact turn matching across complete committed message sequences for Chat and Anthropic endpoints.

## Reviewer Checkpoints

- Every Chat and Anthropic tool-call/result turn, including committed history, is structurally valid before either lineage digest is returned.
- Duplicate or replayed issued IDs, orphan/partial/duplicate/unknown results, and unsupported Anthropic blocks fail without weakening canonical large-integer or key-order fidelity.
- The mandatory coordinator lineage fence, atomic no-mutation rejection, and exactly-once race behavior remain unchanged.

## Verification Results

Paste actual stdout/stderr below each command and replace every pending marker.

### REVIEW_API-1 and REVIEW_API-2 item verification

```bash
go test -count=1 ./apps/edge/internal/openai -run 'TestLogicalRequest(Lineage|EndpointContinuation)'
```

_Actual stdout/stderr:_

```
ok  	iop/apps/edge/internal/openai	0.035s
```

### Archived dependencies

```bash
test -f agent-task/archive/2026/08/m-iop-hot-path-one-shot-execution/02+01_preset_generation/complete.log
test -f agent-task/archive/2026/08/m-iop-hot-path-one-shot-execution/04+02,03_preset_model_authorization/complete.log
```

_Actual stdout/stderr:_

```
(exited 0)
```

### Focused race

```bash
go test -race -count=1 ./apps/edge/internal/openai -run 'TestLogicalRequest(MandatoryLineageFence|Continuation|CommittedLineage|ConcurrentFrontier)'
```

_Actual stdout/stderr:_

```
ok  	iop/apps/edge/internal/openai	1.074s
```

### Common race

```bash
go test -race -count=1 ./packages/go/streamgate ./packages/go/config ./apps/edge/internal/openai ./apps/edge/internal/service
```

_Actual stdout/stderr:_

```
ok  	iop/packages/go/streamgate	2.029s
ok  	iop/packages/go/config	1.559s
ok  	iop/apps/edge/internal/openai	8.919s
ok  	iop/apps/edge/internal/service	7.027s
```

### Vet, formatting, and diff

```bash
go vet ./apps/edge/internal/openai
gofmt -d apps/edge/internal/openai/request_coordinator.go apps/edge/internal/openai/request_lineage.go apps/edge/internal/openai/request_coordinator_test.go
git diff --check
```

_Actual stdout/stderr:_

```
(exited 0)
```

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |

## Code Review Result

- Overall Verdict: PASS
- Dimension Assessment:
  - Correctness: Pass — both endpoint validators scan the complete committed history before hashing and enforce global issued-ID uniqueness plus exact adjacent tool-result sets.
  - Completeness: Pass — the Chat and Anthropic history validators, valid multi-turn controls, malformed-history matrix, and preserved coordinator lineage fence satisfy every planned checklist item.
  - Test Coverage: Pass — fresh focused, race-enabled, common-package, and full Edge package tests cover the changed history boundary and adjacent coordinator behavior.
  - API Contract: Pass — immutable endpoint-native lineage, tool binding, and exactly-once frontier semantics remain consistent with SDD S05 and the OpenAI/Anthropic contracts.
  - Code Quality: Pass — the validation is localized, formatted, free of debug artifacts, and reuses the existing strict Anthropic content decoder.
  - Implementation Deviation: Pass — the implementation stays within the planned lineage and regression-test files; fixture tightening is documented and appropriate.
  - Verification Trust: Pass — every claimed command was rerun successfully; the broader Edge suite also passed when executed from an executable temporary directory.
  - Spec Conformance: Pass — SDD S05 full-history/frontier evidence is satisfied without expanding handler integration or roadmap scope.
- Findings: None.
- Routing Signals:
  - `review_rework_count=4`
  - `evidence_integrity_failure=false`
- Next Step: Write `complete.log`, archive the active pair and task directory, and report milestone completion metadata for runtime aggregation.
