<!-- task=m-iop-agent-cli-runtime/18+14,15_cli_command_tree plan=3 tag=REVIEW_TEST -->

# Code Review Reference - REVIEW_TEST

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-07-30
task=m-iop-agent-cli-runtime/18+14,15_cli_command_tree, plan=3, tag=REVIEW_TEST

## Archive Evidence Snapshot

- Prior task: `agent-task/m-iop-agent-cli-runtime/18+14,15_cli_command_tree`
- Predicted plan archive: `agent-task/m-iop-agent-cli-runtime/18+14,15_cli_command_tree/plan_cloud_G05_2.log`
- Predicted review archive: `agent-task/m-iop-agent-cli-runtime/18+14,15_cli_command_tree/code_review_cloud_G05_2.log`
- Verdict: FAIL
- Findings: 2 Required, 0 Suggested, 0 Nit.
- Affected files: `apps/agent/internal/command/root_test.go` and the active review evidence.
- Reviewer verification: both focused suites, the full package, race, vet, formatting, stale-symbol, and diff checks passed; source hashes were stable. Static review proved that the claimed exact/full JSON and exact-error assertions are absent.
- Roadmap carryover: this remains an S10 command-tree prerequisite and must not add `Roadmap Targets`; the downstream binary/contract closure owns `cli-surface` completion and the headless transcript.

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G04.md` → `code_review_cloud_G04_3.log` and `PLAN-cloud-G04.md` → `plan_cloud_G04_3.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-iop-agent-cli-runtime/18+14,15_cli_command_tree/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and task group is `m-<milestone-slug>`, report completion event metadata. Roadmap state check and `update-roadmap` calls are runtime responsibilities.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| REVIEW_TEST-1 Exact text and JSON output | [x] |
| REVIEW_TEST-2 Exact invalid-output error | [x] |

## Implementation Checklist

- [x] Replace weak output assertions with exact command-boundary text/JSON cases and complete decoded payload equality for every advertised response type.
- [x] Require the exact unsupported-output error while preserving zero service calls, zero mutations, and empty stdout.
- [x] Run fresh focused, package, race, vet, formatting, diff, and hash-stability verification and record literal stdout/stderr.
- [x] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [x] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [x] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [x] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G04_3.log`.
- [x] Archive active `PLAN-*-G??.md` to `plan_cloud_G04_3.log`.
- [x] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [x] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [x] If PASS, move active task directory `agent-task/m-iop-agent-cli-runtime/18+14,15_cli_command_tree/` to `agent-task/archive/YYYY/MM/m-iop-agent-cli-runtime/18+14,15_cli_command_tree/` and update this checklist at the final archive path.
- [x] If PASS and task group is `m-<milestone-slug>`, report completion event metadata for runtime, without modifying roadmap or directly calling `update-roadmap`.
- [x] If PASS for split work, remove empty active parent `agent-task/m-iop-agent-cli-runtime/` or verify it was kept due to remaining siblings/files.
- [ ] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

None.

## Key Design Decisions

- Added local test helper `assertExactJSON(t, got, want)` in `apps/agent/internal/command/root_test.go` to enforce both exact string formatting equality and complete decoded structure equality (`reflect.DeepEqual`).
- Updated `TestCommandMatrix` to compare exact text stdout for every subcommand.
- Added `TestCommandJSONOutputMatrix` to test exact JSON stdout and decoded payload structure for every output-bearing subcommand.
- Updated `TestUnsupportedOutputFormat` to compare the exact error string `"unsupported output format: xml"` while maintaining zero service call, zero mutation, and empty stdout invariants.

## Reviewer Checkpoints

- Every output-bearing command has exact text and JSON command-boundary expectations; `serve` remains output-free.
- Exact JSON expectations name every field and complete decoded payloads match, including automatic-resume and blocker-retryability values.
- Every invalid-output case compares the complete error while retaining zero service calls, zero mutations, and empty stdout.
- Verification Results contain literal stdout/stderr from the exact commands and stable before/after source hashes.

## Verification Results

> Paste literal stdout/stderr for every command below. Do not reconstruct or summarize output. If a command changes, record the replacement and reason in `Deviations from Plan`.

### Exact text and JSON command output

```bash
go test -count=1 ./apps/agent/internal/command -run 'TestCommandMatrix|TestCommandJSONOutputMatrix|TestStableTextAndJSONOutput|TestStatusIncludesOverlayIntegrationAndBlockers'
```

```text
ok  	iop/apps/agent/internal/command	0.005s
```

### Exact invalid-output error

```bash
go test -count=1 ./apps/agent/internal/command -run 'TestUnsupportedOutputFormat'
```

```text
ok  	iop/apps/agent/internal/command	0.004s
```

### Final verification

```bash
sha256sum apps/agent/internal/command/root.go apps/agent/internal/command/service.go apps/agent/internal/command/root_test.go
gofmt -d apps/agent/internal/command/root_test.go
go test -count=1 ./apps/agent/internal/command -run 'TestCommandMatrix|TestCommandJSONOutputMatrix|TestStableTextAndJSONOutput|TestUnsupportedOutputFormat|TestStatusIncludesOverlayIntegrationAndBlockers'
go test -count=1 ./apps/agent/internal/command
go test -count=1 -race ./apps/agent/internal/command
go vet ./apps/agent/internal/command
git diff --check
sha256sum apps/agent/internal/command/root.go apps/agent/internal/command/service.go apps/agent/internal/command/root_test.go
```

```text
37699e3aa4885f1c0a46f8282ab9d50bae8002262a74e26a911cb4bc1630eac4  apps/agent/internal/command/root.go
969a105dfbe3ea11fff98129050447730aa331af89b160eacd17aa1ea74c8998  apps/agent/internal/command/service.go
b38b506d3c5dccac9707b1bea9eba1c47d7720a655bbfba0462207f4e3ca6851  apps/agent/internal/command/root_test.go

$ gofmt -d apps/agent/internal/command/root_test.go
(no output)

$ go test -count=1 ./apps/agent/internal/command -run 'TestCommandMatrix|TestCommandJSONOutputMatrix|TestStableTextAndJSONOutput|TestUnsupportedOutputFormat|TestStatusIncludesOverlayIntegrationAndBlockers'
ok  	iop/apps/agent/internal/command	0.005s

$ go test -count=1 ./apps/agent/internal/command
ok  	iop/apps/agent/internal/command	0.008s

$ go test -count=1 -race ./apps/agent/internal/command
ok  	iop/apps/agent/internal/command	1.041s

$ go vet ./apps/agent/internal/command
(no output)

$ git diff --check
(no output)

37699e3aa4885f1c0a46f8282ab9d50bae8002262a74e26a911cb4bc1630eac4  apps/agent/internal/command/root.go
969a105dfbe3ea11fff98129050447730aa331af89b160eacd17aa1ea74c8998  apps/agent/internal/command/service.go
b38b506d3c5dccac9707b1bea9eba1c47d7720a655bbfba0462207f4e3ca6851  apps/agent/internal/command/root_test.go
```

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Roadmap Targets | Fixed at stub creation from plan when present | Implementing agent must not modify; code-review copies it into `complete.log` as `Roadmap Completion` only on PASS |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |

## Code Review Result

- Overall Verdict: PASS
- Dimension Assessment:
  - Correctness: Pass — exact text, JSON, and invalid-output behavior match the command boundary and response DTOs.
  - Completeness: Pass — both planned regression items and their integrated verification are complete.
  - Test Coverage: Pass — every output-bearing subcommand has exact text and JSON coverage; every command rejects an unsupported output format before dispatch.
  - API Contract: Pass — all advertised response fields, including auto-resume, blocker retryability, and integration position, are asserted exactly.
  - Code Quality: Pass — the test helper is local and focused, with no debug output, stale assertion paths, or unrelated production changes.
  - Implementation Deviation: Pass — implementation remains within the test-only plan scope with no deviations.
  - Verification Trust: Pass — fresh focused, package, race, vet, formatting, diff, and hash-stability checks passed and agree with the recorded evidence.
- Findings: None.
- Routing Signals:
  - review_rework_count=3
  - evidence_integrity_failure=false
- Next Step: Finalize PASS by archiving the active pair, writing `complete.log`, and moving the task to the monthly archive.
