<!-- task=m-node-provider-execution-liveness-recovery/08+07_stall_recovery plan=1 tag=API milestone-task=bounded-retry -->

# Code Review Reference - API

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-08-05
task=m-node-provider-execution-liveness-recovery/08+07_stall_recovery, plan=1, tag=API

## Archive Evidence Snapshot

- Prior pair: `plan_cloud_G08_0.log` and `code_review_cloud_G08_0.log` in this task directory. It was unimplemented and has no official verdict, Required/Suggested/Nit finding, code change, or verification evidence.
- Material self-review finding: the prior plan overloaded the configurable `provider_error` semantic filter even though `openai.stream_evidence_gate.filters[]` is optional; a gate-enabled request without that configured filter would have no stall recovery owner. It also omitted the required OpenAI/provider-pool full-cycle verification.
- Replan carryover: keep Core budget/commit/cancel ownership and the S05 matrix, but register a dedicated request-local liveness filter whenever StreamGate is enabled, independent of configurable semantic filters and provider capabilities. Gate-disabled/unsupported surfaces remain the explicit no-owner terminal boundary.


## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G08.md` → `code_review_cloud_G08_1.log` and `PLAN-cloud-G08.md` → `plan_cloud_G08_1.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-node-provider-execution-liveness-recovery/08+07_stall_recovery/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and task group is `m-node-provider-execution-liveness-recovery`, preserve the first-line `milestone-task` metadata in `complete.log` and report it for the runtime aggregation event. Roadmap state evaluation belongs to `sync-milestone-workstate`.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| API-1: Convert typed execution stalls into raw-free StreamGate events | [ ] |
| API-2: Gate exact replay and hand off the failed provider | [ ] |
| API-3: Prove bounded recovery across OpenAI variants | [ ] |

## Implementation Checklist

- [ ] API-1 preserves typed normalized/buffered/tunnel stalls as one raw-free StreamGate `response_stalled` provider error, retaining only sanitized fence/health/handoff tokens while generic failures keep existing terminal behavior.
- [ ] API-2 installs one internal liveness recovery filter for every StreamGate-enabled request independent of configured semantic filters/capabilities; only confirmed Edge-eligible, uncommitted, side-effect-safe stalls produce ExactReplay, close the fenced old transport, and hand the failed provider/fallback evidence to admission.
- [ ] API-3 adds Chat/Responses normalized/tunnel fixtures for available, unavailable, and unknown alternate recovery; available-only same-provider fallback; unavailable/unknown same-only terminal; no-owner, post-commit, unconfirmed, cancel/tool-side-effect, and shared-budget exhaustion; synchronize contracts/specs.
- [ ] Run focused, package, race, vet, provider-only/OpenAI/local-capacity full-cycles, live provider-pool preflight/scenario, and diff verification with fresh output; assert new identities plus exactly one terminal/dispatch per allowed cycle.
- [ ] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [ ] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [ ] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [ ] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G08_1.log`.
- [ ] Archive active `PLAN-*-G??.md` to `plan_cloud_G08_1.log`.
- [ ] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [ ] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [ ] If PASS, move active task directory `agent-task/m-node-provider-execution-liveness-recovery/08+07_stall_recovery/` to `agent-task/archive/YYYY/MM/m-node-provider-execution-liveness-recovery/08+07_stall_recovery/` and update this checklist at the final archive path.
- [ ] If PASS and task group is `m-node-provider-execution-liveness-recovery`, preserve and report `milestone-task` metadata for runtime aggregation, without modifying roadmap or directly calling `update-roadmap`.
- [ ] If PASS for split work, remove empty active parent `agent-task/m-node-provider-execution-liveness-recovery/` or verify it was kept due to remaining siblings/files.
- [ ] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

_Record any deviations from the plan and the rationale here._

## Key Design Decisions

_Record key design decisions here._

## Reviewer Checkpoints

- Confirm typed normalized/buffered/tunnel stalls map to one raw-free descriptor while generic failures retain current terminal behavior.
- Confirm every StreamGate-enabled request gets exactly one private liveness filter independent of configured filters/capabilities, while gate-disabled/unsupported ingress remains no-owner terminal.
- Confirm commit/cancel/side-effect/fence/shared-budget gates, confirmed-terminal close, failed-provider handoff, available-only fallback, new run identity, and single dispatch/terminal across Chat/Responses variants.
- Confirm focused/race tests plus provider-only, fake-vLLM, local-capacity, and live provider-pool evidence satisfy the final commands.

## Verification Results

> Implementing agent: run each command exactly as written and paste its actual stdout/stderr under `Output`. Record any replacement command and reason in `Deviations from Plan`.

### Verification 1

Command:

```bash
go test -count=20 ./apps/edge/internal/openai -run '^(TestOpenAIStallRecoveryFilter|TestOpenAIAttemptControllerConfirmedStall|TestOpenAIAttemptDispatcherStalledProvider)'
```

Output:

_Paste actual stdout/stderr here._

### Verification 2

Command:

```bash
go test -count=10 ./apps/edge/internal/openai -run '^TestOpenAIStallRecovery'
```

Output:

_Paste actual stdout/stderr here._

### Verification 3

Command:

```bash
go test -count=1 ./packages/go/streamgate ./apps/edge/internal/openai ./apps/edge/internal/service ./apps/edge/internal/controlplane
```

Output:

_Paste actual stdout/stderr here._

### Verification 4

Command:

```bash
go test -race -count=3 ./apps/edge/internal/service ./apps/edge/internal/openai
```

Output:

_Paste actual stdout/stderr here._

### Verification 5

Command:

```bash
go vet ./packages/go/streamgate ./apps/edge/internal/service ./apps/edge/internal/openai ./apps/edge/internal/controlplane
```

Output:

_Paste actual stdout/stderr here._

### Verification 6

Command:

```bash
./scripts/e2e-smoke.sh
```

Output:

_Paste actual stdout/stderr here._

### Verification 7

Command:

```bash
IOP_VLLM_MODE=fake ./scripts/e2e-openai-vllm.sh
```

Output:

_Paste actual stdout/stderr here._

### Verification 8

Command:

```bash
./scripts/e2e-provider-capacity-smoke.sh
```

Output:

_Paste actual stdout/stderr here._

### Verification 9

Command:

```bash
bash scripts/e2e-long-context-admission-smoke.sh --preflight && bash scripts/e2e-long-context-admission-smoke.sh --scenario normal-10
```

Output:

_Paste actual stdout/stderr here._

### Verification 10

Command:

```bash
git diff --check
```

Output:

_Paste actual stdout/stderr here._
---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |
