<!-- task=m-iop-owned-single-request-agent-execution/24+22_claude_smoke_harness plan=0 tag=TEST milestone-task=claude-smoke -->

# Code Review Reference - TEST

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> Execute the plan's selected root cause, scope, files, and dependency decisions as written. Do not choose another owner, narrow/expand the write boundary, or replace a fix with another verification attempt.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-08-07
task=m-iop-owned-single-request-agent-execution/24+22_claude_smoke_harness, plan=0, tag=TEST

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G07.md` → `code_review_cloud_G07_0.log` and `PLAN-cloud-G07.md` → `plan_cloud_G07_0.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-iop-owned-single-request-agent-execution/24+22_claude_smoke_harness/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS, preserve first-line `milestone-task=claude-smoke` metadata in `complete.log` and report it for runtime aggregation. Roadmap state evaluation belongs to `sync-milestone-workstate`.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| TEST-1 Freeze the S12 evidence schema | [ ] |
| TEST-2 Collect fresh, redacted, one-invocation evidence | [ ] |
| TEST-3 Expose isolated Make entry points | [ ] |

## Implementation Checklist

- [ ] Add a closed redacted S12 manifest schema covering source/runtime identity, one ingress, ordered Plan/Work/Review timing, one terminal, workspace before/after, verification, and zero forbidden matches.
- [ ] Add a credential-free self-testing harness with `--self-test`, `--preflight-only`, `--run`, and `--validate-manifest` modes that rejects stale/mismatched/external inputs before invoking Claude.
- [ ] Add isolated Make targets for self-test, preflight, validation, and credentialed run without adding the external run to aggregate local tests.
- [ ] Run dependency, shell syntax, credential-free behavioral, schema/redaction, Make target, and diff verification freshly; do not claim S12 qualification.
- [ ] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [ ] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [ ] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [ ] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G07_0.log`.
- [ ] Archive active `PLAN-*-G??.md` to `plan_cloud_G07_0.log`.
- [ ] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [ ] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [ ] If PASS, move active task directory `agent-task/m-iop-owned-single-request-agent-execution/24+22_claude_smoke_harness/` to `agent-task/archive/YYYY/MM/m-iop-owned-single-request-agent-execution/24+22_claude_smoke_harness/` and update this checklist at the final archive path.
- [ ] If PASS, preserve and report `milestone-task=claude-smoke` metadata for runtime aggregation, without modifying roadmap or directly calling `update-roadmap`.
- [ ] If PASS for split work, remove empty active parent `agent-task/m-iop-owned-single-request-agent-execution/` or verify it was kept due to remaining siblings/files.
- [ ] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

_Record any deviations from the plan and the rationale here._

## Key Design Decisions

_Record key design decisions here._

## Reviewer Checkpoints

- [ ] TEST-1 schema is closed at every object, fixes ingress/stage/terminal constants, accepts only digest/closed evidence, and forbids sensitive/raw fields.
- [ ] TEST-2 validates all source/runtime/Mac/log/metric/workspace/secret-name facts before one Claude child and writes the manifest atomically without raw values.
- [ ] TEST-2 self-test uses only temporary fakes, records one valid invocation, rejects every contradiction, and never contacts network or installed CLI/Edge.
- [ ] TEST-3 targets are isolated from aggregate tests and forward no default endpoint/model/config/secret value.
- [ ] The packet makes no S12 external qualification claim and changes no production runtime or test-rule document.

## Verification Results

Paste actual stdout/stderr for every command. If a command changes, record the replacement and reason in `Deviations from Plan` first. External invocation is not part of this packet.

### TEST-1 intermediate

```sh
./scripts/e2e-single-request-claude.sh --self-test
```

Output: _Paste actual stdout/stderr and exit status._

### TEST-2 intermediate

```sh
bash -n scripts/e2e-single-request-claude.sh && ./scripts/e2e-single-request-claude.sh --self-test
```

Output: _Paste actual stdout/stderr and exit status._

### TEST-3 intermediate

```sh
make test-single-request-claude-smoke-self-test
```

Output: _Paste actual stdout/stderr and exit status._

### Final 1 — dependency

```sh
bash -c 'set -euo pipefail; shopt -s nullglob; candidates=(agent-task/m-iop-owned-single-request-agent-execution/22_*/complete.log agent-task/m-iop-owned-single-request-agent-execution/22+*/complete.log agent-task/archive/*/*/m-iop-owned-single-request-agent-execution/22_*/complete.log agent-task/archive/*/*/m-iop-owned-single-request-agent-execution/22+*/complete.log); printf "%s\n" "${candidates[@]}"; ((${#candidates[@]} == 1))'
```

Output: _Paste actual stdout/stderr and exit status._

### Final 2 — shell syntax

```sh
bash -n scripts/e2e-single-request-claude.sh
```

Output: _Paste actual stdout/stderr and exit status._

### Final 3 — credential-free behavior

```sh
./scripts/e2e-single-request-claude.sh --self-test
```

Output: _Paste actual stdout/stderr and exit status._

### Final 4 — Make entry point

```sh
make test-single-request-claude-smoke-self-test
```

Output: _Paste actual stdout/stderr and exit status._

### Final 5 — target/input inventory

```sh
rg --sort path -n 'test-single-request-claude-smoke|IOP_SINGLE_REQUEST_SMOKE_' Makefile
```

Output: _Paste actual stdout/stderr and exit status._

### Final 6 — aggregate isolation

```sh
bash -c 'set -euo pipefail; if rg --sort path -n "test-single-request-claude-smoke([^:]*):.*test-single-request-claude-smoke$" Makefile; then exit 1; else test $? -eq 1; fi'
```

Output: _Paste actual stdout/stderr and exit status._

### Final 7 — diff

```sh
git diff --check
```

Output: _Paste actual stdout/stderr and exit status._

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |
