<!-- task=m-openai-compatible-output-validation-filters/02+01_repeat_guard plan=18 tag=REVIEW_OFR-REPEAT-17 -->

# Code Review Reference - REVIEW_OFR-REPEAT-17

> **[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation.**
> The task is NOT complete until every implementation-owned section below is filled in.
> Complete the `Implementation Checklist`; the final checklist item is mandatory before saving.
> Fill implementation-owned sections, then stop with active files in place and report ready for review.
> If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields.
> Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state.
> Finalization (`Code Review Result`, log rename, `complete.log`, archive moves, `Review-Only Checklist`) is review-agent-only, even after compaction/resume.
> Follow the ownership table at the bottom of this file for which sections you own.

## Overview

date=2026-07-29
task=m-openai-compatible-output-validation-filters/02+01_repeat_guard, plan=18, tag=REVIEW_OFR-REPEAT-17

## Roadmap Targets

- Milestone: `agent-roadmap/phase/knowledge-tool-optimization-extension/milestones/openai-compatible-output-validation-filters.md`
- Milestone link: [Milestone document](agent-roadmap/phase/knowledge-tool-optimization-extension/milestones/openai-compatible-output-validation-filters.md)
- Task ids:
  - `repeat-guard`: rolling content/history/action repetition detection and safe continuation
- Completion mode: check-on-pass

## Archive Evidence Snapshot

- Dependency `01_resume_notice_builder` is satisfied by `agent-task/archive/2026/07/m-openai-compatible-output-validation-filters/01_resume_notice_builder/complete.log`.
- The failed pair will be archived as `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/plan_cloud_G08_17.log` and `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/code_review_cloud_G08_17.log`.
- Verdict: FAIL; Required=1, Suggested=0, Nit=0.
- Required finding: `code_review_cloud_G08_17.log:201` records invocation count 0 and therefore no 15 provider response IDs, 15 Edge correlations, three accepted capacity rows, or sanitized final result.
- Trusted reviewer evidence on 2026-07-29: `git diff --check` exited 0; SHA-256 was `8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21`; focused repeat-guard tests exited 0; `go test -count=1 ./packages/go/streamgate ./apps/edge/internal/openai` exited 0.
- Follow-up: execute the existing live oracle exactly once on `/Users/toki/agent-work/iop-dev` after every source, runtime, capacity, and isolation precondition passes.

## For the Review Agent

> **[REVIEW AGENT ONLY]** The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in `Verification Results` matches code.
Review completion means the following steps are finished:

1. Append verdict and `review_rework_count` / `evidence_integrity_failure` routing signals.
2. Archive `CODE_REVIEW-cloud-G08.md` → `code_review_cloud_G08_18.log` and `PLAN-cloud-G08.md` → `plan_cloud_G08_18.log`.
3. If PASS, write `complete.log` and move active task directory to `agent-task/archive/YYYY/MM/m-openai-compatible-output-validation-filters/02+01_repeat_guard/`. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and task group is `m-<milestone-slug>`, report completion event metadata. Roadmap state check and `update-roadmap` calls are runtime responsibilities.
5. Check applicable `Review-Only Checklist` items at the final `.log` location before reporting.

---

## Implementation Item Completion

| Item | Status |
|------|---------|
| REVIEW_OFR-REPEAT-17-1 — On the verified Darwin/arm64 dev runner, execute exactly one fresh `ornith:35b` 5-concurrent × 3 live invocation after every precondition passes, then record 15 provider responses, 15 Edge correlations, three accepted capacity rows, the sanitized final result, and cleanup evidence. | [ ] |

## Implementation Checklist

- [ ] [REVIEW_OFR-REPEAT-17-1] On the verified Darwin/arm64 dev runner, execute exactly one fresh `ornith:35b` 5-concurrent × 3 live invocation after every precondition passes, then record 15 provider responses, 15 Edge correlations, three accepted capacity rows, the sanitized final result, and cleanup evidence.
- [x] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

## Review-Only Checklist

> **[REVIEW AGENT ONLY]** This checklist is used only by the review agent.
> Implementing agents must not modify or check this section.

- [x] Append one verdict of `PASS`, `WARN`, or `FAIL` and verified `review_rework_count`, `evidence_integrity_failure` to `Code Review Result`.
- [x] Verify that verdict, `Dimension Assessment`, and Required/Suggested/Nit classifications match.
- [x] Archive active `CODE_REVIEW-*-G??.md` to `code_review_cloud_G08_18.log`.
- [x] Archive active `PLAN-*-G??.md` to `plan_cloud_G08_18.log`.
- [x] Verify that the Agent-Ops managed block in `.gitignore` unignores `agent-task/**/*.md` and `agent-task/**/*.log` and ignores `agent-roadmap/current.md`.
- [ ] If PASS, write `complete.log` based on `agent-ops/skills/common/code-review/templates/complete-log-template.md` and leave no active `.md` files.
- [ ] If PASS, move active task directory `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/` to `agent-task/archive/YYYY/MM/m-openai-compatible-output-validation-filters/02+01_repeat_guard/` and update this checklist at the final archive path.
- [ ] If PASS and task group is `m-<milestone-slug>`, report completion event metadata for runtime, without modifying roadmap or directly calling `update-roadmap`.
- [ ] If PASS for split work, remove empty active parent `agent-task/m-openai-compatible-output-validation-filters/` or verify it was kept due to remaining siblings/files.
- [x] If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write `complete.log`.

## Deviations from Plan

No implementation or test change was made. The required Darwin/arm64 runner is unavailable from this Linux/aarch64 workspace, so the external preflight and the single authorized live invocation were not started. This preserves the plan's explicit prohibition against running the live oracle on a substitute host and against retrying a started invocation.

## Key Design Decisions

The existing environment-gated `TestDevRepeatGuardOrnithSmoke` remains the sole S07 oracle. Local deterministic checks were refreshed, but they are recorded only as supporting evidence and are not treated as a substitute for the required deployed Darwin evidence.

## Reviewer Checkpoints

- Confirm execution occurred on Darwin/arm64 at `/Users/toki/agent-work/iop-dev`, not in a substitute sandbox.
- Confirm login-shell Go is executable and the same shell invokes that exact binary.
- Confirm HEAD, test-only source delta, reviewed SHA-256, deployed runtime identities, listeners, active blocking gate, selected provider capacity/health, prompt/artifact containment, observation quiescence, and zero competing harnesses before launch.
- Confirm exactly one Go test process starts and exits 0.
- Confirm `summary.json` has three runs, 15 globally unique provider response IDs, 15 globally unique Edge correlations, and three accepted capacity rows with `configured=4`, `peak_in_flight=4`, `peak_queued>=1`, `final_in_flight=0`, and `final_queued=0`.
- Confirm sanitized `reproduced` includes fingerprint/offset or the result is `not_reproduced`; both providers return idle, no harness remains, source/runtime identities are unchanged, and no raw/secret-bearing material entered tracked evidence or stdout.

## Verification Results

Record actual stdout/stderr and exit codes for every command. If blocked, record the exact attempted command, output, and resume condition without asking the user or creating a control-plane stop file.

### Local Integrity Verification

```bash
git diff --check
sha256sum apps/edge/internal/openai/stream_gate_vertical_slice_test.go
go test -count=1 ./apps/edge/internal/openai -run 'TestDevRepeatGuard(SmokeEvidence|ObservationCorrelation|ObservationQuiescence|CapacityEvidence)'
go test -count=1 ./packages/go/streamgate ./apps/edge/internal/openai
```

Expected: all commands exit 0 and SHA-256 is `8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21`.

Implementation evidence:

Executed on the current workspace:

```text
$ go version
go version go1.26.2 linux/arm64
$ go env GOMOD
/config/workspace/iop-s1/go.mod
$ git diff --check
exit 0
$ sha256sum apps/edge/internal/openai/stream_gate_vertical_slice_test.go
8f0c767d6fb69175c6856fcd58f1398e89b9e13c6597dc950672b14b4013bd21  apps/edge/internal/openai/stream_gate_vertical_slice_test.go
$ go test -count=1 ./apps/edge/internal/openai -run 'TestDevRepeatGuard(SmokeEvidence|ObservationCorrelation|ObservationQuiescence|CapacityEvidence)'
ok   iop/apps/edge/internal/openai  0.321s
$ go test -count=1 ./packages/go/streamgate ./apps/edge/internal/openai
ok   iop/packages/go/streamgate  0.873s
ok   iop/apps/edge/internal/openai  7.323s
```

All local integrity commands exited 0. The worktree contains the expected reviewed test-file delta and task-loop artifacts; no source change was made by this follow-up.

### External Login-Shell and Source Preflight

```bash
zsh -lic '
set -eu
test "$(uname -s)" = "Darwin"
test "$(uname -m)" = "arm64"
cd /Users/toki/agent-work/iop-dev
go_bin="$(command -v go)"
test -n "$go_bin"
test -x "$go_bin"
"$go_bin" version
"$go_bin" env GOMOD
git rev-parse HEAD
git status --short
shasum -a 256 apps/edge/internal/openai/stream_gate_vertical_slice_test.go
'
```

Expected: Go `1.26.3`, GOMOD `/Users/toki/agent-work/iop-dev/go.mod`, reviewed HEAD, only the reviewed test-file delta, and the reviewed hash.

Implementation evidence:

Blocked before the specified Darwin login-shell command could be attempted. A host-identity check on the current workspace returned:

```text
os=Linux
arch=aarch64
darwin_workspace=absent
zsh=absent
port_18083=closed
port_18001=closed
```

The required `/Users/toki/agent-work/iop-dev` checkout and `zsh` login shell are absent, and this host is not Darwin/arm64. Resume only on the specified Darwin/arm64 dev runner with the reviewed checkout, then run the exact plan preflight there.

### External Runtime and Isolation Preflight

Record sanitized evidence for deployed Edge/Node identities, listeners `18083`/`18001`, active blocking `repeat_guard`, idle provider capacities 3 and 1, bounded prompt, empty artifact directory `/tmp/iop-repeat-guard-live/repeat-guard-G08-18`, writable raw-free observation sink, zero competing harnesses, and stable observation identity/size through the quiet window.

Implementation evidence:

Not started. Runtime and isolation checks are meaningful only after the Darwin login-shell and source preflight passes on the specified runner. The local host has closed required loopback ports and must not be used as a substitute. Resume by completing the exact external login-shell preflight on the Darwin/arm64 runner, then collect the required sanitized runtime/isolation evidence there.

### Single Authorized Live Lifecycle and Capacity Verification

```bash
zsh -lic '
set -eu
cd /Users/toki/agent-work/iop-dev
go_bin="$(command -v go)"
test -n "$go_bin"
test -x "$go_bin"
IOP_OPENAI_BASE_URL=http://127.0.0.1:18083 \
IOP_OPENAI_MODEL=ornith:35b \
IOP_OPENAI_SMOKE_CONCURRENCY=5 \
IOP_OPENAI_SMOKE_RUNS=3 \
IOP_OPENAI_SMOKE_PROMPT_FILE=/tmp/iop-repeat-guard-live/repeat-prompt.txt \
IOP_OPENAI_SMOKE_ARTIFACT_DIR=/tmp/iop-repeat-guard-live/repeat-guard-G08-18 \
IOP_OPENAI_SMOKE_OBSERVATION_FILE=/tmp/iop-repeat-guard-live/edge-observations.jsonl \
IOP_OPENAI_SMOKE_STATUS_URL=http://127.0.0.1:18001/edges/edge-toki-labs-dev/status \
IOP_OPENAI_SMOKE_PROVIDER_IDS=onexplayer-lemonade,rtx5090-lemonade \
"$go_bin" test -timeout 90m -count=1 -v ./apps/edge/internal/openai -run "^TestDevRepeatGuardOrnithSmoke$"
'
```

Expected: invocation count 1, exit 0, 15 globally unique provider response IDs, 15 globally unique Edge correlations, three accepted capacity rows, and sanitized `reproduced` with fingerprint/offset or `not_reproduced`.

Implementation evidence:

Not started; invocation count is 0. The single-use authorization remains unconsumed because the required Darwin/arm64 source, runtime, capacity, and isolation preconditions cannot be met on this host. Resume only after all specified external preconditions pass, then execute the exact live command once on the Darwin runner. Do not run or retry it from this workspace.

### Summary and Cleanup Verification

Expected: `summary.json` proves all identity/lifecycle/capacity cardinality; both providers are idle, no harness remains, runtime/source identity is unchanged, and all raw artifacts remain outside the repository.

Implementation evidence:

No live artifact directory, observation output, or `summary.json` was created because the authorized live process was not started. Consequently, provider-idle, harness-exit, and deployed-runtime-identity evidence remains outstanding and must be collected by the single authorized Darwin invocation.

---

> **[IMPLEMENTING AGENT — BEFORE SAVING] Have you filled in every implementation-owned section?**
> If anything is blank, go back and fill it in before saving this file.
> Leave review-agent-only sections unchanged.

## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Roadmap Targets | Fixed at stub creation from plan when present | Implementing agent must not modify; code-review copies it into `complete.log` as `Roadmap Completion` only on PASS |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a `Deviations from Plan` entry |
| Code Review Result | Review agent appends | Not included in stub |

## Code Review Result

- Overall Verdict: FAIL
- Dimension Assessment:
  - Correctness: Pass — the reviewed test-only delta retains the expected SHA-256, and both the focused repeat-guard evidence tests and the local Stream Gate/OpenAI package baseline pass.
  - Completeness: Fail — `REVIEW_OFR-REPEAT-17-1` remains incomplete because the required Darwin/arm64 live invocation was not started.
  - Test Coverage: Fail — SDD S07 still has no integrated 5-concurrent × 3 provider-pool lifecycle and capacity result.
  - API Contract: Pass — no API or contract source changed in this verification-only loop, and the local evidence remains consistent with the OpenAI-compatible contract.
  - Code Quality: Pass — `git diff --check` passes, the reviewed test-file hash is unchanged, and the implementation evidence is complete enough to judge the blocker.
  - Implementation Deviation: Fail — the plan required one verified dev-runner invocation, but implementation stopped after the current Linux/aarch64 host failed the external preflight.
  - Verification Trust: Pass — the recorded invocation count of 0, host blocker, source hash, focused test result, and local package result agree with fresh reviewer evidence.
  - Spec Conformance: Fail — SDD S07 requires at least three capacity+1 live runs with sanitized lifecycle, correlation, capacity, and final-result evidence, which is absent.
- Findings:
  - Required — `agent-task/m-openai-compatible-output-validation-filters/02+01_repeat_guard/CODE_REVIEW-cloud-G08.md:202`: execute `TestDevRepeatGuardOrnithSmoke` exactly once on the verified Darwin/arm64 runner after every source, runtime, capacity, and isolation precondition passes, then record 15 globally unique provider response IDs, 15 globally unique Edge correlations, three accepted capacity rows, a sanitized `reproduced`/`not_reproduced` result, and post-run cleanup evidence. Invocation count 0 cannot satisfy the plan or SDD S07.
- Routing Signals:
  - `review_rework_count=18`
  - `evidence_integrity_failure=false`
- Next Step: Invoke the plan skill in `prepare-follow-up` mode with this raw finding and fresh verification evidence, then archive this pair and materialize the freshly routed follow-up pair.
