toki/iop
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
35 commits 4 branches 0 tags 115 MiB
Commit graph

4 commits

Author SHA1 Message Date
toki
635ac41859 docs(cli): update CODE_REVIEW.md with final verification results 2026-05-03 16:10:21 +09:00
toki
1176ed844f fix(cli): add START_MARKER assertion and fix Stop comment (REVIEW_REVIEW_API_FOLLOWUP_4) 
- Add START_MARKER verification in TestCLIStartPartialRollbackWithMarkers
- Add requireEventually and readMarker helper functions
- Update CLI.Stop comment to match actual implementation
- Fix all gofmt issues
- SIGKILL cannot trigger trap EXIT, so verify START_MARKER instead
 2026-05-03 16:02:37 +09:00
toki
4bece3fb2d fix(cli): mutex unlock and session cleanup for persistent Execute (REVIEW_REVIEW_API_FOLLOWUP_2) 
- [2-1] executePersistent: add defer sess.mu.Unlock() so all return paths
  release the session mutex. Remove explicit unlock calls.
- [2-2] Protect c.sessions map access in Execute with c.mu. Replace
  c.Stop() in timeout/cancel path with per-session close/kill/delete so
  only the affected profile session is cleaned up.
- [2-3] Add TestCLIExecutePersistentConsecutiveExecutes to verify the
  same persistent profile can be executed consecutively without blocking.
  Apply gofmt to all adapter files.
 2026-05-03 15:01:57 +09:00
toki
4b05859bef feat: cli terminal cycle 구현 및 테스트 코드 추가 2026-05-03 14:51:29 +09:00