toki/iop
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
iop/agent-task/m-iop-agent-cli-runtime/15+13_project_logs/CODE_REVIEW-cloud-G08.md

4.5 KiB
Raw Blame History

Code Review Reference - API

[IMPLEMENTING AGENT — READ FIRST] Filling in this file is mandatory. Fill implementation evidence and actual outputs, then stop with active files in place. Review finalization is not an implementation action.

Overview

date=2026-07-29 task=m-iop-agent-cli-runtime/15+13_project_logs, plan=0, tag=API

Roadmap Targets

  • Milestone: agent-roadmap/phase/automation-runtime-bridge/milestones/iop-agent-cli-runtime.md
  • Milestone link: Milestone 문서
  • Task ids:
    • project-logs: project-local event/log plus WORK_LOG loop/attempt/locator and exactly-once archive lifecycle
  • Completion mode: check-on-pass

For the Review Agent

[REVIEW AGENT ONLY] Implementing agents must not execute finalization.

Compare source and actual evidence to S12. Append verdict/signals; archive CODE_REVIEW-cloud-G08.md → code_review_cloud_G08_0.log and PLAN-local-G08.md → plan_local_G08_0.log; on PASS write complete.log, archive the task, and report completion metadata without editing the roadmap.

Implementation Item Completion

Item Status
API-1 Records [ ]
API-2 CAS journal/archive [ ]
API-3 Event sink/timeline [ ]
API-4 S12 matrix [ ]

Implementation Checklist

  • Define a versioned, bounded ProjectLogRecord and stable project/work/attempt/locator identity schema.
  • Implement CAS-backed append, retention, replay, terminal archive, and restart reconciliation over device-local roots.
  • Implement the agenttask EventSink adapter and deterministic WORK_LOG projection without raw provider output.
  • Prove the S12 11-retry, parallel-task, ordinal, crash-window, and exactly-once archive matrix under the race detector.
  • Update the standalone contract with actual S12 source/test paths and verification evidence.
  • Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

Review-Only Checklist

[REVIEW AGENT ONLY] Implementing agents must not modify this checklist.

  • Append one verdict and verified routing signals.
  • Verify verdict, dimensions, and finding classifications.
  • Archive this review as code_review_cloud_G08_0.log.
  • Archive the plan as plan_local_G08_0.log.
  • Verify the Agent-Ops managed .gitignore block.
  • If PASS, write canonical complete.log and leave no active Markdown files.
  • If PASS, move the task to the dated archive and update this checklist there.
  • If PASS, report project-logs completion metadata without editing the roadmap.
  • If PASS, remove an empty split parent or prove siblings/files remain.
  • If WARN/FAIL, materialize the required next state without complete.log.

Deviations from Plan

Implementer: actual deviations or None.

Key Design Decisions

Implementer: actual decisions.

Reviewer Checkpoints

  • Accepted appends, archive intent, and cleanup are CAS/restart safe.
  • Record schemas preserve exact identities and exclude secrets/raw output.
  • The S12 test really contains 11 retries and an independent parallel task.
  • Terminal-only archives are exactly once across injected crash windows.

Verification Results

Focused suite

go test -count=1 ./apps/agent/internal/projectlog

Paste actual stdout/stderr.

Race and S12 matrix

go test -count=1 -race ./apps/agent/internal/projectlog ./packages/go/agentstate
go test -count=1 -race ./apps/agent/internal/projectlog -run TestS12LoopParallelArchiveMatrix

Paste actual stdout/stderr.

Static checks

go vet ./apps/agent/internal/projectlog
git diff --check

Paste actual stdout/stderr.

[IMPLEMENTING AGENT — BEFORE SAVING] Fill every implementation-owned section and leave review-only content unchanged.

Section Ownership

Section Owner Note
Header, Overview, Roadmap Targets, Review Instructions Fixed Implementer must not modify
Implementation Item Completion, Implementation Checklist Implementing agent Check status only
Review-Only Checklist Review agent Implementer must not modify
Deviations, Decisions, Verification Results Implementing agent Record actual evidence
Reviewer Checkpoints Fixed Reviewer verifies them
Code Review Result and finalization Review agent Append/execute only after review