toki
61d4e76fe8
General API와 Coding Plan이 서로 다른 엔드포인트와 사용량 경계를 유지하도록 프로필, credential route, provider mapping, full-cycle 검증을 함께 반영한다.
46 lines
3.1 KiB
Text
46 lines
3.1 KiB
Text
<!-- task=glm_coding_plan plan=2 tag=REVIEW_API -->
|
|
|
|
# Complete - glm_coding_plan
|
|
|
|
## Completion Time
|
|
|
|
2026-08-02
|
|
|
|
## Summary
|
|
|
|
Completed the GLM General API/Coding Plan profile separation after three review loops; final verdict PASS with 0 Required, 0 Suggested, and 0 Nit findings.
|
|
|
|
## Loop History
|
|
|
|
| Plan | Review | Verdict | Notes |
|
|
|------|--------|---------|-------|
|
|
| `plan_local_G06_0.log` | `code_review_cloud_G06_0.log` | FAIL | Required a policy-safe supported-tool smoke, a deterministic `glm_coding` Edge-to-Node full-cycle, and trustworthy command evidence. |
|
|
| `plan_cloud_G08_1.log` | `code_review_cloud_G07_1.log` | FAIL | Production behavior passed, but the submitted verification transcript still contained elided and reconstructed output. |
|
|
| `plan_cloud_G05_2.log` | `code_review_cloud_G05_2.log` | PASS | Verbatim task-local evidence, fresh reviewer verification, policy checks, and secret-safety checks all passed. |
|
|
|
|
## Implementation and Cleanup
|
|
|
|
- Added independent built-in `glm` and `glm_coding` protocol profile identities with distinct General API and Coding Plan endpoints, Bearer authentication, chat/stream/tool capabilities, and no Responses operation.
|
|
- Allowed a managed GLM Bearer credential slot to bind isolated General API and Coding Plan routes while preserving cross-vendor rejection.
|
|
- Added config, Node adapter, credential-route, provider-mapping, and deterministic Edge-to-Node loopback full-cycle coverage.
|
|
- Added a comment-only two-model/two-provider configuration example, synchronized the current provider-pool spec, and documented a policy-safe Pi supported-tool smoke.
|
|
- Preserved exact combined stdout/stderr in five deterministic task-local verification logs and verified their recorded line counts and SHA-256 hashes.
|
|
|
|
## Final Verification
|
|
|
|
- `git diff --check` and `gofmt -d` checks - PASS; no whitespace or formatting errors.
|
|
- `go test -count=1 ./packages/go/config ./apps/control-plane/internal/credentialstore ./apps/node/internal/adapters/openai_compat` - PASS; all three packages passed fresh.
|
|
- `bash -n scripts/e2e-openai-glm-coding.sh && make test-openai-glm-coding` - PASS; `glm_coding` Edge-to-Node loopback-provider full-cycle passed.
|
|
- `make build-edge` and `TMPDIR="$PWD/build/e2e-tmp" make test-e2e` - PASS; Edge build and all auxiliary smokes passed.
|
|
- Policy-safe `pi --offline --provider zai --model glm-5.1` smoke - PASS after current official Z.AI documentation confirmed Pi remains supported; only the redacted PASS marker was emitted for the model response.
|
|
- Evidence identity checks - PASS; recorded counts and hashes match `verification_focused_2.log`, `verification_glm_coding_2.log`, `verification_aux_e2e_2.log`, `verification_pi_2.log`, and `verification_scope_2.log`.
|
|
- `python3 agent-ops/skills/common/orchestrate-agent-task-loop/scripts/dispatch.py --workspace /config/workspace/iop-s2 --validate-plan agent-task/glm_coding_plan/PLAN-cloud-G05.md` - PASS before archive.
|
|
- Decrypted-token artifact scan across production, guide, task, and verification files - PASS; no token value was found.
|
|
|
|
## Remaining Nit
|
|
|
|
- None.
|
|
|
|
## Follow-up Work
|
|
|
|
- None.
|