toki/mattermost-mobile
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

MM-20007 Fix app crashes when previewing some gif files (#3563)

Browse source
This commit is contained in:
Elias Nahum 2019-11-18 12:31:29 -03:00 committed by Harrison Healey
parent c68138150e
commit 00874eb3ff
4 changed files with 13 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
app/components/message_attachments/attachment_thumbnail.js
View file

@ -2,8 +2,9 @@
// See LICENSE.txt for license information.
import React, {PureComponent} from 'react';
import {Image, StyleSheet, View} from 'react-native';
import {StyleSheet, View} from 'react-native';
import PropTypes from 'prop-types';
import FastImage from 'react-native-fast-image';
export default class AttachmentThumbnail extends PureComponent {
static propTypes = {
@ -19,7 +20,7 @@ export default class AttachmentThumbnail extends PureComponent {
return (
<View style={style.container}>
<Image
<FastImage
source={{uri}}
resizeMode='contain'
resizeMethod='scale'

4
app/components/progressive_image/progressive_image.js
View file

@ -4,12 +4,14 @@
import React, {PureComponent} from 'react';
import PropTypes from 'prop-types';
import {Animated, Image, ImageBackground, Platform, View, StyleSheet} from 'react-native';
import FastImage from 'react-native-fast-image';
import CustomPropTypes from 'app/constants/custom_prop_types';
import ImageCacheManager from 'app/utils/image_cache_manager';
import {changeOpacity, makeStyleSheetFromTheme} from 'app/utils/theme';
const AnimatedImageBackground = Animated.createAnimatedComponent(ImageBackground);
const AnimatedImage = Animated.createAnimatedComponent(FastImage);
export default class ProgressiveImage extends PureComponent {
static propTypes = {
@ -131,7 +133,7 @@ export default class ProgressiveImage extends PureComponent {
ImageComponent = AnimatedImageBackground;
} else {
DefaultComponent = Image;
ImageComponent = Animated.Image;
ImageComponent = AnimatedImage;
}
const styles = getStyleSheet(theme);

4
app/screens/image_preview/image_preview.js
View file

@ -6,7 +6,6 @@ import PropTypes from 'prop-types';
import {
Alert,
Animated,
Image,
Platform,
SafeAreaView,
StatusBar,
@ -22,6 +21,7 @@ import {intlShape} from 'react-intl';
import Permissions from 'react-native-permissions';
import Gallery from 'react-native-image-gallery';
import DeviceInfo from 'react-native-device-info';
import FastImage from 'react-native-fast-image';
import EventEmitter from 'mattermost-redux/utils/event_emitter';
@ -374,7 +374,7 @@ export default class ImagePreview extends PureComponent {
return (
<View style={[style, {justifyContent: 'center', alignItems: 'center'}]}>
<Image
<FastImage
source={source}
style={imageStyle}
/>

5
package-lock.json generated
View file

@ -1293,6 +1293,11 @@
"resolved": "https://registry.npmjs.org/@react-native-community/async-storage/-/async-storage-1.6.2.tgz",
"integrity": "sha512-EJGsbrHubK1mGxPjWB74AaHAd5m9I+Gg2RRPZzMK6org7QOU9WOBnIMFqoeVto3hKOaEPlk8NV74H6G34/2pZQ=="
},
"@react-native-community/cameraroll": {
"version": "1.3.0",
"resolved": "https://registry.npmjs.org/@react-native-community/cameraroll/-/cameraroll-1.3.0.tgz",
"integrity": "sha512-QJl9N34euvGU7s/Gn6jhsqi70O4SmxFxuy+yBnW7ehE8qtPYO91gyLLrtiWdTfYvuVCUNvX/G0LKJQLm8SojAA=="
},
"@react-native-community/cli-platform-android": {
"version": "3.0.0-alpha.7",
"resolved": "https://registry.npmjs.org/@react-native-community/cli-platform-android/-/cli-platform-android-3.0.0-alpha.7.tgz",