toki/mattermost-mobile
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

MM-13666 Detect post as emoji only if not a codeblock (#2497)

Browse source 
* Detect post as emoji only if not a codeblock

* Feedback review

Co-Authored-By: enahum <nahumhbl@gmail.com>

* Feedback review

Co-Authored-By: enahum <nahumhbl@gmail.com>
This commit is contained in:
Elias Nahum 2019-01-10 06:33:45 -03:00
parent 54c3ee97c4
commit 1a8be5444c
No known key found for this signature in database
GPG key ID: E038DB71E0B61702
2 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/utils/emoji_utils.js
View file

@ -46,7 +46,7 @@ function isEmoticon(text) {
}
export function hasEmojisOnly(message, customEmojis) {
if (!message || message.length === 0) {
if (!message || message.length === 0 || (/^\s{4}/).test(message)) {
return {isEmojiOnly: false, shouldRenderJumboEmoji: false};
}

4
app/utils/emoji_utils.test.js
View file

@ -60,6 +60,10 @@ describe('hasEmojisOnly with named emojis', () => {
name: 'Mixed valid and invalid named emojis',
message: ' :smile: invalid :heart: ',
expected: {isEmojiOnly: false, shouldRenderJumboEmoji: false},
}, {
name: 'This should render a codeblock instead',
message: ' :D',
expected: {isEmojiOnly: false, shouldRenderJumboEmoji: false},
}];
const customEmojis = new Map([['valid_custom', 0]]);