From 2216843854a5546fed89ec3930f811af74eb276f Mon Sep 17 00:00:00 2001 From: enahum Date: Mon, 31 Jul 2017 18:39:10 -0400 Subject: [PATCH] Fixes autocomplete to not to crash if rootId is undefined (#804) --- app/components/autocomplete/at_mention/index.js | 2 +- app/components/autocomplete/channel_mention/index.js | 2 +- app/components/autocomplete/emoji_suggestion/index.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/components/autocomplete/at_mention/index.js b/app/components/autocomplete/at_mention/index.js index 76ae173a3..030be6fe6 100644 --- a/app/components/autocomplete/at_mention/index.js +++ b/app/components/autocomplete/at_mention/index.js @@ -17,7 +17,7 @@ function mapStateToProps(state, ownProps) { let postDraft; if (ownProps.isSearch) { postDraft = state.views.search; - } else if (ownProps.rootId.length) { + } else if (ownProps.rootId) { const threadDraft = state.views.thread.drafts[ownProps.rootId]; if (threadDraft) { postDraft = threadDraft.draft; diff --git a/app/components/autocomplete/channel_mention/index.js b/app/components/autocomplete/channel_mention/index.js index 2cb9d267f..bea3809a3 100644 --- a/app/components/autocomplete/channel_mention/index.js +++ b/app/components/autocomplete/channel_mention/index.js @@ -18,7 +18,7 @@ function mapStateToProps(state, ownProps) { let postDraft; if (ownProps.isSearch) { postDraft = state.views.search; - } else if (ownProps.rootId.length) { + } else if (ownProps.rootId) { const threadDraft = state.views.thread.drafts[ownProps.rootId]; if (threadDraft) { postDraft = threadDraft.draft; diff --git a/app/components/autocomplete/emoji_suggestion/index.js b/app/components/autocomplete/emoji_suggestion/index.js index 002fd8491..847a36264 100644 --- a/app/components/autocomplete/emoji_suggestion/index.js +++ b/app/components/autocomplete/emoji_suggestion/index.js @@ -28,7 +28,7 @@ function mapStateToProps(state, ownProps) { const emojis = getEmojisByName(state); let postDraft; - if (ownProps.rootId.length) { + if (ownProps.rootId) { const threadDraft = state.views.thread.drafts[ownProps.rootId]; if (threadDraft) { postDraft = threadDraft.draft;