[MM-48192, MM-48279] Search - don't reset file filter when a user changes teams. (#6833)

This commit is contained in:
Jason Frerich 2022-12-09 12:54:24 -06:00 committed by GitHub
parent 4482bd481e
commit 2524a5be47
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 5 deletions

View file

@ -118,7 +118,7 @@ const Header = ({
theme,
title,
});
}, [selectedFilter]);
}, [onFilterChanged, selectedFilter]);
const filterStyle = useMemo(() => ({marginRight: teams.length > 1 ? 0 : 10}), [teams.length > 1]);

View file

@ -74,7 +74,10 @@ const Results = ({
{translateX: withTiming(translateX, {duration})},
],
};
}, [selectedTab, dimensions.width]);
// Do not transform if loading new data. Causes a case where post
// results show up in Files results when the team is changed
}, [selectedTab, dimensions.width, !loading]);
const paddingTop = useMemo(() => (
{paddingTop: scrollPaddingTop, flexGrow: 1}

View file

@ -163,14 +163,13 @@ const SearchScreen = ({teamId, teams}: Props) => {
}, [showResults]);
const handleSearch = useCallback(async (newSearchTeamId: string, term: string) => {
const searchParams = getSearchParams(term);
const searchParams = getSearchParams(term, filter);
if (!searchParams.terms) {
handleClearSearch();
return;
}
hideHeader(true);
handleLoading(true);
setFilter(FileFilters.ALL);
setLastSearchedValue(term);
addSearchToTeamSearchHistory(serverUrl, newSearchTeamId, term);
const [postResults, {files, channels}] = await Promise.all([
@ -186,7 +185,7 @@ const SearchScreen = ({teamId, teams}: Props) => {
setFileChannelIds(channels?.length ? channels : emptyChannelIds);
handleLoading(false);
setShowResults(true);
}, [handleClearSearch, handleLoading]);
}, [filter, handleClearSearch, handleLoading]);
const onBlur = useCallback(() => {
setSearchIsFocused(false);