From 2fa7d7dd8414290b2b9a496fa7b8b610ef21558b Mon Sep 17 00:00:00 2001 From: enahum Date: Tue, 4 Jul 2017 20:46:07 -0400 Subject: [PATCH] Fix logout/login issue (#707) --- app/screens/channel/channel.js | 2 +- .../channel_post_list/channel_post_list.js | 2 +- app/screens/login_options/login_options.js | 42 ++++++++++--------- 3 files changed, 25 insertions(+), 21 deletions(-) diff --git a/app/screens/channel/channel.js b/app/screens/channel/channel.js index 10dfdc2cc..bc9a42d4c 100644 --- a/app/screens/channel/channel.js +++ b/app/screens/channel/channel.js @@ -79,7 +79,7 @@ class Channel extends PureComponent { } componentWillReceiveProps(nextProps) { - if (this.props.currentTeam && nextProps.currentTeam && this.props.currentTeam.id !== nextProps.currentTeam.id) { + if (nextProps.currentTeam.id && this.props.currentTeam.id !== nextProps.currentTeam.id) { const teamId = nextProps.currentTeam.id; this.loadChannels(teamId); } diff --git a/app/screens/channel/channel_post_list/channel_post_list.js b/app/screens/channel/channel_post_list/channel_post_list.js index ed8a03ce3..85e98110b 100644 --- a/app/screens/channel/channel_post_list/channel_post_list.js +++ b/app/screens/channel/channel_post_list/channel_post_list.js @@ -60,7 +60,7 @@ class ChannelPostList extends PureComponent { } componentWillReceiveProps(nextProps) { - // Show the loader if the channel names change + // Show the loader if the channel id change if (this.props.currentChannelId !== nextProps.currentChannelId) { this.setState({ loaderOpacity: new Animated.Value(1) diff --git a/app/screens/login_options/login_options.js b/app/screens/login_options/login_options.js index 230fb0cf4..d9ff8358b 100644 --- a/app/screens/login_options/login_options.js +++ b/app/screens/login_options/login_options.js @@ -89,27 +89,31 @@ class LoginOptions extends PureComponent { renderGitlabOption = () => { const {config, serverVersion} = this.props; - const version = serverVersion.match(/^[0-9]*.[0-9]*.[0-9]*(-[a-zA-Z0-9.-]*)?/g)[0]; - if (config.EnableSignUpWithGitLab === 'true' && semver.valid(version) && semver.gte(version, 'v3.10.0')) { - return ( - - ); - } + + + {'GitLab'} + + + ); + } + return null; + } return null; };