toki/mattermost-mobile
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix id error when moving to a channel (#7890)

Browse source
This commit is contained in:
Daniel Espino García 2024-04-08 09:52:42 +02:00 committed by GitHub
parent e239887cef
commit 31b737da73
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
app/components/post_list/post_list.tsx
View file

@ -110,7 +110,7 @@ const PostList = ({
const scrolledToHighlighted = useRef(false);
const [refreshing, setRefreshing] = useState(false);
const [showScrollToEndBtn, setShowScrollToEndBtn] = useState(false);
const [lastPostId, setLastPostId] = useState<string>(posts[0].id);
const [lastPostId, setLastPostId] = useState<string | undefined>(posts[0]?.id);
const theme = useTheme();
const serverUrl = useServerUrl();
const orderedPosts = useMemo(() => {
@ -122,8 +122,13 @@ const PostList = ({
}, [orderedPosts]);
const isNewMessage = useMemo(() => {
return posts[0].id !== lastPostId;
}, [posts[0].id, lastPostId]);
if (!lastPostId) {
// Avoid flash when the channel loads without posts
// e.g. The first time we navigate to a channel
return false;
}
return posts[0]?.id !== lastPostId;
}, [posts[0]?.id, lastPostId]);
useEffect(() => {
const t = setTimeout(() => {
@ -170,10 +175,10 @@ const PostList = ({
const onScroll = useCallback((event: NativeSyntheticEvent<NativeScrollEvent>) => {
const {y} = event.nativeEvent.contentOffset;
if (y === 0) {
setLastPostId(posts[0].id);
setLastPostId(posts[0]?.id);
}
setShowScrollToEndBtn(y > CONTENT_OFFSET_THRESHOLD);
}, [posts[0].id]);
}, [posts[0]?.id]);
const onScrollToIndexFailed = useCallback((info: ScrollIndexFailed) => {
const index = Math.min(info.highestMeasuredFrameIndex, info.index);