toki/mattermost-mobile
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Fix handlePreferences warning (#7556)

Browse source 
* Fix handlePreferences warning

* Fix filtered array potentially being undefined
This commit is contained in:
Harrison Healey 2023-09-28 14:51:01 -04:00 committed by GitHub
parent b562e67d02
commit 31eb0ca489
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/database/operator/server_data_operator/handlers/user.ts
View file

@ -37,14 +37,16 @@ const UserHandler = <TBase extends Constructor<ServerDataOperatorBase>>(supercla
*/
handlePreferences = async ({preferences, prepareRecordsOnly = true, sync = false}: HandlePreferencesArgs): Promise<PreferenceModel[]> => {
const records: PreferenceModel[] = [];
const filtered = filterPreferences(preferences);
if (!filtered?.length) {
if (!preferences?.length) {
logWarning(
'An empty or undefined "preferences" array has been passed to the handlePreferences method',
);
return records;
}
const filtered = filterPreferences(preferences);
// WE NEED TO SYNC THE PREFS FROM WHAT WE GOT AND WHAT WE HAVE
const deleteValues: PreferenceModel[] = [];
const stored = await this.database.get(PREFERENCE).query().fetch() as PreferenceModel[];

4
app/helpers/api/preference.ts
View file

@ -53,8 +53,8 @@ export function getSidebarPreferenceAsBool(preferences: Preference[], name: stri
return getPreferenceAsBool(preferences, Preferences.CATEGORIES.SIDEBAR_SETTINGS, name, defaultValue);
}
export function filterPreferences(preferences?: PreferenceType[]) {
if (!preferences?.length) {
export function filterPreferences(preferences: PreferenceType[]) {
if (!preferences.length) {
return preferences;
}