toki/mattermost-mobile
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Fix post in channel batching order (#4090)

Browse source 
* Fix post in channel batching order

* Preserve preferences on reset cache
This commit is contained in:
Elias Nahum 2020-03-30 19:02:05 -03:00 committed by GitHub
parent fc34f34008
commit 3c73e8ec89
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
app/actions/views/post.js
View file

@ -86,10 +86,6 @@ export function getPosts(channelId, page = 0, perPage = Posts.POST_CHUNK_SIZE) {
const posts = Object.values(data.posts);
const actions = [];
if (posts?.length || !postForChannel) {
actions.push(receivedPostsInChannel(data, channelId, page === 0, data.prev_post_id === ''));
}
if (posts?.length) {
actions.push(receivedPosts(data));
const additional = await dispatch(getPostsAdditionalDataBatch(posts));
@ -98,6 +94,10 @@ export function getPosts(channelId, page = 0, perPage = Posts.POST_CHUNK_SIZE) {
}
}
if (posts?.length || !postForChannel) {
actions.push(receivedPostsInChannel(data, channelId, page === 0, data.prev_post_id === ''));
}
dispatch(batchActions(actions, 'BATCH_GET_POSTS'));
return {data};

11
app/store/utils.js
View file

@ -69,12 +69,7 @@ export function getStateForReset(initialState, currentState) {
const {currentUserId} = currentState.entities.users;
const currentUserProfile = currentState.entities.users.profiles[currentUserId];
const {currentTeamId} = currentState.entities.teams;
const myPreferences = {...currentState.entities.preferences.myPreferences};
Object.keys(myPreferences).forEach((key) => {
if (!key.startsWith('theme--')) {
Reflect.deleteProperty(myPreferences, key);
}
});
const preferences = currentState.entities.preferences;
const resetState = merge(initialState, {
entities: {
@ -87,9 +82,7 @@ export function getStateForReset(initialState, currentState) {
teams: {
currentTeamId,
},
preferences: {
myPreferences,
},
preferences,
},
});

3
app/store/utils.test.js
View file

@ -73,7 +73,6 @@ describe('getStateForReset', () => {
const {myPreferences} = resetState.entities.preferences;
const preferenceKeys = Object.keys(myPreferences);
const themeKeys = preferenceKeys.filter((key) => key.startsWith('theme--'));
expect(themeKeys.length).not.toEqual(0);
expect(themeKeys.length).toEqual(preferenceKeys.length);
expect(themeKeys.length).toEqual(2);
});
});