toki/mattermost-mobile
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Fix memory leak on offline indicator component (#1789)

Browse source
This commit is contained in:
Elias Nahum 2018-06-20 15:18:13 -04:00 committed by Sudheer
parent e0a8a5343a
commit 3cc40e676a
1 changed files with 22 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
app/components/offline_indicator/offline_indicator.js
View file

@ -66,13 +66,17 @@ export default class OfflineIndicator extends Component {
this.backgroundColor = new Animated.Value(0);
}
componentDidMount() {
this.mounted = true;
}
componentWillReceiveProps(nextProps) {
const {isLandscape, webSocketStatus} = this.props;
if (nextProps.isLandscape !== isLandscape && this.state.network) {
const navBar = this.getNavBarHeight(nextProps.isLandscape);
const top = new Animated.Value(navBar - HEIGHT);
this.setState({navBar, top});
this.setLocalState({navBar, top});
}
if (nextProps.isOnline) {
@ -92,14 +96,18 @@ export default class OfflineIndicator extends Component {
return (nextState.network !== this.state.network || nextProps.isLandscape !== this.props.isLandscape);
}
componentWillUnmount() {
this.mounted = false;
}
connect = () => {
checkNetwork((result) => {
this.setState({network: CONNECTING}, () => {
this.setLocalState({network: CONNECTING}, () => {
if (result) {
this.props.actions.connection(true);
this.initializeWebSocket();
} else {
this.setState({network: OFFLINE});
this.setLocalState({network: OFFLINE});
}
});
});
@ -123,13 +131,13 @@ export default class OfflineIndicator extends Component {
),
]).start(() => {
this.backgroundColor.setValue(0);
this.setState({network: null});
this.setLocalState({network: null});
});
};
connecting = () => {
const prevState = this.state.network;
this.setState({network: CONNECTING}, () => {
this.setLocalState({network: CONNECTING}, () => {
if (prevState !== OFFLINE) {
this.show();
}
@ -169,11 +177,19 @@ export default class OfflineIndicator extends Component {
};
offline = () => {
this.setState({network: OFFLINE}, () => {
this.setLocalState({network: OFFLINE}, () => {
this.show();
});
};
setLocalState = (state, callback) => {
if (!this.mounted) {
return;
}
this.setState(state, callback);
};
show = () => {
Animated.timing(
this.state.top, {