From 45bc95c95b527fc80bd70cc70ad8e3b63f155255 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Guillermo=20Vay=C3=A1?= Date: Wed, 20 Oct 2021 13:29:15 +0200 Subject: [PATCH] Added checklist to PR template (#5774) --- .github/ISSUE_TEMPLATE.md | 32 ++++++++++++++ .github/PULL_REQUEST_TEMPLATE.md | 62 +++++++++++++++++++++++++++ .github/workflows/codeql-analysis.yml | 43 +++++++++++++++++++ 3 files changed, 137 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE.md create mode 100644 .github/PULL_REQUEST_TEMPLATE.md create mode 100644 .github/workflows/codeql-analysis.yml diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md new file mode 100644 index 000000000..4f6d1acd1 --- /dev/null +++ b/.github/ISSUE_TEMPLATE.md @@ -0,0 +1,32 @@ +Per Mattermost guidelines, GitHub issues are for bug reports: . + +For troubleshooting see: http://forum.mattermost.org/. +For feature proposals see: http://www.mattermost.org/feature-requests/ + +If you've found a bug--something appears unintentional--please follow these steps: + +1. Confirm you’re filing a new issue. [Search existing tickets in Jira](https://mattermost.atlassian.net/jira/software/c/projects/MM/issues/) to ensure that the ticket does not already exist. +2. Confirm your issue does not involve security. Otherwise, please see our [Responsible Disclosure Policy](https://about.mattermost.com/report-security-issue/). +3. [File a new issue](https://github.com/mattermost/mattermost-mobile/issues/new) using the format below. Mattermost will confirm steps to reproduce and file in Jira, or ask for more details if there is trouble reproducing it. If there's already an existing bug in Jira, it will be linked back to the GitHub issue so you can track when it gets fixed. + +#### Summary +Bug report in one concise sentence + +### Environment Information + - Device Name: + - OS Version: + - Mattermost App Version: + - Mattermost Server Version: + +#### Steps to reproduce +How can we reproduce the issue (what version are you using?) + +#### Expected behavior +Describe your issue in detail + +#### Observed behavior (that appears unintentional) +What did you see happen? Please include relevant error messages, screenshots and/or video recordings. + +#### Possible fixes +If you can, link to the line of code that might be responsible for the problem + diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 000000000..f9453b5c0 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,62 @@ + + +#### Summary + + +#### Ticket Link + + +#### Checklist + +- [ ] Added or updated unit tests (required for all new features) +- [ ] Has UI changes +- [ ] Includes text changes and localization file updates +- [ ] Have tested against the 5 core themes to ensure consistency between them. + +#### Device Information +This PR was tested on: + +#### Screenshots + + +#### Release Note + + +```release-note + +``` diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml new file mode 100644 index 000000000..a546cd52f --- /dev/null +++ b/.github/workflows/codeql-analysis.yml @@ -0,0 +1,43 @@ +name: "CodeQL" + +on: + push: + branches: [ master ] + pull_request: + # The branches below must be a subset of the branches above + branches: [ master ] + schedule: + - cron: '0 0 * * 0' + +jobs: + analyze: + name: Analyze + runs-on: ubuntu-latest + + strategy: + fail-fast: false + matrix: + language: [ 'javascript' ] + # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python' ] + + steps: + - name: Checkout repository + uses: actions/checkout@v2 + + # Initializes the CodeQL tools for scanning. + - name: Initialize CodeQL + uses: github/codeql-action/init@v1 + with: + languages: ${{ matrix.language }} + # If you wish to specify custom queries, you can do so here or in a config file. + # By default, queries listed here will override any specified in a config file. + # Prefix the list here with "+" to use these queries and those in the config file. + # queries: ./path/to/local/query, your-org/your-repo/queries@main + + # Autobuild attempts to build any compiled languages (C/C++, C#, or Java). + # If this step fails, then you should remove it and run the build manually (see below) + - name: Autobuild + uses: github/codeql-action/autobuild@v1 + + - name: Perform CodeQL Analysis + uses: github/codeql-action/analyze@v1