Apply suggestions from code review

Co-authored-by: Amy Blais <29708087+amyblais@users.noreply.github.com>
This commit is contained in:
Mustafa Kara 2022-06-07 17:44:31 +03:00 committed by GitHub
parent 5309311d5f
commit 569f66908e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -5,14 +5,14 @@ We are automatically generating Notice.txt by using first-level dependencies of
## Configuration ## Configuration
Notice.txt will be always generated from first level dependencies scanned from package.json files. For some cases it may be useful to define Notice.txt will be always generated from first-level dependencies scanned from package.json files. For some cases it may be useful to define the
dependency to add it's licence to the Notice.txt even if it is not first level dependency or development dependency. dependency to add its licence to the Notice.txt even if it is not first-level dependency or development dependency.
For instance at desktop project we need to add `wix`'s licence to the Notice.txt even if it is not a first level dependency. To do that define For instance at desktop project we need to add `wix`'s licence to the Notice.txt even if it is not a first-level dependency. To do that, define
all dependencies at `dependencies` array at the configuration. For any dependency at `dependencies` section, pipeline code will add their all dependencies at `dependencies` array at the configuration. For any dependency at `dependencies` section, pipeline code will add their
licenses to the Notice.txt file. licenses to the Notice.txt file.
At webapp project `webpack` used in `devDependencies` and it is requested because we are using some files generated by `webpack`. If any dependency At webapp project `webpack` used in `devDependencies`, it is requested because we are using some files generated by `webpack`. If any dependency is
referenced at `devDependencies` section, pipeline will add those dependency licences when they are referenced at `package.json` files. referenced at `devDependencies` section, pipeline will add those dependency licences when they are referenced at `package.json` files.
Sample: Sample: