From 577ab85151c7950d2ca9242ae12444802772b522 Mon Sep 17 00:00:00 2001
From: Miguel Alatzar <migbot@users.noreply.github.com>
Date: Wed, 14 Aug 2019 12:47:52 -0700
Subject: [PATCH] [MM-17565] Set top bar buttons once component is mounted
 (#3123)

* Set header buttons after mount

* Do the same for private channel and dm
---
 app/screens/create_channel/create_channel.js    | 10 ----------
 app/screens/more_channels/more_channels.js      | 17 ++++-------------
 app/screens/more_channels/more_channels.test.js |  4 ++--
 app/screens/more_dms/more_dms.js                |  3 +--
 4 files changed, 7 insertions(+), 27 deletions(-)

diff --git a/app/screens/create_channel/create_channel.js b/app/screens/create_channel/create_channel.js
index 1e5994e7c..7ff26e6ee 100644
--- a/app/screens/create_channel/create_channel.js
+++ b/app/screens/create_channel/create_channel.js
@@ -67,16 +67,6 @@ export default class CreateChannel extends PureComponent {
         if (props.closeButton) {
             this.left = {...this.leftButton, icon: props.closeButton};
         }
-
-        const buttons = {
-            rightButtons: [this.rightButton],
-        };
-
-        if (this.left) {
-            buttons.leftButtons = [this.left];
-        }
-
-        props.actions.setButtons(props.componentId, buttons);
     }
 
     componentDidMount() {
diff --git a/app/screens/more_channels/more_channels.js b/app/screens/more_channels/more_channels.js
index 04b2305cc..d26ff1cf7 100644
--- a/app/screens/more_channels/more_channels.js
+++ b/app/screens/more_channels/more_channels.js
@@ -76,21 +76,12 @@ export default class MoreChannels extends PureComponent {
             id: 'close-more-channels',
             icon: props.closeButton,
         };
-
-        const buttons = {
-            leftButtons: [this.leftButton],
-        };
-
-        if (props.canCreateChannels) {
-            buttons.rightButtons = [this.rightButton];
-        }
-
-        props.actions.setButtons(props.componentId, buttons);
     }
 
     componentDidMount() {
         this.navigationEventListener = Navigation.events().bindComponent(this);
         this.mounted = true;
+        this.setHeaderButtons(this.props.canCreateChannels);
         this.doGetChannels();
     }
 
@@ -166,7 +157,7 @@ export default class MoreChannels extends PureComponent {
 
     getChannels = debounce(this.doGetChannels, 100);
 
-    headerButtons = (createEnabled) => {
+    setHeaderButtons = (createEnabled) => {
         const {actions, canCreateChannels, componentId} = this.props;
         const buttons = {
             leftButtons: [this.leftButton],
@@ -195,7 +186,7 @@ export default class MoreChannels extends PureComponent {
         const {actions, currentTeamId, currentUserId} = this.props;
         const {channels} = this.state;
 
-        this.headerButtons(false);
+        this.setHeaderButtons(false);
         this.setState({adding: true});
 
         const channel = channels.find((c) => c.id === id);
@@ -213,7 +204,7 @@ export default class MoreChannels extends PureComponent {
                     displayName: channel ? channel.display_name : '',
                 }
             );
-            this.headerButtons(true);
+            this.setHeaderButtons(true);
             this.setState({adding: false});
         } else {
             if (channel) {
diff --git a/app/screens/more_channels/more_channels.test.js b/app/screens/more_channels/more_channels.test.js
index 13eb05621..52086ada5 100644
--- a/app/screens/more_channels/more_channels.test.js
+++ b/app/screens/more_channels/more_channels.test.js
@@ -53,14 +53,14 @@ describe('MoreChannels', () => {
         expect(baseProps.actions.dismissModal).toHaveBeenCalledTimes(1);
     });
 
-    test('should call props.actions.setButtons on headerButtons', () => {
+    test('should call props.actions.setButtons on setHeaderButtons', () => {
         const wrapper = shallow(
             <MoreChannels {...baseProps}/>,
             {context: {intl: {formatMessage: jest.fn()}}},
         );
 
         expect(baseProps.actions.setButtons).toHaveBeenCalledTimes(1);
-        wrapper.instance().headerButtons(true);
+        wrapper.instance().setHeaderButtons(true);
         expect(baseProps.actions.setButtons).toHaveBeenCalledTimes(2);
     });
 
diff --git a/app/screens/more_dms/more_dms.js b/app/screens/more_dms/more_dms.js
index 15dcfc2d7..463b312a6 100644
--- a/app/screens/more_dms/more_dms.js
+++ b/app/screens/more_dms/more_dms.js
@@ -75,13 +75,12 @@ export default class MoreDirectMessages extends PureComponent {
             selectedIds: {},
             selectedCount: 0,
         };
-
-        this.updateNavigationButtons(false, context);
     }
 
     componentDidMount() {
         this.navigationEventListener = Navigation.events().bindComponent(this);
         this.mounted = true;
+        this.updateNavigationButtons(false);
 
         this.getProfiles();
     }