From 5d12387d3b1a59d88951ac5fa2eb71afb49b72c4 Mon Sep 17 00:00:00 2001 From: Elias Nahum Date: Fri, 29 Jun 2018 16:36:42 -0400 Subject: [PATCH] Fix ios extension crash and ability to share from files app (#1852) MM-11098 Fix ios extension crash and ability to share from files app --- ios/MattermostShare/SessionManager.m | 2 +- share_extension/ios/extension_post.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ios/MattermostShare/SessionManager.m b/ios/MattermostShare/SessionManager.m index 13298de60..7259774b9 100644 --- a/ios/MattermostShare/SessionManager.m +++ b/ios/MattermostShare/SessionManager.m @@ -26,7 +26,7 @@ -(void)setRequestWithGroup:(NSString *)requestWithGroup certificateName:(NSString *)certificateName { self.requestWithGroup = requestWithGroup; self.certificateName = certificateName; - self.isBackground = certificateName == nil; + self.isBackground = [certificateName length] == 0; } -(void)setDataForRequest:(NSDictionary *)data forRequestWithGroup:(NSString *)requestWithGroup { diff --git a/share_extension/ios/extension_post.js b/share_extension/ios/extension_post.js index 62484ffed..2f15c3a02 100644 --- a/share_extension/ios/extension_post.js +++ b/share_extension/ios/extension_post.js @@ -247,7 +247,7 @@ export default class ExtensionPost extends PureComponent { break; default: { const fullPath = item.value; - const filePath = fullPath.replace('file://', ''); + const filePath = decodeURIComponent(fullPath.replace('file://', '')); const fileSize = await RNFetchBlob.fs.stat(filePath); const filename = fullPath.replace(/^.*[\\/]/, ''); const extension = filename.split('.').pop(); @@ -612,7 +612,7 @@ export default class ExtensionPost extends PureComponent { post, requestId: generateId().replace(/-/g, ''), useBackgroundUpload: this.useBackgroundUpload, - certificate, + certificate: certificate || '', }; this.setState({sending: true});