toki/mattermost-mobile
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Aligning correctly 'has guests' warning in channel info screen (#3097)

Browse source 
* Aligning correctly 'has guests' warning in channel info screen

* Fixing eslint problems

* Adding tests

* Fixing tests
This commit is contained in:
Jesús Espino 2019-08-12 18:14:47 +02:00 committed by Miguel Alatzar
parent 9aa7d7e523
commit 7410e3c266
3 changed files with 2290 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2181
app/screens/channel_info/__snapshots__/channel_info_header.test.js.snap Normal file
View file

File diff suppressed because it is too large Load diff

12
app/screens/channel_info/channel_info_header.js
View file

@ -68,11 +68,13 @@ export default class ChannelInfoHeader extends React.PureComponent {
}
return (
<View style={style.section}>
<FormattedText
style={style.header}
id={messageId}
defaultMessage={defaultMessage}
/>
<View style={style.row}>
<FormattedText
style={style.header}
id={messageId}
defaultMessage={defaultMessage}
/>
</View>
</View>
);
}

102
app/screens/channel_info/channel_info_header.test.js Normal file
View file

@ -0,0 +1,102 @@
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
// See LICENSE.txt for license information.
import React from 'react';
import {shallow} from 'enzyme';
import Preferences from 'mattermost-redux/constants/preferences';
import {General} from 'mattermost-redux/constants';
import ChannelInfoHeader from './channel_info_header.js';
jest.mock('app/utils/theme', () => {
const original = require.requireActual('app/utils/theme');
return {
...original,
changeOpacity: jest.fn(),
};
});
describe('channel_info_header', () => {
const intlMock = {
formatMessage: jest.fn(),
formatDate: jest.fn(),
formatTime: jest.fn(),
formatRelative: jest.fn(),
formatNumber: jest.fn(),
formatPlural: jest.fn(),
formatHTMLMessage: jest.fn(),
now: jest.fn(),
};
const baseProps = {
createAt: 123,
creator: 'Creator',
memberCount: 3,
displayName: 'Channel name',
header: 'Header string',
onPermalinkPress: jest.fn(),
purpose: 'Purpose string',
status: 'status',
theme: Preferences.THEMES.default,
type: General.OPEN_CHANNEL,
isArchived: false,
isBot: false,
hasGuests: false,
isGroupConstrained: false,
};
test('should match snapshot', async () => {
const wrapper = shallow(
<ChannelInfoHeader
{...baseProps}
/>,
{context: {intl: intlMock}},
);
expect(wrapper.getElement()).toMatchSnapshot();
});
test('should match snapshot when is group constrained', async () => {
const wrapper = shallow(
<ChannelInfoHeader
{...baseProps}
isGroupConstrained={true}
/>,
{context: {intl: intlMock}},
);
expect(wrapper.getElement()).toMatchSnapshot();
});
test('should match snapshot when public channel and hasGuests', async () => {
const wrapper = shallow(
<ChannelInfoHeader
{...baseProps}
hasGuests={true}
/>,
{context: {intl: intlMock}},
);
expect(wrapper.getElement()).toMatchSnapshot();
});
test('should match snapshot when DM and hasGuests', async () => {
const wrapper = shallow(
<ChannelInfoHeader
{...baseProps}
type={General.DM_CHANNEL}
hasGuests={true}
/>,
{context: {intl: intlMock}},
);
expect(wrapper.getElement()).toMatchSnapshot();
});
test('should match snapshot when GM and hasGuests', async () => {
const wrapper = shallow(
<ChannelInfoHeader
{...baseProps}
type={General.GM_CHANNEL}
hasGuests={true}
/>,
{context: {intl: intlMock}},
);
expect(wrapper.getElement()).toMatchSnapshot();
});
});