From 10a58011d4ac3f2631772996b02a9d268618e5c0 Mon Sep 17 00:00:00 2001 From: harshil Sharma Date: Mon, 30 Oct 2023 20:18:06 +0530 Subject: [PATCH 1/2] Fixed bug where icons were missing in plus menu --- .../categories_list/header/plus_menu/item.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/screens/home/channel_list/categories_list/header/plus_menu/item.tsx b/app/screens/home/channel_list/categories_list/header/plus_menu/item.tsx index 34c61a2a3..f1455daf6 100644 --- a/app/screens/home/channel_list/categories_list/header/plus_menu/item.tsx +++ b/app/screens/home/channel_list/categories_list/header/plus_menu/item.tsx @@ -16,24 +16,24 @@ const PlusMenuItem = ({pickerAction, onPress}: PlusMenuItemProps) => { const menuItems = { browseChannels: { - icon: 'globe', + leftIcon: 'globe', text: intl.formatMessage({id: 'plus_menu.browse_channels.title', defaultMessage: 'Browse Channels'}), testID: 'plus_menu_item.browse_channels', }, createNewChannel: { - icon: 'plus', + leftIcon: 'plus', text: intl.formatMessage({id: 'plus_menu.create_new_channel.title', defaultMessage: 'Create New Channel'}), testID: 'plus_menu_item.create_new_channel', }, openDirectMessage: { - icon: 'account-outline', + leftIcon: 'account-outline', text: intl.formatMessage({id: 'plus_menu.open_direct_message.title', defaultMessage: 'Open a Direct Message'}), testID: 'plus_menu_item.open_direct_message', }, invitePeopleToTeam: { - icon: 'account-plus-outline', + leftIcon: 'account-plus-outline', text: intl.formatMessage({id: 'plus_menu.invite_people_to_team.title', defaultMessage: 'Invite people to the team'}), testID: 'plus_menu_item.invite_people_to_team', }, From ead1a2f73b87a8ba515e1852360d4e14e18504fa Mon Sep 17 00:00:00 2001 From: harshil Sharma Date: Tue, 31 Oct 2023 07:24:34 +0530 Subject: [PATCH 2/2] added types --- .../home/channel_list/categories_list/header/plus_menu/item.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/screens/home/channel_list/categories_list/header/plus_menu/item.tsx b/app/screens/home/channel_list/categories_list/header/plus_menu/item.tsx index f1455daf6..5a73b923b 100644 --- a/app/screens/home/channel_list/categories_list/header/plus_menu/item.tsx +++ b/app/screens/home/channel_list/categories_list/header/plus_menu/item.tsx @@ -14,7 +14,7 @@ type PlusMenuItemProps = { const PlusMenuItem = ({pickerAction, onPress}: PlusMenuItemProps) => { const intl = useIntl(); - const menuItems = { + const menuItems: {[key: string]: Omit, 'onPress'>} = { browseChannels: { leftIcon: 'globe', text: intl.formatMessage({id: 'plus_menu.browse_channels.title', defaultMessage: 'Browse Channels'}),