toki/mattermost-mobile
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

MM-18642 Ensure SSL exception is thrown for bad servers (#4299)

Browse source 
Without the explicitly thrown exception, the TLS handshake never exits cleanly as it should ( [conversation](https://community.mattermost.com/private-core/pl/36cp76j5g3r7z8hre1pr8hfhmy) )
This commit is contained in:
Amit Uttam 2020-05-14 10:00:23 -03:00 committed by GitHub
parent 1f59cbfa28
commit 8d26fb0c0d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
patches/rn-fetch-blob+0.12.0.patch
View file

@ -194,7 +194,7 @@ index a8abd71..9078855 100644
if(rnFetchBlobFileResp != null && !rnFetchBlobFileResp.isDownloadComplete()){
callback.invoke("Download interrupted.", null);
diff --git a/node_modules/rn-fetch-blob/android/src/main/java/com/RNFetchBlob/RNFetchBlobUtils.java b/node_modules/rn-fetch-blob/android/src/main/java/com/RNFetchBlob/RNFetchBlobUtils.java
index ab35fdd..69f4b49 100644
index ab35fdd..60465a0 100644
--- a/node_modules/rn-fetch-blob/android/src/main/java/com/RNFetchBlob/RNFetchBlobUtils.java
+++ b/node_modules/rn-fetch-blob/android/src/main/java/com/RNFetchBlob/RNFetchBlobUtils.java
@@ -6,12 +6,16 @@ import com.facebook.react.modules.core.DeviceEventManagerModule;
@ -233,7 +233,7 @@ index ab35fdd..69f4b49 100644
}
public static OkHttpClient.Builder getUnsafeOkHttpClient(OkHttpClient client) {
@@ -92,4 +98,59 @@ public class RNFetchBlobUtils {
@@ -92,4 +98,60 @@ public class RNFetchBlobUtils {
throw new RuntimeException(e);
}
}
@ -255,6 +255,7 @@ index ab35fdd..69f4b49 100644
+ defaultTrustManager.checkServerTrusted(chain, authType);
+ } catch(CertificateException ce) {
+ emitWarningEvent("RNFetchBlob custom: Server presented problem with SSL handshake.", RNFetchBlobConst.EVENT_SSL_TRUST_MESSAGE);
+ throw ce;
+ }
+ }
+