From 8f23aeeae5bafe5b38985fd0ddb00a917f44178e Mon Sep 17 00:00:00 2001 From: Jesse Hallam Date: Mon, 13 Jan 2020 16:47:24 -0400 Subject: [PATCH] Revert "MM-17519: do not stringify booleans (#3717)" (#3803) This reverts commit 765545570f88fd99c186c2b7927787b939ea90e3. --- app/components/widgets/settings/bool_setting.js | 2 +- app/components/widgets/settings/bool_setting.test.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/components/widgets/settings/bool_setting.js b/app/components/widgets/settings/bool_setting.js index 72bd9c61a..11a0dff8c 100644 --- a/app/components/widgets/settings/bool_setting.js +++ b/app/components/widgets/settings/bool_setting.js @@ -41,7 +41,7 @@ export default class BoolSetting extends PureComponent { }; handleChange = (value) => { - this.props.onChange(this.props.id, Boolean(value)); + this.props.onChange(this.props.id, `${value}`); }; render() { diff --git a/app/components/widgets/settings/bool_setting.test.js b/app/components/widgets/settings/bool_setting.test.js index db89e1d46..72c9da7f7 100644 --- a/app/components/widgets/settings/bool_setting.test.js +++ b/app/components/widgets/settings/bool_setting.test.js @@ -26,10 +26,10 @@ describe('components/widgets/settings/TextSetting', () => { wrapper.instance().handleChange(false); expect(onChange).toHaveBeenCalledTimes(1); - expect(onChange).toHaveBeenCalledWith('elementid', false); + expect(onChange).toHaveBeenCalledWith('elementid', 'false'); wrapper.instance().handleChange(true); expect(onChange).toHaveBeenCalledTimes(2); - expect(onChange).toHaveBeenCalledWith('elementid', true); + expect(onChange).toHaveBeenCalledWith('elementid', 'true'); }); });