toki/mattermost-mobile
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Automated cherry pick of #4192 (#4216)

Browse source 
* Fix infinite loop retrieving post files

Right now if all the attachments of a post are removed the component
update code enters into an infinite loop becuase the comparison between
arrays always return false.

* Move all the code inside the file changing detector condition

Co-authored-by: Mario de Frutos <mario@defrutos.org>
This commit is contained in:
Mattermost Build 2020-04-23 13:56:14 +02:00 committed by GitHub
parent 9f578461e4
commit 9434acd79a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/components/file_attachment_list/file_attachment_list.js
View file

@ -69,13 +69,11 @@ export default class FileAttachmentList extends PureComponent {
}
componentDidUpdate(prevProps) {
if (prevProps.files !== this.props.files) {
if (prevProps.files.length !== this.props.files.length) {
this.filesForGallery = this.getFilesForGallery(this.props);
this.buildGalleryFiles().then((results) => {
this.galleryFiles = results;
});
}
if (this.props.files !== prevProps.files && this.props.files.length === 0) {
this.loadFilesForPost();
}
}