From ae3d0107f831ab2c21523dcc43b24d2d40043ac0 Mon Sep 17 00:00:00 2001
From: Jesse Hallam <jesse.hallam@gmail.com>
Date: Thu, 12 Dec 2019 12:25:27 -0400
Subject: [PATCH] MM-17519: do not stringify booleans (#3693)

Match the webapp behaviour so as to avoid stringifying booleans in the interactive dialog payloads.

Fixes: https://mattermost.atlassian.net/browse/MM-17519
---
 app/components/widgets/settings/bool_setting.js      | 2 +-
 app/components/widgets/settings/bool_setting.test.js | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/components/widgets/settings/bool_setting.js b/app/components/widgets/settings/bool_setting.js
index 11a0dff8c..72bd9c61a 100644
--- a/app/components/widgets/settings/bool_setting.js
+++ b/app/components/widgets/settings/bool_setting.js
@@ -41,7 +41,7 @@ export default class BoolSetting extends PureComponent {
     };
 
     handleChange = (value) => {
-        this.props.onChange(this.props.id, `${value}`);
+        this.props.onChange(this.props.id, Boolean(value));
     };
 
     render() {
diff --git a/app/components/widgets/settings/bool_setting.test.js b/app/components/widgets/settings/bool_setting.test.js
index 72c9da7f7..db89e1d46 100644
--- a/app/components/widgets/settings/bool_setting.test.js
+++ b/app/components/widgets/settings/bool_setting.test.js
@@ -26,10 +26,10 @@ describe('components/widgets/settings/TextSetting', () => {
 
         wrapper.instance().handleChange(false);
         expect(onChange).toHaveBeenCalledTimes(1);
-        expect(onChange).toHaveBeenCalledWith('elementid', 'false');
+        expect(onChange).toHaveBeenCalledWith('elementid', false);
 
         wrapper.instance().handleChange(true);
         expect(onChange).toHaveBeenCalledTimes(2);
-        expect(onChange).toHaveBeenCalledWith('elementid', 'true');
+        expect(onChange).toHaveBeenCalledWith('elementid', true);
     });
 });