toki/mattermost-mobile
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Handle missing error on error response (#5461)

Browse source
This commit is contained in:
Daniel Espino García 2021-07-19 15:05:22 +02:00 committed by GitHub
parent 8f8338f547
commit bbd9bb3265
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 24 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
app/screens/apps_form/apps_form_component.tsx
View file

@ -184,23 +184,34 @@ export default class AppsFormComponent extends PureComponent<Props, State> {
updateErrors = (elements: DialogElement[], fieldErrors?: {[x: string]: string}, formError?: string): boolean => {
let hasErrors = false;
if (fieldErrors &&
Object.keys(fieldErrors).length >= 0 &&
checkIfErrorsMatchElements(fieldErrors as any, elements)
) {
hasErrors = true;
this.setState({fieldErrors});
}
const state = {} as State;
if (formError) {
hasErrors = true;
this.setState({formError});
if (this.scrollView?.current) {
this.scrollView.current.scrollTo({x: 0, y: 0});
state.formError = formError;
}
if (fieldErrors && Object.keys(fieldErrors).length >= 0) {
hasErrors = true;
if (checkIfErrorsMatchElements(fieldErrors as any, elements)) {
state.fieldErrors = fieldErrors;
} else if (!state.formError) {
const field = Object.keys(fieldErrors)[0];
state.formError = this.context.intl.formatMessage({
id: 'apps.error.responses.unknown_field_error',
defaultMessage: 'Received an error for an unkown field. Field name: `{field}`. Error: `{error}`.',
}, {
field,
error: fieldErrors[field],
});
}
}
if (hasErrors) {
this.setState(state);
if (state.formError && this.scrollView?.current) {
this.scrollView.current.scrollTo({x: 0, y: 0});
}
}
return hasErrors;
}

1
assets/base/i18n/en.json
View file

@ -45,6 +45,7 @@
"apps.error.responses.navigate.no_url": "Response type is `navigate`, but no url was included in response.",
"apps.error.responses.unexpected_error": "Received an unexpected error.",
"apps.error.responses.unexpected_type": "App response type was not expected. Response type: {type}.",
"apps.error.responses.unknown_field_error": "Received an error for an unkown field. Field name: `{field}`. Error: `{error}`.",
"apps.error.responses.unknown_type": "App response type not supported. Response type: {type}.",
"apps.error.unknown": "Unknown error occurred.",
"apps.suggestion.dynamic.error": "Dynamic select error",