toki/mattermost-mobile
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[MM-36792] Consistent query param names (#5643)

Browse source 
Summary
Be consistent with query parameter names: use `per_page` instead of `pageSize` for the Thread API. The server will continue to support the `pageSize` parameter until version 6.0 of the server becomes the minimum server version required for the mobile app. 

Related PRs:
[MM-36792] limit number of threads returned from SQL store mattermost-server#18260
[MM-36792] Consistent query param names mattermost-webapp#8700

Ticket Link
https://mattermost.atlassian.net/browse/MM-36792
This commit is contained in:
Ashish Bhate 2021-08-31 19:20:10 +05:30 committed by GitHub
parent 52a3e22a8d
commit c90d040b40
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
app/client/rest/posts.ts
View file

@ -4,7 +4,7 @@
import {analytics} from '@init/analytics';
import {FileInfo} from '@mm-redux/types/files';
import {Post} from '@mm-redux/types/posts';
import {buildQueryString} from '@mm-redux/utils/helpers';
import {buildQueryString, isMinimumServerVersion} from '@mm-redux/utils/helpers';
import {PER_PAGE_DEFAULT} from './constants';
@ -126,9 +126,16 @@ const ClientPosts = (superclass: any) => class extends superclass {
);
};
getUserThreads = async (userId: string, teamId: string, before = '', after = '', pageSize = PER_PAGE_DEFAULT, extended = false, deleted = false, unread = false, since = 0) => {
getUserThreads = async (userId: string, teamId: string, before = '', after = '', perPage = PER_PAGE_DEFAULT, extended = false, deleted = false, unread = false, since = 0) => {
const serverVersion = this.getServerVersion();
let queryStringObj;
if (isMinimumServerVersion(serverVersion, 6, 0)) {
queryStringObj = {before, after, per_page: perPage, extended, deleted, unread, since};
} else {
queryStringObj = {before, after, pageSize: perPage, extended, deleted, unread, since};
}
return this.doFetch(
`${this.getUserThreadsRoute(userId, teamId)}${buildQueryString({before, after, pageSize, extended, deleted, unread, since})}`,
`${this.getUserThreadsRoute(userId, teamId)}${buildQueryString(queryStringObj)}`,
{method: 'get'},
);
};