toki/mattermost-mobile
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Displayed channel related error with name field

Browse source
This commit is contained in:
harshil Sharma 2023-11-16 17:06:39 +05:30
parent e7b3aede18
commit cec7961d18
2 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
app/constants/server_errors.ts
View file

@ -7,4 +7,5 @@ export default {
PLUGIN_DISMISSED_POST_ERROR: 'plugin.message_will_be_posted.dismiss_post',
SEND_EMAIL_WITH_DEFAULTS_ERROR: 'api.team.invite_members.unable_to_send_email_with_defaults.app_error',
TEAM_MEMBERSHIP_DENIAL_ERROR_ID: 'api.team.add_members.user_denied',
DUPLICATE_CHANNEL_NAME: 'store.sql_channel.save_channel.exists.app_error',
};

13
app/screens/convert_gm_to_channel/convert_gm_to_channel_form/convert_gm_to_channel_form.tsx
View file

@ -8,9 +8,10 @@ import {Text, View} from 'react-native';
import {convertGroupMessageToPrivateChannel, switchToChannelById} from '@actions/remote/channel';
import Button from '@components/button';
import Loading from '@components/loading';
import {ServerErrors} from '@constants';
import {useServerUrl} from '@context/server';
import {useTheme} from '@context/theme';
import {isErrorWithMessage} from '@utils/errors';
import {isErrorWithMessage, isServerError} from '@utils/errors';
import {logError} from '@utils/log';
import {preventDoubleTap} from '@utils/tap';
import {changeOpacity, makeStyleSheetFromTheme} from '@utils/theme';
@ -65,6 +66,7 @@ export const ConvertGMToChannelForm = ({
const [selectedTeam, setSelectedTeam] = useState<Team>(commonTeams[0]);
const [newChannelName, setNewChannelName] = useState<string>('');
const [errorMessage, setErrorMessage] = useState<string>('');
const [channelNameErrorMessage, setChannelNameErrorMessage] = useState<string>('');
const [conversionInProgress, setConversionInProgress] = useState(false);
const userDisplayNames = useMemo(() => profiles.map((profile) => displayUsername(profile, locale, teammateNameDisplay)), [profiles, teammateNameDisplay, locale]);
@ -79,7 +81,9 @@ export const ConvertGMToChannelForm = ({
const {updatedChannel, error} = await convertGroupMessageToPrivateChannel(serverUrl, channelId, selectedTeam.id, newChannelName);
if (error) {
if (isErrorWithMessage(error)) {
if (isServerError(error) && error.server_error_id === ServerErrors.DUPLICATE_CHANNEL_NAME && isErrorWithMessage(error)) {
setChannelNameErrorMessage(error.message);
} else if (isErrorWithMessage(error)) {
setErrorMessage(error.message);
} else {
setErrorMessage(formatMessage({id: 'channel_info.convert_gm_to_channel.conversion_error', defaultMessage: 'Something went wrong. Failed to convert Group Message to Private Channel.'}));
@ -153,7 +157,10 @@ export const ConvertGMToChannelForm = ({
selectedTeamId={selectedTeam?.id}
/>
}
<ChannelNameInput onChange={setNewChannelName}/>
<ChannelNameInput
onChange={setNewChannelName}
error={channelNameErrorMessage}
/>
<Button
onPress={handleOnPress}
text={confirmButtonText}