From d88f59bc6b969e3dcd7330fbfb821de3873f11ce Mon Sep 17 00:00:00 2001 From: Harrison Healey Date: Fri, 11 Aug 2017 16:45:13 -0400 Subject: [PATCH] RN-282 Switched usage of splice to slice (#850) --- app/screens/channel_add_members/channel_add_members.js | 2 +- app/screens/channel_members/channel_members.js | 2 +- app/screens/more_channels/more_channels.js | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/screens/channel_add_members/channel_add_members.js b/app/screens/channel_add_members/channel_add_members.js index f73fa5970..087b1c6de 100644 --- a/app/screens/channel_add_members/channel_add_members.js +++ b/app/screens/channel_add_members/channel_add_members.js @@ -86,7 +86,7 @@ class ChannelAddMembers extends PureComponent { nextProps.loadMoreRequestStatus === RequestStatus.SUCCESS) { const {page} = this.state; const profiles = markSelectedProfiles( - nextProps.membersNotInChannel.splice(0, (page + 1) * General.PROFILE_CHUNK_SIZE), + nextProps.membersNotInChannel.slice(0, (page + 1) * General.PROFILE_CHUNK_SIZE), this.state.selectedMembers ); this.setState({profiles, showNoResults: true}); diff --git a/app/screens/channel_members/channel_members.js b/app/screens/channel_members/channel_members.js index 428268887..00b22aa83 100644 --- a/app/screens/channel_members/channel_members.js +++ b/app/screens/channel_members/channel_members.js @@ -86,7 +86,7 @@ class ChannelMembers extends PureComponent { nextProps.requestStatus === RequestStatus.SUCCESS) { const {page} = this.state; const profiles = markSelectedProfiles( - nextProps.currentChannelMembers.splice(0, (page + 1) * General.PROFILE_CHUNK_SIZE), + nextProps.currentChannelMembers.slice(0, (page + 1) * General.PROFILE_CHUNK_SIZE), this.state.selectedMembers ); this.setState({profiles, showNoResults: true}); diff --git a/app/screens/more_channels/more_channels.js b/app/screens/more_channels/more_channels.js index 7ffd560f9..be0975d3b 100644 --- a/app/screens/more_channels/more_channels.js +++ b/app/screens/more_channels/more_channels.js @@ -57,7 +57,7 @@ class MoreChannels extends PureComponent { this.searchTimeoutId = 0; this.state = { - channels: props.channels.splice(0, General.CHANNELS_CHUNK_SIZE), + channels: props.channels.slice(0, General.CHANNELS_CHUNK_SIZE), createScreenVisible: false, page: 0, adding: false, @@ -102,7 +102,7 @@ class MoreChannels extends PureComponent { } else if (requestStatus.status === RequestStatus.STARTED && nextProps.requestStatus.status === RequestStatus.SUCCESS) { const {page} = this.state; - const channels = nextProps.channels.splice(0, (page + 1) * General.CHANNELS_CHUNK_SIZE); + const channels = nextProps.channels.slice(0, (page + 1) * General.CHANNELS_CHUNK_SIZE); this.setState({channels, showNoResults: true}); }