From e744083833778a6ebf48ca917b11005ff092efd1 Mon Sep 17 00:00:00 2001 From: Saturnino Abril Date: Wed, 20 Mar 2019 22:15:01 +0800 Subject: [PATCH] remove state.value and rely only on props.value (#2635) --- .../search_bar/search_bar.android.js | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/app/components/search_bar/search_bar.android.js b/app/components/search_bar/search_bar.android.js index 83aef1b22..bcc15db7a 100644 --- a/app/components/search_bar/search_bar.android.js +++ b/app/components/search_bar/search_bar.android.js @@ -68,22 +68,11 @@ export default class SearchBarAndroid extends PureComponent { constructor(props) { super(props); this.state = { - value: props.value, isFocused: false, refocusInput: true, }; } - static getDerivedStateFromProps(nextProps, prevState) { - if (nextProps.value !== prevState.value) { - return { - value: nextProps.value, - }; - } - - return null; - } - cancel = () => { this.onCancelButtonPress(); }; @@ -107,7 +96,6 @@ export default class SearchBarAndroid extends PureComponent { InteractionManager.runAfterInteractions(() => { this.setState({ isFocused: false, - value: '', }, () => { this.props.onCancelButtonPress(); }); @@ -119,9 +107,7 @@ export default class SearchBarAndroid extends PureComponent { }; onChangeText = (value) => { - this.setState({value}, () => { - this.props.onChangeText(value); - }); + this.props.onChangeText(value); }; onSelectionChange = (event) => { @@ -219,7 +205,7 @@ export default class SearchBarAndroid extends PureComponent { ref='input' blurOnSubmit={blurOnSubmit} refocusInput={this.state.refocusInput} - value={this.state.value} + value={this.props.value} autoCapitalize={autoCapitalize} autoCorrect={false} returnKeyType={returnKeyType || 'search'}