toki/mattermost-mobile
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

MM-25562 Fix dismiss reaction list crash (#4353)

Browse source
This commit is contained in:
Elias Nahum 2020-05-27 12:45:35 -04:00 committed by GitHub
parent d100d646f2
commit ee05367cae
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 13 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/components/slide_up_panel/slide_up_panel.js
View file

@ -221,7 +221,7 @@ export default class SlideUpPanel extends PureComponent {
scrollToTop = () => {
if (this.scrollViewRef?.current) {
this.scrollViewRef.current._component.scrollTo({ //eslint-disable-line no-underscore-dangle
this.scrollViewRef.current.scrollTo({
x: 0,
y: 0,
animated: false,

2
app/screens/reaction_list/index.js
View file

@ -19,7 +19,7 @@ function makeMapStateToProps() {
const getProfilesByIdsAndUsernames = makeGetProfilesByIdsAndUsernames();
return function mapStateToProps(state, ownProps) {
const reactions = getReactionsForPostSelector(state, ownProps.postId);
const reactions = getReactionsForPostSelector(state, ownProps.postId) || undefined;
const allUserIds = getUniqueUserIds(reactions);
return {

25
app/utils/error_handling.js
View file

@ -1,27 +1,22 @@
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
// See LICENSE.txt for license information.
import {
Alert,
} from 'react-native';
import {
setJSExceptionHandler,
setNativeExceptionHandler,
} from 'react-native-exception-handler';
import {Alert} from 'react-native';
import {setJSExceptionHandler, setNativeExceptionHandler} from 'react-native-exception-handler';
import {dismissAllModals} from '@actions/navigation';
import {purgeOfflineStore} from '@actions/views/root';
import {close as closeWebSocket} from '@actions/websocket';
import {DEFAULT_LOCALE, getTranslations} from '@i18n';
import {Client4} from '@mm-redux/client';
import {logError} from '@mm-redux/actions/errors';
import {close as closeWebSocket} from '@actions/websocket';
import {purgeOfflineStore} from 'app/actions/views/root';
import {DEFAULT_LOCALE, getTranslations} from 'app/i18n';
import {t} from 'app/utils/i18n';
import {t} from '@utils/i18n';
import {
captureException,
captureJSException,
initializeSentry,
LOGGER_NATIVE,
} from 'app/utils/sentry';
} from '@utils/sentry';
class JavascriptAndNativeErrorHandler {
initializeErrorHandling = (store) => {
@ -63,7 +58,9 @@ class JavascriptAndNativeErrorHandler {
translations[t('mobile.error_handler.description')],
[{
text: translations[t('mobile.error_handler.button')],
onPress: () => {
onPress: async () => {
await dismissAllModals();
// purge the store
dispatch(purgeOfflineStore());
},