toki/mattermost-mobile
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Fix flaky biometric authentication test (#8995)

Browse source 
* Fix flaky biometric authentication test

Eliminates timing race conditions in SecurityManager test by using fixed timestamps instead of real Date.now() values. The test was failing inconsistently due to timing variations between test runs.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* use fake timers

* revert changes

---------

Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Guillermo Vayá 2025-08-04 10:41:03 +02:00 committed by GitHub
parent f4530653e3
commit f7162c9ab6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 23 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
app/managers/security_manager/index.test.ts
View file

@ -344,11 +344,29 @@ describe('SecurityManager', () => {
});
test('should not attempt biometric authentication if server was previously authenticated within 5 mins', async () => {
SecurityManager.addServer('server-12', {MobileEnableBiometrics: 'true'} as ClientConfig, true);
SecurityManager.serverConfig['server-12'].lastAccessed = Date.now() - toMilliseconds({minutes: 1});
await expect(SecurityManager.authenticateWithBiometricsIfNeeded('server-12')).resolves.toBe(true);
expect(Emm.isDeviceSecured).not.toHaveBeenCalled();
expect(Emm.authenticate).not.toHaveBeenCalled();
// Mock toMilliseconds locally to return correct value for this test
const originalToMilliseconds = jest.requireActual('@utils/datetime').toMilliseconds;
jest.mocked(require('@utils/datetime').toMilliseconds).mockImplementation(originalToMilliseconds);
// Use a fixed timestamp instead of Date.now() to eliminate timing races
const fixedTime = 1672574400000; // Fixed timestamp: Jan 1, 2023 12:00:00 GMT
const oneMinuteAgo = fixedTime - (60 * 1000);
// Mock Date.now to return our fixed time
const originalDateNow = Date.now;
Date.now = jest.fn(() => fixedTime);
try {
SecurityManager.addServer('server-12', {MobileEnableBiometrics: 'true'} as ClientConfig, true);
SecurityManager.serverConfig['server-12'].lastAccessed = oneMinuteAgo;
await expect(SecurityManager.authenticateWithBiometricsIfNeeded('server-12')).resolves.toBe(true);
expect(Emm.isDeviceSecured).not.toHaveBeenCalled();
expect(Emm.authenticate).not.toHaveBeenCalled();
} finally {
// Restore original implementations
Date.now = originalDateNow;
jest.mocked(require('@utils/datetime').toMilliseconds).mockReturnValue(25000);
}
});
test('should not attempt biometric authentication if server was previously failed authentication even though lastAccess is less than 5 mins', async () => {