From fa10680ef3c535bfd15a43a4de9d9c456fd18f5c Mon Sep 17 00:00:00 2001
From: Chris Duarte <csduarte@users.noreply.github.com>
Date: Fri, 28 Dec 2018 03:31:10 -0800
Subject: [PATCH] Fixes for duplicate text on message attachments, empty space
 when attachment has no title (#2460)

---
 .../message_attachments/attachment_fields.js  | 20 ++++++++++---------
 .../message_attachments/message_attachment.js |  2 +-
 2 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/app/components/message_attachments/attachment_fields.js b/app/components/message_attachments/attachment_fields.js
index cb96cff17..dd42f57f0 100644
--- a/app/components/message_attachments/attachment_fields.js
+++ b/app/components/message_attachments/attachment_fields.js
@@ -66,16 +66,18 @@ export default class AttachmentFields extends PureComponent {
                     style={style.flex}
                     key={`attachment__field-${i}__${nrTables}`}
                 >
-                    <View
-                        style={style.headingContainer}
-                        key={`attachment__field-caption-${i}__${nrTables}`}
-                    >
-                        <View>
-                            <Text style={style.heading}>
-                                {field.title}
-                            </Text>
+                    {Boolean(field.title) && (
+                        <View
+                            style={style.headingContainer}
+                            key={`attachment__field-caption-${i}__${nrTables}`}
+                        >
+                            <View>
+                                <Text style={style.heading}>
+                                    {field.title}
+                                </Text>
+                            </View>
                         </View>
-                    </View>
+                    )}
                     <View
                         style={style.flex}
                         key={`attachment__field-${i}__${nrTables}`}
diff --git a/app/components/message_attachments/message_attachment.js b/app/components/message_attachments/message_attachment.js
index 19fd18e25..9ff263e2c 100644
--- a/app/components/message_attachments/message_attachment.js
+++ b/app/components/message_attachments/message_attachment.js
@@ -97,7 +97,7 @@ export default class MessageAttachment extends PureComponent {
                         navigator={navigator}
                         onPermalinkPress={onPermalinkPress}
                         textStyles={textStyles}
-                        value={attachment.text || attachment.fallback}
+                        value={attachment.text}
                     />
                     <AttachmentFields
                         baseTextStyle={baseTextStyle}