Commit graph

26 commits

Author SHA1 Message Date
Amit Uttam
0f70af7b16 MM-15469 (Android) Alert if shared text is longer than message limit (#3264)
* MM-15469 Alert if shared text is longer than message limit

One can't manually enter text into the share extension's text box past 4000 characters (the default/defined text size limit). However, this restriction can still be circumvented by sharing a large item of text. In this latter case, the textarea displays just the first 4000 characters, but the value buffer still contains the entire shared text. On hitting "Send", the oversize text can still be shared.

This commit implements [MM-15469](https://mattermost.atlassian.net/browse/MM-15469) to better align the Android sharing user experience with the iOS experience.

Since a pre-existing i18n string was used, no additional translations are required.

Fixes https://github.com/mattermost/mattermost-server/issues/11431

* Add available characters remaining counter in Android Share textarea

Shows number of available characters remaining until textarea limit (default
= 4000). Similar to iOS experience.

**iOS (normal)**

![iOS (normal)](https://user-images.githubusercontent.com/887849/65007527-d6d1f700-d8dc-11e9-9382-7e4b3c6f4f5d.png)

**Android (normal)**

![Android (normal)](https://user-images.githubusercontent.com/887849/65007570-f2d59880-d8dc-11e9-9795-ed137e4dd506.jpg)

**iOS (past limit)**

![iOS (past limit)](https://user-images.githubusercontent.com/887849/65007638-2b757200-d8dd-11e9-987d-f5e89b2aa0d3.png)

**Android (past limit)**

![Android (past limit)](https://user-images.githubusercontent.com/887849/65007720-5e1f6a80-d8dd-11e9-97ba-370fa6c8db58.jpg)

* Don't limit size of Android Share extension text input box

Pasted shared text was getting cut off after hitting the `MAX_MESSAGE_LENGTH` for shared posts. Alert validation now checks this limit before allowing content to be posted, which made the `maxLength` limit redundant.

Context: https://github.com/mattermost/mattermost-mobile/pull/3264#issuecomment-540962933
2019-10-16 09:51:06 +03:00
Amit Uttam
1f88356557 Expand text input area in Android Share extension to use available space (#3262) 2019-09-16 12:03:20 -07:00
Elias Nahum
89b96d51db MM-16430 refactor app entry point (#2924)
* MM-16430 refactor app entry point

* iOS Extensions to use session token from KeyChain

* Remove token from general credentials entity

* Fix mattermost-managed.ios to return the cachedConfig

* Migrate server based keychain for android push notifications

* remove unneeded async

* Remove unneeded android InitializationModule
2019-06-26 15:21:20 -04:00
Elias Nahum
c3c3d85248
MM-16095 Android share extension to use keychain for authentication (#2876)
* MM-16095 Android share extension to use keychain for authentication

* Remove unnecessary comment
2019-06-15 14:13:54 -04:00
Harrison Healey
6e099d6a21 MM-15643 Send user to settings when passcode is required (#2836)
* MM-15643 Send user to settings when passcode is required

* Allow access to the managed config in the iOS extensions
2019-05-27 19:38:32 -04:00
Elias Nahum
5183bc4b50 MM-15215 fix crash caused by malformed post textbox localize string 2019-04-18 18:24:36 -04:00
Elias Nahum
88f5848850
Dependencies update (#2576)
* Dependencies update

* Fix WebView

* Update to RN 0.58.5 and include the WebSocket fix

* Update react-native-video

* Fix RNFetchBlob
2019-02-20 17:17:04 -03:00
Sudheer
d627f96589
MM-13866 Never ending loader if app is un authenticated (#2539)
* if token or url is not present setState of loaded flag to true
2019-01-31 20:12:25 +05:30
Elias Nahum
d5a9a058bb
Fetch team channels on extension init (#2383) 2018-11-27 19:45:44 -03:00
Harrison Healey
cfb372f75a
MM-11157 Switch ESLint to use eslint-config-mattermost (#2247) 2018-10-11 13:35:25 -04:00
Elias Nahum
b20e976dff
Properly handle max file size (#2248)
* Properly handle max file size

* Feedback review
2018-10-11 14:11:05 -03:00
Elias Nahum
637ca9244a
Update RN to version 0.57.0 (#2131) 2018-09-20 19:05:41 -03:00
Saturnino Abril
0afdbdd0f9 remove backgroundColor from styles.video of Android share extension that's causing app to crash (#2119) 2018-09-14 09:10:10 -03:00
Jesús Espino
1456c7cf29 MM-11718: Show only non-archived channels on Share (#2059) 2018-08-30 14:37:36 -04:00
Elias Nahum
96e9c6c707 Update rn-fetch-blob and CBA support for iOS (#2033)
* Update rn-fetch-blob and CBA support for iOS

* remove trusty

* remove react-native-fast-image dependency
2018-08-29 14:01:37 -04:00
Elias Nahum
cf85c3c1e8 Fix Android share extension and better handle errors (#1965) 2018-08-03 13:18:21 -04:00
Harrison Healey
dee530cce7 MM-11116 Re-added updated QuickTextInput component to work around RN issue (#1859) 2018-07-02 09:09:31 -04:00
Martin Kraft
3bde858a64 MM-10717: Update longpress buttons when add reaction, edit post, or d… (#1779)
* MM-10717: Update longpress buttons when add reaction, edit post, or delete post permissions change.

* MM-10717: Makes tooltip actions prop required.

* MM-10717: Switches all direct access of 'config' and 'license' to use selectors.
2018-06-21 08:43:17 -04:00
Jesse Hallam
8372e95d4a add eslint-plugin-header, and --fix all (#1726) 2018-06-19 19:14:50 -04:00
Elias Nahum
8e0d167f95 Fix push notification and emm race conditions (#1691)
* Fix push notification and emm race conditions

* feedback review

* Removed unnecesary code
2018-05-22 11:02:14 -04:00
Elias Nahum
aebe22f58d
Fix Android sharing files without extension (#1646) 2018-04-30 11:57:24 -03:00
Harrison Healey
e300ed5c88 Replaced occurances of wrapWithPreventDoubleTap with preventDoubleTap (#1499) 2018-03-14 00:14:35 +08:00
Jesse Hallam
58b72302d6 update eslint's comma-dangle rule to always-multiline (#1457)
* update eslint's `comma-dangle` rule to `always-multiline`

* add check and fix scripts to package.json

* Invoke `yarn fix` to adopt the updated eslint rules. No other changes are included.
2018-02-23 09:06:02 -05:00
enahum
509fe37f1f
[ICU-676] Make the app extensions follow the max file size that the server accepts (#1411)
* Android Share extension follows server config file size limit

* iOS Share extention follows config file size limit

* feedback review
2018-02-07 18:02:38 -03:00
enahum
676a3c4bda
Fix share extension (#1386)
* Remove iOS extension garbage code

* Fix Android Share Extension crash
2018-01-26 18:50:08 -03:00
enahum
926ffe96c5
Android share extension (#1352)
* Android share extension

* Feedback review

* Feedback review
2018-01-17 18:17:02 -03:00