* Initial setup for new keyboard * fix the offset calculation onMove by adding isKeyboardFullyOpened * Done with the keyboard handling implementation * Handled keyboard focus and blured state using context * Added default height for input container * Android support * Tablet state handling * Fix for refreshing offset in list * Created a default context for mention post list * Fix linter errors * Fix tests * Minor * Fix the height issue for tablet view * Review comments * Dependency fix * Reveiw comment * keyboard animation only enabled with screen on top navigation * added tests * Added extra keyboard component for emoji picker (#9328) * Added extra keyboard component * handled swipe geature for extra keyboard * scroll to bottom visible on emoji picker * Check for stale event for keyboard geature area * fix keyboard stale event for mid-gesture change swipe direction * Closing emoji picker when message priority is opened * changing to thread view closes emoji picker * Close emoij picker and keyboard when attachment icons are clicked * handle android emoji picker behaviour * Remove emoji picker code * fix tests * Address reviev comments * Test fixes * usePreventDoubleTab for race condition and corrected comment on isInputAccessoryViewMode flag * File attachments option in bottom sheet quick action (#9331) * Added extra keyboard component * handled swipe geature for extra keyboard * File attachments option in bottom sheet quick action * Updated tests * i18n * fix test * Added tests * Review comment * fix tests * Integrated Emoji picker to Extra keyboard component. (#9339) * Added extra keyboard component * handled swipe geature for extra keyboard * scroll to bottom visible on emoji picker * Fix the post input container height change issue * Added emoji picker with search functionality * keyboard height not recorded fallback to default height, set search to false closing emoji picker * fix search funcitonality in android * scroll to end bottom dismissed with pressed * Fixed the scroll issue for android * fix the flickering post input issue * Wired up the emoji picker * Added keyboard and spaceback in emoji picker * intl extract * initial cursor position and simple calculation review comment * separated grapheme to utils file * Review comments * nitpick * Fix the bottom safe area and navigation stack restore fix * Fix test * disabled emoji picker in edit post screen * change the name of the variable to name it clarier * fix the tab gap issue in andriod * disabled the emoji skin tone change on andriod * fix the input container jump issue * fix the failing test * UX review * added white space after the attachment icon * When @ or / is press open keyboard on andriod also fix the scroll issue when keyboard is open * back bottom closes emoji picker and opening keyboard jump fix * reverted code * fixed the flickering issue of input and scroll position fix * Fix the gap issue in thread * fix the warning reaminated issue when opening a channel * Fix the extra space issue between input and emoij picker * Minor fix for extra space between input and emoji picker * Fix thread view bottom safe area and gap between keyboard and searched emojis * Fix the keyboard issue in tablet * Fix the warning issue react-native-keyboard-controller * Fix tests * Fix the tablet search hight issue * Replaced the ExtraKeyboardProvider with KeyboardProvider from rnkc for permalink * Bottom sheet jump issue resolved * Search do not close after selecting emoji in search list * Added the bottom inset height in search emoji for android * fix buid issue * Fix the cancel state to emoji picker * use portals for autocomplete * fix permalink extra space in post list * Portal only for android --------- Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: Rahim Rahman <rahim.rahman@mattermost.com> Co-authored-by: Harshil Sharma <harshilsharma63@gmail.com> Co-authored-by: Elias Nahum <nahumhbl@gmail.com>
248 lines
8.5 KiB
TypeScript
248 lines
8.5 KiB
TypeScript
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
import {renderHook, act} from '@testing-library/react-hooks';
|
|
import {BehaviorSubject} from 'rxjs';
|
|
|
|
import {Screens} from '@constants';
|
|
import NavigationStore from '@store/navigation_store';
|
|
|
|
import {useIsScreenVisible} from './use_screen_visibility';
|
|
|
|
const mockSubject = new BehaviorSubject<string | undefined>(undefined);
|
|
|
|
jest.mock('@store/navigation_store', () => ({
|
|
getVisibleScreen: jest.fn(() => mockSubject.value),
|
|
getSubject: jest.fn(() => mockSubject),
|
|
}));
|
|
|
|
describe('useIsScreenVisible', () => {
|
|
const mockNavigationStore = NavigationStore as jest.Mocked<typeof NavigationStore>;
|
|
|
|
beforeEach(() => {
|
|
jest.clearAllMocks();
|
|
mockSubject.next(undefined);
|
|
});
|
|
|
|
describe('initialization', () => {
|
|
it('should return false when componentId is undefined', () => {
|
|
const {result} = renderHook(() => useIsScreenVisible(undefined));
|
|
|
|
expect(result.current).toBe(false);
|
|
});
|
|
|
|
it('should return true when componentId matches visible screen on mount', () => {
|
|
mockSubject.next(Screens.CHANNEL);
|
|
mockNavigationStore.getVisibleScreen.mockReturnValue(Screens.CHANNEL);
|
|
|
|
const {result} = renderHook(() => useIsScreenVisible(Screens.CHANNEL));
|
|
|
|
expect(result.current).toBe(true);
|
|
});
|
|
|
|
it('should return false when componentId does not match visible screen on mount', () => {
|
|
mockSubject.next(Screens.CHANNEL);
|
|
mockNavigationStore.getVisibleScreen.mockReturnValue(Screens.CHANNEL);
|
|
|
|
const {result} = renderHook(() => useIsScreenVisible(Screens.THREAD));
|
|
|
|
expect(result.current).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe('subscription updates', () => {
|
|
it('should update when visible screen changes to match componentId', () => {
|
|
mockSubject.next(Screens.CHANNEL);
|
|
mockNavigationStore.getVisibleScreen.mockReturnValue(Screens.CHANNEL);
|
|
|
|
const {result} = renderHook(() => useIsScreenVisible(Screens.THREAD));
|
|
|
|
expect(result.current).toBe(false);
|
|
|
|
act(() => {
|
|
mockSubject.next(Screens.THREAD);
|
|
});
|
|
|
|
expect(result.current).toBe(true);
|
|
});
|
|
|
|
it('should update when visible screen changes away from componentId', () => {
|
|
mockSubject.next(Screens.THREAD);
|
|
mockNavigationStore.getVisibleScreen.mockReturnValue(Screens.THREAD);
|
|
|
|
const {result} = renderHook(() => useIsScreenVisible(Screens.THREAD));
|
|
|
|
expect(result.current).toBe(true);
|
|
|
|
act(() => {
|
|
mockSubject.next(Screens.CHANNEL);
|
|
});
|
|
|
|
expect(result.current).toBe(false);
|
|
});
|
|
|
|
it('should handle multiple screen changes', () => {
|
|
mockSubject.next(Screens.CHANNEL);
|
|
mockNavigationStore.getVisibleScreen.mockReturnValue(Screens.CHANNEL);
|
|
|
|
const {result} = renderHook(() => useIsScreenVisible(Screens.THREAD));
|
|
|
|
act(() => {
|
|
mockSubject.next(Screens.THREAD);
|
|
});
|
|
expect(result.current).toBe(true);
|
|
|
|
act(() => {
|
|
mockSubject.next(Screens.CHANNEL);
|
|
});
|
|
expect(result.current).toBe(false);
|
|
|
|
act(() => {
|
|
mockSubject.next(Screens.THREAD);
|
|
});
|
|
expect(result.current).toBe(true);
|
|
});
|
|
|
|
it('should handle undefined visible screen', () => {
|
|
mockSubject.next(Screens.THREAD);
|
|
mockNavigationStore.getVisibleScreen.mockReturnValue(Screens.THREAD);
|
|
|
|
const {result} = renderHook(() => useIsScreenVisible(Screens.THREAD));
|
|
|
|
expect(result.current).toBe(true);
|
|
|
|
act(() => {
|
|
mockSubject.next(undefined);
|
|
});
|
|
|
|
expect(result.current).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe('componentId changes', () => {
|
|
it('should update when componentId changes', () => {
|
|
mockSubject.next(Screens.CHANNEL);
|
|
mockNavigationStore.getVisibleScreen.mockReturnValue(Screens.CHANNEL);
|
|
|
|
const {result, rerender} = renderHook(
|
|
({componentId}: {componentId?: typeof Screens.CHANNEL | typeof Screens.THREAD}) => useIsScreenVisible(componentId),
|
|
{initialProps: {componentId: Screens.CHANNEL}},
|
|
);
|
|
|
|
expect(result.current).toBe(true);
|
|
|
|
rerender({componentId: Screens.THREAD});
|
|
|
|
expect(result.current).toBe(false);
|
|
});
|
|
|
|
it('should set to false when componentId changes to undefined', () => {
|
|
mockSubject.next(Screens.CHANNEL);
|
|
mockNavigationStore.getVisibleScreen.mockReturnValue(Screens.CHANNEL);
|
|
|
|
const {result, rerender} = renderHook(
|
|
({componentId}: {componentId?: typeof Screens.CHANNEL}) => useIsScreenVisible(componentId),
|
|
{initialProps: {componentId: Screens.CHANNEL}},
|
|
);
|
|
|
|
expect(result.current).toBe(true);
|
|
|
|
rerender({componentId: undefined});
|
|
|
|
expect(result.current).toBe(false);
|
|
});
|
|
|
|
it('should subscribe to new componentId when it changes', () => {
|
|
mockSubject.next(Screens.CHANNEL);
|
|
mockNavigationStore.getVisibleScreen.mockReturnValue(Screens.CHANNEL);
|
|
|
|
const {result, rerender} = renderHook(
|
|
({componentId}: {componentId?: typeof Screens.CHANNEL | typeof Screens.THREAD}) => useIsScreenVisible(componentId),
|
|
{initialProps: {componentId: Screens.CHANNEL}},
|
|
);
|
|
|
|
rerender({componentId: Screens.THREAD});
|
|
|
|
act(() => {
|
|
mockSubject.next(Screens.THREAD);
|
|
});
|
|
|
|
expect(result.current).toBe(true);
|
|
});
|
|
});
|
|
|
|
describe('cleanup', () => {
|
|
it('should unsubscribe when component unmounts', () => {
|
|
const unsubscribe = jest.fn();
|
|
const subscribeSpy = jest.spyOn(mockSubject, 'subscribe').mockReturnValue({
|
|
unsubscribe,
|
|
} as unknown as ReturnType<typeof mockSubject.subscribe>);
|
|
|
|
const {unmount} = renderHook(() => useIsScreenVisible(Screens.CHANNEL));
|
|
|
|
unmount();
|
|
|
|
expect(unsubscribe).toHaveBeenCalled();
|
|
|
|
subscribeSpy.mockRestore();
|
|
});
|
|
|
|
it('should unsubscribe when componentId changes', () => {
|
|
const unsubscribe1 = jest.fn();
|
|
const unsubscribe2 = jest.fn();
|
|
let callCount = 0;
|
|
const subscribeSpy = jest.spyOn(mockSubject, 'subscribe').mockImplementation(() => {
|
|
callCount++;
|
|
if (callCount === 1) {
|
|
return {unsubscribe: unsubscribe1} as unknown as ReturnType<typeof mockSubject.subscribe>;
|
|
}
|
|
return {unsubscribe: unsubscribe2} as unknown as ReturnType<typeof mockSubject.subscribe>;
|
|
});
|
|
|
|
const {rerender} = renderHook(
|
|
({componentId}: {componentId?: typeof Screens.CHANNEL | typeof Screens.THREAD}) => useIsScreenVisible(componentId),
|
|
{initialProps: {componentId: Screens.CHANNEL}},
|
|
);
|
|
|
|
rerender({componentId: Screens.THREAD as typeof Screens.CHANNEL | typeof Screens.THREAD});
|
|
|
|
expect(unsubscribe1).toHaveBeenCalled();
|
|
|
|
subscribeSpy.mockRestore();
|
|
});
|
|
});
|
|
|
|
describe('edge cases', () => {
|
|
it('should handle rapid screen changes', () => {
|
|
mockSubject.next(Screens.CHANNEL);
|
|
mockNavigationStore.getVisibleScreen.mockReturnValue(Screens.CHANNEL);
|
|
|
|
const {result} = renderHook(() => useIsScreenVisible(Screens.THREAD));
|
|
|
|
act(() => {
|
|
mockSubject.next(Screens.THREAD);
|
|
mockSubject.next(Screens.CHANNEL);
|
|
mockSubject.next(Screens.THREAD);
|
|
});
|
|
|
|
expect(result.current).toBe(true);
|
|
});
|
|
|
|
it('should handle same screen being set multiple times', () => {
|
|
mockSubject.next(Screens.CHANNEL);
|
|
mockNavigationStore.getVisibleScreen.mockReturnValue(Screens.CHANNEL);
|
|
|
|
const {result} = renderHook(() => useIsScreenVisible(Screens.CHANNEL));
|
|
|
|
expect(result.current).toBe(true);
|
|
|
|
act(() => {
|
|
mockSubject.next(Screens.CHANNEL);
|
|
mockSubject.next(Screens.CHANNEL);
|
|
});
|
|
|
|
expect(result.current).toBe(true);
|
|
});
|
|
});
|
|
});
|
|
|