* Initial setup for new keyboard * fix the offset calculation onMove by adding isKeyboardFullyOpened * Done with the keyboard handling implementation * Handled keyboard focus and blured state using context * Added default height for input container * Android support * Tablet state handling * Fix for refreshing offset in list * Created a default context for mention post list * Fix linter errors * Fix tests * Minor * Fix the height issue for tablet view * Review comments * Dependency fix * Reveiw comment * keyboard animation only enabled with screen on top navigation * added tests * Added extra keyboard component for emoji picker (#9328) * Added extra keyboard component * handled swipe geature for extra keyboard * scroll to bottom visible on emoji picker * Check for stale event for keyboard geature area * fix keyboard stale event for mid-gesture change swipe direction * Closing emoji picker when message priority is opened * changing to thread view closes emoji picker * Close emoij picker and keyboard when attachment icons are clicked * handle android emoji picker behaviour * Remove emoji picker code * fix tests * Address reviev comments * Test fixes * usePreventDoubleTab for race condition and corrected comment on isInputAccessoryViewMode flag * File attachments option in bottom sheet quick action (#9331) * Added extra keyboard component * handled swipe geature for extra keyboard * File attachments option in bottom sheet quick action * Updated tests * i18n * fix test * Added tests * Review comment * fix tests * Integrated Emoji picker to Extra keyboard component. (#9339) * Added extra keyboard component * handled swipe geature for extra keyboard * scroll to bottom visible on emoji picker * Fix the post input container height change issue * Added emoji picker with search functionality * keyboard height not recorded fallback to default height, set search to false closing emoji picker * fix search funcitonality in android * scroll to end bottom dismissed with pressed * Fixed the scroll issue for android * fix the flickering post input issue * Wired up the emoji picker * Added keyboard and spaceback in emoji picker * intl extract * initial cursor position and simple calculation review comment * separated grapheme to utils file * Review comments * nitpick * Fix the bottom safe area and navigation stack restore fix * Fix test * disabled emoji picker in edit post screen * change the name of the variable to name it clarier * fix the tab gap issue in andriod * disabled the emoji skin tone change on andriod * fix the input container jump issue * fix the failing test * UX review * added white space after the attachment icon * When @ or / is press open keyboard on andriod also fix the scroll issue when keyboard is open * back bottom closes emoji picker and opening keyboard jump fix * reverted code * fixed the flickering issue of input and scroll position fix * Fix the gap issue in thread * fix the warning reaminated issue when opening a channel * Fix the extra space issue between input and emoij picker * Minor fix for extra space between input and emoji picker * Fix thread view bottom safe area and gap between keyboard and searched emojis * Fix the keyboard issue in tablet * Fix the warning issue react-native-keyboard-controller * Fix tests * Fix the tablet search hight issue * Replaced the ExtraKeyboardProvider with KeyboardProvider from rnkc for permalink * Bottom sheet jump issue resolved * Search do not close after selecting emoji in search list * Added the bottom inset height in search emoji for android * fix buid issue * Fix the cancel state to emoji picker * use portals for autocomplete * fix permalink extra space in post list * Portal only for android --------- Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: Rahim Rahman <rahim.rahman@mattermost.com> Co-authored-by: Harshil Sharma <harshilsharma63@gmail.com> Co-authored-by: Elias Nahum <nahumhbl@gmail.com>
430 lines
16 KiB
TypeScript
430 lines
16 KiB
TypeScript
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
import {fireEvent, waitFor} from '@testing-library/react-native';
|
|
import {Alert} from 'react-native';
|
|
|
|
import {Screens} from '@constants';
|
|
import {dismissBottomSheet} from '@screens/navigation';
|
|
import {renderWithIntlAndTheme} from '@test/intl-test-helper';
|
|
import PickerUtil from '@utils/file/file_picker';
|
|
|
|
import AttachmentOptions from './attachment_options';
|
|
|
|
jest.mock('@screens/navigation', () => ({
|
|
dismissBottomSheet: jest.fn(() => Promise.resolve()),
|
|
}));
|
|
|
|
jest.mock('@utils/file/file_picker');
|
|
|
|
jest.mock('@utils/file', () => ({
|
|
fileMaxWarning: jest.fn((...args) => `Maximum ${args[1]} files allowed`),
|
|
uploadDisabledWarning: jest.fn(() => 'File uploads are disabled'),
|
|
}));
|
|
|
|
jest.mock('@hooks/device', () => ({
|
|
useIsTablet: jest.fn(() => false),
|
|
}));
|
|
|
|
describe('AttachmentOptions', () => {
|
|
const mockDismissBottomSheet = dismissBottomSheet as jest.Mock;
|
|
const mockAttachFileFromPhotoGallery = jest.fn();
|
|
const mockAttachFileFromCamera = jest.fn();
|
|
const mockAttachFileFromFiles = jest.fn();
|
|
|
|
const baseProps = {
|
|
componentId: 'Channel' as const,
|
|
onUploadFiles: jest.fn(),
|
|
maxFileCount: 10,
|
|
fileCount: 0,
|
|
maxFilesReached: false,
|
|
canUploadFiles: true,
|
|
testID: 'test-attachment-options',
|
|
};
|
|
|
|
beforeEach(() => {
|
|
jest.clearAllMocks();
|
|
jest.spyOn(Alert, 'alert');
|
|
|
|
(PickerUtil as jest.Mock).mockImplementation(() => ({
|
|
attachFileFromPhotoGallery: mockAttachFileFromPhotoGallery,
|
|
attachFileFromCamera: mockAttachFileFromCamera,
|
|
attachFileFromFiles: mockAttachFileFromFiles,
|
|
}));
|
|
});
|
|
|
|
describe('action handlers', () => {
|
|
it('should call picker.attachFileFromPhotoGallery when photo library is selected', async () => {
|
|
const {getByTestId} = renderWithIntlAndTheme(
|
|
<AttachmentOptions {...baseProps}/>,
|
|
);
|
|
|
|
const photoLibraryItem = getByTestId('file_attachment.photo_library');
|
|
fireEvent.press(photoLibraryItem);
|
|
|
|
await waitFor(() => {
|
|
expect(mockDismissBottomSheet).toHaveBeenCalledWith(Screens.ATTACHMENT_OPTIONS);
|
|
expect(mockAttachFileFromPhotoGallery).toHaveBeenCalledWith(10);
|
|
});
|
|
});
|
|
|
|
it('should call picker.attachFileFromCamera when take photo is selected', async () => {
|
|
const {getByTestId} = renderWithIntlAndTheme(
|
|
<AttachmentOptions {...baseProps}/>,
|
|
);
|
|
|
|
const takePhotoItem = getByTestId('file_attachment.take_photo');
|
|
fireEvent.press(takePhotoItem);
|
|
|
|
await waitFor(() => {
|
|
expect(mockDismissBottomSheet).toHaveBeenCalledWith(Screens.ATTACHMENT_OPTIONS);
|
|
expect(mockAttachFileFromCamera).toHaveBeenCalledWith({
|
|
quality: 0.8,
|
|
mediaType: 'photo',
|
|
saveToPhotos: true,
|
|
});
|
|
});
|
|
});
|
|
|
|
it('should call picker.attachFileFromCamera when take video is selected', async () => {
|
|
const {getByTestId} = renderWithIntlAndTheme(
|
|
<AttachmentOptions {...baseProps}/>,
|
|
);
|
|
|
|
const takeVideoItem = getByTestId('file_attachment.take_video');
|
|
fireEvent.press(takeVideoItem);
|
|
|
|
await waitFor(() => {
|
|
expect(mockDismissBottomSheet).toHaveBeenCalledWith(Screens.ATTACHMENT_OPTIONS);
|
|
expect(mockAttachFileFromCamera).toHaveBeenCalledWith({
|
|
quality: 0.8,
|
|
videoQuality: 'high',
|
|
mediaType: 'video',
|
|
saveToPhotos: true,
|
|
});
|
|
});
|
|
});
|
|
|
|
it('should call picker.attachFileFromFiles when attach file is selected', async () => {
|
|
const {getByTestId} = renderWithIntlAndTheme(
|
|
<AttachmentOptions {...baseProps}/>,
|
|
);
|
|
|
|
const attachFileItem = getByTestId('file_attachment.attach_file');
|
|
fireEvent.press(attachFileItem);
|
|
|
|
await waitFor(() => {
|
|
expect(mockDismissBottomSheet).toHaveBeenCalledWith(Screens.ATTACHMENT_OPTIONS);
|
|
expect(mockAttachFileFromFiles).toHaveBeenCalledWith(undefined, true);
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('validation - canUploadFiles', () => {
|
|
it('should show alert and not call picker when canUploadFiles is false for photo library', async () => {
|
|
const props = {
|
|
...baseProps,
|
|
canUploadFiles: false,
|
|
};
|
|
const {getByTestId} = renderWithIntlAndTheme(
|
|
<AttachmentOptions {...props}/>,
|
|
);
|
|
|
|
const photoLibraryItem = getByTestId('file_attachment.photo_library');
|
|
fireEvent.press(photoLibraryItem);
|
|
|
|
await waitFor(() => {
|
|
expect(mockDismissBottomSheet).toHaveBeenCalledWith(Screens.ATTACHMENT_OPTIONS);
|
|
expect(Alert.alert).toHaveBeenCalledWith(
|
|
'Error',
|
|
'File uploads are disabled',
|
|
);
|
|
expect(mockAttachFileFromPhotoGallery).not.toHaveBeenCalled();
|
|
});
|
|
});
|
|
|
|
it('should show alert and not call picker when canUploadFiles is false for camera', async () => {
|
|
const props = {
|
|
...baseProps,
|
|
canUploadFiles: false,
|
|
};
|
|
const {getByTestId} = renderWithIntlAndTheme(
|
|
<AttachmentOptions {...props}/>,
|
|
);
|
|
|
|
const takePhotoItem = getByTestId('file_attachment.take_photo');
|
|
fireEvent.press(takePhotoItem);
|
|
|
|
await waitFor(() => {
|
|
expect(mockDismissBottomSheet).toHaveBeenCalledWith(Screens.ATTACHMENT_OPTIONS);
|
|
expect(Alert.alert).toHaveBeenCalledWith(
|
|
'Error',
|
|
'File uploads are disabled',
|
|
);
|
|
expect(mockAttachFileFromCamera).not.toHaveBeenCalled();
|
|
});
|
|
});
|
|
|
|
it('should show alert and not call picker when canUploadFiles is false for attach file', async () => {
|
|
const props = {
|
|
...baseProps,
|
|
canUploadFiles: false,
|
|
};
|
|
const {getByTestId} = renderWithIntlAndTheme(
|
|
<AttachmentOptions {...props}/>,
|
|
);
|
|
|
|
const attachFileItem = getByTestId('file_attachment.attach_file');
|
|
fireEvent.press(attachFileItem);
|
|
|
|
await waitFor(() => {
|
|
expect(mockDismissBottomSheet).toHaveBeenCalledWith(Screens.ATTACHMENT_OPTIONS);
|
|
expect(Alert.alert).toHaveBeenCalledWith(
|
|
'Error',
|
|
'File uploads are disabled',
|
|
);
|
|
expect(mockAttachFileFromFiles).not.toHaveBeenCalled();
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('validation - maxFilesReached', () => {
|
|
it('should show alert and not call picker when maxFilesReached is true for photo library', async () => {
|
|
const props = {
|
|
...baseProps,
|
|
maxFilesReached: true,
|
|
maxFileCount: 10,
|
|
};
|
|
const {getByTestId} = renderWithIntlAndTheme(
|
|
<AttachmentOptions {...props}/>,
|
|
);
|
|
|
|
const photoLibraryItem = getByTestId('file_attachment.photo_library');
|
|
fireEvent.press(photoLibraryItem);
|
|
|
|
await waitFor(() => {
|
|
expect(mockDismissBottomSheet).toHaveBeenCalledWith(Screens.ATTACHMENT_OPTIONS);
|
|
expect(Alert.alert).toHaveBeenCalledWith(
|
|
'Error',
|
|
'Maximum 10 files allowed',
|
|
);
|
|
expect(mockAttachFileFromPhotoGallery).not.toHaveBeenCalled();
|
|
});
|
|
});
|
|
|
|
it('should show alert and not call picker when maxFilesReached is true for camera', async () => {
|
|
const props = {
|
|
...baseProps,
|
|
maxFilesReached: true,
|
|
maxFileCount: 10,
|
|
};
|
|
const {getByTestId} = renderWithIntlAndTheme(
|
|
<AttachmentOptions {...props}/>,
|
|
);
|
|
|
|
const takePhotoItem = getByTestId('file_attachment.take_photo');
|
|
fireEvent.press(takePhotoItem);
|
|
|
|
await waitFor(() => {
|
|
expect(mockDismissBottomSheet).toHaveBeenCalledWith(Screens.ATTACHMENT_OPTIONS);
|
|
expect(Alert.alert).toHaveBeenCalledWith(
|
|
'Error',
|
|
'Maximum 10 files allowed',
|
|
);
|
|
expect(mockAttachFileFromCamera).not.toHaveBeenCalled();
|
|
});
|
|
});
|
|
|
|
it('should show alert and not call picker when maxFilesReached is true for attach file', async () => {
|
|
const props = {
|
|
...baseProps,
|
|
maxFilesReached: true,
|
|
maxFileCount: 10,
|
|
};
|
|
const {getByTestId} = renderWithIntlAndTheme(
|
|
<AttachmentOptions {...props}/>,
|
|
);
|
|
|
|
const attachFileItem = getByTestId('file_attachment.attach_file');
|
|
fireEvent.press(attachFileItem);
|
|
|
|
await waitFor(() => {
|
|
expect(mockDismissBottomSheet).toHaveBeenCalledWith(Screens.ATTACHMENT_OPTIONS);
|
|
expect(Alert.alert).toHaveBeenCalledWith(
|
|
'Error',
|
|
'Maximum 10 files allowed',
|
|
);
|
|
expect(mockAttachFileFromFiles).not.toHaveBeenCalled();
|
|
});
|
|
});
|
|
|
|
it('should not show alert when maxFilesReached is true but maxFileCount is undefined', async () => {
|
|
const props = {
|
|
...baseProps,
|
|
maxFilesReached: true,
|
|
maxFileCount: undefined,
|
|
};
|
|
const {getByTestId} = renderWithIntlAndTheme(
|
|
<AttachmentOptions {...props}/>,
|
|
);
|
|
|
|
const photoLibraryItem = getByTestId('file_attachment.photo_library');
|
|
fireEvent.press(photoLibraryItem);
|
|
|
|
await waitFor(() => {
|
|
expect(mockDismissBottomSheet).toHaveBeenCalledWith(Screens.ATTACHMENT_OPTIONS);
|
|
expect(Alert.alert).not.toHaveBeenCalled();
|
|
expect(mockAttachFileFromPhotoGallery).toHaveBeenCalled();
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('selection limit calculation', () => {
|
|
it('should pass correct selection limit when fileCount is less than maxFileCount', async () => {
|
|
const props = {
|
|
...baseProps,
|
|
fileCount: 3,
|
|
maxFileCount: 10,
|
|
};
|
|
const {getByTestId} = renderWithIntlAndTheme(
|
|
<AttachmentOptions {...props}/>,
|
|
);
|
|
|
|
const photoLibraryItem = getByTestId('file_attachment.photo_library');
|
|
fireEvent.press(photoLibraryItem);
|
|
|
|
await waitFor(() => {
|
|
expect(mockAttachFileFromPhotoGallery).toHaveBeenCalledWith(7);
|
|
});
|
|
});
|
|
|
|
it('should pass undefined selection limit when maxFileCount is not provided', async () => {
|
|
const props = {
|
|
...baseProps,
|
|
maxFileCount: undefined,
|
|
};
|
|
const {getByTestId} = renderWithIntlAndTheme(
|
|
<AttachmentOptions {...props}/>,
|
|
);
|
|
|
|
const photoLibraryItem = getByTestId('file_attachment.photo_library');
|
|
fireEvent.press(photoLibraryItem);
|
|
|
|
await waitFor(() => {
|
|
expect(mockAttachFileFromPhotoGallery).toHaveBeenCalledWith(undefined);
|
|
});
|
|
});
|
|
|
|
it('should pass undefined selection limit when fileCount equals maxFileCount', async () => {
|
|
const props = {
|
|
...baseProps,
|
|
fileCount: 10,
|
|
maxFileCount: 10,
|
|
};
|
|
const {getByTestId} = renderWithIntlAndTheme(
|
|
<AttachmentOptions {...props}/>,
|
|
);
|
|
|
|
const photoLibraryItem = getByTestId('file_attachment.photo_library');
|
|
fireEvent.press(photoLibraryItem);
|
|
|
|
await waitFor(() => {
|
|
expect(mockAttachFileFromPhotoGallery).toHaveBeenCalledWith(0);
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('edge cases', () => {
|
|
it('should use default closeButtonId when not provided', () => {
|
|
const props = {
|
|
...baseProps,
|
|
};
|
|
delete (props as {closeButtonId?: string}).closeButtonId;
|
|
|
|
renderWithIntlAndTheme(<AttachmentOptions {...props}/>);
|
|
|
|
// Component should render without errors
|
|
});
|
|
|
|
it('should use default fileCount when not provided', async () => {
|
|
const props = {
|
|
...baseProps,
|
|
};
|
|
delete (props as {fileCount?: number}).fileCount;
|
|
|
|
const {getByTestId} = renderWithIntlAndTheme(
|
|
<AttachmentOptions {...props}/>,
|
|
);
|
|
|
|
const photoLibraryItem = getByTestId('file_attachment.photo_library');
|
|
fireEvent.press(photoLibraryItem);
|
|
|
|
await waitFor(() => {
|
|
expect(mockAttachFileFromPhotoGallery).toHaveBeenCalledWith(10);
|
|
});
|
|
});
|
|
|
|
it('should use default maxFilesReached when not provided', async () => {
|
|
const props = {
|
|
...baseProps,
|
|
};
|
|
delete (props as {maxFilesReached?: boolean}).maxFilesReached;
|
|
|
|
const {getByTestId} = renderWithIntlAndTheme(
|
|
<AttachmentOptions {...props}/>,
|
|
);
|
|
|
|
const photoLibraryItem = getByTestId('file_attachment.photo_library');
|
|
fireEvent.press(photoLibraryItem);
|
|
|
|
await waitFor(() => {
|
|
expect(mockAttachFileFromPhotoGallery).toHaveBeenCalled();
|
|
expect(Alert.alert).not.toHaveBeenCalled();
|
|
});
|
|
});
|
|
|
|
it('should use default canUploadFiles when not provided', async () => {
|
|
const props = {
|
|
...baseProps,
|
|
};
|
|
delete (props as {canUploadFiles?: boolean}).canUploadFiles;
|
|
|
|
const {getByTestId} = renderWithIntlAndTheme(
|
|
<AttachmentOptions {...props}/>,
|
|
);
|
|
|
|
const photoLibraryItem = getByTestId('file_attachment.photo_library');
|
|
fireEvent.press(photoLibraryItem);
|
|
|
|
await waitFor(() => {
|
|
expect(mockAttachFileFromPhotoGallery).toHaveBeenCalled();
|
|
expect(Alert.alert).not.toHaveBeenCalled();
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('tablet rendering', () => {
|
|
it('should not render title when isTablet is true', () => {
|
|
const useIsTablet = require('@hooks/device').useIsTablet;
|
|
useIsTablet.mockReturnValue(true);
|
|
|
|
const {queryByText} = renderWithIntlAndTheme(
|
|
<AttachmentOptions {...baseProps}/>,
|
|
);
|
|
|
|
expect(queryByText('Files and media')).toBeNull();
|
|
});
|
|
|
|
it('should render title when isTablet is false', () => {
|
|
const useIsTablet = require('@hooks/device').useIsTablet;
|
|
useIsTablet.mockReturnValue(false);
|
|
|
|
const {getByText} = renderWithIntlAndTheme(
|
|
<AttachmentOptions {...baseProps}/>,
|
|
);
|
|
|
|
expect(getByText('Files and media')).toBeTruthy();
|
|
});
|
|
});
|
|
});
|
|
|