* Initial setup for new keyboard
* fix the offset calculation onMove by adding isKeyboardFullyOpened
* Done with the keyboard handling implementation
* Handled keyboard focus and blured state using context
* Added default height for input container
* Android support
* Tablet state handling
* Fix for refreshing offset in list
* Created a default context for mention post list
* Fix linter errors
* Fix tests
* Minor
* Fix the height issue for tablet view
* Review comments
* Dependency fix
* Reveiw comment
* keyboard animation only enabled with screen on top navigation
* added tests
* Added extra keyboard component for emoji picker (#9328)
* Added extra keyboard component
* handled swipe geature for extra keyboard
* scroll to bottom visible on emoji picker
* Check for stale event for keyboard geature area
* fix keyboard stale event for mid-gesture change swipe direction
* Closing emoji picker when message priority is opened
* changing to thread view closes emoji picker
* Close emoij picker and keyboard when attachment icons are clicked
* handle android emoji picker behaviour
* Remove emoji picker code
* fix tests
* Address reviev comments
* Test fixes
* usePreventDoubleTab for race condition and corrected comment on isInputAccessoryViewMode flag
* File attachments option in bottom sheet quick action (#9331)
* Added extra keyboard component
* handled swipe geature for extra keyboard
* File attachments option in bottom sheet quick action
* Updated tests
* i18n
* fix test
* Added tests
* Review comment
* fix tests
* Integrated Emoji picker to Extra keyboard component. (#9339)
* Added extra keyboard component
* handled swipe geature for extra keyboard
* scroll to bottom visible on emoji picker
* Fix the post input container height change issue
* Added emoji picker with search functionality
* keyboard height not recorded fallback to default height, set search to false closing emoji picker
* fix search funcitonality in android
* scroll to end bottom dismissed with pressed
* Fixed the scroll issue for android
* fix the flickering post input issue
* Wired up the emoji picker
* Added keyboard and spaceback in emoji picker
* intl extract
* initial cursor position and simple calculation review comment
* separated grapheme to utils file
* Review comments
* nitpick
* Fix the bottom safe area and navigation stack restore fix
* Fix test
* disabled emoji picker in edit post screen
* change the name of the variable to name it clarier
* fix the tab gap issue in andriod
* disabled the emoji skin tone change on andriod
* fix the input container jump issue
* fix the failing test
* UX review
* added white space after the attachment icon
* When @ or / is press open keyboard on andriod also fix the scroll issue when keyboard is open
* back bottom closes emoji picker and opening keyboard jump fix
* reverted code
* fixed the flickering issue of input and scroll position fix
* Fix the gap issue in thread
* fix the warning reaminated issue when opening a channel
* Fix the extra space issue between input and emoij picker
* Minor fix for extra space between input and emoji picker
* Fix thread view bottom safe area and gap between keyboard and searched emojis
* Fix the keyboard issue in tablet
* Fix the warning issue react-native-keyboard-controller
* Fix tests
* Fix the tablet search hight issue
* Replaced the ExtraKeyboardProvider with KeyboardProvider from rnkc for permalink
* Bottom sheet jump issue resolved
* Search do not close after selecting emoji in search list
* Added the bottom inset height in search emoji for android
* fix buid issue
* Fix the cancel state to emoji picker
* use portals for autocomplete
* fix permalink extra space in post list
* Portal only for android
---------
(cherry picked from commit e39b27be7e)
Co-authored-by: Rajat Dabade <rajatdabade1997@gmail.com>
Co-authored-by: Rahim Rahman <rahim.rahman@mattermost.com>
Co-authored-by: Harshil Sharma <harshilsharma63@gmail.com>
Co-authored-by: Elias Nahum <nahumhbl@gmail.com>
360 lines
13 KiB
TypeScript
360 lines
13 KiB
TypeScript
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
import {renderHook, act} from '@testing-library/react-hooks';
|
|
import {KeyboardController} from 'react-native-keyboard-controller';
|
|
import {useSafeAreaInsets} from 'react-native-safe-area-context';
|
|
|
|
import {useIsTablet} from '@hooks/device';
|
|
|
|
import {useKeyboardAnimation} from './keyboardAnimation';
|
|
import {useKeyboardAwarePostDraft} from './useKeyboardAwarePostDraft';
|
|
import {useKeyboardScrollAdjustment} from './useKeyboardScrollAdjustment';
|
|
|
|
jest.mock('react-native/Libraries/Utilities/Platform', () => ({
|
|
OS: 'ios',
|
|
select: jest.fn((obj) => obj.ios),
|
|
}));
|
|
|
|
jest.mock('react-native-keyboard-controller', () => ({
|
|
KeyboardController: {
|
|
dismiss: jest.fn(() => Promise.resolve()),
|
|
},
|
|
}));
|
|
|
|
jest.mock('react-native-reanimated', () => {
|
|
const sharedValues = new Map();
|
|
|
|
return {
|
|
...jest.requireActual('react-native-reanimated/mock'),
|
|
useSharedValue: jest.fn((initial) => {
|
|
const key = Math.random();
|
|
const sv = {
|
|
value: initial,
|
|
_key: key,
|
|
};
|
|
sharedValues.set(key, sv);
|
|
return sv;
|
|
}),
|
|
useDerivedValue: jest.fn((fn) => ({
|
|
value: fn(),
|
|
})),
|
|
useAnimatedStyle: jest.fn((fn) => fn()),
|
|
useAnimatedScrollHandler: jest.fn((handlers) => (event: {contentOffset: {y: number}}) => {
|
|
if (handlers.onScroll) {
|
|
handlers.onScroll(event);
|
|
}
|
|
}),
|
|
useAnimatedReaction: jest.fn(),
|
|
};
|
|
});
|
|
|
|
jest.mock('react-native-safe-area-context', () => ({
|
|
useSafeAreaInsets: jest.fn(),
|
|
}));
|
|
|
|
jest.mock('@hooks/device', () => ({
|
|
useIsTablet: jest.fn(),
|
|
}));
|
|
|
|
jest.mock('./keyboardAnimation', () => ({
|
|
useKeyboardAnimation: jest.fn(),
|
|
}));
|
|
|
|
jest.mock('./useKeyboardScrollAdjustment', () => ({
|
|
useKeyboardScrollAdjustment: jest.fn(),
|
|
}));
|
|
|
|
describe('useKeyboardAwarePostDraft', () => {
|
|
const mockUseKeyboardAnimation = useKeyboardAnimation as jest.Mock;
|
|
const mockUseKeyboardScrollAdjustment = useKeyboardScrollAdjustment as jest.Mock;
|
|
const mockUseIsTablet = useIsTablet as jest.Mock;
|
|
const mockUseSafeAreaInsets = useSafeAreaInsets as jest.Mock;
|
|
const mockKeyboardControllerDismiss = KeyboardController.dismiss as jest.Mock;
|
|
|
|
const mockKeyboardAnimationReturn = {
|
|
keyboardTranslateY: {value: 0},
|
|
bottomInset: {value: 0},
|
|
scrollOffset: {value: 0},
|
|
scrollPosition: {value: 0},
|
|
onScroll: jest.fn(),
|
|
isKeyboardFullyOpen: {value: false},
|
|
isKeyboardFullyClosed: {value: true},
|
|
isKeyboardInTransition: {value: false},
|
|
isInputAccessoryViewMode: {value: false},
|
|
isTransitioningFromCustomView: {value: false},
|
|
};
|
|
|
|
beforeEach(() => {
|
|
jest.clearAllMocks();
|
|
mockUseIsTablet.mockReturnValue(false);
|
|
mockUseSafeAreaInsets.mockReturnValue({bottom: 0, top: 0, left: 0, right: 0});
|
|
mockUseKeyboardAnimation.mockReturnValue(mockKeyboardAnimationReturn);
|
|
mockUseKeyboardScrollAdjustment.mockImplementation(() => {});
|
|
});
|
|
|
|
describe('initialization', () => {
|
|
it('should initialize with default values', () => {
|
|
const {result} = renderHook(() => useKeyboardAwarePostDraft());
|
|
|
|
expect(result.current.postInputContainerHeight).toBe(91);
|
|
expect(result.current.listRef.current).toBeNull();
|
|
expect(result.current.inputRef.current).toBeUndefined();
|
|
expect(result.current.keyboardTranslateY).toBe(mockKeyboardAnimationReturn.keyboardTranslateY);
|
|
expect(result.current.contentInset).toBe(mockKeyboardAnimationReturn.bottomInset);
|
|
expect(result.current.onScroll).toBe(mockKeyboardAnimationReturn.onScroll);
|
|
expect(result.current.blurInput).toBeDefined();
|
|
expect(result.current.focusInput).toBeDefined();
|
|
expect(result.current.blurAndDismissKeyboard).toBeDefined();
|
|
});
|
|
|
|
it('should call useKeyboardAnimation with correct parameters', () => {
|
|
renderHook(() => useKeyboardAwarePostDraft(false, true));
|
|
|
|
expect(mockUseKeyboardAnimation).toHaveBeenCalledWith(
|
|
91, // DEFAULT_POST_INPUT_HEIGHT
|
|
true, // isIOS
|
|
false, // isTablet
|
|
0, // insets.bottom
|
|
false, // isThreadView
|
|
true, // enabled
|
|
);
|
|
});
|
|
|
|
it('should call useKeyboardScrollAdjustment with correct parameters', () => {
|
|
const {result} = renderHook(() => useKeyboardAwarePostDraft());
|
|
|
|
expect(mockUseKeyboardScrollAdjustment).toHaveBeenCalledWith(
|
|
result.current.listRef,
|
|
mockKeyboardAnimationReturn.scrollPosition,
|
|
mockKeyboardAnimationReturn.scrollOffset,
|
|
true, // isIOS
|
|
mockKeyboardAnimationReturn.isInputAccessoryViewMode,
|
|
mockKeyboardAnimationReturn.isTransitioningFromCustomView,
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('isThreadView parameter', () => {
|
|
it('should pass isThreadView=true to useKeyboardAnimation', () => {
|
|
renderHook(() => useKeyboardAwarePostDraft(true));
|
|
|
|
expect(mockUseKeyboardAnimation).toHaveBeenCalledWith(
|
|
91,
|
|
true,
|
|
false,
|
|
0,
|
|
true, // isThreadView
|
|
true,
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('enabled parameter', () => {
|
|
it('should pass enabled=false to useKeyboardAnimation', () => {
|
|
renderHook(() => useKeyboardAwarePostDraft(false, false));
|
|
|
|
expect(mockUseKeyboardAnimation).toHaveBeenCalledWith(
|
|
91,
|
|
true,
|
|
false,
|
|
0,
|
|
false,
|
|
false, // enabled
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('postInputContainerHeight', () => {
|
|
it('should update postInputContainerHeight when setPostInputContainerHeight is called', () => {
|
|
const {result} = renderHook(() => useKeyboardAwarePostDraft());
|
|
|
|
act(() => {
|
|
result.current.setPostInputContainerHeight(150);
|
|
});
|
|
|
|
expect(result.current.postInputContainerHeight).toBe(150);
|
|
});
|
|
|
|
it('should update postInputContainerHeight state', () => {
|
|
const {result} = renderHook(() => useKeyboardAwarePostDraft());
|
|
|
|
act(() => {
|
|
result.current.setPostInputContainerHeight(150);
|
|
});
|
|
|
|
expect(result.current.postInputContainerHeight).toBe(150);
|
|
});
|
|
});
|
|
|
|
describe('input ref callbacks', () => {
|
|
it('should call blur on inputRef when blurInput is called', () => {
|
|
const {result} = renderHook(() => useKeyboardAwarePostDraft());
|
|
const mockBlur = jest.fn();
|
|
|
|
// @ts-expect-error Test mock - only need blur method
|
|
result.current.inputRef.current = {blur: mockBlur};
|
|
|
|
act(() => {
|
|
result.current.blurInput();
|
|
});
|
|
|
|
expect(mockBlur).toHaveBeenCalled();
|
|
});
|
|
|
|
it('should not throw when blurInput is called without inputRef', () => {
|
|
const {result} = renderHook(() => useKeyboardAwarePostDraft());
|
|
|
|
expect(() => {
|
|
act(() => {
|
|
result.current.blurInput();
|
|
});
|
|
}).not.toThrow();
|
|
});
|
|
|
|
it('should call focus on inputRef when focusInput is called', () => {
|
|
const {result} = renderHook(() => useKeyboardAwarePostDraft());
|
|
const mockFocus = jest.fn();
|
|
|
|
// @ts-expect-error Test mock - only need focus method
|
|
result.current.inputRef.current = {focus: mockFocus};
|
|
|
|
act(() => {
|
|
result.current.focusInput();
|
|
});
|
|
|
|
expect(mockFocus).toHaveBeenCalled();
|
|
});
|
|
|
|
it('should not throw when focusInput is called without inputRef', () => {
|
|
const {result} = renderHook(() => useKeyboardAwarePostDraft());
|
|
|
|
expect(() => {
|
|
act(() => {
|
|
result.current.focusInput();
|
|
});
|
|
}).not.toThrow();
|
|
});
|
|
});
|
|
|
|
describe('blurAndDismissKeyboard', () => {
|
|
it('should reset shared values and dismiss keyboard', async () => {
|
|
const mockKeyboardTranslateY = {value: 300};
|
|
const mockBottomInset = {value: 300};
|
|
const mockScrollOffset = {value: 300};
|
|
const mockBlur = jest.fn();
|
|
|
|
mockUseKeyboardAnimation.mockReturnValue({
|
|
...mockKeyboardAnimationReturn,
|
|
keyboardTranslateY: mockKeyboardTranslateY,
|
|
bottomInset: mockBottomInset,
|
|
scrollOffset: mockScrollOffset,
|
|
});
|
|
|
|
const {result} = renderHook(() => useKeyboardAwarePostDraft());
|
|
|
|
// @ts-expect-error Test mock - only need blur method
|
|
result.current.inputRef.current = {blur: mockBlur};
|
|
|
|
await act(async () => {
|
|
await result.current.blurAndDismissKeyboard();
|
|
});
|
|
|
|
expect(mockKeyboardTranslateY.value).toBe(0);
|
|
expect(mockBottomInset.value).toBe(0);
|
|
expect(mockScrollOffset.value).toBe(0);
|
|
expect(mockBlur).toHaveBeenCalled();
|
|
expect(mockKeyboardControllerDismiss).toHaveBeenCalled();
|
|
});
|
|
|
|
it('should handle missing inputRef gracefully', async () => {
|
|
const mockKeyboardTranslateY = {value: 300};
|
|
const mockBottomInset = {value: 300};
|
|
const mockScrollOffset = {value: 300};
|
|
|
|
mockUseKeyboardAnimation.mockReturnValue({
|
|
...mockKeyboardAnimationReturn,
|
|
keyboardTranslateY: mockKeyboardTranslateY,
|
|
bottomInset: mockBottomInset,
|
|
scrollOffset: mockScrollOffset,
|
|
});
|
|
|
|
const {result} = renderHook(() => useKeyboardAwarePostDraft());
|
|
|
|
await act(async () => {
|
|
await result.current.blurAndDismissKeyboard();
|
|
});
|
|
|
|
expect(mockKeyboardTranslateY.value).toBe(0);
|
|
expect(mockBottomInset.value).toBe(0);
|
|
expect(mockScrollOffset.value).toBe(0);
|
|
expect(mockKeyboardControllerDismiss).toHaveBeenCalled();
|
|
});
|
|
});
|
|
|
|
describe('inputContainerAnimatedStyle', () => {
|
|
it('should return animated style with translateY on iOS', () => {
|
|
const mockKeyboardTranslateY = {value: 200};
|
|
mockUseKeyboardAnimation.mockReturnValue({
|
|
...mockKeyboardAnimationReturn,
|
|
keyboardTranslateY: mockKeyboardTranslateY,
|
|
});
|
|
|
|
const {result} = renderHook(() => useKeyboardAwarePostDraft());
|
|
|
|
const style = result.current.inputContainerAnimatedStyle;
|
|
expect(style).toEqual({
|
|
transform: [{translateY: -200}],
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('tablet and safe area handling', () => {
|
|
it('should pass tablet and safe area values to useKeyboardAnimation', () => {
|
|
mockUseIsTablet.mockReturnValue(true);
|
|
mockUseSafeAreaInsets.mockReturnValue({bottom: 20, top: 0, left: 0, right: 0});
|
|
|
|
renderHook(() => useKeyboardAwarePostDraft());
|
|
|
|
expect(mockUseKeyboardAnimation).toHaveBeenCalledWith(
|
|
91,
|
|
true,
|
|
true, // isTablet
|
|
20, // insets.bottom
|
|
false,
|
|
true,
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('return values', () => {
|
|
it('should return all expected properties', () => {
|
|
const {result} = renderHook(() => useKeyboardAwarePostDraft());
|
|
|
|
expect(result.current).toHaveProperty('keyboardTranslateY');
|
|
expect(result.current).toHaveProperty('listRef');
|
|
expect(result.current).toHaveProperty('inputRef');
|
|
expect(result.current).toHaveProperty('contentInset');
|
|
expect(result.current).toHaveProperty('onScroll');
|
|
expect(result.current).toHaveProperty('postInputContainerHeight');
|
|
expect(result.current).toHaveProperty('setPostInputContainerHeight');
|
|
expect(result.current).toHaveProperty('inputContainerAnimatedStyle');
|
|
expect(result.current).toHaveProperty('keyboardHeight');
|
|
expect(result.current).toHaveProperty('scrollOffset');
|
|
expect(result.current).toHaveProperty('scrollPosition');
|
|
expect(result.current).toHaveProperty('blurInput');
|
|
expect(result.current).toHaveProperty('focusInput');
|
|
expect(result.current).toHaveProperty('blurAndDismissKeyboard');
|
|
expect(result.current).toHaveProperty('isKeyboardFullyOpen');
|
|
expect(result.current).toHaveProperty('isKeyboardFullyClosed');
|
|
expect(result.current).toHaveProperty('isKeyboardInTransition');
|
|
});
|
|
|
|
it('should return keyboardHeight as alias for keyboardTranslateY', () => {
|
|
const {result} = renderHook(() => useKeyboardAwarePostDraft());
|
|
|
|
expect(result.current.keyboardHeight).toBe(result.current.keyboardTranslateY);
|
|
});
|
|
});
|
|
});
|
|
|