From c1d6978ce98cebe747f8b5862810efe6f9c5e3e6 Mon Sep 17 00:00:00 2001 From: "leedongmyung[desktop]" Date: Sat, 18 Nov 2023 20:10:52 +0900 Subject: [PATCH] cod refactoring --- lib/oto/application.dart | 7 +++---- lib/oto/build/build_dart.dart | 2 +- lib/oto/build/build_dot_net.dart | 2 +- lib/oto/build/build_ios.dart | 6 +++--- 4 files changed, 8 insertions(+), 9 deletions(-) diff --git a/lib/oto/application.dart b/lib/oto/application.dart index 22d00c3..98a84f1 100644 --- a/lib/oto/application.dart +++ b/lib/oto/application.dart @@ -35,15 +35,14 @@ class Application { Future build(BuildType buildType, {String? yamlContent}) async { setUTF8(); - DataBuild? build; - // var envArgs = envArguments(arguments); // bool isTest = envArgs.containsKey('isTest'); //for Unit Test try { var composer = _mapComposer[buildType]!; await composer.compose(yamlContent, printBuildStep); _jenkinsData = composer.jenkinsData; - build = DataBuild.fromJson(getMapFromYaml(composer.buildYaml)!); + DataBuild? build = + DataBuild.fromJson(getMapFromYaml(composer.buildYaml)!); await CLI.println( '********************************* Build Data *************************************', color: Color.magenta); @@ -69,7 +68,7 @@ class Application { if (Platform.isWindows) { var data = await ProcessExecutor.start(StringBuffer('chcp 65001')); var exitCode = await data.process.exitCode; - print('======> Set Korean: ${exitCode == 0}'); + print('Set Korean: ${exitCode == 0}'); } return simpleFuture; } diff --git a/lib/oto/build/build_dart.dart b/lib/oto/build/build_dart.dart index 2bb9de4..c633dbc 100644 --- a/lib/oto/build/build_dart.dart +++ b/lib/oto/build/build_dart.dart @@ -35,7 +35,7 @@ class BuildDart extends Command { } var process = await ProcessExecutor.start(await appendShell(shell, command), - workspace: workspace, enableStderr: false); + workspace: workspace, printStderr: false); return await complete(await process.process.exitCode, command, errorMessage: process.stderr.toString()); diff --git a/lib/oto/build/build_dot_net.dart b/lib/oto/build/build_dot_net.dart index fa39a78..e14f796 100644 --- a/lib/oto/build/build_dot_net.dart +++ b/lib/oto/build/build_dot_net.dart @@ -17,7 +17,7 @@ class BuildDotNet extends Command { shell.writeln( 'MSBuild ${data.projectFile} /t:build /p:Configuration=Release;Platform=x86'); var process = await ProcessExecutor.start(shell, - workspace: workspace, enableStderr: false); + workspace: workspace, printStderr: false); return complete(await process.process.exitCode, command, errorMessage: process.stderr.toString()); diff --git a/lib/oto/build/build_ios.dart b/lib/oto/build/build_ios.dart index 6782d94..9d75f46 100644 --- a/lib/oto/build/build_ios.dart +++ b/lib/oto/build/build_ios.dart @@ -35,7 +35,7 @@ class BuildiOS extends Command { ' && xcodebuild -workspace $workspacePath -scheme ${data.scheme} -destination $destination'); var processData = await ProcessExecutor.start(shell, - workspace: workspace, enableStderr: false); + workspace: workspace, printStderr: false); var exitCode = await processData.process.exitCode; var success = exitCode == 0; if (success) { @@ -69,7 +69,7 @@ class ArchiveiOS extends Command { 'xcodebuild -workspace $workspacePath -scheme ${data.scheme} -archivePath $archivePath archive'); var processData = await ProcessExecutor.start(shell, - workspace: workspace, enableStderr: false); + workspace: workspace, printStderr: false); return complete(await processData.process.exitCode, command, errorMessage: processData.stderr.toString()); @@ -94,7 +94,7 @@ class ExportiOS extends Command { 'xcodebuild -exportArchive -archivePath $archivePath -exportPath $exportPath -exportOptionsPlist $exportOptionPlistPath'); var processData = await ProcessExecutor.start(shell, - workspace: workspace, enableStderr: false); + workspace: workspace, printStderr: false); return complete(await processData.process.exitCode, command, errorMessage: processData.stderr.toString());