iop/agent-task/m-iop-agent-cli-runtime/CODE_REVIEW-cloud-G07.md

Code Review Reference - REVIEW_REVIEW_API

[IMPLEMENTING AGENT — READ FIRST] Filling in this file is the mandatory final step of implementation. The task is NOT complete until every implementation-owned section below is filled in. Complete the Implementation Checklist; the final checklist item is mandatory before saving. Fill implementation-owned sections, then stop with active files in place and report ready for review. If implementation is blocked, record the exact blocker, attempted commands/output, and resume condition only in implementation-owned evidence fields. Do not ask the user directly, present choices, call user-input tools, create control-plane stop files, or classify the next state. Finalization (Code Review Result, log rename, complete.log, archive moves, Review-Only Checklist) is review-agent-only, even after compaction/resume. Follow the ownership table at the bottom of this file for which sections you own.

Overview

date=2026-07-31 task=m-iop-agent-cli-runtime, plan=2, tag=REVIEW_REVIEW_API

Roadmap Targets

• Milestone: agent-roadmap/phase/automation-runtime-bridge/milestones/iop-agent-cli-runtime.md
• Milestone link: Milestone document
• Task ids:
  • cli-surface: headless binary, split config, Milestone discovery/selection/preview, lifecycle, and per-work overlay/integration/blocker observation
• Completion mode: check-on-pass

Archive Evidence Snapshot

• agent-task/m-iop-agent-cli-runtime/plan_local_G07_0.log and agent-task/m-iop-agent-cli-runtime/code_review_cloud_G07_0.log: first review loop, FAIL with 2 Required production/evidence findings.
• agent-task/m-iop-agent-cli-runtime/plan_cloud_G06_1.log and agent-task/m-iop-agent-cli-runtime/code_review_cloud_G07_1.log: second review loop, FAIL with 2 Required, 0 Suggested, and 0 Nit findings.
• Required correctness finding: scanWorkflow accepts a slug but also strips m- as though every input were a task-group identifier. The reviewer fixture m-m-foo failed catalog discovery with taskloop: selected milestone "foo" has no active or archived task artifacts.
• Required evidence finding: the adapter test does not assert exact ordinals, both overlays, or exact blocker fields; the built-binary transcript only shows works: 0 and still validates stdout by substring for one step.
• Reviewer verification: the API-1, API-2, and API-3 named suites passed fresh on the current checkout, proving that the remaining defects are test-oracle gaps rather than command failures.
• Roadmap carryover: cli-surface remains the only unchecked Milestone Task and still requires exact Roadmap Completion plus trustworthy SDD S10 headless evidence.

For the Review Agent

[REVIEW AGENT ONLY] The finalization steps below are review-agent only. Implementing agents must not execute this section.

Compare implementation of each item against source files and verify that output in Verification Results matches code. Review completion means the following steps are finished:

1. Append verdict and review_rework_count / evidence_integrity_failure routing signals.
2. Archive CODE_REVIEW-cloud-G07.md → code_review_cloud_G07_2.log and PLAN-cloud-G07.md → plan_cloud_G07_2.log.
3. If PASS, write complete.log and move active task directory to agent-task/archive/YYYY/MM/m-iop-agent-cli-runtime/. If WARN/FAIL, fully write the next filesystem state required by the code-review skill.
4. If PASS and m-iop-agent-cli-runtime is a Milestone task group, report completion event metadata. Roadmap state check and update-roadmap calls are runtime responsibilities.
5. Check applicable Review-Only Checklist items at the final .log location before reporting.

---

Implementation Item Completion

Item	Status
REVIEW_REVIEW_API-1	[ ]
REVIEW_REVIEW_API-2	[ ]
REVIEW_REVIEW_API-3	[ ]

Implementation Checklist

• [REVIEW_REVIEW_API-1] Separate canonical Milestone slug parsing from m- task-group parsing and add an m-foo catalog/selection/inspection round-trip regression.
• [REVIEW_REVIEW_API-2] Make adapter and compiled-binary S10 evidence assert the exact ordered two-work projection and exact stdout/stderr for every transcript step.
• [REVIEW_REVIEW_API-3] Run the complete fresh local S10 verification matrix without real provider execution and record exact output.
• Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.

Review-Only Checklist

[REVIEW AGENT ONLY] This checklist is used only by the review agent. Implementing agents must not modify or check this section.

• Append one verdict of PASS, WARN, or FAIL and verified review_rework_count, evidence_integrity_failure to Code Review Result.
• Verify that verdict, Dimension Assessment, and Required/Suggested/Nit classifications match.
• Archive active CODE_REVIEW-*-G??.md to code_review_cloud_G07_2.log.
• Archive active PLAN-*-G??.md to plan_cloud_G07_2.log.
• Verify that the Agent-Ops managed block in .gitignore unignores agent-task/**/*.md and agent-task/**/*.log and ignores agent-roadmap/current.md.
• If PASS, write complete.log based on agent-ops/skills/common/code-review/templates/complete-log-template.md and leave no active .md files.
• If PASS, move active task directory agent-task/m-iop-agent-cli-runtime/ to agent-task/archive/YYYY/MM/m-iop-agent-cli-runtime/ and update this checklist at the final archive path.
• If PASS and m-iop-agent-cli-runtime is a Milestone task group, report completion event metadata for runtime, without modifying roadmap or directly calling update-roadmap.
• If PASS for split work, remove empty active parent agent-task/m-iop-agent-cli-runtime/ or verify it was kept due to remaining siblings/files.
• If WARN/FAIL, write the next filesystem state matching code-review verdict and do not write complete.log.

Deviations from Plan

Record any deviations from the plan and the rationale here.

Key Design Decisions

Record key design decisions here.

Reviewer Checkpoints

• Verify that canonical Milestone slugs are parsed without stripping m-, while only the task-group boundary strips exactly one m- prefix.
• Verify that the m-foo canonical slug round-trips through catalog discovery, exact selection, persisted selection, workflow snapshot, and InspectTaskGroup("m-m-foo").
• Verify exact ordered two-work adapter projection, including ids, states, both overlays, integrations, dispatch ordinals, scoped blocker fields, and top-level blockers.
• Verify the compiled binary asserts complete stdout and stderr for every transcript step, including the seeded two-work status and exact validate output.
• Verify no real provider CLI is started and that S10 evidence maps only to Milestone Task cli-surface.

Verification Results

REVIEW_REVIEW_API-1 Focused Verification

TMPDIR=/tmp GOTMPDIR=/tmp GOCACHE=/tmp/iop-cli-recovery2-cache go test -count=1 ./apps/agent/internal/taskloop -run '^(TestWorkflowMilestonePrefixSlugRoundTrip|TestWorkflowMilestonesListsSelectableTaskGroups|TestWorkflowMilestonesFailClosedBoundaryMatrix|TestInspectTaskGroupRejectsInvalidIdentifiers|TestWorkflowMilestonesNormalizesArchiveCollisionSuffixes|TestWorkflowArchiveOnlyMilestoneRemainsSelectable|TestInspectTaskGroupArchiveOnly)
## Section Ownership

| Section | Owner | Note |
|---------|-------|------|
| Header comment, Overview, Review Agent Instructions | Fixed at stub creation | Implementing agent must not modify or execute these (archive, complete.log, and task-directory archive move are review-agent only) |
| Roadmap Targets | Fixed at stub creation from plan when present | Implementing agent must not modify; code-review copies it into complete.log as `Roadmap Completion` only on PASS |
| Archive Evidence Snapshot | Fixed at stub creation from plan when present | Implementing agent uses it as default prior-loop context; read only the specific archive files cited there when more detail is required |
| Implementation Item Completion (item names) | Fixed at stub creation | Implementing agent checks `[ ]` → `[x]` only |
| Implementation Checklist (item text/order) | Fixed at stub creation from plan | Implementing agent checks `[ ]` → `[x]` only |
| Review-Only Checklist | Review agent only | Implementing agent must not modify or check this section |
| Deviations from Plan, Key Design Decisions | Implementing agent | Replace placeholder text with actual content |
| Reviewer Checkpoints | Fixed at stub creation | Pre-filled from plan |
| Verification Results (section headings + commands) | Fixed at stub creation | Implementing agent fills in command output only; command changes require a Deviations from Plan entry |
| Code Review Result | Review agent appends | Not included in stub |