5.1 KiB
Code Review Reference - TEST
[IMPLEMENTING AGENT — READ FIRST] Complete implementation-owned sections, paste actual output, and leave this pair active. Do not archive files, write
complete.log, ask the user, or classify the next state.
Overview
date=2026-08-14 task=m-thin-agent-model-comparison-benchmark, plan=2, tag=TEST
Archive Evidence Snapshot
- Pre-refine intent is checkpoint
e09aa66c3cdb829366463c10f8bc5f5801e3136e. - Replaced unstarted refinement:
plan_local_G08_1.log,code_review_cloud_G08_1.log; no verdict. - This replan fixes URL normalization, token lifetime, and Claude row-workspace binding without changing the benchmark scope.
For the Review Agent
Rerun applicable deterministic checks and inspect immutable evidence. Append an official verdict only after implementation is submitted. On PASS, archive this pair with suffix 2, preserve first-line milestone metadata in complete.log, and move the task directory to the dated archive; roadmap aggregation remains a later runtime action.
Implementation Item Completion
| Item | Status |
|---|---|
| TEST-1 Consume the Immutable Nine-Row Matrix | [ ] |
| TEST-2 Render, Score Once, and Conclude | [ ] |
Implementation Checklist
- Pass the authenticated catalog/runtime gate without creating a producer workspace.
- Create nine empty row workspaces and execute each fixed caller/model tuple exactly once in its row workspace, with no retry/resume/recovery.
- Fill the nine-row result table from immutable evidence, using caller-provided usage or
미제공. - After all attempts, create one shuffled opaque bijection and copy/extract each scorable exact source without route facts.
- Render each scorable opaque source once at desktop and once at mobile, then score it once with locked anchors and direct evidence.
- Write a bounded conclusion comparing only successful scorable results and separating operational facts from quality.
- Run the final count, isolation, placeholder, retry, secret, arithmetic, and scope checks.
- Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.
Review-Only Checklist
[REVIEW AGENT ONLY] Implementing agents must not modify this checklist.
- Append one verdict with verified
review_rework_countandevidence_integrity_failure. - Verify verdict, dimensions, and finding severities agree.
- Rerun required checks and inspect the nine ledgers/streams plus score evidence.
- For every Required/Suggested finding, record evidence, exact root cause, one selected fix, affected files/tests, and acceptance commands.
- Archive this file to
code_review_cloud_G08_2.logand the plan toplan_local_G08_2.log. - Verify the Agent-Ops
.gitignoreblock. - On PASS, write
complete.log, preserve milestone metadata, move the task directory to the dated archive, and update this checklist there. - On WARN/FAIL, create only the next state required by the code-review skill and do not write
complete.log.
Deviations from Plan
Replace with actual deviations or None.
Key Design Decisions
Replace with actual implementation decisions.
Reviewer Checkpoints
- Confirm URL normalization yields one
/v1/models, the token remains available through row 09, and no producer workspace predates gate success. - Confirm all nine exact tuples ran once and each direct caller was bound to its declared empty row workspace.
- Confirm no product/config/script/manifest/state-store change entered the worktree.
- Confirm route facts were absent from opaque scoring inputs until all scores froze.
- Confirm usage is caller-provided or
미제공, and failures/unscorable artifacts are not zero. - Confirm every scorable source has one SHA record, two one-shot renders, direct anchor evidence, and correct arithmetic.
Verification Results
External gate and producer attempts
Paste redacted gate output, each expanded command, sole exit status, and attempt.txt. Do not paste credentials or sensitive raw provider payloads.
Replace with actual output.
Local deterministic checks
Run the exact final checks from PLAN-local-G08.md and paste stdout/stderr plus exit statuses.
Replace with actual output.
Manual scorecard review
Record reviewer arithmetic, anchor/evidence, opaque isolation, render count, usage handling, and bounded-conclusion findings.
Replace with actual findings.
Section Ownership
| Section | Owner | Note |
|---|---|---|
| Header, overview, archive snapshot, reviewer instructions | Fixed | Implementer must not modify |
| Implementation item/checklist status | Implementer | Check only after actual completion |
| Review-Only Checklist | Review agent | Implementer must not modify |
| Deviations, decisions, verification results | Implementer, then reviewer | Replace placeholders with actual evidence |
| Code Review Result | Review agent | Appended only during official review |