103 lines
3.8 KiB
Markdown
103 lines
3.8 KiB
Markdown
<!-- task=gemini_reasoning_compat plan=0 tag=API -->
|
|
|
|
# Code Review Reference - API
|
|
|
|
> **[IMPLEMENTING AGENT — READ FIRST]** Implement the plan through the existing normalization boundary, run verification, fill every implementation-owned section, leave active files in place, and report ready for review. Do not append a verdict, archive, write `complete.log`, or ask the user.
|
|
|
|
## Overview
|
|
|
|
date=2026-08-14
|
|
task=gemini_reasoning_compat, plan=0, tag=API
|
|
|
|
## For the Review Agent
|
|
|
|
> **[REVIEW AGENT ONLY]** Compare source with the plan, rerun fresh verification, and finalize only through the code-review skill.
|
|
|
|
## Implementation Item Completion
|
|
|
|
| Item | Status |
|
|
|---|---|
|
|
| API-1 Correct Gemini profile levels | [ ] |
|
|
| API-2 Prove bridge inheritance and synchronize contracts | [ ] |
|
|
|
|
## Implementation Checklist
|
|
|
|
- [ ] Implement API-1 the Gemini portable effort levels inside the existing profile normalization.
|
|
- [ ] Implement API-2 focused config and Responses-bridge regression tests plus contract/spec synchronization.
|
|
- [ ] Run fresh local verification and the exact-source dev Gemini reasoning cycles.
|
|
- [ ] Fill implementation-owned sections in CODE_REVIEW-*-G??.md with actual implementation notes and verification output.
|
|
|
|
## Review-Only Checklist
|
|
|
|
> **[REVIEW AGENT ONLY]** Implementers must not modify this section.
|
|
|
|
- [ ] Append PASS/WARN/FAIL and routing signals.
|
|
- [ ] Verify dimensions and finding classifications.
|
|
- [ ] Run and record fresh verification.
|
|
- [ ] Record reviewer evidence, root cause, one selected fix, targets, and acceptance commands for Required/Suggested findings.
|
|
- [ ] Archive review as `code_review_cloud_G04_0.log` and plan as `plan_local_G04_0.log`.
|
|
- [ ] Verify managed `.gitignore`; on PASS write `complete.log` and archive the task directory, otherwise write only the required next state.
|
|
|
|
## Deviations from Plan
|
|
|
|
_Replace with actual deviations or `None`._
|
|
|
|
## Key Design Decisions
|
|
|
|
_Record actual decisions._
|
|
|
|
## Reviewer Checkpoints
|
|
|
|
- Only Gemini profile levels changed; generic normalization remains the owner.
|
|
- low/medium/high are exact, xhigh/max fall to high, none fails closed.
|
|
- No direct-handler normalizer, model/caller branch, extension, `thinking_level`, or `thinking_budget` synthesis exists.
|
|
- Responses bridge inherits the mapping through `selectProviderOperation`.
|
|
- Gemini-native thinking config and thought signatures remain unchanged.
|
|
|
|
## Verification Results
|
|
|
|
### Profile Mapping
|
|
|
|
```bash
|
|
go test -count=1 ./packages/go/config -run 'TestGeminiProtocolProfileReasoningEffortScale|TestProtocolProfileEffortNormalizationOverlayAndValidation'
|
|
```
|
|
|
|
_Paste actual stdout/stderr._
|
|
|
|
### Responses Bridge
|
|
|
|
```bash
|
|
go test -count=1 ./apps/edge/internal/openai -run 'TestResponsesProtocolProfileGeminiEffortFallsBackToHigh|TestResponsesProtocolProfileBridgesToGeminiChat'
|
|
```
|
|
|
|
_Paste actual stdout/stderr._
|
|
|
|
### Full Verification
|
|
|
|
```bash
|
|
gofmt -w packages/go/config/protocol_profile.go packages/go/config/protocol_profile_test.go apps/edge/internal/openai/responses_protocol_profile_test.go
|
|
go test -count=1 ./packages/go/config
|
|
go test -count=1 ./apps/edge/internal/openai
|
|
git diff --check
|
|
```
|
|
|
|
_Paste actual stdout/stderr._
|
|
|
|
### Contract and Dev Evidence
|
|
|
|
```bash
|
|
rg --sort path -n 'Gemini.*reasoning_effort|xhigh|max.*high' agent-contract/inner/edge-config-runtime-refresh.md agent-contract/outer/openai-compatible-api.md agent-spec/input/openai-compatible-surface.md
|
|
```
|
|
|
|
_Paste document output and sanitized exact-source dev low/high/max cycle evidence. Never paste credentials or provider payloads._
|
|
|
|
## Section Ownership
|
|
|
|
| Section | Owner |
|
|
|---|---|
|
|
| Fixed header/overview/instructions/checkpoints | Fixed |
|
|
| Item Completion/Implementation Checklist | Implementer checks only |
|
|
| Review-Only Checklist | Reviewer |
|
|
| Deviations/Key Decisions | Implementer |
|
|
| Verification Results | Implementer, then reviewer |
|
|
| Code Review Result | Reviewer appends |
|