toki/mattermost-mobile
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

remove state.value and rely only on props.value (#2635)

Browse source
This commit is contained in:
Saturnino Abril 2019-03-20 22:15:01 +08:00 committed by GitHub
parent 676babf313
commit e744083833
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
app/components/search_bar/search_bar.android.js
View file

@ -68,22 +68,11 @@ export default class SearchBarAndroid extends PureComponent {
constructor(props) {
super(props);
this.state = {
value: props.value,
isFocused: false,
refocusInput: true,
};
}
static getDerivedStateFromProps(nextProps, prevState) {
if (nextProps.value !== prevState.value) {
return {
value: nextProps.value,
};
}
return null;
}
cancel = () => {
this.onCancelButtonPress();
};
@ -107,7 +96,6 @@ export default class SearchBarAndroid extends PureComponent {
InteractionManager.runAfterInteractions(() => {
this.setState({
isFocused: false,
value: '',
}, () => {
this.props.onCancelButtonPress();
});
@ -119,9 +107,7 @@ export default class SearchBarAndroid extends PureComponent {
};
onChangeText = (value) => {
this.setState({value}, () => {
this.props.onChangeText(value);
});
this.props.onChangeText(value);
};
onSelectionChange = (event) => {
@ -219,7 +205,7 @@ export default class SearchBarAndroid extends PureComponent {
ref='input'
blurOnSubmit={blurOnSubmit}
refocusInput={this.state.refocusInput}
value={this.state.value}
value={this.props.value}
autoCapitalize={autoCapitalize}
autoCorrect={false}
returnKeyType={returnKeyType || 'search'}